From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6CC36473D7 for ; Fri, 6 Oct 2023 20:49:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E595E68CA72; Fri, 6 Oct 2023 23:49:47 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2109.outbound.protection.outlook.com [40.92.91.109]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F2CEE68C94A for ; Fri, 6 Oct 2023 23:49:40 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BFWbNqAkaC1Ei13JLssenIGy+1f/NeEnz4xxXMCfvfjsir3TXERNj29m5UswHl1VhspvbFdPVMQm1RIv66IV3AaVmv0bmlpiW5R5Exi66KjV1V3yHJos/HDmPcwWMuVnLXSS+7ylMqsNEPon1kjbCx97rzw7tPV9VDMEpwYN5IVZBCrfrsXBn6ROn671cMaS/vWpyGJgYAncZmd/Bn6+Bipbu1bvN40cWOpY3+Rr1oM3PiO1dm/PC2DhBgJZEVdR6QiSPrfeWbz5RFNewTUlZ2I0OHlyx0FebfwKqK+oHJHeJvMvghQnZxULUDe1VP8CK3TtWGvOzFk97VB1BwalnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/bNMWSHNDA60Zr5vfG87s9MZFWJBjSufDA1Iqvwg+F0=; b=Fn95dX40njdmSgLL+FE6O/UF+zGuE1cYO5ina1bEZGdoUHzof3pQt3FvsOkvmaRLrMiwBBW76u94zmOZyuGAgJq7tENwAvkZSH0v4wGCetjNwkOMnPT6s7+hOfWFZqt52YZ+NeSpxOJ7KzDnwaZg+bZodvlyG2lEBUC5Q/iCRcPV0irW1qckuM6m0A48BP2qQyncAWYnbH+XICMHMkQtqZRpN2UKpOP9e2rFcXafBRvVWUrnqNq6gzpxMtkQXpiSJbR5iFkUQ1QR9SGuPOMeiD5745sDrI21fNFftGpFdgWwTBllowlcmKysx/38mAjR+u6pT+WBZNgs6Z3ERgFmHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/bNMWSHNDA60Zr5vfG87s9MZFWJBjSufDA1Iqvwg+F0=; b=eCUFL+1JV4yDG6hHDqfZBXGryQx6NxILIYoB1bqEZlWeiDTQdirT/ouShuPHLJ0+C6JRDUoGvZzOzswGDIVMqEwBXJWfnBYfF3Z5ZMu6lUpKpXUAnLgLjcieYsJQm7TFpTJSEVbiY3KaJwXm+p0TcKWnGlyeRilzZD0M5iiWA2AhcNOz1LBFIigVJLoqRsH82IMwREP6lngbTASUF0UfAWzozXJD2/qWLDJg5lbRJxHgVdJRMrORLRm6foPdpHCl0RQ00J3RvCgY2rSr9hAyqxDERNoC73bQkOI+DMJbZllb/s5n+T7yMijRSGAF6aqyk7vRf3+hIJmb1ZEqdjiQ1Q== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0155.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:376::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.33; Fri, 6 Oct 2023 20:49:38 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6792.026; Fri, 6 Oct 2023 20:49:37 +0000 Message-ID: Date: Fri, 6 Oct 2023 22:50:51 +0200 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [EFlQ3BntcYuiRa8QCtMRxJ/SJxbEvtGj] X-ClientProxiedBy: ZRAP278CA0004.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::14) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <57ce8caa-6e98-4910-b70f-ea505bf9f6b5@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0155:EE_ X-MS-Office365-Filtering-Correlation-Id: dbe04bfb-f670-4d86-f999-08dbc6adc124 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: juCIiveT4pjdssQruvGlfSTJNdEW2JKe56/Ol+hHb69aNRmEpl37Ud/6EBfspYyw3GuFFsQgau0i0or4vJu84AH4mFfdNm1WIsiq1PvP2WTy9+p1go1LkIlboVvgMBzJYonBI4Pu3ld9EeukhmDYGuKLPsYsW+7X9m5jnZGXzyWjoBMPRr9Z6wo2+XYf9Rwk4r8gnEtTxvUHiJwRdOp7nlzB7C2XF8wpU6EVYAdQQXwGRkErBxCNPuD46ryjWuf7ZTFAeAzxPTqXq3W0M99xu8PTgyhxetF29x78vJNCNv9PoJO1lxEuANwgel/CTN0nJ9Dqz1NH3/ptrVHdtEj7kLBBitpkppXMzy2LxQSQFYr4jTg0u6CwkzmEGjqwDkKh9iIGaFF7oOuYFUS0yznBePxL6ooFXHo8wdAnpS8Wf8lFrkh+rU1COvXibJLfnq1NdbPsDNeq7rAdbRvFuyL6OS53R0a5ldi8ndKE+IkSrCY2mJyYRYOU2mqmlw7IKEGTiuHOdo3Z4fLoMTbvVBtXPX8sYC+0jzhu4849ZCWNuUkNgiy3J4IpeHfZz77Cc5mY X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M210OE90azYrWVdNaXEzMHNiOGpNWWFSR2M5ZXBSY2pTRDEyUm92VTFKQW13?= =?utf-8?B?SlFjZ1BNenM4WkpJQk5tc0lBL0NkWjAzZi9MYmZBa0RNK0dkUmJHYU82dFh6?= =?utf-8?B?U0puOXBwamNiUkRhRnI5WjRUVWtweVZHUjlwYXl5dzEyaHhHU0ZVQ1pVTWMr?= =?utf-8?B?QW41UHFxVjFKZCtWaWtVdjJMeXpEUzN2QlJPSDJBTXZLTm1mOWh1R284eTdo?= =?utf-8?B?RHUrVERINktNcGhybzM1RnUvYzYwMmZnSFV5dUxFa3dJeC9FQ0V3OW5oZW9J?= =?utf-8?B?emp2OFo1bXJaMWIySXp3ZkVwLzBYQXlzRENWUG1yVmx4UUcwNHlMbUt3VDV1?= =?utf-8?B?Zkd5bVRFVDVpWU1uMEs0anY5NWIzcDU1NmVNamUwaVljV1VNZUx3VUtwcWVU?= =?utf-8?B?S2RoQ0gyaCtaSDgzUWFZR3Y1b0xJaFE5Y0N6RFNpcDBKa1g3Um1udnY0ZEJy?= =?utf-8?B?d3AzajdHS1UzZmM3UUttUXkvdEtlL05ZV2doUzJGbzlQckRnWmpISFg2T1BT?= =?utf-8?B?TTMxUFFIRC9kRlY2QXpmWDR3czlHL2EwTDZYK3V3VU91elp5YzAvVEp6Um1P?= =?utf-8?B?WDg0ejVnQkJXTmFIOUhNb0I1TnVBdElNamhKRXc0ZjVWMkNZb093T1NpOGZZ?= =?utf-8?B?KzBXbm1IQ0xYczU4ZGFJTWtPNDAxd01oVlcwUHZnOHRWVlh3VTVqVmZzR0dH?= =?utf-8?B?MDVMaHROYUdwbzhvN2lLMWR5LzRCZ2ZqU2ZWdjR4cFlLalF2TVJ1UEoyWnBv?= =?utf-8?B?SUkzc01kWXZnMXJGR1pBZ20yZnVzdmFsaS9Nd1YvQjVWR25LMWF2SnpZL25z?= =?utf-8?B?YlR0clQyaCtaSkkvOEtJcEE4WUQ0MjNqcHpVYlBaUExRU2F4VW84Uk1Lbkoz?= =?utf-8?B?THUycEFnQklSU0Y0N0pPY1VLUS8wR3VOWStOMDRwTjV6RCtIKzZndnR5VWVY?= =?utf-8?B?QXRnSGw0UnMrTHRhT3B2M09TSVpjRzVRMTlTL1IvV0xpTWZocHB6ZDZzRmxz?= =?utf-8?B?SkQ5LzA2Z1cxaktaQ2N6YzRqeUVZNVhGdWY4TFpkNENMa0t0TXJ1YmJoWVNR?= =?utf-8?B?ZWFCV29tTGptaWZpdXplWnRrc2RiNTA3ay9qV21sT3NRYUJKUVlneENuMW1n?= =?utf-8?B?TXBpVXZxMWRHVjZqdXJuMlgwalQvVDlYMnFCSExMV0U0ZTFFSk9ncGpoZmtN?= =?utf-8?B?TWROU1RXZ0I2aUtpQWo2czQ3MnBXamZ1Nklab0c1dm8zOGMvdzBDNlJ1aXR1?= =?utf-8?B?SEVlcGhKQ0tiRUdPU2R1a0V1aXlKRE04ZzAxcjVSUDIzV1A4dCtPOHpIaU5H?= =?utf-8?B?MFRGQWYzSk5aRXpwM0FJbjM4cUhwbjNNNGdUYmd0cUNQZWpXUWE5TjkwN0dy?= =?utf-8?B?K1Z5QkdCNjRHdjNXNmxoNllmMEV0SUcwd2VKK1VmQldlVGI3enZ1QkJpNlFm?= =?utf-8?B?VXIxd1B4bFhoNWpaVU9VeEZ5ajZ1azBiaTFWdTNubHV2ak51aUl3eE9nNVRm?= =?utf-8?B?SVZkb0ZKWTh1NVI0dGlSVzNzcmY4algrL2lFV0ZoMFJJNFZjMHk1ZkR5U05j?= =?utf-8?B?QUUrYVFodUZkdGhIZm5MUnV4OXBFUGV5VWhTSkJzRUJ4c2VwdmxTNzVwV05H?= =?utf-8?B?UVAwYmc1RjRlM0ZIbUhkV2JyRHdyV2lTMzBEUTBjWDNOckFOemprTmRQMENo?= =?utf-8?Q?oUrSf/ZTd1le9I+POyaT?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbe04bfb-f670-4d86-f999-08dbc6adc124 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 20:49:37.7616 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0155 Subject: Re: [FFmpeg-devel] [PATCH 02/42] avcodec/refstruct: Add simple API for refcounted objects X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Nicolas George: > Andreas Rheinhardt (12023-10-06): >> Do you mean a template that generates functions like >> >> HEVCVPS *ff_hevc_vps_ref(HEVCVPS *vps) >> { >> return ff_refstruct_ref(vps); >> } >> >> automatically? > > Yes, but better, directly: > > void ff_hevc_vps_unref(HEVCVPS *vps) > { > if (atomic_fetch_sub_explicit(&(*vps)->AVRC_FIELD, 1, memory_order_acq_rel) == 1) { > AVRC_FREE(*vps); > *vps = NULL; > } > } > > Apart from the type safety, I see a significant benefit in having the > free function hard-coded in the unref function rather than having to > spare a pointer for it. > And as I have already explained, I do not think that this benefit is significant and you have provided no evidence (i.e. an example) that it is so. Additionally, the flexibility provided by function pointers is useful for stuff like CBS. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".