From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 77C9948CF0 for ; Wed, 24 Jan 2024 14:20:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 730FF68D0D2; Wed, 24 Jan 2024 16:20:16 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2087.outbound.protection.outlook.com [40.92.73.87]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5FBF268CFE2 for ; Wed, 24 Jan 2024 16:20:10 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R5+epYNM/1kDpaQB0OINRfHmmXv6vwaFld8jS2EHLVVOvx2edeIOhN2U5+tkEhJ7el53OhiaNafOjWKbgoGWYP26xrK+PrUYBSXLG/OVRUTEn+9ufGW4otINW0TLn9YqBxWpBjWsMr8L5tAKX5beSkU+loWQ+qeLGjSVvZ5ENmw7zt9e8z4XaonZw6VQJSXXQL4DKJ6L6hUqVseYBGecJs8wsW9rCpe//mjqwg75WTcP8QW9bFDqNQBlI5cfbrYfwFvGw3kc3LWLP3UgAqPThAEuTAhviu1E1Ijf+hkW0EpDsVdaffAlFAcguvUKhwcmtUZRg6Rw872B9z5xp/pA9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cUUKrGPxolZHY0MW7OvYaqyrG90pEo/WoYOj/+4inCo=; b=aoTljNMk/t1Upfn3kcRwTWveRBjcV+o+UNbiydi8tVINU02eJt/TeDR6fn/LbZjXUu/XqNPEh1UG9HhT6ZSalFoLO2fbeTzeqKZJ3yQJg2y+3kiKLLNap/oyMA/FcSqHzHIbQ2G4mgQrPpIBPJoZB0yNdBb+nPwn2o1iaAbwQSiSgtg9pF0xTZnrX9Ynjalp1XcSibrob4RnrOFrFMvtb1mNuG+bJCk5E3n3Zi0v/S/wMAJZWfFWDc+TXR3kJO/GGpDTCjpq4pcut/u+tMff1CkavCExX4xDblaiuwMuZ75NTacJoJ1l7h0s8lES5AqwNzBqLVVzQNuyAC6Zh1idrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cUUKrGPxolZHY0MW7OvYaqyrG90pEo/WoYOj/+4inCo=; b=ZC0cLACjb9W2FjUbQK790rJ8jQGAsPFir+aq+VFWmcLgLXH9MlY1ToPQHD713V/Gy3umoeqf4hE0Dz5PGPKMt85FCV4uD+HXFhzN2JuN3OKihQYxBf6XXy0xO9qaotM4YVybxEVtzV4LFtMJOOIWBK+sV60gsnVqxYWeiTH2JYif5ttCYLFtvem8KKWVdDxfTaz6NZavh7FAI8gzrYLWcmjWGfB2qtISsxwN+P9qTmUUpYZbaetyYuFabQ9nRQArL3Aqg95Rx6AJitmLqgWVlxapmw/g6i/f9XeT2/mpFRyMvu8s2xFcEKSEYRMbe5WI3g4GdxoUaVM7BpR/w62U6w== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0243.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Wed, 24 Jan 2024 14:20:07 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7202.031; Wed, 24 Jan 2024 14:20:07 +0000 Message-ID: Date: Wed, 24 Jan 2024 15:21:46 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240123015043.16349-1-jamrial@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240123015043.16349-1-jamrial@gmail.com> X-TMN: [TI+q+L269Ahxw34x/C0H9LSS5tT3d6TqaDuy7xiUR/w=] X-ClientProxiedBy: FR0P281CA0267.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::13) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <86fe9fad-efc4-4d75-817b-2b8db75a394c@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0243:EE_ X-MS-Office365-Filtering-Correlation-Id: a174264e-006d-4d65-ab9e-08dc1ce79102 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sjAdnaJpk/xUlchPO9k+bs+JKsLyXCqG70TPaghOri6vXkujrwtQJhxkeLm05o2zia0Vl9mH+NeQvfL2WVHRtEfeSn02ChBTLG6XueFExBDlRiAeYdgRDSY012e7SliVEKIYQjZoE2Kiad5lmIxH69twCWd33dWNkIW2RUmaIybx1uHpk/lZ9oeR2JlTPHSmRIOurUz9uQD5iuwOszdzXHBIgqKfZeU1I2I2U1DOAedjQqSBq0qWYyAbPMq7/pyTVLcxK6z9zyenIOq+ChsQbnH2OgUkfiB5kmwwrGupZZc3jEZEqJYl+4eIOHt0crE7HdI+mM6yuG0AZhwoznhlST6ZMrQ6iSmgMqgp/CCn7TcqddrPpKaiiHgF3KLz2rrrrX2kYUBGUWxkCjQMQAOobNI1gzF3PUQU0s9LRFNuhCjykXPGMwH1ustLgOczAXHeHr/xpA2j5cdFF+u4guUKhlGIc4Z9lNzMEalX+7j5bFLf6Cm72AYkecvJSO6dsWqmTwjOWlxn+oblDly8i5b2agthVWin+mqhI3tHgw0omgjqU67ldUeCn0qXOQafK2F2 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3FWMnNGSklEdWdIZ3I1cG1hazN6blNESjV1TTRRbHFzRWxySngrSW1wWmJI?= =?utf-8?B?WklCS2l0N21nb3JlcGpKYjZKYUdyZkp5bVB6TmdGK3lHSGVleUk3b2xJR3dY?= =?utf-8?B?eG82bmsxakMzZ3ZKU2xBU2VaY2RibFNFR3RCWERnZVpPUENYdWF3VWd0Q1po?= =?utf-8?B?K0hDS3BJbjZqSmtOc3llb3kvam5GL2ZYa1JIRGVua0VrVkVnWjdtOUxPSmsx?= =?utf-8?B?YzRjYXFpRWVXN2pKT2Y0dWd4dDZlNVc4Si9QOERXMUNSZzhMd3BETFdBRXFl?= =?utf-8?B?dFF4d1VnVkgvQmhjSWIzZVY4c2JBcVJCM2ZVM1ZVb3FwZ0pjTlluZmwxNnhP?= =?utf-8?B?VlgxN2Q5SHM2MkNrb2RudDlQSkM1L1BjMjVvRS9lL1NPMVh5ZXkvdWQwTndo?= =?utf-8?B?RGQxOUM3dGlvV25TT3lzOTRidHF1OVYvM0pIYU5LaFVjcEcrTG0zbURMbTVO?= =?utf-8?B?bUdIZ2M3QWs0TjZIM2g0VGNKa3BYRnY1UWJocW05dmk5S0ZST0NWTlVWYU0z?= =?utf-8?B?amc0Y0JkQ2wrUTBvbjJzazcwaHpuVk9DakIxVW1VcXltOU1ta2xSUGZOZDlS?= =?utf-8?B?SXhCWWlpWVA2MmpZVzlzcXJWcE9IUWF5bWdmMnVMTVZFNUhKU1ZLM0ZZdlo0?= =?utf-8?B?OEp5Sy9uaFZVM05zYk9RdG5oUXlPaVNsRUpXdTViUlJWOGZwc25WcWhLUVk5?= =?utf-8?B?MUVzYzFQSXVyalRMTEQreVlVbzdHNzZBdkdhYmFEUjFsSlM1dWdTNDlPbDdq?= =?utf-8?B?eDdIZmwwanZLT1hyVm9SK241MHRZZWNtc0ZZaEY5eXc0TURrTkcyU1dQRUxZ?= =?utf-8?B?eWtVVVlhVWtHV1VodFozQi93TXdaR01sU1NEZ3RoRmRMdEdNYTVKVTVMTURi?= =?utf-8?B?MUhUN0NjRUtxVjdMOExINE9Yd0prayt0Y2Vudno2ckE3Zll5QWhGRjVzT2hZ?= =?utf-8?B?MWxSRDRmLzBNbkI1dHVxVmdqT2Zwd2o0SEVMUmMva1Zpb3RMR1hnZkRWcEs5?= =?utf-8?B?aXcyalAyTDRJd0N0d1J5aUNlaXcvTTFTdUQxWGpDOHUybnl5b3YzSmlHNUhK?= =?utf-8?B?ZkJmaVRtN0c4VXNaZ1VvVzlESjYvaXFOL0RLT0EzWnB3YVZzamROQ0RiVmV3?= =?utf-8?B?WTUvY3k0dW4xNzFEZy9tZUpqT0tIWDBPMHRFWmdnYWtjZXdnOTdsNTR4TVNz?= =?utf-8?B?akhZWkxOY095MDE3ZlJUUDdRYnppMGhHSEZMa0gvVFA3QVhhaG4xMzVHSGVw?= =?utf-8?B?S3VhOHNhWGEycUs3VUJWTE9oazh5TVZYbHlNMy8zb3g2NWZpMW1WdUVkM0Qr?= =?utf-8?B?SzRoQnR2Zy9rbUVZUnRmL01KZGNzM1F4WkNIRlhtNHAvcW4vblF2SjRCNWhn?= =?utf-8?B?SGpiUGk1bUlhOFRZU1Nha09Qb0VFYXMwN20yNmVzWk1XNmFlT2k3cHM2eVd1?= =?utf-8?B?NzEza0E4QWdXN2xLaWJLWlFrRjlIc3JmNDFUeUM3UTlNbUdzT0k1aW5vRUJ6?= =?utf-8?B?R2pUMFZxSnE4UzBBbm5PTGJwSjkrdXVwYWVMMzFnS0l3WlBnbzhJU2dNTUVH?= =?utf-8?B?SUk0OFhRWStEZ21MUU5tZ29hVGZLNWJ2WHRNQlNGZE9DTHZXaUgvUDlMV1dk?= =?utf-8?B?TlpzcUVUUm1LVWdzZWI0eFFSZ01JeFVXK1ZhdU5xcEtmaVNCNHA2ZUF0WHB3?= =?utf-8?Q?RES2AGQWOaXatXFe1YZx?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a174264e-006d-4d65-ab9e-08dc1ce79102 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 14:20:07.7446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0243 Subject: Re: [FFmpeg-devel] [PATCH] avutil/opt: use AVBPrint to print a channel layout in av_opt_get() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > A 128 byte buffer may not be enough for some layouts with lots of channels. > > Signed-off-by: James Almer > --- > libavutil/opt.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index 0908751752..814b485a15 100644 > --- a/libavutil/opt.c > +++ b/libavutil/opt.c > @@ -936,9 +936,15 @@ FF_DISABLE_DEPRECATION_WARNINGS > break; > FF_ENABLE_DEPRECATION_WARNINGS > #endif > - case AV_OPT_TYPE_CHLAYOUT: > - ret = av_channel_layout_describe(dst, buf, sizeof(buf)); > - break; > + case AV_OPT_TYPE_CHLAYOUT: { > + AVBPrint bp; > + av_bprint_init(&bp, 0, AV_BPRINT_SIZE_UNLIMITED); > + av_channel_layout_describe_bprint(dst, &bp); > + if (!av_bprint_is_complete(&bp)) > + return AVERROR(ENOMEM); Potential memleak here. > + av_bprint_finalize(&bp, (char **)out_val); > + return *out_val ? 0 : AVERROR(ENOMEM); > + } > case AV_OPT_TYPE_DICT: > if (!*(AVDictionary **)dst && (search_flags & AV_OPT_ALLOW_NULL)) { > *out_val = NULL; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".