From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C5B754F013 for ; Sun, 15 Jun 2025 03:38:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 248C468D09F; Sun, 15 Jun 2025 06:38:52 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2039.outbound.protection.outlook.com [40.92.89.39]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2521868CD75 for ; Sun, 15 Jun 2025 06:38:45 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fmLBkZQHycd1XCzX4Sdo2joTohL9Ldfc78WSNJFcFhpihyP/EwD3n1tWWl6NrQR5JfDBdluctr+dSH4LUSVjt7FqPKEdfEvscSICerOHbF6DWjmoOh7zu0JtbMnSePGZEZ8AS3wdywTCrf/iSwPPOCyZjjG3yqGIIkfpQH+mjhuAxsq946A55+Icn5NLjzrjXi4avnYHb3F+MuvzTMxg/JqHD0TMpgqHBgz3T06w2N5y3IAH0u7jQam9406vN5tEHfFcCQfMJKk3FmvzjoY7aTZ5FOBA4P3RiTyhiYWjHkY01wy2zYNtZqjuIyX/JwW/rdsWzc56wDJtLuPb/ljW6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q/3lGAoVejfUbjn/VqiuY6N4D3cEb3qBKE/iZnuXHmg=; b=UgpLuz77RY2lTh4qSMoNRxPnfY0mEvO2fxWhCZUT34eOukjIU2dKlEm+2H898O90Sp/eFxm7XvV6C7WBEl4UzVz+Rv7JOIcGE20ja0xfkeXN9QNbJc7mPdSPdZ+dGs9eiPtwWp6PSRI8GAYaj2bTW6nqQsy7A/eByG9Dn+fpfy3lHb+YSCHeC4mpFxnmIaYw9hTPnNeHno4Do/rpParP9NfO107HXB1KkgHTIGGZbze5BI0ZpYq+BYZJ4lFj6Hcbs+T9AokNsHNoL283Fl8G9xR3pm9KeL9SKV/3oOQsVHxqk6fR68bXlN4K6UoahNNyh9TQ+cBAjPVT5OYEnQGj8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q/3lGAoVejfUbjn/VqiuY6N4D3cEb3qBKE/iZnuXHmg=; b=grC5nRHfq0lkNLhd6/TW1RQe2gBLAzjJ9LelEg0jfej06QLQvxRCfstBYUz7Dk08SH75KP7ze2x7DKJdJSSQi+VAvnD1MdI+yD5hAmgcrfMVjZL+WHmX8nF07cOGc/J3fYSyftgPhnG8glOTwSRw2ltX6E3zQwTD75dypmR7wsXEoa7jYumCUd9hywxqf9SV7sRXHqQrRzsJenTjlgPJ0pSUrJS9KMazg4Vs1jkDZSN4DTlbucat5EbKJLvmWw7XunI+UcMCiotvzaNpzyp1HZS21RLQlBThgCeX2QAF07FvlHXPIRxXGu6SGe85fg8G3obDZDwQVtYD5nacEaGvng== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0047.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:23a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.28; Sun, 15 Jun 2025 03:38:43 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.8835.019; Sun, 15 Jun 2025 03:38:43 +0000 Message-ID: Date: Sun, 15 Jun 2025 05:38:41 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-ClientProxiedBy: FR2P281CA0171.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::16) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0047:EE_ X-MS-Office365-Filtering-Correlation-Id: bd8b5894-7808-406c-4985-08ddabbe2021 X-Microsoft-Antispam: BCL:0; ARA:14566002|41001999006|19110799006|8060799009|7092599006|15080799009|5072599009|461199028|6090799003|3412199025|440099028|40105399003|10035399007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dHI2LzlQVHpTeXNkbFZKeFlCNG13eTZPU0VjRWxhV0VxNFZ3RFJkcEN5aHVN?= =?utf-8?B?ZEt0MzVsSEQyUUhMU0l0dmxwNGFaRjcwN1NrMlp3QkJsU0tESTAvdUR6WUZw?= =?utf-8?B?eGN5bzAxTVBBblQxbXVyUzZ5ZzY0UUhGaWhVMk1NWEZ1Z3hqY2hUSjMvUmZ2?= =?utf-8?B?MG5zV2ViTVFVMTkwVU85NW9rYzBSM0ROY1lGMXRPNk5nQmZPTVRhenhQVUIx?= =?utf-8?B?Y2dmWXNoYVVxdjBDK29EVjJSYmRMbjRlQ2pjeFVYWEVkVkROd0d5WFk1Q2dl?= =?utf-8?B?UG5pa3R6MmtEWXVna2FIRFMvVlQxWThVUTFQMnZ2NmRwVTlWbGtsSGFnamto?= =?utf-8?B?ZUJNdmhwbW5LYTdOTXRZQWUwM28vU0FXeGNuanR2dCtWemZ0RTF5aFVJZUtk?= =?utf-8?B?bTBvUFRKRVRmdjMreE1rRG8zWUMvOUVVeUk1bEZFSC9zeGVaMVhabFlwSzFP?= =?utf-8?B?TWNNVDNmRTc4MlhqSzJYakQzcTRmZVdqbVVBMEQ4cDNtSlNKMGVmZUpxUTVn?= =?utf-8?B?SDVOMmU2ZWFTbUU1N2VQV1piMU1pTzVUTnB3WWp3TExRWFBVNElJdmxPM2lx?= =?utf-8?B?cHZFSXNQQ2NTOWJaVlcxbUpXRWZ1Si9makh4UEQzekFtcCs0SjZOTjlrQWJQ?= =?utf-8?B?WkZyMUdsL3JzQVpUanRQR0pRZkVCVTExa3F3OFFRb1lEN1I1ZWdSK1FMMlhX?= =?utf-8?B?SmJhSjh2M0Q4QzdiM0xRWHVnNjZCQ29LdW5xRVcwQzlwYWlSWCtWb0t5M0hz?= =?utf-8?B?eUZheWY0UTgzbCt6bm9UVWkrMHpYa1NxU1JneG5jck1HbG0wc0JpOUVPTERY?= =?utf-8?B?TzNoUk1qb2MxYTVEbUtDTmUzWmp0UTMxNnVwU2FhQ0taM0ZUTlZIMFBmVWR2?= =?utf-8?B?YmJnK3FxOHpRckZmUTdFbE4zRUNzY1NWbXIwbXp2ZFhDVHdWZmFtNVI4Qm9D?= =?utf-8?B?bXF0dkpEMTFLcUhreUo3WktuU2RXU0xjN0tPVXdKaUF1ZE54dG5JTHNFR09a?= =?utf-8?B?TkNMbDA2a1NSZmRWcXRWNEdjT2s3OTByUEY5bGErVVg2NFpCakpxbFlRSDhE?= =?utf-8?B?U3JrSm9jVGFQemdiRExCY3J3MDBjNGpjaXl0bmlTWHU3TUorUUk5bk9MNUNh?= =?utf-8?B?cTl4SHhPdmpJcmduSEtqN2VmQlBXV3ZyenNnQUVKYS8vZlhJV0phaEZaQzNx?= =?utf-8?B?bVRxU0lCUXZCZ0lHcWpuRWlNMi9sMlV2N3JYSkY2SEw4RGswcXB2MjhVSmdG?= =?utf-8?B?TCtmQmo5bitRTzBuclk1dk9JMHMwUTFDTVdFbEJRbXlPZ1JhRStLMVVLZnpl?= =?utf-8?B?ZFZHT3IzYThxc3hSTU1rd0xYN0x0ZExGRXFsMjJPR203b0p5TDcyeFdHbjdi?= =?utf-8?B?UHovaU02UE1GenlxcVhoTXFEN2RuaFRDQjdlVnRXQi9teTRTeXRpM2QwQ2dI?= =?utf-8?B?a3ZlWlFBVzN1TFAvbXFLcTJZalkzYmE2dHFPelNmQlJibGxyejl1OGpWckJi?= =?utf-8?B?Z3ZuSkNXVi9nem5vRFFObW9HdlN0SHFwV1ZVeXIwWlBybUFDaVIxQWNSL0Jj?= =?utf-8?B?RTVYMGYzZ083N1lMVkl2UC9LYkpMMElRbnVKS2I1dTFpZnMzQkVyUTVKK0JK?= =?utf-8?B?QVBiTE0vcDZmUkNPMHVDT3ZlTVo5UitqVHc4NHVmeHdrWEhZdlFCM0dUNG1I?= =?utf-8?Q?54V1CsmFYCdOgxKZ+EIl?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmRQc3RpOHExakFwbXBPejQ5UmZmaWJMK252Uno5eEU3a2NCSThQQW1BM2lv?= =?utf-8?B?NHY4bzRHOERPWlVJeU83aDRmTW45VFZzZWY4L0pmem13SksvY1ErTEVYZmZi?= =?utf-8?B?c2JwZ1ZBRkZyLzNpRGZLckt1bXlpeHQzc3RIY3VnTEZYc1Z0YWgrYXZWN2x0?= =?utf-8?B?NHllMm16cXBRaVhyNHQ2L1B6anB4YVNJWXBOK29yNU5jZm5EVVQ1aUozVmFj?= =?utf-8?B?OUgwWWhYTXBGdmdaWGRaRUFtTmpNdXoxbDVja080bk5YYWJUcjU3ZzFqV05l?= =?utf-8?B?TGlrTGFnUVR0OUdqdHVRWllBYWlBbk5wZGpDRis5N3QxL0tndnd3UDNyL0l6?= =?utf-8?B?T3hMbVVIbzRNN05CbFNxWGw4Vkc0QXRFRGQvdURTZWI0SnpLWERodWlKZ2JS?= =?utf-8?B?OTVPN29oNkx1RS9zRnF3aWJtZmhlU3BxSEF1TTd5TW40cm05YXJDOXNaTWl4?= =?utf-8?B?NlpVUjNRelF4S0tEMTVnSCtldCtpNHQyMk0xRU1FNVdtWjNUOXlucGYzWUw2?= =?utf-8?B?Y0l1K0pMTDFGWmVuYm9wblQrV0dFRE5jcFd4WGY5S0hyOEFHTG9pdG53VU9U?= =?utf-8?B?Q3pEdzNlZlVJMTUxS0tBTjRDd1d0WUlTd0IxTU5QUTdvRXlIVy9QK291YlRL?= =?utf-8?B?blNQcE9kYWtTc1ZyRlJGMzF0THhrSmJtdjROd2RnTENWakZmTXZXNmxBNEVm?= =?utf-8?B?RTNKY0R4MW01cHlTVFRQbnZKUjM0TXQrTUJTL1pCdXNmaWh5SzYyMDZmY2h4?= =?utf-8?B?akR0Z0JlRWk4MkZpZFdJbzZ6QmtqVUpQbXhCL1FvQ01iR1ZjNnc2LzlJVVRJ?= =?utf-8?B?MzZlNG5pTTQ0azNaNm1UNUtuby9SRmNtaEhyb1pqU1FjN05qeVF6TkZKWnQ4?= =?utf-8?B?dE51a1JTb3BOTVgwS2ZTVlBTVklNcGs1SmhyeG16NEFqWFFzTFJNTDhsVnhv?= =?utf-8?B?M28zNTVaSmdydCtEMnlqMlB0Ui94clBEZWVnQ1ZRbnp3Qi9jZkhVaGNjbUZ3?= =?utf-8?B?d0tjSGpJVVhsOWdudC94aENpdVB0cW9XakpGbEV0cDA0UHBXT21iUnlvSld2?= =?utf-8?B?OWxLM3ptMGRnVytPQWowZTBndDJsc1VnMTdLZ1NNSndIbE1Oc0NBcWNqdVBv?= =?utf-8?B?YkZtNlMvQ2NtZW1KL3lCSlVoNDY5VHQvNkJNcDlOQUJxQnZKR20xaGo1SHhz?= =?utf-8?B?dmFyNFZiZFZ4NWUyci9GY3lMaWQydkRQcDl2blBaZVJUVGsxa3J4U01NWmsw?= =?utf-8?B?d1JOZzY3S2ordUxJeWl3SllTVlhiS1l4UktlV2pnMFZiVGZ0NVYvSHlkTXM0?= =?utf-8?B?RHZWeWtCYzZSQXlVSE5qODZrdlIrSnNaLzg4Kzd2RFFJY0NKeU5iL29GSFJD?= =?utf-8?B?dHhxOFhoMlBTcHpMbmpjWTFmYjBHdEEwdVRpdWVqVFFISkFBK0MyVVJLTXhR?= =?utf-8?B?dldlMU8vdVlDTWJyVmFKOGo5QjRUdkZUbVVlZlkxaGlSZkJwblFIZm5GeEJj?= =?utf-8?B?STQxK0RxVVB0M2tlM0szODloUkZKSmJiSmw3SDV1MVNuelVHMlJwTEZKQmRG?= =?utf-8?B?amQrclNhSnlSQW9vejJJazZ2SG52TnhzOFExaTdSQkF1L1RjODdGQVVWQlJN?= =?utf-8?B?NUdvVnk2Rnk0NUc2U0pwSHVpRkQxTnFRS1JJazlvQXJMQy9LVERYbjh5bTNl?= =?utf-8?B?eXpBS2hRZmsvNXBicFE5Y0VDQWNMUXVqZWFPb3ZnbU51VGdLVGU2NTdwVjlI?= =?utf-8?B?ZTBES2p1bDdLRUt5WDJXRjVMeU44dlRSaE5PSXNkZ0lqbWJZN2tzV2ZjVUJP?= =?utf-8?B?dGMwU1g1eTZOcUNoWm45Zz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd8b5894-7808-406c-4985-08ddabbe2021 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2025 03:38:43.3397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0047 Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jack Lau via ffmpeg-devel: > api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem > > In higher versions (openssl 1.0.2 and higher), > the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), > so passing a const string doesn't cause an warnings. > However, in lower versions of OpenSSL, > the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len), > which leads to warnings. > > OpenSSL guarantees that it will not modify the string, > so it's safe to cast the pem_str to (void *) to avoid this warning. > > Signed-off-by: Jack Lau > --- > libavformat/tls_openssl.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > index 86e8935fee..0a6e5680f4 100644 > --- a/libavformat/tls_openssl.c > +++ b/libavformat/tls_openssl.c > @@ -415,7 +415,12 @@ error: > */ > static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv) > { > - BIO *mem = BIO_new_mem_buf(pem_str, -1); > + BIO *mem = NULL; > +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */ > + mem = BIO_new_mem_buf((void *)pem_str, -1); > +#else > + mem = BIO_new_mem_buf(pem_str, -1); > +#endif > if (!mem) { > av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n"); > return NULL; > @@ -445,7 +450,12 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv) > */ > static X509 *cert_from_pem_string(const char *pem_str) > { > - BIO *mem = BIO_new_mem_buf(pem_str, -1); > + BIO *mem = NULL; > +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */ > + mem = BIO_new_mem_buf((void *)pem_str, -1); > +#else > + mem = BIO_new_mem_buf(pem_str, -1); > +#endif #if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */ BIO *mem = BIO_new_mem_buf((void *)pem_str, -1); #else BIO *mem = BIO_new_mem_buf(pem_str, -1); #endif would have the advantage that it avoids the useless initialization and that the old code can be cleanly removed when we drop support for old versions of openssl. Same for above. > if (!mem) { > av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n"); > return NULL; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".