From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 300EA48415 for ; Sun, 3 Mar 2024 06:43:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 55E2468D352; Sun, 3 Mar 2024 08:43:44 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2045.outbound.protection.outlook.com [40.92.91.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 11F9F68D335 for ; Sun, 3 Mar 2024 08:43:37 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H9vkv5SytA9Zi/I+4Ikj/jeoPlMYllmLr8bredKfGIUTLjKga08y5fAdQFXwPZbFaeGrQZ3BwbobLucMnQajc3FCHNBhxDcAvSpQ8mMsBDeVI5vejTOO8r3p5B5Tu3sB9zu4yL9SX2pmedXNSIJRsM4RDBalTjtEOkNdmAivNwHXxiKa1TOX+pHWh+dk82eO+LjAWIdcKKeT6Tw2nHqLUxnADfONojUVY8FrQlvbUpWAimSfQBRJ81RBOZHW3ZD4kSfMBWYgFe8TTwpQ4PfP+RFNfFxI4RdP2OE9Ksy5JTS/KE2obY4t3+4rcgWGzk9xZPyO+j4H6diNkv1V2MKqkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1yEnNzGwXqVLFtWN3Dd14MKYoZCVvBAxCpb8hr15ZMY=; b=Ds48DSrxW2N3bh91/lseirhxU61NqO00iwyCZqJeAiNjNuweRzHZmwqsGS9TuU1yuI6rTaFdrWtoogiwPMbdYuEA/3PpzyNQ2+LXVOUZ4AYVFS3Q7pF/tfD/8uvRVaWUnkPII+NnwQ1RJk9+WPBAO78eaulmVM7WlSg1u1pBe6N4+EpOu+gd7986iX530ZiJuyOyayTyeV02Jg4wtI451GdBbTtxRdaGGyYX/1voW5sXn7O3a1h8+MK+JftsTmm51DSLP9OzrQt26pW87rRC7vdXcHxh0qCrUJVlrWpQkIxJrL7ot0gKHryYUixBJ01eGshb5WMQce04AjbivU3FIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1yEnNzGwXqVLFtWN3Dd14MKYoZCVvBAxCpb8hr15ZMY=; b=Nb9iGebLtgHO5ZPZ45CH+PWx2ws1xtMW2zMmMJfqpT+E3n1EkY1CvNaJYJU/nsQp9VqRYYTFb2ijNo2tdMDGvNvt/k9oZshHuRUclcjDHuTx/5JyE59F5DsZeMWIVkkqmqgxWBAAP9EZxGnot1XlwduBusyNYg/YlDtu7SKSf6saBzuXO8crNyDaIfGmpR+EtRaFMppEeUPZvfUrQY0AIjrJgdAPf2j/MHhuLjnO0CXyCr6+5kiOs6ys96EfKI1tY8q2HdW7TztU2lyZ+H7rtJr4ctZ/MxYKUkrjfaa/uzZ1x0Gdt16ZtVc2Qxamm9BHRhgV+hmAavLtbFxul2kaTQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0048.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:23b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Sun, 3 Mar 2024 06:43:35 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7316.023; Sun, 3 Mar 2024 06:43:35 +0000 Message-ID: Date: Sun, 3 Mar 2024 07:45:34 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [N6FM+iNICn0NS1eYZh0novGDT3kNtyuOrc+3ztfwx98=] X-ClientProxiedBy: FR2P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::6) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0048:EE_ X-MS-Office365-Filtering-Correlation-Id: 843c37ba-aad9-4df2-2138-08dc3b4d402a X-MS-Exchange-SLBlob-MailProps: 9IecXKUgicCfRWu2dKEWzkA/SoSVqy+wqj9mGNGXdzPvnvERLNPObh8vMQF4PqSx283J2Eiz9SK3y2TUKdf6/ETqiWVBqL4dOdozd6eZ/NTQw+Gj9QFVWDVw+JkluG0e4N0VsFjGMrinKQLUWgbM1nHoQIry50W1S+NXnX8YJ3NJKPxMlIwzVq7uz/mltGQlkMOkKyHl6elpxULd/nPssO0CHPRtpIqUu3N8dLjZkVOflmzlFjlnKVd9ar/jRmUBOeOcvauv8knOT4UbLEECRDrxwA1jLtNtTk7RcPbNFsKNKYvK1IwE1Abt3ciWuPGaD9nX8OGGE02pCeqg+RQXJz0a1l5jJlPTbnZEBblszotrkkDXTW5rQItGo2RBW5UuIOEYc+7cfSTVtdzgfRIChpB1+rFf5CQMkiMM7Vgvx74sPGNZEqgYiNZsATBxHxd1HhRcrWNoNdlgV0ck0y5jojq08Yagc4w53y+c515/PhpPVCBguonqoQ4G0y4q6eDaOCOE5C3KzH9sosOI0Tz8IDRonzqtrNWC1CvIUpxhmKhA/KYWrQMRlKlSOF7aSDshZWFfImTASG9HYmeZafAk0p2Wr3zaSElwEWbRs3lq4zkrrdRRjbjF7OEPECSjqhRV1t5G3GHfs2ZZtPqS44CFFrGS2eoW1k4NkGFSVxGupKJiRpyznx5Od2dNxVK1QvA5ibbAYKqDtkZxjoFr0lVghelBUlo7QmkHZCRajZRzo4QYqVYi4DmVqA== X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: De+eTLwDH8pADLVKIHWUc7yvS5OI2Xr4g4Fo8yDrsImCzXRVBInx58woOTs3KDDiHgWvFooYgdeM4WhIpE6EUJXCXGVyZch8oUOYNewx1b5AyEEKkjaq6bFvnKRnqcVLjN7J2NGRKW5K9/GdrRkBF+BkShA5Md8ZgWmTz45X3+5hmBBALVNIiUGV6VpcgXaIg3GaW3hPynqA3N2WdK/Pa80fZ/NkzUFxLj5bCaJ1Uteln54LY++99jEPWPalmM35NhA+WWp0xjkuWTh+ZBi5kaBvhb69GBXVibRdpOKOod/SZdgNzAURhl8gjfAepYAsJ1qN8uiouWuyF9FuzZJB2693RqRQq15iyV81F5DD0xdJoZn7TjWfAMzeLdh7NorwX2zCmruJCBm+9R8KgzREKo+py2QqBwEehtzmsHx+7AHx8j7ZyoSEqMd94qnnJQd8OpiceBeC9/cg4Y4JACqx6ok7ijY/IZGzYfiuaBKpxLOt7ziGx18SQpNZqMhTej5j6q1Ckv5zoNqvT3WINeaRF64jYnGnjpZ9GRcgPVgcZHreOCX3zS+UgdRln+IdiPYi X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cktMa01xS2VnMGFjUGRGclVBZHJSNWJGMUhPNzFQYjdRYzNLems4M3dBbU9F?= =?utf-8?B?Wm9aUjUxTk44SmpiYS9WMmI0UENRMEU2SGlvMWUvRkplK0NjanpVKzdYb2pY?= =?utf-8?B?ektsMHJ4RDNjcU1malo1emtTdGhCZU02MStCN1UzaDUvU2dLQmkyN2NDYllv?= =?utf-8?B?YTVYdDA4YjVxQWdQSStMdnN0MFpGMUFpYy9hblcwL1FETE5BaCtubVcrY1Mx?= =?utf-8?B?dElScXY4cTd0ZHdyVVFrTXBXQ3JlNGphRmxMbzQxb2QzTFMrSHVrN3VIclpz?= =?utf-8?B?clhyTVo4TkxRQ2hrT1k5SEhTUlZlWDRWOEQvMkxsbXdtT21xSkJxUEVaS3U3?= =?utf-8?B?MVlTYjZBb3N0Mm14c2YyUUpLUnd6cjV6STNzU1YwbFkrQWpNVjBPUjMxUmpr?= =?utf-8?B?andXQVRQT3QrTGVERjFkWVRSTmt5c0l3RkpTVnNEZlJlTWJwYXg5NFJTVTR4?= =?utf-8?B?UFNYd000eGdCakt2czdLM0E1TTZlaC9ZaHZ0czZSTVVMV3Evc0xOUDEreVgv?= =?utf-8?B?VkRObFlOOWpFY3NJdlF3S0pTT0xHc1lWQllvUnk1TUIraHF6MDhnUE9QeXVq?= =?utf-8?B?bldIYUh1WHovejlSU0ZyTkxxZ21LZU5XOHdRN1ZDQmJEV2ZQeHJkSVNnL1ZZ?= =?utf-8?B?cEx2YWJ2NVJzaFVaTFVtdHRJWlFxTjU0YWptNytTREJvVUk2NlRpWU9ORVYx?= =?utf-8?B?NURFWUZ0VThCS1l5dlZvZEVDNFNnTDR1MkEvSU43aEs1RWVSUkNQOWJOQ3Bo?= =?utf-8?B?ck1WYVR4QXJHRjdnQldKdzViR3JmTFhVajJnZmM2ai9Yd2IxZWYyTXdJR2No?= =?utf-8?B?K1EvdGptdVEwRU1xWmpaMkdFWUM1TG9YYndnR1F1ckRROVB2U3BYRXgrc282?= =?utf-8?B?eHJ5TlJkSnluS0tCdFNXRWZ6aDdsOThXN0lOWlR5eG50Szk4S1BTSG1ZY0wz?= =?utf-8?B?NWdLUm9XOTNmR3hLUHNGWU1RU2ZMY0hQNTZBU2pNcVNDZlFBcE5aN3hGT2lw?= =?utf-8?B?Q1RBQ0pYNVhqeDg3djhHaDc5Z1dCZmQwU0RBTmE0amo2N2l2V3VOU3hUNTIr?= =?utf-8?B?ZGxsdWh3cytWUHdnWVpTSkR1S3lhS2UraHlKS0VEckwxMEwvbGdxU0dzMHdD?= =?utf-8?B?M1ZnajdlZUhKVGIrMjgrWWtManRVSmtSd1crekcwc2owSTlDRmx0NW41YXQx?= =?utf-8?B?VG5FV0xMNHcvSXNXWnBldE1yLzNyT1BpZUJBaE9VNXcvMFJGanM1eXFRSkhl?= =?utf-8?B?Q2c1dHg2MmIxUURDNmpmUDdDbXltYVYrc2ZkUDRYSEw4VW12UkFZb0pNNDAr?= =?utf-8?B?RFhQcGdGL1BFZ3Bxa3M5MlloR2VoR1d1UGRLVVhVcDBaQVZCTWoyY1YxS0Vv?= =?utf-8?B?ZXo0aU5HV1JDS2RGTnN1Y0IxYVhId05hOWtOb3Voc3U1L0I3MHZCWFMyMVBJ?= =?utf-8?B?WTJIb0tjQTRkWWk0dW03SitNVjN6NzhST1FMWFl1V1d1WjVlRnMwODRnWkVZ?= =?utf-8?B?QVJVaWk0bHRncElwY3dwTmpadlFvTDN0Z0txOHFEdkpsODJGYjNURllJN1VR?= =?utf-8?B?eTBOWEF3ZXVJNEMxZlpWdlVGRTVKdjlBTGJSdHQ0K3cwWVhZUFFvYTh6clYw?= =?utf-8?B?azRXYzRzcUNSZy9IRFRFTE9sU0E5U2huWDBaMTRkd2ExMTVBU0YzQnQ5VXU5?= =?utf-8?B?ODc2L2JONVhTRkJNdFF4SzF4VnQwdkMzTXFxN3R3dmpGQVpLQ1R2dnRBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 843c37ba-aad9-4df2-2138-08dc3b4d402a X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2024 06:43:35.6580 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0048 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: check pred flag to fix undefined beavhiours X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Nuo Mi: > libavcodec/vvc/vvc_inter.c:823:18: runtime error: signed integer overflow: 1426128896 + 1426128896 cannot be represented in type 'int' > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior libavcodec/vvc/vvc_inter.c:823:18 > --- > libavcodec/vvc/vvc_inter.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/vvc/vvc_inter.c b/libavcodec/vvc/vvc_inter.c > index d5be32aa14..48c566b097 100644 > --- a/libavcodec/vvc/vvc_inter.c > +++ b/libavcodec/vvc/vvc_inter.c > @@ -816,13 +816,16 @@ static void derive_affine_mvc(MvField *mvc, const VVCFrameContext *fc, const MvF > const int hs = fc->ps.sps->hshift[1]; > const int vs = fc->ps.sps->vshift[1]; > const MvField* mv2 = ff_vvc_get_mvf(fc, x0 + hs * sbw, y0 + vs * sbh); > + > *mvc = *mv; > - mvc->mv[0].x += mv2->mv[0].x; > - mvc->mv[0].y += mv2->mv[0].y; > - mvc->mv[1].x += mv2->mv[1].x; > - mvc->mv[1].y += mv2->mv[1].y; > - ff_vvc_round_mv(mvc->mv + 0, 0, 1); > - ff_vvc_round_mv(mvc->mv + 1, 0, 1); > + for (int i = L0; i <= L1; i++) { > + PredFlag mask = 1 << i; > + if (mv2->pred_flag & mask) { > + mvc->mv[i].x += mv2->mv[i].x; > + mvc->mv[i].y += mv2->mv[i].y; > + ff_vvc_round_mv(mvc->mv + i, 0, 1); > + } > + } > } > > static void pred_affine_blk(VVCLocalContext *lc) This adds branches; the UB alone could also be fixed/suppressed with casting to unsigned. Would the latter cause any problems or are the values set here unused lateron? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".