From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4C807472E8 for ; Thu, 2 May 2024 07:12:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D22A768D7A0; Thu, 2 May 2024 10:12:45 +0300 (EEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2088.outbound.protection.outlook.com [40.92.58.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 15CD168D778 for ; Thu, 2 May 2024 10:12:39 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ba3wDJjm9ty4L/RAS+gzhzaaHgOZEKl7+v+sLlUxblTUwKjcOBPpxzGVpijOfUxuRDZfLWQpmiodpDu2GCgm+CmQEzaq/YmxAP2cN1n/Cuotg4tfCE43tVS6DZgFLi41psrhK0wAso98M86Rfv2AbOd+ieP6jDT5dMGCv4DH2O2wZJ3OKKX2MDm8TZA2o5C52IULq3sOu/5EGIomDnIsgnR9kPINytZF8PgxEOrGWF0JAu+1ZbS6pmaeSca0NMgLYmf5sALE5vvXVGV+TuNl/7rSa8fX1ooHGDWuChd19Y2HEJqMof564dydbuHog4vqQSd3l1BNG016uiPu1eQCUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UInitiQFtWmkq/KioNoKrToCwRzgGhq/jBa06+HezIo=; b=M6/PyqiwTvO8OhKIE775MNxYOnaBG8vYjJyxr7iHXXfhVEWpLCHWl92sT2p16NdJ9uMi1IUH0KSYqEocZgcpHwgJEkXijY6lOIcE61idYeyCOd9HOh9LecxF/w2xYzfF1GkHj3ZTjR5EVGTks/R7qSns5uv8hQqpVsz9GxOBKrpxSzU8dHZGZWJMRqutY60QdkiyX1R68ankX1rcyjAAhoRjxLl7TkbUOyMUBZ1fJuGmcroRaImoYvdKtOtLGKvWSMubdacmmkdNdfNE4AK6JD80tKb/MtdBOI54riEV8OaH6tLFkjL0kyQxMQwr82VESHXguEHlnqcxZnopMxpzhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UInitiQFtWmkq/KioNoKrToCwRzgGhq/jBa06+HezIo=; b=OVeqKIkfgFZtOyeIVpAUUG8bdMGhvRnVQcpATUNAmwd3zV0wWvHemst2aUAv1pqg1UTHFCrIDYS/kWBFfl8ZR4qbJTi3hDLocetMLEH/BNf1mpcqDLMqXuUWn1DjcRUIA77BsJ0yTSHlw0QoB4xYWMRhacsWyrI4HauOyCkdHJeL+Xp505qoOyc7g55MmCiK1IUM5VqCqLMmWm7ETEd9FjYc3wuv4PrM8UNr5IqkiyZfMGGsOdxKnIVVNhW2SemJiH5V9GUBCav+FlQhOrTbWqUp5wQQvV29gdDy4tgFm5KqYC0dgXPETcUoL15tR7/PakCBPJmLRZvHSyXQY8RAOA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0166.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:375::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Thu, 2 May 2024 07:12:37 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7519.031; Thu, 2 May 2024 07:12:37 +0000 Message-ID: Date: Thu, 2 May 2024 09:12:36 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240502004150.3627661-1-michael@niedermayer.cc> <20240502004150.3627661-2-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240502004150.3627661-2-michael@niedermayer.cc> X-TMN: [8+1Y9POPGfkTRkt/rLonSmEm0+aWwV7Moq44v5Os29I=] X-ClientProxiedBy: FR3P281CA0175.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::12) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <89ccd83d-05b8-43f4-ba93-ee3929a61471@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0166:EE_ X-MS-Office365-Filtering-Correlation-Id: ec0f17ff-6553-41b3-c912-08dc6a773f59 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: h/G76GPccP3s2D9tztxI9ZJ8NShBXhcLuyCCQdyP6kB1OxMhc1baPjdxHN99iMh7BEbRJ86Jkafy2K5haNJK5TP7Tp5rjzUKwyvm+tiM77HCxUmug/OtbzxnnV4DyrTRlfQ3b9bz838gpnyouJC99o0pTEhILuTnoZ0MQcYbRWZR+l4uy37yEDm7ipcCXITwB35t30zfkp7Uk9Yc2Si93ULaFSIkuZTEXFebhw3B7X0/RE8RJ47pEAvtUng2qWwKmzBhoyK4uXxNcDzNn8o9l0WFEtxcPhSUMLuUSAj4sPIF1y4sUDxsQFCKwtQGyEG7mG7d02jB0igHhm0t8cDwUWKNTw44tZU1f6DpTzmkqWnm+7x320anra8BhhmyRoqJDq3UYEGqrjWkHhgN++I4lu8qpUvih6s+eihw7e0+4gHWamZzw3UflGNKGCqPspbyDE5vnlYlsHksMKfvwwLFMztqIugbh1bpi82zZjU3JHtHQ2BQe4rFk1FX7sqRvNtPvvw+WekF2nNUvS4YpFnC16Atbi8fGJ+jEFNxDNX0JbEmRvoSE/+uZjtpDKr+LcwF X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVNpcHpOTkZaRzJKd2FxUW54U3pzMFRhMWhab3JSNGNMell1Y0x1RytURHhu?= =?utf-8?B?WUt5ZWdrT2s4ay9LUnBuK1VOckgzeGxmdzQyS1NjVEZtTUJIUGhMcHJ6a0Fs?= =?utf-8?B?RmxNTWhWOEZDdGRiMjdrdGpocEZnOXFadkdyVzVkcWUzdXNQTGdra3MzRWRy?= =?utf-8?B?eG1yY2thbmh0RHUvNVBhZ1VRczgrUks5TUkwNlI1R2VpU2dMOXBlbjRDOWJW?= =?utf-8?B?VWNKemNmNE0wNGRoMlVtQm1yK2pJNVUrYk10TUxuN2kvK3ZYNTVRRlB1bktW?= =?utf-8?B?dDRaZHVWcmdHY1VIRWJ3NnF3NW5xMWZSemxNK2RQMzJzcFN2WE56WnNxWTJn?= =?utf-8?B?VFVodHYreG9TTUhJUFhrUEVBTDRrUjNzY2ViVnh1dUVQM282Q2EwYUdqbW5x?= =?utf-8?B?OStldUhxeVgwZ0hKNVI1MmhGVEtMT1YyeStlSTh6d01LcTBxWkQ0MlBjV3VB?= =?utf-8?B?b2NuWmVRZWEzN1dIWnAybjNkMGdJQW8zaUlvQzlxZnI3SWlUSTUxL3BRSWlz?= =?utf-8?B?eFhZcGpxcWZ0RW9pTEExRVFNOVpjenduSjlkSzVYeWVLQmVweEVMV0dzUFNT?= =?utf-8?B?Yyt3NW04ZUVxTkFpT0sxN0lQb1B6VjYzaXJrWDc3UHJqQlk0dkpyS0U4dzJv?= =?utf-8?B?YnVjKzV0NlJSN2VtMmhKeGRhbkR2cjRhVDh2Vk5JR29kSnJBNGtMQlVpanF5?= =?utf-8?B?M0ZCcXYydjM4aXhoWVFZSFhuek85R2dWbVVya2czUHZva0w3YnpaVzkyY2hL?= =?utf-8?B?SXZwRHc2MVpTZ0o1a1ZXSTBkYWZ3Z1JjWjhnSmNQVWxPekU0aGttdXdBY3pP?= =?utf-8?B?U2hiVXlpaWh5SUtRM3BITCsvdXNRcVVNQVN0eFZIYWlOclFudnNDbDJDdE9E?= =?utf-8?B?ekRDZjVKREJROFUzVllxUUhveHVpYnRHQmQva2tzOWxsMlRKem9sMmxzYllM?= =?utf-8?B?V3VtaVhXN2ltazR5cmlkbExYQVRyUFQrc0hOTmpZL24wajZpaU9tUnlDMndB?= =?utf-8?B?Z2dkTFk1VGFwb0xqTkQzWDYzbnZ5WW5ZbGR1YWpFZmNpSzk2UERRQ2xSdjUr?= =?utf-8?B?c2FUeGxWa2tvaUF3NXhLQUxQUVFyQmpxdXYxcGlvb0gzUDcyVFcrUlNWMU9P?= =?utf-8?B?VVYvOHVCK2k4andwSDhvQ3dwcEh1ZHpPMzlwZlBjYzBxbHZ1OVFLQ2VaMXgr?= =?utf-8?B?M00yT2lhWm1VMjhIRTQrQWJwNUxKTHE4UGZYNlE0amZqSUlkd2hlTVA2Sm85?= =?utf-8?B?YWc4QURtY05zeWhmakN4OXNGWUdDZ2M0d2pTTkhGUTNJQ0c4R1BWUGpLc3dh?= =?utf-8?B?U21aVUg4VmFqR2xaSG9GZmYrRnRYbnNuWDJIM1NHWGY3TUJzTzJ5N09mamR3?= =?utf-8?B?M2luQWdYaTdLQmNZNlFaVWpXQjBQVXBLL3FLcTRZV1I0eGZFelplQXFSR3VE?= =?utf-8?B?eDBEQmNuNlkydEUwbk84WHdqTjlxczhpU3hMTkM3WjNiREsraGx5eVd3SEEx?= =?utf-8?B?ZU8rMkZwaXVGeDd1UHpCdzI0ZDF0MkFpSmRkdTJySjhNaTk3ZVFEZ2daNzhn?= =?utf-8?B?TkYvaWNpTDBoaWcydGpTTmZGVEZ4YjVBVWZFdkxQNndqODltOElxbU54TTJE?= =?utf-8?B?cW9hcHN5RUV2b0FOcVNGYUJDSzJSRXJtZmJTMm5NV01Cbit3a1NyQXB0RmNh?= =?utf-8?B?SllIc0NudW5hc0ZzNU1reUw4TkJPNXcyN1JUVnplZ1RidVFsbnRLd3JRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec0f17ff-6553-41b3-c912-08dc6a773f59 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 07:12:37.8294 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0166 Subject: Re: [FFmpeg-devel] [PATCH 2/7] avcodec/av1dec: initialize ret in av1_receive_frame_internal() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: CID1596605 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/av1dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > index 4f9222cca27..93ab04eb378 100644 > --- a/libavcodec/av1dec.c > +++ b/libavcodec/av1dec.c > @@ -1262,7 +1262,7 @@ static int av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame) > { > AV1DecContext *s = avctx->priv_data; > AV1RawTileGroup *raw_tile_group = NULL; > - int i = 0, ret; > + int i = 0, ret = 0; > > for (i = s->nb_unit; i < s->current_obu.nb_units; i++) { > CodedBitstreamUnit *unit = &s->current_obu.units[i]; A better approach is to actually initialize ret before every goto end in order to ensure that only the actually desired ret is returned and not some earlier value. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".