From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 26617499D1 for ; Sun, 25 Feb 2024 12:52:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1179768B068; Sun, 25 Feb 2024 14:52:38 +0200 (EET) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2109.outbound.protection.outlook.com [40.92.48.109]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9191668B068 for ; Sun, 25 Feb 2024 14:52:31 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cp0sIwc/t6WLrBjHZGFG1LVFgdF4G3lzJiA+qTli+ILfoCDPpqJGVk2iYhdRruoSSEsY4DReP3LBBNYSEbqyETLYToZG+HWxu0vVf3cjcq5EsqWyNJxHTkWMfiJ87PnARako6iyEwzOqbH/34rFwTfPGGXEemxJnKLu7LGNcoEwiRcLxn2calHeTNnSo7j7MvIt3RV87P2KN+z1IaGjlAB75N8lnbopXoDmII5VMjzkO+N3mssRzzD9kcbAFph97FdVDw+uh0Yk55g1ROZB9XzL9wTD/yWjiDm8swESf8y/l8EJwIP8DGmaHQNy87cNYImwQqUN9DqrJZ9Gf67ssEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c3IWj5lH7CoSF/CjlwZwm4Xuk9dXlyVhXueR6QVXcjw=; b=gmsFJOXZDBLeTVynuTIGZb0ynapkB9Obc1twajlSvwDq/RUCtB+HW+W7thKDOsUN16KoYwjkVgodGO/yh53VMppksjEqHfy7tO0A/oFjA6viEYauPesEFAS4tJ6AOPHDpNKA2NSj1rlTFWlcIYKhbCPX3zNIchMFWnPHnsimbbagNi2OM9PiTWD3PC9InVj7AYYg5iDMPxGN8J4N3romRvVkmbmzZMnSFnMbx7p6aTayVEtEq/kXhFPVvhqD0CoG3ZVD64XufhcYJJ67wHmqTtmKTKlt8G1ma4QX+3CZzcJM6oQmii3rt8Jt6SssCtswsWTOjepQQdJvcbNkmRDKAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c3IWj5lH7CoSF/CjlwZwm4Xuk9dXlyVhXueR6QVXcjw=; b=VFNZh82Oer6PTEptQMWMXQkf9z1GxD+c2+F6WDSILl/Mi8ySnEk2ZfOwH4O2DV30v+GSrYBLaIjtU/nZW9bdT9chdmJ+pO+kgT5VSafv4gEu0NPfyUa/KzM8EYohPCPKFCHmUdbPkdMhfeNNCEk3qKRwnkFaQwLr4gqXI2qhvJhto3tKANlk8w1f4qYLLd6RWLeLKTuB7+dXMQhINgSgPjpea6hQW5CeW8eTCt5wn/neAjYl0DW0PqQTzYOBXYPPF4j5Qe+6bQZG3cNdUa0Un6PZSfs2+9NZPZmCYxwC9Dvo452zA9OIOhbO7jj9Crx0O30Q1UYDp991rr3hrjZamQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0381.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:270::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.33; Sun, 25 Feb 2024 12:52:29 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7316.023; Sun, 25 Feb 2024 12:52:29 +0000 Message-ID: Date: Sun, 25 Feb 2024 13:54:28 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [FTGWg9Eb2oZ2YsUBKKtpdRtbN1FQXUeb4Hx8T0jWx4A=] X-ClientProxiedBy: ZR2P278CA0014.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::20) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0381:EE_ X-MS-Office365-Filtering-Correlation-Id: cfe4ade7-b3f8-496d-1cff-08dc36009fe7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bv65JMTpDez3caYHUsk1rDdD+Om7vx+Q4+vvoejLJVrZv32ST/qY8C7UZVlgp0e68y8T+1VjnxeyRGjaQn/XPHeYHroZhHKJApVP72P1ur7Ak3EGnXSrgN5cbcsUIfAdlnYM8/HRW2nUDHc1pVqvojprIXO14nVh6gTOE/jBWEPgKyn69Ibw00aWIYXYbn0/SSvbUlwz0h0wusFt+gqrfeZVCfyk1iRufZcoz160WJP9vLEqzevqykWJ8+vjtZlY02Q7NEQDWEj2AiWeq9A07FsMGRe/7hvxsaG3ofBKXQ2aeXgk+lO7ZgWy3SPJKmx36R2yWr/hozDyd/38YIV9FKNQ4bHNsCdVNI1kddG9xZ0SWxHvFOQb8RlHBrixxuF3ped4ORNOsYd0S/4kqI1X496O5h/0C7iAj9zoScgFP3JjcuV54/OOHZcjszclnRq3IHo9lXa7cmO7TI61oFI4FyJQJOhzdp9mmczaJEZHGVPPXkcRhAdvfMDSTWFourdLoU4CPydsXZv9MW2KjD7VI/kudkWvUBCdrmlShq8xlEapsHYT89wPDzcIBo7mf4n7 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHVtR2tZM05PZzU0L1BLU2VQLzNDbk1na0laR1F5aXNaRmFoS2dYaTlDaVRT?= =?utf-8?B?cFZzY0ZLejZrU3dYM2twSTRnVE1XeE1XN0hrLzJ3WndKTE1nZEV1Zkc0eE9k?= =?utf-8?B?Ym96RkRPd2ZXbDJmNDhIaVZnS0NKcUZCeU84QzJZaERBT1MzZW40OXpvK3Bx?= =?utf-8?B?TkM1aDRCLzkrNFFyTExlKzZ6dXZlVE9Ja2kzejFpVVBiVEhqTjIrQlNtbFd0?= =?utf-8?B?dkdSclJXN2RrWHQzeTN1K2hYL0p3QXFtbkcxUDZpSUZENkJoNHN2OFlDVWdx?= =?utf-8?B?SmVTSlh5R2xjUUJQZWVnNDBUdlp0S3czcmg1NmlaSkRaenZGRWtKSml1eWhW?= =?utf-8?B?RWZSbnRDQ1Jodm4xdGZSWnJydm55ZU9yb1R5L3pQbVQwS1QrTjJFZldHK0U0?= =?utf-8?B?blJBRXp2QzNIQ1NhYjZJbVhWSytjaFg3N2FRRmcyaERCK0poTHFUcE5sNzdt?= =?utf-8?B?ZUNicGhLZDZZM2dpREtqRVZXalE1S0NCYzVhTk1NNmxaOGhBdUFCTVhLU05K?= =?utf-8?B?SnVXdXVDYmkyNThYSU5FNWZGTnVzaXM5M3ZDalhzS2lPTXQ5NE5wU3g3QnpO?= =?utf-8?B?OXZwSWE3VktsTFI4S0tURlMvcWhMZW02RmMwOXJCaHFyWWpPVjRiQVFLVGs2?= =?utf-8?B?T3RiTE9vZWcxN3YxSHdpMngxQlBSaTFEM2lKU1JKc0Q5NTJSNE5XSHYvV01l?= =?utf-8?B?NDVOMXVKTEp0eTRxSGJJNzQ2c2ZHajF6SjFGWjc4RjVDR2FFNVpLc28ydUVT?= =?utf-8?B?dk9LaEJzWVkvcmNPQWN0MHcvUVJvcldJU3c1d3JGT0ZDZ010bU5ldThyaHZQ?= =?utf-8?B?QTJEcnh2TjJOZTc3b2tqOEdCMEc3VDRtbXhuSEp2S1IvN3h3TzVJSUtxZG5Q?= =?utf-8?B?VE9aVFozOHdiOFdwRnpWVytOOGFPZkNKSUF4L0MxVC9rRXNyM0RYajdjd0l1?= =?utf-8?B?dG9zdG14Q0dvRDJINWFBODZkSHk4cGxZWVV3NXpWdXpFTXBrNGMzUUFnTXZ0?= =?utf-8?B?RHFUK3p5RGEwNWxwRjFESjJ5dENLeHQ5Y25OYmM4aGNBMVlqQVJmZmpMbVpG?= =?utf-8?B?UCtKT3FIZDVQeEo5NVF2YzJSU0ExUzJXUGZpeGtVdUhHVEZKbHdNSklSR01G?= =?utf-8?B?SmZobGpEQTdhSncrdzhUc1ZzaDFPeTV5ZXVZNkxyQVlRUUNMQlZaYkszdFBx?= =?utf-8?B?dXVUb3dRSkk1THo4eE5XZ0pnSHV6NWc4N294RnZPQTh3VEczZUI5Q2VFWnBZ?= =?utf-8?B?Q0tMR3BaSzA2UUp2VVd2dEZLb0JJK0FkL1JvRm5nL1FOVHUvU0tKeFFUQ0tF?= =?utf-8?B?U01pR2daSW5ob21xUnNKdXJpU3pockZHQ0RVNFhDM216cHltaVB1ZEtoSW5k?= =?utf-8?B?TzczODRVRW5zQ2l5VFd6WGRNSzVReVA4ZE9SQisyalBMQStJOWxMM21uWEQ5?= =?utf-8?B?NVhIQ1p5ZjlrNE9yK2NFaXdpVHhJRTZKT2FuMVlXL0hYWndOU21DSjhGRy9U?= =?utf-8?B?SGNnSmRKZVdNSm43ZkdGdmw3Qjk0QVVlNit0Rzl4SEtGcXI2TTVBZ0RYK0hu?= =?utf-8?B?TnBZdEFJblBqMldPS3ZRUkJybXhOWmNCd3ZENGZ3RmQvVytHUSs3QXNETG9o?= =?utf-8?B?ZVdDTTdSdE95S0RESjlMcVh1NXd5aXVIRmZZRUxzZTRvT3pUS05EZnpqYlh6?= =?utf-8?B?RzQ5KzNTUnZRV3dSaklCc2F3ZHZDWXRhR3Exem9adVVyT1UwTi9QeXRBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfe4ade7-b3f8-496d-1cff-08dc36009fe7 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2024 12:52:29.4689 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0381 Subject: Re: [FFmpeg-devel] [PATCH] configure: Disable linker warnings for common symbols X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Common symbols are not part of ISO-C and therefore not used > by FFmpeg at all. Yet linker warnings to ensure it stays > that way are nevertheless wrong, because the existence of > common symbols does not imply that there is a bug in our code. > > More precisely, Clang's ASAN implementation uses a common symbol > ___asan_globals_registered when used on Elf targets with > the -fsanitize-address-globals-dead-stripping option; > said option is the default since Clang 17 [1]. > This leads to 1883 warnings about ___asan_globals_registered > when linking here. > (Even without that option there were warnings like > _ZN14__interception10real_vforkE being overridden.) > > Said warning is also unnecessary: The proper way to ensure > that our code is free of common symbols is to let the compiler > enforce this. But this is already the default since GCC 10 > and Clang 11, so there is no risk of introducing our own > common symbols. > > [1]: https://reviews.llvm.org/D152604 > > Signed-off-by: Andreas Rheinhardt > --- > There is btw a second incompatibility between our configure script > and Clang ASAN: Since version 16 it defaults to > -fsanitize-address-use-odr-indicator and with this option set, > it creates a __odr_asan_gen_FOO symbol for every object FOO > in addition to the symbol FOO itself; configure therefore sets > extern_prefix (used for ASM name mangling) to "__odr_asan_gen_". > > configure | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configure b/configure > index 197f762b58..108816bd1e 100755 > --- a/configure > +++ b/configure > @@ -7337,7 +7337,6 @@ void (^block)(void); > EOF > > # add some linker flags > -check_ldflags -Wl,--warn-common > check_ldflags -Wl,-rpath-link=:libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil > enabled rpath && add_ldexeflags -Wl,-rpath,$libdir && add_ldsoflags -Wl,-rpath,$libdir > test_ldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic Will apply this patch tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".