From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4A5FE49D67 for ; Sun, 10 Mar 2024 16:06:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 66E3B68CD53; Sun, 10 Mar 2024 18:06:29 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2080.outbound.protection.outlook.com [40.92.73.80]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0A41568BC64 for ; Sun, 10 Mar 2024 18:06:23 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hl25R/Ef6coPd3+9V8tZQ0LuW1cIL1oBhw0B4ReivzerMGBLufFrDX3YZtzVXkuU8Cy3nBZhdAYmU3MDkgATGQdway3DP2ZbRaUKlPmJ+y8I25XShH74iAVMmEgEez/4GTGaRRwDEb07+bGj7vYHIhg1LqCEEiX/HiDHmx14wMkcHuf+byt5D45LL8grLx3LgjiDKjbXlHDTzNJv0bCqTrUGK+ggvzsuyV2Xm6Ue1sdNcVwm9Fy1yy831ZGtaavNCyi0HFUxRY3tBHrEpfiq8Juz95JGdh82Tb/OBfJTrC9+ElsLCswgJDNAgYx0FCeLR0LyMNLg+Ms44OgetNtpKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+I9T50/dvFHVfIY5SOg0K78JHsibS0dNynn0mix+9zA=; b=LRgfRiSUVV4dAu5HggWd7DVOhR14yyJctSsTB5LHEeZv46GB513yz+w3zor1QRmGL7ofgefqRtt21ItcZXp8fYOppWW59m/YP7gni763mVwYmTf4mSvUIK52Ygdle/C9Qse2+juyQ5y18yxMQOM/iejNzV671ygeKuvUdEergR1qWZpg2Wz0ChZaoufU7Ehjg1mb4NL0G1X/FGDlYGFkpLS79WaqTPaIxLI1OqEFJ0YHYIw/gSkYeFZx0CGV+4WfDWH3dgAbeK2pJjpFQSnZZhWCHCeKlFBdTjM+PliMfmIiF4Zk71Pr/ky6QRIpBGJIlilnTBPWp/MpE9Uyqe4KTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+I9T50/dvFHVfIY5SOg0K78JHsibS0dNynn0mix+9zA=; b=V3c7aMk+0gw3KNtUySNSXDaQbSOs0tR+V6ilZ2mo3W9toT8hXGf0dtfZQm8Ky5JjnbrCWsdKZP/F++NlJqu33mitbhT2VFVdvSRXQtFXzpJPCHmQE6zrUkMN6GG+0UOeUVDPR0ABDiIHitjT1TlQUCZo5eEJ3k0A+dxzr6czFUj0BGkskwKykq8WmeCGpNYrjJsuA6ShVHULn/SylxMUaw8Q+fldfCAmdho79/D/V9cqTJ5W9J51lWcbWlSVHfhged6KXmOzU3YG9/kNfi3kbolE83mLzHp9oglssa5s9Ex6wuLOM3VNkFRC3W+DrAOipoEMUHX5DkelJctKV5S59g== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0006.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:359::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.34; Sun, 10 Mar 2024 16:06:21 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::228d:8c6f:ed10:82eb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::228d:8c6f:ed10:82eb%7]) with mapi id 15.20.7362.031; Sun, 10 Mar 2024 16:06:21 +0000 Message-ID: Date: Sun, 10 Mar 2024 17:06:18 +0100 User-Agent: Mozilla Thunderbird To: FFmpeg development discussions and patches References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [2wfLFNNy77HDD+iy2GR4bdMEwQTL2LTzHRfO7FGSZjc=] X-ClientProxiedBy: ZR0P278CA0028.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::15) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <39a2ac8d-4440-4ec5-92ce-048fdc9e4c04@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0006:EE_ X-MS-Office365-Filtering-Correlation-Id: 472383fb-921b-4ece-afe7-08dc411c06cd X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnrycYYMiKOh26ty8tiVyH4gt7FFIm7Fb9OjlYN9NlwH+T7FXLkTdbG7FVQhExwO8o/Dllt7016g9et0D8ZecLzny8J5GWPar/y0MetSAgHEyDlDQNB90QcUZOBNBRUGbDm/NF5XxBnenQeqVwvZf2l6mgJY+7ee0m9yygDmXc0BdG/2YNT4WAlstNZS4Kwjm+Xdlua+5rD1B5HqRVnSDDKQqhSo2x9fzI1Pff8B/ePi3OTq4pnNgjr3nBUbDYJbPFA1lB4H+CyhHcMxvMx3GCbAj7P895YY3lcwlRaRa7G/V6nMFa/bSVXyk8JGOz+DNR+06PPA1iR9zvlrVqKoJnq/gCeYmhfgiojDL9NpPB/Po6ad1Xg095KxPr5uQZxaaVc98aS8U6cobdIPYl2CIh59bt1+wq3NU44a370Eimwbxh3BgkSdLGZz3S8DpyKuLKHKWWyMdnRVcfGudzVPONWgN3lTp25XjeI7zT9nsDg6Dvjhgy812YtkqvDLKbJJHJrLZcPoVlYQ+GgwfizC45t0921SiPtvpguu4HVmAupuz08yxOnnEhLnCSwmeePkukRXICdHoHPgRvWfE2rQJSSvq/h9OtJeRCPZSMmIp3sdnBVJFr85oI33aNjNN/TsXBbXV7vZFHtq1HkNb1rjvPrKYZ6YiM5RNfyOSqwFyKBD24cj8dok96rLHGvivx/l9vzQVoM0t2wmiKHhT4Ly4L0deB49WZihoAkboWE3szC8mWbsGFFcsgETAPMNVX9Fdic= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fLn1pFaRuPOmBZ17i/bpZBcTdgbLOw0hl+wFuxh9fiGhJ0xbRHsVkNQWc5a6RBhZQ8wv7OkclvOx2QlvMz6qxrW27rHI17ZqQTWHG8B+Wlr7JTAKK97wi3qvVByiRKek58u7l7JA9oqB0sh5FtN8CfejO9ak7byXEikzi0+JuIPuGE1HaZL3Pwohg//jDBVfT1OtRKWPrtI6Yn0UhdzgnCVr58NRU9LYrUKphZP4lq1Wyz82jOdjZCavnHpHJ09+33SUV0D/i0McHSrWUHFg0ZnYt+jRk3uet5aQy6WFEbrVABRu3Fi7SJwTb+JIzWRWDmqaHSSC4ucKmye4yHRPA8xacU7CLJVlXC/Llvw392XrIhRjzfDgqiRVYuob5MU9sB+3JYhUNmFw1gUVXpqUW6TZ837O7CPU2Ajb4v/Ulw2zKtL4kYWK1pnlOtR4RAoCiKgfmJkyxqv1HwRecV2R7rs9OSu0tfXp+0pfFGSgzZLtGprzRZynjl7mGWKeJ+ySZbgIGvL+yHbq33j4doncbbis/KI11jRt+zPHFY0LELGU0aA2lwHxIivtYO/oLKyx X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlAvQmhiU1U5ZTIzOWNvS1VKQ1pvRVdtekRoNHU1Rjh0V0p3akZLektSK0xH?= =?utf-8?B?a2Y5VnVaYzQ2NHc0MWsyNFdyZmVabmJWakt2UXpsalpNU2c0QlJQa1pEZWZD?= =?utf-8?B?eDNXTG9xbWtJb1VPL1pVWUZ1NEZIempPSHF2ZlMreWgyMU8waFladTJJM3JN?= =?utf-8?B?aFo5Y0g2YnFacjdPbmkxVnh5M2hCZUZtNS9GRExWcU4rRC9hMGZHL24wcmlE?= =?utf-8?B?eEI4MjBDSkl3RDExUkZ6d1R1UmNLVk1PbFBTWUpXNFhKdnIyYlVhTDZNNlNj?= =?utf-8?B?djRPRlFGRXFkOEFiNGZNZ29qU0VrdG4zVXZ4WXRSNTZBZS9ubTQxc0Q5a1ZR?= =?utf-8?B?TGZLSHZiTDFzUlRCWTRJczYvSTQ4NEJuNE5TOUVCbHVPeGlKYmNnVzh3ZElQ?= =?utf-8?B?V3h3b1RxUFE4bmJIMTBuT1NSSWtYV0hmM2ozS2hjSE5XbjdMTTEyZTRFczNm?= =?utf-8?B?MjRNYUR4T24zamNiVDdvRitJUUJTUFF3REdEQS9TQkNhT1dIT2hXTXRlT0pX?= =?utf-8?B?TzdqcFA5M3NyRkFVbEh6TmRPRXBlNEgvRWd2L2lteGRkMVdiRGtRaTQwZ21C?= =?utf-8?B?cTFLMXF2ZGxCZUQ2ank0V0E1Z3Evamk0MHhzRFBRaGZPT1dYcGdleUFBbURR?= =?utf-8?B?aFRuZ1plbmJseGlHZU4vTitnWjFXSWR1V2crZ3lwZkQ3ZEFObkJmMWhNUGYv?= =?utf-8?B?eGt5QVRHTnZpQy9QRFRsMTNtOTZHK1JvMEh1VTBDQVZPR2EyZFk5am1Ha0cx?= =?utf-8?B?Tjk0ZzlXMTVhZTZuaXRnUXRaZHJpdWdvakRsSk5vOEdQdlhwakZva1o3RnJ5?= =?utf-8?B?dkFPMTJ2ampXWUVxU1RJbU9iNHExblIva1pwUnVlbUgrcVpzS2l3Skc5OXFu?= =?utf-8?B?cFpmWDhXYmVRZElVOGIyNWNkNTYrTVk1U2lYZTlsZnB2UmV3L1kxZElHbTMw?= =?utf-8?B?b3RNWlU1T2NyMnRWRWNzcHBPcmhNcnFPUWxvZzNuQy9uQWNaMjFnYk1VeXdZ?= =?utf-8?B?dXd6ODBGVVUrQ0s1Q0ZyRGZxK3AxcmU3MFlWLzdRTzF2bDlhVFhQc2VzVVZ5?= =?utf-8?B?ZmtBaWxDZTRlcnRlUW5KbVN3SWZCSnlyU2p0L3ozQS9PaHB4c3FpS3NNZUFh?= =?utf-8?B?SkxSdUpVandYK0hnTXVYVlgzUmtMempSWmVkcVIxeElsZmtraSs0SWxCUFA3?= =?utf-8?B?VHhLNnJETU54N3hhS2ltc25RR1d3SVBMaFJrTmZ5QllPTzl6SFkvQ3BtRFlz?= =?utf-8?B?dTZNZUh4ZzYyN1ZlYW9ZTXBHVVJOaWlMRHhmQXRHUUhlRXFVWUJoRzNRRHA3?= =?utf-8?B?ekVwVjl4eUJpSXErWUp6V0xVN3RTVmE3WnJkNmJyN1d1LzQxRFYwVXFKMXQv?= =?utf-8?B?dGUvdkFyMjd1M014LzNpamxnc0JXZlR0T2F5Y3lmaWhxdTB3OTJVS3hwVWFK?= =?utf-8?B?bWVEZ2d4dGdmQkJVSXExb2hIbkxseTkzR05NeGo2WkRLYXVmTXYrTWlFWjNJ?= =?utf-8?B?T1YyY0QyMEdtb253b201TytDU2s2L0w4SE50WlNud3g2QVBXdkppY0hTaURN?= =?utf-8?B?Q3pyckwrZmZ6ckJyTDdCcS9HanU2c3UzODJsbGNLa0ZQckdacmNvaldjUzZo?= =?utf-8?B?M2pKZnJPVjBNN2UyNWszcktORld1ZStUc0NFQWxrMVN2MTJwK0J4RW9Fb21w?= =?utf-8?B?WFQwMFVnMlpnOTQ3Tmt5cDJVMTY2REtZbmFCSjJKMVFlRG4xMU9uS0VnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 472383fb-921b-4ece-afe7-08dc411c06cd X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2024 16:06:21.1032 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0006 Subject: Re: [FFmpeg-devel] [PATCH 4/6] avcodec/tiff: Improve inclusions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Stefano Sabatini: > On date Sunday 2024-03-10 15:15:02 +0100, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/mjpegdec.c | 1 - >> libavcodec/tiff.c | 1 + >> libavcodec/tiff.h | 3 --- >> libavcodec/tiffenc.c | 3 +-- >> 4 files changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c >> index 43b36d0a8f..c9409eac6c 100644 >> --- a/libavcodec/mjpegdec.c >> +++ b/libavcodec/mjpegdec.c >> @@ -52,7 +52,6 @@ >> #include "jpeglsdec.h" >> #include "profiles.h" >> #include "put_bits.h" >> -#include "tiff.h" >> #include "exif.h" >> #include "bytestream.h" >> #include "tiff_common.h" >> diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c >> index 5d350f4e7e..15e5edd93b 100644 >> --- a/libavcodec/tiff.c >> +++ b/libavcodec/tiff.c >> @@ -48,6 +48,7 @@ >> #include "faxcompr.h" >> #include "lzw.h" >> #include "tiff.h" >> +#include "tiff_common.h" >> #include "tiff_data.h" >> #include "mjpegdec.h" >> #include "thread.h" >> diff --git a/libavcodec/tiff.h b/libavcodec/tiff.h >> index e67c59abad..2dd21dea52 100644 >> --- a/libavcodec/tiff.h >> +++ b/libavcodec/tiff.h >> @@ -30,9 +30,6 @@ >> #ifndef AVCODEC_TIFF_H >> #define AVCODEC_TIFF_H >> >> -#include > >> -#include "tiff_common.h" > > why? there are cases where only tiff.h must be used? > Must? Like in most header matters, this is not a question of "must". tiff.h provides (mostly) TIFF related defines that are independent of any particular implementation, whereas tiff_common.h mostly provides auxiliary functions for decoder/parser (the encoder only uses type_sizes*). And not even all of these need it: faxcompr only needs tiff.h, not tiff_common.h and mjpegdec.c needs only tiff_common.h. - Andreas *: This array uses a weird value for strings; the encoder has a size table of its own with a different value at this position and uses type_sizes at only one place. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".