From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BFE2D47AF7 for ; Mon, 2 Oct 2023 10:03:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 89A7268CCCA; Mon, 2 Oct 2023 13:02:57 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2015.outbound.protection.outlook.com [40.92.73.15]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9DB2568CB7A for ; Mon, 2 Oct 2023 13:02:50 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nubzJbUBsk4JId0t3znNRV3+cONDDktKGSkEMBK/Gh4+WEF/qp7KM/cWkvI5hMdoaBKrSg6uvCWt4n7QUF2xf2uG+OF0x0Hb1q33mt2Z/1ArE3quqO6Zq0luhjMrUhKIkmFQ8YScb6tuYMxJl/4Yj5ezYlhlkXaz+kJ+G2JUaLs4w8GdMyZhDb9IjDAl7GHdP6/xp7wm6qF87OVxOZov/pLiaU7T3O2gxOMaP4gcy5P7rovL/ggyrNXvlF/FFaPp8+bba/ObFAPjzPpgRfSdy8McFjJBQGIUd4wpYMjY66uq+1N7MP0LXWj10xhcNQjUyNFUh6byzpQhJo4kkeJITQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r+0hatkTyc10d3SuoTk3LvSoObJlUfYlcYtxqjMWP1w=; b=Wtj+Ii3V/Q/+Hzlcm2PO0hZU7xo2kk1DrffXH7ESIeisHqTj1Gt9jSljynXe0sxVVnspdVwbqsy5o4ilzi7X/5v9MDmE/YR0db3j7FtlFb3eQd87/4cYPi6EpXWT3lXZhUTIjGG6HSZy9y0Ul/QcZJmU5+YiifxlF3Zl5SyjMFpa+hGiZz60gMDHxfmtGqT8OHhFGPPpd/UyAq0xkh4bevP9WaDYaACe3nK1DxcCEAZZVhTkCAQOATjh/q3in+WUknmGRnd/0cc6VirtMExfvgAtFlNSz+sa0pcJuXLtQ+pJykLChxsJ2xa/2qkzo57bl1eZdvJhyYid5p3tCZ9KMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r+0hatkTyc10d3SuoTk3LvSoObJlUfYlcYtxqjMWP1w=; b=pjHAI+7dIIOHiO9OY+GQPRJdGrcVnt4rJYvrB3mrWnLqltGXTn3lkmmSnzf96EbRWXVlUYAeIm/4asaeCVpvE9M9/7j3QzEWnLDT4QoucmEa/ru7NHDS3SSVfWBR3O1lnbFWwGNwndASCgFreWpOP/HHlAtSoS5BVNtkmXwIgAjMGkW/OMCe7jbMvRkgQxg1ycKBHIdg2lrcEx4K5g9PhSHbd5Cl40zEJEQ2/TKf2ngJ1AWLb/+3mUHRhig1ycXiGpKz98NLJwK2SxWQaEy2KEZiV1lPawKdxhAjFE18kI5UZwVdnz1JyTGPHXefsPNMc9yCvnC319Ud23kwMgCNyw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0224.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:279::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Mon, 2 Oct 2023 10:02:47 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6792.026; Mon, 2 Oct 2023 10:02:47 +0000 Message-ID: Date: Mon, 2 Oct 2023 12:04:02 +0200 User-Agent: Mozilla Thunderbird To: FFmpeg development discussions and patches References: <169623987047.6638.13940830507445718036@lain.khirnov.net> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <169623987047.6638.13940830507445718036@lain.khirnov.net> X-TMN: [DnTW79H3N5h04mKtCl2YN28A6cP9Q+xQ] X-ClientProxiedBy: ZR0P278CA0053.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::22) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0224:EE_ X-MS-Office365-Filtering-Correlation-Id: 4519c355-3fe5-4627-0be4-08dbc32ebaab X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rRuJuHwUUCFb0Wr6DviwmXQKtqw/Co9cuUhI/ik7me/4b7tdQShDu11Ltz/8/mkbf87jCA0YvSH228Qsgr7bkmnsu0Vy8tv4D2m2AL2Kgbe0kucK1AYup0DdjF1gR2/OcsLu9Gvnnon1Re9ryHfFyn0987vwVHHiy5JzBCFoR2XwMMBr/VmkQQ4HXQNnuWxRIQJVyOyFgFBlfHTH9KRTduzyq5x+R4+DkQzCHR2cvHmFQDhZEutEoAadSKJVGy/nB//N2jpq8fmOwZmazquz81Ql3BlsRKrKyRaWnWDhywNCKVDYJDCly5HDf+Ibu98rg2aI4KRYJ+bOr6nL+H6pRICq6/eqaTa43rm57sWFw1soX7NzbhQBbhP3D0BC+veo+emZh3lFJ90FFXSRHYcnMfx1uxe6gCNMc7ZB79Ng5TSFdZPgQbop9d4VYFTGMkfLGvIo0iGO5ksUqhs4vVhht2Su1uzCZYUX45H412sJGstRlqIE9rW+rNfJG1vWNtcGJv1/ZLa4iwfow/PdBU70R4NhcmSjKPqUb96+OnzM6ymaIZZlPfei+Y4od66pkizn X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDlaZDRIZ0xkZHZuUzJ5MUdIZHVaZnVYUDJSQ1Fid2hEOU0yK1FJeXVRRnJa?= =?utf-8?B?Slhsek53YVQrbVVrdEJwRUhWZGhBdFFYY0l6anZaNGM2a3JVbzM4TUVlRXlw?= =?utf-8?B?Zk5HeUYySW54SElpNkkxSmhIOWR6dmo3QmV1NTEveEFzT3BHazY3THE5NXJu?= =?utf-8?B?STkvbVowZllOZEk4eEkwUUJSSi9OR09IZnc1TVEwL0psOVE5d3NKMXY3MzFH?= =?utf-8?B?dGpzTnNUMkpqVjRMYkZxT21yc0hreGVZdlk1NW45dDFpSlZyY21ZcEdySlVV?= =?utf-8?B?MktpRjFSZGxCQ3RXUXlMR256eTVVZXdkSzBXVWpONFBBSHRyZy9xd1NXYWpj?= =?utf-8?B?VkRkWDVKM0s5YzRRYjFQc0R6VERJbm5IRUgzREU0WklDVlZjamFJY0pqdnZh?= =?utf-8?B?WFVvaFQ3UXN2VWUwVEF4MFRxTXRMcy9ldmV5UGkwQmNsNmJ4L0hqU2thTlVV?= =?utf-8?B?OEJDV0dBdUxNczBhRnBhRFFlOEZhR2U5eHJlNWFRU1hyMXgwMzZmcXJPM216?= =?utf-8?B?THdlRVpOTGNGWUY5dW1IYm5qY1o4QkE5N21BMUJpaUFlSDEzOXl4K2FDVkJK?= =?utf-8?B?UkRyZjNyTjZuT01hQTlaWmg4aklGOVl6YjBIRjhTVkIvQVZDYkxpYTlpM1Q5?= =?utf-8?B?VVErcFFNbHkxdGUxOVlqb2pwTDJpK2orUG13cXd4UEllYjNWQVlkcU8rOEtS?= =?utf-8?B?Z2hZSEJVOTlEZlpUSjVVelFXMTNmM3R5eEpYU1JhVGZ1N3FDOXc0cno1T3Fl?= =?utf-8?B?amR0N0lMWWpaSlJnQnhOTzlqTWdoVkpZaGZWSkhDdSttd2h2VnRoMUVZNUdy?= =?utf-8?B?QnRlOXVERWVkT2pBbXV5Ri9yUHpBUWNnaDVwZ25RejlSSWlOZWc1aktudmRa?= =?utf-8?B?YXhIWWZOQVZSRncwMUxETzB4UmRaTHA0RGxRUGQrSVJKVGNLZnFaT2p6TkZa?= =?utf-8?B?Wit3c1VEc2N1RWg0MTROODhYMFo2UFVXU1VpL2dlTTY2c1daSXZybmQrazJX?= =?utf-8?B?WnBNMDU2WWxSWTQ3YVZvTjV2b1l5OWpoUnp0YVkyd0lmY1pwL3A3ckpRMVpv?= =?utf-8?B?WlFwdGFoTktwUFJERnQ5VXRoYnNMYnFER3hSa3dsWWFoYWpYbnFIblZzT3BV?= =?utf-8?B?bXR4VGlnVWtMSmtHSEU5VGpjRzRSOFpWM2YyOCtzc1lPSnBkcFNNVDluNUt2?= =?utf-8?B?V1pRdFpsOS91Ri8vQjdtSDJHQXNocEhIa1RacGQwZk9BVXNYM0h3d3VudVdX?= =?utf-8?B?WC9SK3lmRGpsZXVMTlRvQjA5L0lFcTNOOUhMUGpDL2dSMTNXcFFXa3cwWjh6?= =?utf-8?B?YUZHRlFlNHYrYmRCcjJ0OEtpREpPUWtReGh6ZmpKaThXem5VN0s5Z2FKN1RM?= =?utf-8?B?eitWbmt2MlpvZ0ZFREM1Sy9pZzU0UmpyN003UVdNN3pOTHkyOFU3by9jUGNs?= =?utf-8?B?ZjhLdmhUYUlTMmlQemxDOTZuSDFLWmxMYUZyN3dQeUN1T2F4bjh3RWFtS0Mr?= =?utf-8?B?dnZZTWtyZGg0eFVVekp1NHVYWWJnZ3VXVGEwL1N0SW50WDFxcXZmZU03TjlP?= =?utf-8?B?LzRPRkZ3b08zRTdIQTcrN1g2ejN6RXVCZjJaNStmWEhKUVFlYnYxdkhMSjgv?= =?utf-8?B?MXdvRFFqZXBkb2w0clNTUVZTN0I0YzU1bGdJT2M5MmxwTlp0ZURKMm9EUEVt?= =?utf-8?Q?HvW7sPwNenJ9276qSnKE?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4519c355-3fe5-4627-0be4-08dbc32ebaab X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 10:02:47.3261 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0224 Subject: Re: [FFmpeg-devel] [PATCH 06/42] avcodec/vp8: Use RefStruct API for seg_map X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2023-09-19 21:56:58) >> @@ -139,11 +138,7 @@ static int vp8_ref_frame(VP8Context *s, VP8Frame *dst, const VP8Frame *src) >> >> if ((ret = ff_thread_ref_frame(&dst->tf, &src->tf)) < 0) >> return ret; >> - if (src->seg_map && >> - !(dst->seg_map = av_buffer_ref(src->seg_map))) { >> - vp8_release_frame(s, dst); >> - return AVERROR(ENOMEM); >> - } >> + ff_refstruct_replace(&dst->seg_map, src->seg_map); > > It seems misleading to use replace rather than ref when dst is clean at > this point. > This is done with an eye towards 37/42, in which vp8_ref_frame() will be replaced by vp8_replace_frame(). > Otherwise looks ok. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".