From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id AEEBD403E8 for ; Wed, 26 Feb 2025 08:53:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6097C68CA5F; Wed, 26 Feb 2025 10:53:07 +0200 (EET) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2091.outbound.protection.outlook.com [40.92.49.91]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7FD4A68C0DD for ; Wed, 26 Feb 2025 10:53:01 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vHCryrXFkOn3VAYgxCW5LzjQvtFsvIdfF9FqXyA0J+Xh2I1xWSD/Icvx283hs4qILol1g3BJWH6UCbSTNSUFe+ntbmiDUq4hO4UIVyXEWt+eQC69HnSZ/7wdMzdai5G0/pEwPRKAfION2Lj4Gcbyxoh99WTbaCKwTWdHlpnEk6bqwY7ZEr9TX7Tb8NLpaFAhH3Tdh+kNfgfCUkU0w0v0VbZDfz7GCUIIEQFTd4m3W4WBN9GrSaZH0xY4nxsCgniRlHGqHmTDyL9nHqMvGGFbxXKqvi4M1GhbidfjumskO2umc5V0CDUBEmdzFXtn98Fay4uXL4JD3ZJzLd9HDXjj8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vc9+6BRAetuq+CTEqqg38cpiOMLyLSD935mGXcMDo7E=; b=eqgFkMc4sE3hoOsu12H84Ugk2RpdLPT6r3JrSRryYKWgRTZKIybsOw5jlnPkgZk8+qPRG69XiTauOWwtEMHbIHOXs4WJ2ZOFDFoz+VbtAJBVTS3K2p7qxT61JmFqjP/+U6WNPePHC59svrH6wwCsrxvI5Ku313A0jgGOaJjmQAfuY8VJUK9fcOmL0UGPEfCBflT9tfqQ1iVP7jFHK5eaDzd4KtVy5W6yBe6VIvzcTvFg+rZWKIr8vzAKTX/42gRCSqocyuwlJi6EqaMjvRpJ5c63D7qThzdLXeXUDBD4dcrsSZLoNs7mpbaJI+yAkYu3QbxRoDytl9oZpgmWqTe6qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vc9+6BRAetuq+CTEqqg38cpiOMLyLSD935mGXcMDo7E=; b=GAveWojH0Dx5s3AtpzHDbL5FxxKzwUz5NriejDs5pg2/TxcjHMGf7/W46j5S4NIad28RartpocA8GAGIbEoVNRC8SgkiSFKoZEz7JjUisjeU5TUgMM6OaGPDlcPZzUteId+ocZJs+yh0tIhKlu+vBuX3qI6ItxZAPcU8zF7AV6diWPpaNVSQo6MfbZPU9axg/eHzynIjP2Iys7rkeX8LtDKmcno/aZPgj72mcyJduj4u/w7EunkolXrzaEPI0hsBV+PlqOBdVgeN9OFH3X0nS8/VrhthCQyryGvsTrABTfAQw64iXdAJPrRYxJ3qqz+jvkyMz2YnByy/JzX95Kb08A== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0133.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:374::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.18; Wed, 26 Feb 2025 08:53:00 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%5]) with mapi id 15.20.8489.014; Wed, 26 Feb 2025 08:53:00 +0000 Message-ID: Date: Wed, 26 Feb 2025 09:52:58 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250226040116.1056751-1-tatum.rashad@gmail.com> <20250226040116.1056751-2-tatum.rashad@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250226040116.1056751-2-tatum.rashad@gmail.com> X-ClientProxiedBy: ZR2P278CA0057.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:53::14) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <3ce08890-e895-4f56-95a5-2ed0c419a327@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0133:EE_ X-MS-Office365-Filtering-Correlation-Id: a7220928-665a-4b31-4fc6-08dd5642f8d2 X-Microsoft-Antispam: BCL:0; ARA:14566002|5072599009|8060799006|19110799003|7092599003|15080799006|461199028|6090799003|440099028|3412199025|11031999003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eFQxTlhDZkVmR1c3c2s0WTZPdWhFNnF3MnZuOHRuSjFHUkZ6dzNrYTRjTllG?= =?utf-8?B?TFBZbjhtOGZGdWJ4OU1nRVQwRTdYRzkwN1J3UjJBOWExRE1uaHZQdy92L1FT?= =?utf-8?B?MFNqc1FXSXRkMWhhNVJCSjNwNFVYM0Z4dFJrR1ZvNWZQdXdYSXdyVS91ZytE?= =?utf-8?B?TlZ1cm1SV0JwQjZpWDBsL2w0NTUzQ1EzVEdnQWwvd212L3oxZ3ZUeHZOKytw?= =?utf-8?B?TWJQNEROdUlyZG1sL0tudVR6R1JUbWxkUU9OMlo4Zmc0T2FCTVJqaTVUZTY0?= =?utf-8?B?VElGamRQYjljZGVDUnJMS3F1a3JsNDRNRVRLenU2cEVjYU91Tm9KV0JTVksr?= =?utf-8?B?d1RaYzlTTlR2RHpuelhtS24zZFpSenR4ZFpzM3ViWTUrVDhUWTdVU1VVOEVO?= =?utf-8?B?TGFSdnN5ZUtIUU5BV0lrYUIyNWNvVnNGeWJVMWV2T0ZxMGRDcDYrRFlISzJG?= =?utf-8?B?RldwTnNJblZ0dzU2ZzQvT0xvZDByNnd4NlF0WUcwcVhxelMxb0NCT3NHNVlW?= =?utf-8?B?eW53TUFPREl1cUtXNkNHb1BzV0lWQjRmSWtPcjI0NXFvanQ4M05EbEZoM3Vk?= =?utf-8?B?aDBxRFQzWm45UVdudFZ6NWx3c3RwNmtXS0dRdHd1OWNjVHlLZFR6VDh3dzcz?= =?utf-8?B?NS96RnZobkFKU1NvUE1BWmdmU3BQbWJVTkZBWmI5Z01PcUZRb01aazhaNllC?= =?utf-8?B?Ty90aWVXSWErdnhSakRTaGRsdXhWak9wckgxaUp3cnJnNXhLbjk3SlZjVzR3?= =?utf-8?B?TWloK0pTS0Y4MEpNSWNoc2U0VVE1d0o5TzhocUNYc1p5SXFiWVN5ZWdYbEpN?= =?utf-8?B?ZGQwY3dtSTJBNytyeGhra2cwMUFNMUhpQ3FkTW9wSGZxUlNIRmEyVStBcU02?= =?utf-8?B?a3ZNampuTXFNelN1Rzc1YWdDbzJjQ0o2L3VicSt0ZWhBNVdOWGdXRzBScXky?= =?utf-8?B?MUlncmYrS0IyNmoxeUMrTFZZNXN5ODEzL21HOXRtVC83L2dtRGZGRWZuZ29G?= =?utf-8?B?V0lWeml1aXFjUFQ5UmFkb2xHdDVUMVFLSXJMZWlyMzBWTm56K2k0Y0tYTGI3?= =?utf-8?B?VWQwam9WWDZDT3BqRnc2anQ1S3lLMnpvckdWdGI2d3NRNzIwcVY3VzB6S21l?= =?utf-8?B?ZmxwYWh4WVhJTnhhM1JMWW4rSTEwU1VNWWJybGpsbEIxbEJ4aGhobDJhRzVn?= =?utf-8?B?a1VUQXhwajgxQmZuREViUlROd2o0aWVQMDlGbGVVaGRtVkpYcHNXaEpOMlVW?= =?utf-8?B?TlJmQXZZbkFPU1c5bW1JV3hXTFgyUVBjSHR2TWFjMVE2MW1PRXJmQ21nVzMz?= =?utf-8?B?c29LTkRJMzdJeTNxZHdQNWZNRjJHNWhHU1dINnIrMG16endaeFBPZzNtVGxH?= =?utf-8?B?RTVZYnRFUFVENWgrMzhnYU9QV01uZlRROXJ6azhTQVNEUENLazBmN2NQUHBx?= =?utf-8?B?U1NkYWJ5VEJsdUhzNDcvTDNDcXhVN3dLL3BWa1YwaEZGeFB5NzRqSFhGMHlk?= =?utf-8?B?eFBOdUJ0dytJT2xWUlBqdG1kZEovazY1UlNLcnJiMHJPc0hHQU5MK2EvY1FQ?= =?utf-8?B?aHAwUT09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0JXcmwyWmgxQ2dwUkwvWklDVysyK1MrdzhFeXd3dXZBRWRFNzZSYmtjOXBC?= =?utf-8?B?Y3hpR052ek02L2h6eXJzUHU1c1ZqbmE3UVVvaUJoUm1HUzZ0M2FkMzR5MnQz?= =?utf-8?B?NjhKaktuaVhaL0NSd1pVVitRT1RIY1k0V0NTRmZHNWRJQVJ3MFdFMmFPWktq?= =?utf-8?B?VGFtMFNTaFpTNGhOU3BiZGtRRk5xRisvcnhkY3RvSEgvREo0WUtab1A5aHow?= =?utf-8?B?Znd2QVVUanhGOUIzTmRzNnpUNlZUbHJxaG9PeTh3QUZEaG9WVW1pSjVOaDgz?= =?utf-8?B?a2tmbURlMThjOVg4a1d4b3NjNmlvT3hnMnQ3TnpZMXN5YndzRlAzWnhFL1FT?= =?utf-8?B?enNOZmhxaW1DelVKWUlndENBdlFNVzNiODRjNnhjQVNId2FuYUh0eGN1aVQz?= =?utf-8?B?Q0RYNHN0YlVKWEZVK1pYMlJUMHhrK3lwWHAyMTlobkhwTWpJMXFzU2ZNWitK?= =?utf-8?B?NEt0U3JzVEtUeGtobHNpaFhCZC9VTktRWE1YMzg2Mm9iRXFPRFlEai92eG5o?= =?utf-8?B?NCtIWlVvcGNQdEtxR2ltZmM0eDAwZjBTazZuNC9RTnJvT1lFd01JWW50OU5P?= =?utf-8?B?cE9RT2lhUS8xY0lDU20rTDAwbW56eU14MUFuYkdxSFZHdERNWFE1ODVYbGdP?= =?utf-8?B?dUNySW1mZXhYS1M1NHFlMmNCWFZ0ckN2SEp0ek5KaHVMVHVWR0dndWpnMm0r?= =?utf-8?B?c2xiZURScFViOXFtM1FqNDBOSGJtNnNOZ2tvQWZYUktNdG1MSWMrbDZSYVVP?= =?utf-8?B?V0xVMkxvbFY5SlFnTmRvVnF5M3F6Yk1zNXBDd3hZanRiOThNNHZiTFY3YzAx?= =?utf-8?B?emd0VmUzRjRWeXRETmZqaGVPeUlySGpENHBPMElnVXdUc2dMcTcvclF1ODZk?= =?utf-8?B?Y0JsUWJ2WTRmV3d2VFFYUklHVW81N09SNDI2NXA1aDE5elVaTkdaMnVBazNO?= =?utf-8?B?cjg2REZUVThEWm1NRFJzMDg1dGt2U3RTWlRzbGIxZ1BxV09ndlRTMCs2ZU1q?= =?utf-8?B?dkVxS29YOGZrN0ZSUnYzRDl5bmt3Uk5uOEhuWGNTQ0FJdXpVdEJ6bVErZnUw?= =?utf-8?B?STJXKzV4bWZZVXZJV1F0ZXg1SWpWbkhCMnNSMHBud1FXc0pkd1pET3ZYTitr?= =?utf-8?B?MllqVlowdFFYVGhSVEhRcTUxc3Bsc3dhRy80cXduVjVEUFNsbU0zcVlhdlg1?= =?utf-8?B?OXgwY0VIbDd4SDhjaU9RQk5lNmlsK29OZ1ZtNW1rdDEzekJRQXgvMEZxMmVI?= =?utf-8?B?cWMvK0l0dGl0Qkt4WTRJbm9nVnVPbzVaaWovY2dIb2xBOXhad1c5YXFpdnJ1?= =?utf-8?B?SjN2Z2JPOXllcnpEbkovSU1vQkV4YXBHaE11eTAwQmJQdkxkaTRSMkEwY3hw?= =?utf-8?B?cFJKRDFvTHFYTSs2ZXpBR3lMdXRBYmVHUkxiWC9EVGtPbStDRlI1TG1EWGNH?= =?utf-8?B?WGpCK1VrTnNLVHA4aU1GWTZRQk9qSWFYRnQ3MWwzZHRyTVZQWHVabG0za01G?= =?utf-8?B?S1VwR0tleE5oc0JKOG81ZFZBRm5vcCtidG1GZTN1cWJDcG13TFM2dVZUMUgz?= =?utf-8?B?UURwV1RvWm80NFBrbUh2U2UyaFZEM2N0RjRjQmM5UUVJam5GSDBFU1ZHZHov?= =?utf-8?B?VUp1NGNBalFFOG41ZHdKbXp3emljbWh1WWppaFBiM1c5VXppOUpqUUFPenlT?= =?utf-8?B?Rnh6SWdvVzhVKzhBdnRlLy80ZUU1N2NWWXlsdkozOTN1RnJ4b3h3a1JnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7220928-665a-4b31-4fc6-08dd5642f8d2 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 08:53:00.2068 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0133 Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] libavformat/rtsp: Free memory allocated for temporary variables while processing sdp info X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Rashad Tatum: > --- > libavformat/rtsp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index 0c65f8d1a4..ac17717195 100644 > --- a/libavformat/rtsp.c > +++ b/libavformat/rtsp.c > @@ -478,6 +478,7 @@ static void sdp_parse_line(AVFormatContext *s, SDPParseState *s1, > sdp_ip_str); > > } > + av_freep(&sdp_ip_str); > break; > case 's': > av_dict_set(&s->metadata, "title", p, 0); > @@ -702,6 +703,7 @@ static void sdp_parse_line(AVFormatContext *s, SDPParseState *s1, > } > } > } > + av_freep(&dest_addr); > } else { > if (rt->server_type == RTSP_SERVER_WMS) > ff_wms_parse_sdp_a_line(s, p); Your first patch introduces a memleak; the stuff you allocated there should be freed in the patch, not fixed up in a later patch. (Also note that there must not be a leak in any error path, which is not true when your patchset is applied: dest_addr leaks when rtsp_src can't be allocated.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".