From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DBF5748B6A for ; Sat, 3 Feb 2024 13:56:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EE81868D0DD; Sat, 3 Feb 2024 15:56:05 +0200 (EET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2029.outbound.protection.outlook.com [40.92.90.29]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0298668C954 for ; Sat, 3 Feb 2024 15:56:00 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SLtvGskL1h5OYcpiCXZRHeVwvr8caJ4pJumelh1JRBMcIl9J/K3G3tJtLt9LiFU28fg62M4D0+iNwqUuIErwnKG8qLg+Dx14aQH/Ss7x2yLr/EXtCxTOokXlMnkNu6i+3CXGaldhVEqdV7nwQQH9wMr6ujxxJ3GkCkSt5q+k+dh7EvXSA+uPH5WZmyyHRIqv4pxIiYafFr9EU7JQZFCpbYFMe7Ggt3DYiVWoODUp1fifGsZGP+AEaLFUNZ22jwVdEng0yKtGHdGEHsfdRwwJ3vuYziyz7JP8nF9QOlV6+Fhou0gfCm5gpG7IDDD8kr/2MViI/oZeHAZsmDr3LJr5PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iglt0nvYu8G5wLCjDmOW6YAKxTUkx9UKMGM5P89WzWg=; b=ijtQTVamlWst2HBJEC3DJjPoyOWLHgUb6VL7ZA+zXNsmA4ATyotG0L0ZA1GYoFsnQ48QBuOrZsqrXn9ZGtn5qUe0CkTparQj9K0ZV2iU+vC0Wz9WmgVY1wioOe5hZhV1UN8L2bHO1oywuV+sSHdyhJWNEvpkFa/TUJUo8ZQNdnzW2SCIbuMwOAMTXYpa/EIegfH663xX5PrWAU/R/NcEGbqK69ZXDhSwW1Kzjfb6XilwQRl718U1vbEUz16kTN6P2e72AmklIGvNmsSEdxR/hFOI82gvWo1eSvhT6DDSYs5jPwwL9dF40at9sIl1+BNnOAMjLzxITBowvJNjDkEWKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iglt0nvYu8G5wLCjDmOW6YAKxTUkx9UKMGM5P89WzWg=; b=tumOa2QBwwawIvrmzOWgFehnQ5wn193t9HAv1CNduXsv1CVN0wCNG3Ouh5W7Evy03FTgsEnDQLxJIav+g7XQaTMArVdp0NMe16kStcgJsF9ZMOKYHHbFUyfsRmypedykOyj1uy14OfD22fAr41ko3tykXEYEBjhZiyWO99FPJxxpDka1LZ5NixCTsktMOEgHxLBdinbdiXNbXmC69ifT7FY+yQAfIwuoCtbBfThg+8K5HeORMJWzVHyNo3JIDZiHQG5j/6kEWOJkEeHBtFs4Lw42LP44B2fmmfD9QKDtTbvqowbqRjsXbWHPxqFiXOc6ONIMvp2BxwZTl05U77R+Yw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0024.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:14f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.31; Sat, 3 Feb 2024 13:55:58 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7202.031; Sat, 3 Feb 2024 13:55:58 +0000 Message-ID: Date: Sat, 3 Feb 2024 14:57:51 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [Qz0AMVA0wzWVxKoQDA5V5Pb8zJH3xHHCAASfU1w7PJg=] X-ClientProxiedBy: ZR0P278CA0097.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::12) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0024:EE_ X-MS-Office365-Filtering-Correlation-Id: f3577370-623e-48b7-bdc8-08dc24bfd926 X-MS-Exchange-SLBlob-MailProps: obhAqMD0nT+ERw+OxinLks2okyJDipwkdvBo89yNbpzCQfTXMqBGxi++1vRHzEsQjHh/HcFU4GTQ30uFk6ZUfi5Iq/C3EdnZ9qUU+YO0nOVrXOz5UO9iAO/T6pQ1ZJAQua8V5ZuSoSYzGj7bLbMsGlWQA7XdOUD62X4fcPu3e61rwsdnJMo0DRfUMvTSoG2xItHKyiKzkkrT+QpYALdltZ0EBaJ2Dj/uwPXbQTDqN8cbMJK+AFGea0c+VysALZWzKgIjBnTOJp8HJj3IurZMC2GmP6QfFsDhY6QNMDqNgPQimmZKb0byR1175S5CWff+DUL1xRPBy3PqUsFgRrz4JUEC+EXY0ZwHsEVw1VYN2oWUbmpTu5mlWCBf39Z3S51wYWKtbxYgCUGoxKMNJNAyW3Sf5tBpg+mivIHF+rq8WLSp+cMEJxvaY2qXvcKQG2rD1IcahbcyytkcFdsxY+p2dXfXtQtXc5LS44ABleB8mMX9Q+qpsLvFt+8JT7C4yRQuVl5x92oNhVLR6ea9E6XRauHtqit7iGBizDJzbHnRn4JCzWdNiXyaNo83N+np8rUk46jrnZP0vszE5iENu/64hdLJC1kgJhiKm6jXIQ8BUtKSFTeF79TAU+Yy83quR4aRBkWqiRkZlLfxd2us4Qn6ADIdFcmvdw6/CNmhrgm6XuhIxOPhz2r8aRk1I94WOTnZW+thzP6hNHWar5TiVAI1jmgruADOUa6e1CnNFQucyIpMH44gdERA7ng1UWThXmNJhyJliZINKWIK2ONb++kuU3JqFOjCkAw91rj+D+KRelk+Hry0jQAUT+mzUqE3KX8U X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 98PppaNA43erFCYnK4I/Vp3jxseE7sjXkqN8gWgxzYtJPeOmkMU4jokc5pZuX7Uu8i90Hp6+Fmmkw3g7rqp7eOkscVWcPxD1pk/kYKKmrEkUITzTFolypuBV2LZV4CD0WRbDCiCKJ7/LFl5+k8KvMeQs4+vqYjrKQayzpnPFQ+Ai0KH4U8ZYoACsKFGWs4H4CNx+vC9mSNkz7CSZigMQijX97Vtyr7VCupzTwibkY3JQQhT2xUOpxugk58Ku9cjTj097cpbrNZ/vbbvQjEqrT1qpUvQvG472gF93d3TCOav//tSv9hjor3cFFIzX7dYx+DKN45XjkS8dbspn/uTIdfsN2XLAbNVo66owWpiKuJDg5ZsL/ItAB9y+IqvqP3XlzquRGtIJvzqvd6DmcAVhmKXbOkdfY1VUjTymTo9n/66r/+ShUIJJL3UCnudxMJWQMm63rOKDGV7fNB4W6mow6rxkhpio4YRI7VGYXG3/VFxnKjLWUySdlYp+H4PJRDky+X10jsLo96P0MDCpgLJC07KxykQgxyzN1jV00w7+xO9paifoAGPoGXj7B6sCz5Qj7MRp2HH1tJGfeXOFVsA+BrAj1OeBV7GXmYBm5LvSKvw= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHh5SjZqUHhFUFNPMzhaR1JiSkNCR2xhTXZDWm9aTTJ1VXU1L1VyMEV6ZnE1?= =?utf-8?B?eXhaTkd3SHlFSUM3WXgrSlFlbENjbjdZWUwvK011N1ZjMG9VdzEyQVR5MmFW?= =?utf-8?B?TFh3dmxWMUV6aUl5U05YU29qVWNkVENPWkxBMnp6RUcxMVgxQmdqSHhGVUhL?= =?utf-8?B?dEFKQmoxVGZWU3FFbzYrT08xTXVFZmh2T1YybDU5WUZYalk3Y2h0UEVjRjB3?= =?utf-8?B?TERJWDBuMnhZV1JkQnRCZ1FSVjVmVkxpL0loR05qa3RiWWZEMHJleVdNSjhy?= =?utf-8?B?SXEyRCtnZitHY0huMzRtMDJyNzRxRnUwZlhTQzc2RlJFcGJIMHQxcTZmRFp1?= =?utf-8?B?K1hZQ0diYXdSVXUrZHpCNnNPWWVBamhIOE9DL3Y3blVhV0tObzRnaXNpT2xY?= =?utf-8?B?VUladENTRmZFblVTUy9LQTRoS3pGODhzSVQ5WU9lVHp6OFFwM1pLVXh4ckFx?= =?utf-8?B?UVdKUkM2YklMSStVbERWNjlwclVUQ2FjVUNoOGJRdll4amJVNHhxcFJOVEUr?= =?utf-8?B?eFI4UHNKR2dtbjV5N2pyZGFCNzBDZ1FXZnFpczRlVk5qelZ2Uis5am5idUdp?= =?utf-8?B?Nld5aytZU1ZhM3kwZjRkR3JQRGI2SFVGQ2hLODNnVDZjeHhVenZBOFRZSE1l?= =?utf-8?B?M1JhdDZ6SHRKM09mWlZ2bk1BTEs1RVFPN1VjeEJ2emFWVlIvVzdlMmQrNFhj?= =?utf-8?B?SUREcjVXQ2VHNjJrWXFPdStPMU9mdEJzVE53bFdLenR0NWg0dnQrY1E4bGNS?= =?utf-8?B?TFlPWVZqc0tFN3BRK2dOSktwZ3V0dlF2aTVieEM5dWhaNWlNNU9sZFN6NEZM?= =?utf-8?B?QksrU3RPQmxzcFh0S0hTUW5xZHVSZnowNE51L0lVenh0Z3ZFbDM0aE4zaXY4?= =?utf-8?B?MjNYL0NrVGYyRC9IZXpnTUJUQzdiR2VwOEFSM01VRi9oOENrbXRaMlJONnNO?= =?utf-8?B?M0VVWnFvQUwvMkpRN1l4R3VhMHlCcVQwbUdFZllOYkFxTXcveW94c1NIY1ph?= =?utf-8?B?N0IwMCt2TlA3dnNsYUQvSjY1WFJaRnhZdkVXTXYxUHpYY09DdEQwb29QaXpn?= =?utf-8?B?bysrQVRMSVROY0psZHNNZ0o5RGNFbFRaeDJ3bVZ4R2FMQzJwbVE5WVprUE1L?= =?utf-8?B?aFJPb1Fya01XZVJHYTZaNUxQVEQxbUQ0RytabFZpNlhESHZaY2k2K1VSc1Jw?= =?utf-8?B?bUI4aTB4RFRjdnRlTzdKenVzNHJkUVhpWFBRZGROVE9pK1dkV0d2cjdTc1B3?= =?utf-8?B?em5iWUtNdUFTRkFUMm5YWnBSV0wyNzN6T3lOMDBoeVk4YUlla0JaNTNEMWJE?= =?utf-8?B?S2QzOFFRc2FXTmlWdGJxY3lVOTM5SVZpditQRzVCUlpnK2FwcnpoeHc5R1ht?= =?utf-8?B?Y2lGVlBNVUU3TTE4Y09ScGsxRXBZQVIvaWExN2FxdUtlTXZ4RGtCT1h3aXBV?= =?utf-8?B?bHJiMXJlTGxjTDhITDVUdVIyMG8vQ2hTK2ticmpRZkVoSnV0Z3RaV25SSHo5?= =?utf-8?B?azFoN3RIUFlIZ0Z5NFpJVVRyY1NWbXpSS0ZnT2VQU2U4UzZVMytIaXBJbVZx?= =?utf-8?B?SFVwRnZJcTJ6WTRTb3QvdnpyaXkyN0JlUXNtTzdRUnFuaDBrbDMzOFhmazBn?= =?utf-8?B?SFhXVGVTb3JXcGduODdlYlNtSXZyaFNocjZzWDhLSGF6em04MmRrczc0VVUv?= =?utf-8?Q?KNeEruiMIzpFGwh2yMqu?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3577370-623e-48b7-bdc8-08dc24bfd926 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2024 13:55:58.2407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0024 Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp8: Enforce key-frame only for WebP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > VP8-in-WebP only uses key frame encoding (see [1]), yet this > is currently not enforced. This commit does so in order to > make output reproducible with frame-threading as the VP8 decoder's > update_thread_context is not called at all when using decoding > VP8-in-WebP (as this is unnecessary for key frame-only streams). > > [1]: https://developers.google.com/speed/webp/docs/riff_container > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp8.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c > index 83c60adeb0..7972775a1c 100644 > --- a/libavcodec/vp8.c > +++ b/libavcodec/vp8.c > @@ -2665,7 +2665,11 @@ int vp78_decode_frame(AVCodecContext *avctx, AVFrame *rframe, int *got_frame, > if (ret < 0) > goto err; > > - if (s->actually_webp) { > + if (!is_vp7 && s->actually_webp) { > + // VP8 in WebP is supposed to be intra-only. Enforce this here > + // to ensure that output is reproducible with frame-threading. > + if (!s->keyframe) > + return AVERROR_INVALIDDATA; > // avctx->pix_fmt already set in caller. > } else if (!is_vp7 && s->pix_fmt == AV_PIX_FMT_NONE) { > s->pix_fmt = get_pixel_format(s); Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".