[FFmpeg-devel] [PATCH] avcodec/libvpxdec: Remove redundant unreferencing of AVFrame

[FFmpeg-devel] [PATCH] avcodec/libvpxdec: Remove redundant unreferencing of AVFrame

[Andreas Rheinhardt]

The AVFrame of a decoder with the ordinary decode callback
is generically unreferenced on error.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/libvpxdec.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
index 72ef5fa9a7..c6187fd5a1 100644
--- a/libavcodec/libvpxdec.c
+++ b/libavcodec/libvpxdec.c
@@ -317,10 +317,8 @@ static int vpx_decode(AVCodecContext *avctx, AVFrame *picture,
                 return AVERROR(ENOMEM);
             if (ctx->has_alpha_channel) {
                 picture->buf[1] = av_buffer_ref(img_alpha->fb_priv);
-                if (!picture->buf[1]) {
-                    av_frame_unref(picture);
+                if (!picture->buf[1])
                     return AVERROR(ENOMEM);
-                }
             }
             for (int i = 0; i < 4; i++) {
                 picture->data[i] = planes[i];
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxdec: Remove redundant unreferencing of AVFrame

[James Zern via ffmpeg-devel]

On Mon, Sep 18, 2023 at 5:40 AM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> The AVFrame of a decoder with the ordinary decode callback
> is generically unreferenced on error.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/libvpxdec.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>

lgtm.

> diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
> index 72ef5fa9a7..c6187fd5a1 100644
> --- a/libavcodec/libvpxdec.c
> +++ b/libavcodec/libvpxdec.c
> @@ -317,10 +317,8 @@ static int vpx_decode(AVCodecContext *avctx, AVFrame *picture,
>                  return AVERROR(ENOMEM);
>              if (ctx->has_alpha_channel) {
>                  picture->buf[1] = av_buffer_ref(img_alpha->fb_priv);
> -                if (!picture->buf[1]) {
> -                    av_frame_unref(picture);
> +                if (!picture->buf[1])
>                      return AVERROR(ENOMEM);
> -                }
>              }
>              for (int i = 0; i < 4; i++) {
>                  picture->data[i] = planes[i];
> --
> 2.34.1
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".