From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 36EBF437A1 for ; Wed, 26 Oct 2022 23:33:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E1B768BABD; Thu, 27 Oct 2022 02:33:37 +0300 (EEST) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2087.outbound.protection.outlook.com [40.92.49.87]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E22E368B940 for ; Thu, 27 Oct 2022 02:33:30 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MZcod4O7CPGjPchGQVwZivq02fZGULA1aetylbUNYf4WakvncPsKzjB++ir3a/9K1vf1pexIISxLHB/KSUvwD5J18wcahGEmvh14NcXxkEuaCLfbKM804PShY6li/tcZJ0qkgvAKeAs+CEJwhzhs1BvMlrOgkwiy1mRWN1eKXBdDCkbsQuW/kfRaoxc3QroRYAuGaixTWzLfJTRYRJV7VX3QuLb9ei18KyF+KIHdzUXnaY3SUcBw6pPVi4gIaFu2iCVjd/npTZ3DyU9pQo/lJSy7/H+IsN33DP+JeBVbvUR7HxZF9ML0cn0whiHhggkgEweBAJeszEY0hD02S8/tvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R8QZs65KcX2g26+SL83vg05a+qqMb4JROQi75W41vJY=; b=a3sCjn8XNM3ff0J1Ey2uPJa3Zv5/6PfKL9I3DGXUfLRxqXxeTAVsB3nclCR57i6KP3HUmkWYmrVF/lhIRu7woo3qJyiuy13bPQH/yKy3Gw+ph+2lqihzLCAjcqt0ukGT3gGiV8IMTei4nyFMx0pdY4+LERDiUtFSPCuDtg3oz7JG4JauCw0wla1HcFekpJTU5mHw6fuCks1UJMqbRqANDDba8+88a6wIKH0U+U3p5+Ombf7FGusTO88z+Ry84P/rDKhJoe3jQpr1XcmbyN2tIjn+JnmGUi5kbf3gYac8LkhgUh5bNT0a15ww1jvJP4PaPJd9fMSBeNlpCJMYzU5PAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R8QZs65KcX2g26+SL83vg05a+qqMb4JROQi75W41vJY=; b=WrZmBLfKAoyhKEaMf/MrwUhUjZlQVP7YAka/5tph9dO2C6ODOzQ0vxOhhILrDagKgoMt4Kc03lVm0bt/L3Oj0fdilOO9VnwUj5ZL/k8b0KxBHr6cIkKXcLaho3OS/QIrLqrNqYKFpNe1vxXG2Fol4Dqc4Yx2pV4DDgigZ7HuriXWO+DByYVIW2zMCCz2+qFEiGL/d4tMwkyL6by/crCFQYm3ZTx9bvHFH34/uWvMItq68fmJjq9Fh1yvnNDkLtzTBYsMzoG/T3pmoi3L7MGeRhW50QdbzqMZh6L1n9MPK3/zewPDjoJwtcMr062eDm6C1wY6WnOP0oiYxLxyodJxfw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0294.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:329::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct 2022 23:33:28 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f9d7:680f:70c4:44fe]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f9d7:680f:70c4:44fe%7]) with mapi id 15.20.5709.015; Wed, 26 Oct 2022 23:33:28 +0000 Message-ID: Date: Thu, 27 Oct 2022 01:33:39 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [tIIyd5R8XUThapJBOhniGLWTePzguCdZw8AsJZiszK8=] X-ClientProxiedBy: FR0P281CA0084.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::23) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0294:EE_ X-MS-Office365-Filtering-Correlation-Id: 000e5cc6-5650-48f7-7e6e-08dab7aa7be3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l2+QNjw2tIuH+1M08jmz2riw+nOWNWIwo1DFhUX75fm/nZ/wMr7I2VK5HV/gEmWh6+KGPyIvTxcLhqTsjTg2B+16Y+SVuQ488AccZscsTi3LtLu/FPa264tBIwHu7Q2jvAUMmRXECYcdYno+lo31yWxY1hlb6kiblAgSm0WLSgHCQnK3SkD2n9+YYv/VdqyFjqKbqE6yUF9qMPQrWvLmAoQHJenhn4jtwdHMgYbZOfOJ2kBetP0mG9wd9BoUpk5nnK7fBCSCiLXdFG4opTHwp3/bKOVV1ghebQ1TpDRJzALSuKYtUUInVzcMjAp6swVpTsOMiBYhJt0jVgkl8rOMdRoc6ZIwMU3+hDerwdM+7+9ilmDs3tV2scweWUAmI/F6gPXBg/Tmuef7RUmrOoLicxG9TinPv35c8D3eNWAFoGopjWT8zhwZv/5WM6R8vMO1WzKci5TxyVC1vGRTwcA6Iq9vbk16+U0z9e9VPyO5zcqHXgwvSr3ElXNzEnweC5xSlMHvUGnzHTt4hFEyRj2L2PNfR1xBmwRHDbWd9I1dMgubTigrLEHilZcgVSK8SSpIoCpexQ5zzPC0SnQ8t6Mcun6DK6Ih3X+zUCfjr+5g1K7M3DM9sFGQmZt98qi92EJpCXHBe1xF1fmP2u8SuWEU6Dsma0xfrJ2F9p4Ce1fm/nJgT7RhynqF/mFugPrp/ORi X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjNTNlRzMUlHMjg2T1pXRUJwQkVFUXYxOGlacUc5Yk1FSm1DQnZJclRqbEJJ?= =?utf-8?B?aG1RTjhlQ2hhdXk2cThWVDJ1M0owY3BQNldtSVJSZUdTaE9QL2NEODl4NWx0?= =?utf-8?B?ZUR1VXg3Zy9FNEI5MFhRVkI5K25WekVrUUNpL2hYc2ZtVGtXZUMxeXlkZFh3?= =?utf-8?B?N0MwMGFhcHBwai9Pc295SGtHbVN6bnUxRkVmWmU0dG5mUmo2c3VGazJncnR6?= =?utf-8?B?VnRMMFgxQ0FIeEx3R3IvS3JnWjhiY0pET0EwRE92blR5QnJObGxmUG5ITGtw?= =?utf-8?B?QU5SYTNGdjN5V0REK2MyWXBabGN6VUk0dzlLa0VNcklqVzBRRHF2WlczeVZr?= =?utf-8?B?YTJOT0MrT0NEOHc2czNjTnVWN1hvclJBMFVFNEN4cFRibWJtT1Q1K0pRa05w?= =?utf-8?B?bG4zZk1DTFBqOUdkV0NuaW9sVTR1YXp3bHUvNFdYc25uOVIyVzNZVm9nSFF0?= =?utf-8?B?N2l5dkNlVVd2YWZGUnV2M3lEb0lPbEJoSlcrcnJPZ24zSmRGeDcwVzNsU1ds?= =?utf-8?B?SFlQSFh0QTBwWWRXbUdWdDVjVnp0UzEyUnNqNVFFRlIwNTNUYkNDMng1Y29L?= =?utf-8?B?S1RhVDlZWUlMV0JidXdXRXBsZEFMZG5OM05tL1NyM2tTRGRTa0JqZk1hZXZF?= =?utf-8?B?NVY3K254cnRHU2w3VnhoTUU0dXA4a05kdWJNUlF5aE5wZjY0QXdORmdZOW1z?= =?utf-8?B?SVNxckhVZjg4QnBiR2xjMG54YW10Y0FQSE1DNWJPbHR5anMxUEdWc1ViWDds?= =?utf-8?B?a3FId1IyV0JobVozUWZDbWVlRFFEQVFSSm8zdnBvVGpiVkpLQVozdk4yVjNx?= =?utf-8?B?VTlnK3NlM3o0eFlOb0tXVXNaMWdjOW1TREJkZUZuWTQ4N2RoTEFUQVdxaGtj?= =?utf-8?B?TC8reUxaSnhyVjBraUoxZUlRcXpXTmpreXN1d1ZqRUorMzJyVVFDRVhsWXd5?= =?utf-8?B?OThzTklOZElvSUtOS01rQnh2SytjQVMyR1o0djhwS0YrUW1kZmNOYUQ5MGN1?= =?utf-8?B?ZGtJY2Q4M3ZUbGlLbXNTWFh1d0Y0WmRSRU5YRms2RzVyM0RIdUFiM1BVaC9W?= =?utf-8?B?WGRsOVV4dmg0YXl5cmNtOTk5WWVadFI3TmtrSmJPTjloclpNa0ZTbEJVYndW?= =?utf-8?B?NlhVT1FYUHl3MEhwY1l1Zk5nOXdvL1NiNklic2l4ZmJoWG04UWthekNxN2pW?= =?utf-8?B?bkppUXJzZ2M1Q0p4RS9UZnR2UzhNVzFCVWtweFlMOHV6NzBaaVFJd01WOHY3?= =?utf-8?B?Rk10bWFLU28vRlJRNWh3TmEvZHNIcjByQWNtc0QzL0k4SVZCamtiNHE3ZVR2?= =?utf-8?B?dEo2SGlOR3Q5ajFkeURnTHducURZQlhxWjl3UElWTzVlKzJlb2E0SG50S1My?= =?utf-8?B?eS9NY0t6bmlvMDFvY0paNWJadm9FaU1KQ3dzeUxKRXpEWHF6QnVKMWQ0U2Vv?= =?utf-8?B?SHI4TnpNNDFsamxmcTQ3bklwd01WUXkrelhmNWhWVnFteG16Z1M1MXc5SGtp?= =?utf-8?B?R0ZCQVBZb1B3RDJ2ZmNLNkdNeHUrMFpiQWtZcG9qdGpyMno4OXpvdE5GakhH?= =?utf-8?B?SkFGVWFyN2ljZFNLT1dsWjRvbSs4c3RiNStYMEhVQ0Z2OGQvSnlhc29rQ3BO?= =?utf-8?B?R2Z0YlJoUDA2ZDlZaTFCdjJFL1N5TjJnbDZLY2VFVVlDU05hd1lUV3htQk96?= =?utf-8?B?M1U2RlpRbzBQUXpsNEZ6Y3ozVjlXOFQ4TjNockhBM1JIVDNneG9yU2dVRjR2?= =?utf-8?Q?Eh+0giTySfdBgMFFx7HFRsX6LP00n1mQ52XMtcU?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 000e5cc6-5650-48f7-7e6e-08dab7aa7be3 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 23:33:27.9675 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0294 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Don't initialize H264Chroma ctx unnecessarily X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > It is only used by the decoders' lowres code, so only initialize > it for decoders. > > Signed-off-by: Andreas Rheinhardt > --- > configure | 4 ++-- > libavcodec/mpegvideo.c | 1 - > libavcodec/mpegvideo_dec.c | 3 +++ > 3 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index eefd103414..dd207769a2 100755 > --- a/configure > +++ b/configure > @@ -2754,8 +2754,8 @@ me_cmp_select="idctdsp" > mpeg_er_select="error_resilience" > mpegaudio_select="mpegaudiodsp mpegaudioheader" > mpegaudiodsp_select="dct" > -mpegvideo_select="blockdsp h264chroma hpeldsp idctdsp videodsp" > -mpegvideodec_select="mpegvideo mpeg_er" > +mpegvideo_select="blockdsp hpeldsp idctdsp videodsp" > +mpegvideodec_select="h264chroma mpegvideo mpeg_er" > mpegvideoenc_select="aandcttables fdctdsp me_cmp mpegvideo pixblockdsp qpeldsp" > msmpeg4dec_select="h263_decoder" > msmpeg4enc_select="h263_encoder" > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index c436dc8001..697438fa6f 100644 > --- a/libavcodec/mpegvideo.c > +++ b/libavcodec/mpegvideo.c > @@ -275,7 +275,6 @@ static void gray8(uint8_t *dst, const uint8_t *src, ptrdiff_t linesize, int h) > static av_cold int dct_init(MpegEncContext *s) > { > ff_blockdsp_init(&s->bdsp); > - ff_h264chroma_init(&s->h264chroma, 8); //for lowres > ff_hpeldsp_init(&s->hdsp, s->avctx->flags); > ff_videodsp_init(&s->vdsp, s->avctx->bits_per_raw_sample); > > diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c > index c2d6d8bdd7..12c7144ffb 100644 > --- a/libavcodec/mpegvideo_dec.c > +++ b/libavcodec/mpegvideo_dec.c > @@ -51,6 +51,8 @@ void ff_mpv_decode_init(MpegEncContext *s, AVCodecContext *avctx) > > /* convert fourcc to upper case */ > s->codec_tag = ff_toupper4(avctx->codec_tag); > + > + ff_h264chroma_init(&s->h264chroma, 8); //for lowres > } > > int ff_mpeg_update_thread_context(AVCodecContext *dst, > @@ -83,6 +85,7 @@ int ff_mpeg_update_thread_context(AVCodecContext *dst, > memset(s, 0, sizeof(*s)); > s->avctx = dst; > s->private_ctx = private_ctx; > + memcpy(&s->h264chroma, &s1->h264chroma, sizeof(s->h264chroma)); > return err; > } > } Will apply the first two patches of this patchset tonight. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".