From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D39AD4813B for ; Mon, 19 May 2025 11:54:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 9847C68D63F; Mon, 19 May 2025 14:54:39 +0300 (EEST) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2035.outbound.protection.outlook.com [40.92.48.35]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id AC4DB68D628 for ; Mon, 19 May 2025 14:54:32 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I8j4qO4AlgSPKLZI7U9UetBNShNWBV2agR7OoOAdRvcmhXttfI81Vq4J5oUV2hiWjlB016p6ZdR1stDeh16nYR5+ntuFAVg9+B0j2XUMgfkQGWqDYtPAtE2zVO6KDgi11O83NaozyVGSw7rT+mNCgzVPdgcay/DQugnl+7xjRyrDMB89fkUfuqzkdS+TM19rldOwZ3e3dQmBDrU8oTIGQmrVHJI2IFyJ7uvwwXdQ4aUzx3KKScpe9hhOrLiJHIbTQKxtbLc4wXK4p4VuC65/CGOSQqPLGjrYtZJM3F2XNB5t02y1YreCcCUWlV5sFirtxBxje7G1hrFXsnPGs2iXaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=67FmkXvReJRAYsiqnZKMgCTEOBCzUHEz0mFMXf8g0ek=; b=XnwcCEn2OZ+8gQMRSXZudiEkub3VvUQQ9PS6oePiTose8lVj3O6eG7DO0K9K50B4cwXHg9dyioufxGEdMeCtkYU5eAkOdY1c4ToOlJys1vS22f5Qc1kEOBoSkbzYgetn+wuTB1w7EkZdl7F0IyGwB0xzTngqvYtIo94Ubo26bPE6WX86X3mHkANsALr0SSnnlYJcsSiHhB7Tu8IXIBvckMDudZx2/sEGSSFNm/7FHUFxbBV5dul9+Y1lqNeqod4vGn/wh1qI8Gv7G2x9PvccqZhGwiIMXKMtAXSG2EJt6BjALFimY2o4pUecrthj7Jqwy6ezalKu1K/Yp6WUB4HAJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=67FmkXvReJRAYsiqnZKMgCTEOBCzUHEz0mFMXf8g0ek=; b=d8h+mdC5HXl4POoTf1uI8VmtiVl4lO7RAAVQOI0zoAyK7SMUDeVH5p2fAp1gKX5nONZ6PBcHEt9ouI61BhUKm9kElKfQX4c5bQH2IlFFQZHg1HDeyAi+DPgHs7cx5WO7thfjxFyKgK/j+wZjmujJGpyfj1Fas38/4z4d2h9pObOnCFxJIRAti6odWAmjGtBf9PjnXpJjlYCObLpL0fFeU/atJRMeFadnOtGtiCKDwg4BT6oD3vHZqzS5MCbROhnzwLm7b7CeajdHP2SK4+imNQIL9NQlYhkWlFe4PSoxdteyM9LUNQMmgTWSGY6ZLbw+c6lP0FbumUot15yXc/Bb+A== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0159.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:322::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.32; Mon, 19 May 2025 11:54:30 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.8722.027; Mon, 19 May 2025 11:54:30 +0000 Message-ID: Date: Mon, 19 May 2025 13:54:29 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250519114134.338832-1-chenyu202107@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250519114134.338832-1-chenyu202107@gmail.com> X-ClientProxiedBy: FR2P281CA0179.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::15) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0159:EE_ X-MS-Office365-Filtering-Correlation-Id: f7b54c14-44df-4b86-ed73-08dd96cbe9fa X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmoaApi1aWVt9ILKZbGoHsd6r0jZUvLKGZZSrPJFeX4w+V3JGcouHzybDS7LN9KoQtMwNQNNw3mD1g13g2pkyi7ts2rNMooP93n6M2CXYwX58HB5v4eV+P1AYz2B0tTVXEEsGH3R8Xuw8fmStnWz2BNAaxMYGR9mj0pCq32b6H4a1ZNE9hyLqAcNdSKE8VbwqidVsoeSphe+utMbJfUzfp9aUKRTGU8G54JPT+kOOetsuaXEfIZ9R243Zb1/FSWMJyTgY5cZys2dFMQmjOcejPX++ebIpcBbvOJ1MrCwVORcPPpC+2FR28nVnjnSFDRuq/km4+k34WQoD+Lx0x3tkC89ZJMRtpKJqXx85mgDAA9mRUmo+gaXlj9r00vr1eEhSL7BHtQiUGBFWG3SYZkPmTSggGIfJm3a5CUnY31jzEGFAAmC4CZTRLP7cSOPrlHcP0dN83bYF6ajP0y64C4YxGzPZISfTaH6nflam1JxL4HT+X1hVssgjcAvdJ6YBldLUZcanJ+B/rGrP6ToG6UGVSVuyJVwBpbGPkEGYX7USBq5hM4tgVEEg5Ptf3bAB3l40+Sm7HV3E5Yff9MdlToWZyTFmdeujNw5/OOwfNmAx+UTYWh8q7lNboACiJwONDZE3F3pouO+5KyPRJKM5phOA7eHQa5bF60eToaTyhBWdqI92b9sLjlhssO14QCAheHu+w46Ezio24fCaSgLYftDc8ch9eVaVKQlDlU6O/fomVfXLdv5ZDbtYOsA49dae7rGMqM= X-Microsoft-Antispam: BCL:0; ARA:14566002|5072599009|461199028|6090799003|41001999006|15080799009|19110799006|7092599006|8060799009|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dzZnM2hUcHlpaTFvL1hqLzZyUkNZR1Q2MzVKNDZ5YTI5T29zTjROR05RUGUw?= =?utf-8?B?MlkyR0RFbkdLemlPd0dvRFo1Q3h6cElmaTlvbzJ5R0JXU0VHMC9lbWdjalo2?= =?utf-8?B?NEQ2cHRweE1QMlpHTTFPVXB2RWMzUW00RDhiWDBoMGE2MzVpQUVucEE2blpE?= =?utf-8?B?dCswWTBpREZoN1Ivczd5Q25CSzFCKzVya3g1WWJTS0dmMEMyY09hTXNZME1Q?= =?utf-8?B?MGRzckFYNUNiZFBBcHFiWGd5Tjl4MXF4Q3N6enFiL1JPWXlCS1l0R2d2Uk1G?= =?utf-8?B?WklpQ01DK01VS2JlL2xmWWZ6d2FDRG9BTjJiOFhjZU9rQ3Y5RHJsbytQSm4r?= =?utf-8?B?eTJkY1NWUXNhQUdkZStmanpFbFg0ZHd6MGwyMHdFRm1ySjM5dlBhempKZnZp?= =?utf-8?B?enV1ejVlNkhOTmhkYnFWYkNpTnM1S1dPby90T2F6T2JJV1UrOElvM1V2QUJ1?= =?utf-8?B?S0x1YXJWeDZJN3p2VUZkN2FFUDBueXZnWXROQXhUaSsvNElwbzU2aDEzdlM5?= =?utf-8?B?YVA2N0tnYWJjSlg1bFdYY3NWQVU5VmJuU0w2V3VmSzdNNHdOUkREK3F6c1pG?= =?utf-8?B?ZjBtclpENlRxTlkxUDhDSTJGOGJJRTNBR2hlSU0vaEk4TE9uSUZxRWtEV2VK?= =?utf-8?B?UHdaWkV5Rm1ORFVNTGJPQVRZRGtBY1dpWXpLZXJ0WGhKeGpUQUl6TVFjZzVS?= =?utf-8?B?NktvM2pmOWJ0R1JvTHRxVFA1K3Zmclg4eVNGaGNqdzNxSHZ1bkxqa0RuZkZV?= =?utf-8?B?UVN2S2pSV2dDNXBFZHM5MnRNSjBiSE1IekhzTW0xelpVdGRLWndIWWdOTWNR?= =?utf-8?B?WGZRN2dyUTVaQVg1UFNOa3FDYmhwdElqQnhkQk5ScWc0a2FYTUxsY0dWNkJR?= =?utf-8?B?eXBvRVlYdW0vZ25GN2dPdjdrTHhXN2VIc0JOKzNzdjNWeUgxSVpQOXlTNnZB?= =?utf-8?B?MkM3bmtOZ3l5dkxMR0h4NWcrQWU5UUl1dW8rdlBqc0Y4cVU0UWN5ZGRmR3J6?= =?utf-8?B?emdGSndlLzFQdTJRYmFiaCtGbG9iNVVQQzBLRUVQN2Q5VS9iSnhzTmpxeWF5?= =?utf-8?B?TTh2cm5OVVllTytQVXBpM1h2S1B0aC93N2NWUE53U2hNanlrRTRvNTRQZW5V?= =?utf-8?B?MFNGRTgvbW42VmZjQXlXbTdTaUFpREdyR09HSjRVREZxam0ycU43R1BETS81?= =?utf-8?B?WDF5L0FlSWVJS2ZDNU9udzNsUzY5alFZZXJuTlNBYzJkUk9OVHpGa0Uva0Zz?= =?utf-8?B?WEh3M3B4amVuK1NSZGpZZmNaTTB3N1lNUmdzMlNMZXRlc0cwa2V5c2MrVkNa?= =?utf-8?B?d3pQclp2QW9KK1hKUjNYcmVaSzM0Z3pCYkk2Ny9NMDIyRVBaZ1FTdnZoeGt6?= =?utf-8?B?bVMvSmk4ZWlRK1RtTEJPeUhUWjB2Q3dzdmxJYlBwWEJ2VnRWb2d2SURWQ2du?= =?utf-8?B?bldlamtzRkpxampXNVc3VXp4Z0IxQ09VL1M0cWJaRjBwb1Q0Z3BzcVN2YVI2?= =?utf-8?B?V3NJU1lPWVUyZUd5MGNsNGFiZHBGaURNTjZNTlRjME1wR1VRVGRwTFFUK2l4?= =?utf-8?Q?lBYdLMqhlvqxU/FhoqAYjPbcg=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHZpQzd2SmppaDVzdTN5RFFndmhMd3FNZG5pOFk0MUJPUCtKV1Nmdjg0ekZJ?= =?utf-8?B?bDZ6WHVieEpFZys4ZmRvdjMrcVU5cnFsSEtaNFlodkxQUDJmc2JBLzRROUpT?= =?utf-8?B?T2ZtTjZmMjFBdThFTmxrZUV4eEhZb2lOT1ZVSW0yMEtFeTA3M1VyQXN4Z3p1?= =?utf-8?B?R2ZUajhEcmRpYy9ycFNiQmExK1ZSUVVnNEtzejJ1Sm5YTFpCaGhJNW5oc1JD?= =?utf-8?B?VFp1S1YvYnh4S0YwalBNbnU3WDdNU2o0QjMzdGJLNFFXcFhobjMrSithK3RO?= =?utf-8?B?N3ZkdlFkNE5XUWxzczNyTGhuZlBveWNzSWYxVCsrQWVLYjRiVkx1WDVzOUx1?= =?utf-8?B?WCtmOE0zSkxtYXBqK2ZlbTdQRmRvWlR0QjluWGlEYW1RdnpqbXVsVlMxc2N2?= =?utf-8?B?eXNhQVVDNStaRmJ0VFl3bGtSL3BGUXpSdnFBYmZLUVlZeGF3bnBhTzBUY0V5?= =?utf-8?B?RjVwQXVjSVlDY2t6azMyaDBZTUVTMHRCMUdkbk92LzFQTVNsKzh2R1Jqa0Rq?= =?utf-8?B?Zm5IcmRFSVZzcEZXWmhsNkp4UDlrMVhjYSsyVm1SRm5SWGI1WG80OUcxc29T?= =?utf-8?B?YkdPaWh1T1M5QzMyM2E5WHlPZTVPbTlQdUdZVUZzZ1V5ZXEya045TDFWcndq?= =?utf-8?B?RFpBa01sd2hvSFVqZUdHNEFQNnVoYkVFdzlJMWVPYlV3MTFTQU1wZkNwV29r?= =?utf-8?B?Rm5lWUZNQUJ4RTZwR0dyaGxtM0JlUVk1S3dTSXgzUVRxa0lVMHpTeFhTSGhU?= =?utf-8?B?VVkrcDhVejZUdFFhSUZFZTlRQmlaUHR3bjZFN0pDRDBhU2FkazhtNmxxc2Ja?= =?utf-8?B?VW40VFhzR1BVTFUySlhOcWJyZnpHQVZ5cnlibHJDNVFJYUZURHZoQklzcC9m?= =?utf-8?B?N3p1NytKNEdla1REczFaRWZYclZSK3F4S0lLSlR3WHFHZ21TVnU3SjJTeitz?= =?utf-8?B?RjVpR0tLajFWTkQrTmNGbk9uRFMzYVNoQ0lpKytoci9vNGRzb3RDdVo5TW1G?= =?utf-8?B?Vks5Q0NQNW11aGNvMHBUckJDRmxIVjRETS95NFlIMHAvVDFENGg5aUtJOWN3?= =?utf-8?B?WGlOSk9YYnlNQlhPNUN5RXA1OWlKZDZZdGlIU2xWdnVNZVEwNUJiQlNTSkZm?= =?utf-8?B?VjhTei9mdi8rQ1gwdUtyRjY2UjBHVG1rTHdhZ0FXRE5NMGtFQlNEQmRCOGlS?= =?utf-8?B?SzEyR3BCNHN5TG9LZDhZdGg0eWd0QU85aGZqYkhDR21SNzhNQjBXYlowRGNB?= =?utf-8?B?bDZuanM0V2lPVVNkWTZLOElrMkNReFpJVTd4aXhlb285WFRrRml2NkhVeEV6?= =?utf-8?B?M3QwbUJQZStMaUpRVHpidlp4cU1tWU5IZnJjNGd2djN3c0MrZUtiNDVQcGFu?= =?utf-8?B?QWlzenNYeGlyeWFrVXlBclRHRnA4aWo5bjYvZFkvK1g4MHkyMWIwWEdDRitG?= =?utf-8?B?S0dUU0lqQmM5a0hyN241RGwrUDloQStMT1BCNFBtdWtkamd0WmMxSVdZcmM0?= =?utf-8?B?ZUU5Q3ZMZVVrbGVXblhGd1VKaGliVUgrYmZuUmRiT253d1NsY0VoRjdPQ2tp?= =?utf-8?B?cUxyYitGVU43eGpudEdsMVhVdjZ0Uy9ZY0xPQ2ZyRHUxTkJLbzBIclk0STBo?= =?utf-8?B?TE9Vdlo4TGkvbE5LRStESHZSTHdiRkZDUUYwUWd1N2FXSHRpQitoYS9lMWF6?= =?utf-8?B?dHMvRjc1dWVqQlVnc2ZxUlpEbnhsWTVuRDFsM0dEb1g2VzJSS2Jrekc4UkZu?= =?utf-8?B?ZWoxNk5BRTVneWdqK09KTmhNdTNkclVMdnpBbkNyeDUrQlpnT0lNWHRXSm9H?= =?utf-8?B?NG5qemVoaEFDU1IyN3cwQT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7b54c14-44df-4b86-ed73-08dd96cbe9fa X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2025 11:54:30.8261 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0159 Subject: Re: [FFmpeg-devel] [PATCH 1/1] [ffmpeg-deve] avcodec/mpegaudiodec optimizing code size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: chenyu202107@gmail.com: > From: chenyu > > Optimizing 160k code size by converting static array to dynamic malloc memory. > > Signed-off-by: chenyu > --- > libavcodec/mpegaudiodata.h | 4 ++-- > libavcodec/mpegaudiodec_common_tablegen.h | 10 ++++++++-- > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/mpegaudiodata.h b/libavcodec/mpegaudiodata.h > index 720c4bee64..6dfb74cd01 100644 > --- a/libavcodec/mpegaudiodata.h > +++ b/libavcodec/mpegaudiodata.h > @@ -50,8 +50,8 @@ extern const unsigned char * const ff_mpa_alloc_tables[5]; > extern const int8_t ff_table_4_3_exp [TABLE_4_3_SIZE]; > extern const uint32_t ff_table_4_3_value[TABLE_4_3_SIZE]; > #else > -extern int8_t ff_table_4_3_exp [TABLE_4_3_SIZE]; > -extern uint32_t ff_table_4_3_value[TABLE_4_3_SIZE]; > +extern int8_t *ff_table_4_3_exp; > +extern uint32_t *ff_table_4_3_value; > #endif > > /* VLCs for decoding layer 3 huffman tables */ > diff --git a/libavcodec/mpegaudiodec_common_tablegen.h b/libavcodec/mpegaudiodec_common_tablegen.h > index bf402c9d84..66e93df27f 100644 > --- a/libavcodec/mpegaudiodec_common_tablegen.h > +++ b/libavcodec/mpegaudiodec_common_tablegen.h > @@ -34,9 +34,10 @@ > #else > #include > #include "libavutil/attributes.h" > +#include "libavutil/mem.h" > > -int8_t ff_table_4_3_exp [TABLE_4_3_SIZE]; > -uint32_t ff_table_4_3_value[TABLE_4_3_SIZE]; > +int8_t *ff_table_4_3_exp; > +uint32_t *ff_table_4_3_value; > > #define FRAC_BITS 23 > #define IMDCT_SCALAR 1.759 > @@ -51,6 +52,11 @@ static av_cold void mpegaudiodec_common_tableinit(void) > }; > double pow43_val = 0; > > +#if !CONFIG_HARDCODED_TABLES > + ff_table_4_3_exp = (int8_t *)av_calloc(TABLE_4_3_SIZE, sizeof(int8_t)); > + ff_table_4_3_value = (uint32_t *)av_calloc(TABLE_4_3_SIZE, sizeof(uint32_t)); > +#endif > + > for (int i = 1; i < TABLE_4_3_SIZE; i++) { > double f, fm; > int e, m; This does not improve "code size" at all; after all you are actually adding code (and an indirection) with your allocation. If one interprets "code size" as "size of the binary" (instead of just .text), then this patch still doesn't make sense, because the tables are currently in .bss which does not increase the size of the binaries (that's at least the case for common systems, is it different for you?). And of course you are missing the error check (in fact, you have no way to return an error from init functions like this). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".