From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTP id 8405B4A5D5
for <ffmpegdev@gitmailbox.com>; Thu, 2 May 2024 21:35:01 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4A8ED68D885;
Fri, 3 May 2024 00:35:00 +0300 (EEST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
(mail-he1eur01olkn2056.outbound.protection.outlook.com [40.92.65.56])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 579FE68D7E6
for <ffmpeg-devel@ffmpeg.org>; Fri, 3 May 2024 00:34:52 +0300 (EEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=LhruHz1aqqeSIddtG5ZHtG9w8rtZVXjENMFFk3mjhCDO8auhpl7bx5oh5+4t+upx+K+K4/95Y83OPEXabL+UwhfwZbCIyEstylgh4XparCfUpVpEvuxEj/vpqNtUcNIr/rY0Y1dD48KlYLQwCtFev46/iCRcfaBbDyNeqTYt3AlP4U8S0+QH52pKvF9IzZzx64nGuCMM8PJHqvngrnqhUr+jvoyv8T4qzu0cikmZxefc2Z+t2Cvb5dUef0/YMX9FA+uq+s9EHrJg1Kx0rCfV+HW+dcO+Eig3GC2RpVMEuSMlkK8MhfV5xrnnonpS2xX53NEXUkVxg3WnuOkfDuAiew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=etWi5e2MO/c9+b5hp5YAKtXg+CoozBUnn+yCOt8TebA=;
b=EuhsqHXmDISiwotrqcWineYJSqze6iigWK3Zkv+o77N1B3q15qpjLwBO7EJ2Uw+586RpEAqWO/TVIqtOGNM0ee7SNegGtakXXSotWU7VnBsspnHbv2x57Vi+D18FF2weEFElicMj1gImaFmahkV2xxDOx6WG6Yf6MO/wwXcuS3sKRoI4YXYpwGlRy/wT2zLmF9QthPcAW+Sc+aPNiUNn7RkT43YwfKF4wxkd85xdbQJ6+qf5qZaUePUaeD2pMlqDhCK1PndP3mVfgtHV7D1UTRxbZRLRjY4Xj6Yk8VkI6Ur5jYebqRCoKS64J2VR1vDTmectCHZ0AfoVRz2cgY1VRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=etWi5e2MO/c9+b5hp5YAKtXg+CoozBUnn+yCOt8TebA=;
b=gxA3h2HA1A0ZQdBSK8JUlxLHzKKywEfZR2izC1LPSg959lT/wgaxjtvtgRkrZxwlss8fN51Ft/hqRZhD7WIc9YIHTWjOInAr5/wsO74Ffb6UEpJGz+8S+XnJswKHyBxE9NjZJGZw3UBO0XoDwkXuueBT1/xoHfT5UpV/0H/P85cHIWGQ4fu/X6qK7m/6C3sggUY5z9EAHv89xqhCPXXjNhIingxpjTFPu9X4oMfkow25BbAB7rziC5jR4AhuAcTGCAeSb8hQP5xQDPkDaEn/xp+bwJSFY4UM/yFQ4EHvqGA4RsjQ0NlM5+IgG7+lYokgpGj7rmCYyyw8hn/S2zSW8Q==
Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14)
by PR3P250MB0097.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:170::7) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.28; Thu, 2 May
2024 21:34:50 +0000
Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7519.031; Thu, 2 May 2024
21:34:50 +0000
Message-ID: <AS8P250MB0744D9007D8A02C99404A4748F182@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
Date: Thu, 2 May 2024 23:34:48 +0200
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <20240502004150.3627661-1-michael@niedermayer.cc>
<20240502004150.3627661-2-michael@niedermayer.cc>
<AS8P250MB0744EA369A70F9BD1A68466C8F182@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
<20240502212939.GE6420@pb2>
Content-Language: en-US
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
In-Reply-To: <20240502212939.GE6420@pb2>
X-TMN: [BSLYAxoUm4jUDWU1tgGJZbweWxaGXuiVGt+gyKFyd5Q=]
X-ClientProxiedBy: ZR2P278CA0046.CHEP278.PROD.OUTLOOK.COM
(2603:10a6:910:53::19) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
(2603:10a6:20b:541::14)
X-Microsoft-Original-Message-ID: <95cde4f8-9516-4ef3-8fc3-b62d562c1ba4@outlook.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0097:EE_
X-MS-Office365-Filtering-Correlation-Id: be69d7ea-b3be-4a96-d4ee-08dc6aefb258
X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016;
X-Microsoft-Antispam-Message-Info: Eq48V/1nd8gotpk5PhWBN4g2Anwq2Vkbp/hG8AoZO7K3x3n0AufNb4zx6LOOF53qCdYhM5rJDFlcYVfuNm0SHYHCtURnn8qcRUxuteyrohaRDSFhypu0QGA9UFw+b1wnlVAYm977rr51gNFV3BqA6GItDNLBwfTTPDFtTuW9/mbs4sg/Qt/scVxwS69IkO63iNS2ROV2GkHQobqZOWfIDzogu6A7eSocT3gWBl9ZwZqdDZpm9oJem+MBtFEt3Db3U+QTlt+4zYicjvSuC1Y/nzrb9iBezShLEupVRleBxEBgFIEWfudaraF3aH7dfDl57LKoQoZK+L/fiwduEG1Cbes94NRhQ64gvLWGK0pI4BqzN8y0atcFB7qDmlTMzI1bFIM8PN5WEq5cr818W6oMcUg68UnqfY4ELxcicFwPckTEajaKnPP9AkzaEG4Ga0ZG/kB53cgHApTkVZwMocrk81+4QavPUgdT0W4R3Mobn5R+rAoZndOWrzILsEKYyZniQN+OP5sPofmJlApe/I7fZhZ4tAEgcCouNuHcWJBAS1kCpDha9lT/di4f8SV1ys1q
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFoyMUYzWFp3Kzg3K3BGVDJBRzNrcFVSU2FxbytlM21TUFRxR3FWTVcxVWt6?=
=?utf-8?B?L1VhTXFQYlZTcTFhektuZmZYK29pYVJOYXV4MEtFdUl0Q08yRE8yRGp3TFFu?=
=?utf-8?B?b21pNS9NL1IxVndNVS9rKzUxMmh2UGswWjV0TDFvNEhsWTdEYXIrSTZybUtE?=
=?utf-8?B?UlBzVDZBSDZmUnNKNVNzYVRRdEcwQmhTdnpNeXlOU1RwRk04bU40eEFXRjM5?=
=?utf-8?B?VGZBUVU1ei9vckg1ejd4dzVidGpXdVp6MFFDdENhaXQ3UGx5Y25MTFpyZENy?=
=?utf-8?B?NGdlR1kvNjhrS1ZJdVhuUXlrWTVrWnBFM2JqS2R2RUpZWVhqNHJoUnU2azJs?=
=?utf-8?B?Z2w1bVF6SVN2WDR6aXk3WE9kQldXNWxWcUNXdk1EbW1yTStlTUx6QzJWdnVZ?=
=?utf-8?B?aUhHemxCdk83T2ZTLytuRUp2TkhFbGRudE95L3ROL0xZWTQySjVUNHBGOE9p?=
=?utf-8?B?Y3d0eThlckt4cllOZDBpS2FDMk5kazZrRDdDNjF4SmpEbFZ2V2Npd3M1SXhU?=
=?utf-8?B?MXc1dkN1ZXB5OTg0MUJZSmpwLzNLWUxKTjNtcG1YMER1ZGwxMGdmYnlpNFBH?=
=?utf-8?B?OXJXampqZlJjQWl4bTBVNWprY0QzYzY5SnoxUTJhVzgzTnlWRFgxdnhDQ0M3?=
=?utf-8?B?NTNoZFJsTGYrN2gxUER1K2N1WEVxM2RNZWdoTS8vMDI1NDBXRUhOdEJwb1hm?=
=?utf-8?B?Q3hRZ01QU243bnBNNU1NNWhVQUh2eHZ1M3ZKZFkyR3llWVVDemFmbGowQjcw?=
=?utf-8?B?Q3M1emtRRGZRODR4Um0xTGUvZjBOdFp0R0xndjVuT2JVQjkxSUJLTDVzTFk2?=
=?utf-8?B?TWNGRUdsRFFsZ1M0TjlkdUVZTjNtLytEeS9jWUJqc2RHN0FmVCtSc216WkRD?=
=?utf-8?B?SWJrM3QvYjVSS1hycWROckw5N3NDbHRuek03blMzSWt1dlc4RFRuN2E0dm1V?=
=?utf-8?B?UXdqb3BEQ1FDSWIvL3gvMi9sTzJQejdlV2Qvc3M0eU1YNFJybC9mclJTY0ZQ?=
=?utf-8?B?eldIZHRmdzFZcTlXRHhLWU80M01INzZjZ2hsYXh2UlprSzJTSXdocDRFeXJK?=
=?utf-8?B?WDdpa05WektHOXlDYmlzR2V3NUVOYzBIK1ZYZGpob2dreUdMU0V0QWhZR3BL?=
=?utf-8?B?ZTQvOGYrTmNJbXlQRFFLbGQ2ZnhQSEtuaS9HSnRlcFVRYVRPa3Y0Wk13cHBp?=
=?utf-8?B?dnI4ZEFRQkc5ckdzNEtsQVJPbStKSHhjZEpKeExqc0M1ODNaZ252MnczaDI4?=
=?utf-8?B?QjMxSEMzQldUdlJwUGZzV2paOWlXU1k1YmQ5Z1psb0pyb0hSbzVoTXNWVWs5?=
=?utf-8?B?TTZrd3hjRVVxVC9KSi9vcW9HekNvR0FXaFFZcGtWaFU4WjNNWW9xODhESHha?=
=?utf-8?B?MWRTV1J2VG85UzhaS0pGaGZBcTdSUmlmRXFKOVE1ZTF5UlErTGM4Yk9BNERL?=
=?utf-8?B?dEx4YmZmbDROc0NSQXdrVzB6cTEwNmY3RlpKNUVuMmlhNlJXbmV2SVdHKys3?=
=?utf-8?B?RWlYMjlVNWgrM3l4UjZKMkZseHQ0QXRybmYxZUc0dGx4WE9YMS9OdDJmaDln?=
=?utf-8?B?OTRCNEFid2JMRVh1RkNtcG0wak5PT0RnbVRTb2dMTXJ3NzJIR2QrMXVEQU54?=
=?utf-8?B?WldLb0xMZjZiZk1STDFTZ0l6RVJMTG1icTN2MUw2MUpubXh4RnZ2djUyOXpW?=
=?utf-8?B?SW9ISFZWdWtvSnpyR3dkKzZWQnRPbVVuRHVOYjZxSm9lOGxFSUtvcXV3PT0=?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be69d7ea-b3be-4a96-d4ee-08dc6aefb258
X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 21:34:50.6948 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0097
Subject: Re: [FFmpeg-devel] [PATCH 2/7] avcodec/av1dec: initialize ret in
av1_receive_frame_internal()
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/AS8P250MB0744D9007D8A02C99404A4748F182@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
Michael Niedermayer:
> On Thu, May 02, 2024 at 09:12:36AM +0200, Andreas Rheinhardt wrote:
>> Michael Niedermayer:
>>> Fixes: CID1596605 Uninitialized scalar variable
>>>
>>> Sponsored-by: Sovereign Tech Fund
>>> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
>>> ---
>>> libavcodec/av1dec.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
>>> index 4f9222cca27..93ab04eb378 100644
>>> --- a/libavcodec/av1dec.c
>>> +++ b/libavcodec/av1dec.c
>>> @@ -1262,7 +1262,7 @@ static int av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame)
>>> {
>>> AV1DecContext *s = avctx->priv_data;
>>> AV1RawTileGroup *raw_tile_group = NULL;
>>> - int i = 0, ret;
>>> + int i = 0, ret = 0;
>>>
>>> for (i = s->nb_unit; i < s->current_obu.nb_units; i++) {
>>> CodedBitstreamUnit *unit = &s->current_obu.units[i];
>>
>> A better approach is to actually initialize ret before every goto end in
>> order to ensure that only the actually desired ret is returned and not
>> some earlier value.
>
> ok, will apply with ret = 0 before the 2 goto end lacking it that i see
>
I already sent a patch for this.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".