From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2421546FCE for ; Mon, 24 Jul 2023 22:19:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6F6D168C0D3; Tue, 25 Jul 2023 01:19:29 +0300 (EEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn2043.outbound.protection.outlook.com [40.92.66.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B131868C7B8 for ; Tue, 25 Jul 2023 01:19:22 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AHrGnTvnLxofLZl3srkWoxyOjew36NhTQQ70Ke3R30sOwy7p5nWCqIQkN13jvHFSqhfubOMSyRh0DrRXEK8OQCTcT6LXLcvlal1HkGGs9VrVRC6qd0Grn7q75mxFAgr8w0RZDYS3svm4FWBFRx8IKsA362E3eD1DpPJ35K81AYxr6E6KuStp7FZaq3Z9frXBb4RDgNLo7psiQrFsPtmzbFClIg+ML7YJ7DJDDMEwMPTEnK/MWNXj8W0emZUuGhMXbM/xorldZvog2oHWXYNEHtmFSeA4RhST2+ut04xk/MpbtvEz5fhx6MQaCpfF4S91NStypHuvxzSonEdhS80Otw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kXAo3mgWtA69ewKg+PxGGycx5dZNwFfxQB+hVLgWffY=; b=km0OGafrexUt+6V4AyLtonrdPo0+laD7Gsc90vpyEq2qdisg5EceUoxRbLNLTNyIwyilikpOBTPyIl1v+HroGUBDrmoJ36dSU8PdCpKuxSx/eUzVjSoSepvwh7/Gd5MI3J2VdyJ/VsylYEmxVKbG9ZRe8nJ/XgEDehfaFG0kNdNlNMvAdZJr+EC6NRqYo5F68utvNchnoaGfRwPz7Hnjlev+igjWHYO50uYYMfUHcdKnlr1FLK9ElKwXUj8/wz0OF2lGHGWNjZL2Nry7qKtChwVPn5+NGKDEUICkE2nVB6FyrW0c/X5jRJM45BPz1fmc4THSyymWYEPDmKPCryTBQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kXAo3mgWtA69ewKg+PxGGycx5dZNwFfxQB+hVLgWffY=; b=PEzVBj5Qc07WvWjgnwIokTpewPSWPeElpC/rYp9xIZoQiY+4p8BA6gcWFnjDHaGpHd0g0AdKgW8aHSkIR1d7ZQMGi8ZbmEB61exrjqHTWtgQKBaEPHCBqwmMPnvC4fIN8/T/jjUXN7wwUZjRrLZFndc//dCf7POUKil40LdzcRBJEhmP53TMmZJ4pfLORWkX0EIa5i1clHFBMXl1CkzzNR41dsWEqkXHAPZqnvUXzBWvkYtz61OSeEGFEfTeHHgJOMwXIGtes9OteVlQdaDgFoMIwBxfh5PDCrhuPNU9sJN5I5rnb6CVCGyLA3YLysJCrjT1oH5Wa/XPy8LI8MWLXA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0250.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:37d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Mon, 24 Jul 2023 22:19:21 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6609.032; Mon, 24 Jul 2023 22:19:21 +0000 Message-ID: Date: Tue, 25 Jul 2023 00:20:31 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [h5pYB8ChvTqg+v4wi6dZXddg9zUmUN2N] X-ClientProxiedBy: FR0P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::17) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0250:EE_ X-MS-Office365-Filtering-Correlation-Id: 8136c361-5400-4109-3b4e-08db8c94076b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tmq6I1Fhly4nD3K15CB1VnFKRjos6oy5h2V9IlVC4ZGHNtkD3Db2NPLv7xQ4yiUEcwX6rwUYdoGNZeJXQyLP3SrSlbbGJNGgGt40Zs+gd55DEmRhR7P9VE0cH1E6MDcchTmsHGeoSvnWDfg3sw4CZ4ecIhrGLBTg7hNZ4ebF6S8p/Z+5RY9SoeniG6Z2qzsU5NHcf8LX6AoFjezAeUyz4Gqt2RNx3urKc7kfgFUUBi0Lsn6BxF74D6bDhMCBxJeTDwRRuow7BU5MX9eHZXiVXq651Ei92v4/aEEV7GcpRsa3NfIz9kdEtacNRl5bcv4R9wTQpZa41aO+lQzFe7lbmyEDVFa12NcNBgP3YI9GBuwmAf9HPGWM1K2XQbS2RDuCITretQifkrWVq2N70EoMw/ZOMK8edAur3ss+RUZuO7GTP2libudan104QHsowBJvLtCSL0rq33uxnVRbwY1KNGAIif64gxUKQFHIjpb6/QLVxem32868Bzw3qyKrLe8wZ0nNdydbu1lKFj5pPa+AgoOqCmi0D9xtxmzeT9iBbPxBCZdOQV2PvlrFuqsHHktj X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qmx5a1J2TWpZNTdOYTlLeTJ5RFdRUVR4Z3loWXhrWGJiUWFieHhwMU9Cbmp1?= =?utf-8?B?cEFLaStvY3phM3kyMy9hRE1UWTR4ZmtmNkxldTVZSHBLWkcxNDlsN0V5R3p2?= =?utf-8?B?RVRzS05xYnRPZ0VuTlp5ZFk3MVJaQ0N2SFg3d1lTTFZTaHFlSTQ0R3hhbmQ0?= =?utf-8?B?MkMvWWNLbUYycmpYbDRXelJDWC9RNVUyWEd5QW5kazVIVUI3bmtmZzQza2hN?= =?utf-8?B?d3N1QkFqY1FWSHphSXd2eWxxNnBLNXRmQnRGM2pqRnFTYXUzVTVGZzhlL0JP?= =?utf-8?B?VXAvTDV5NVd5c1ZlQ3NlQzM2K2RUSFlpdXlEdnZDY1RkN1hJT3QwODRoVVF2?= =?utf-8?B?K2dvL0ZMOHh1RGpGY21wL1NOZWZPMVNraUs3WTN0TTJtay9OSHZiSEZxVmlZ?= =?utf-8?B?T2UzQWxyd01pUnFYS3gvK2JzOEdPbW41dC9WVXcvZFk4VzlGZXFLYmp1SG1s?= =?utf-8?B?Z0F6ODZvVnhVb3FpNXJva2d5K3hZcWZVSEVFZ2ZpS2hQUmYydUFFSU9hMTRi?= =?utf-8?B?RkExYXM2aUFNMlB5clhrS0ZPaEgrYVNsSkkvU0lJT1dmRjJJV0IyLzg3Wm12?= =?utf-8?B?dmxkUms3RVFWYmZRYk9hUWoxdVZZTzhTYlJkSndQT2NKamU4L2J3NXVKeVJ3?= =?utf-8?B?aW5taFV2MjU3VS9DMnNsWkxmeURtbWlKTXpoSXU0akZkREF5alhwUmE0RUdE?= =?utf-8?B?VmphWHJFdklhUEZTLzQ0UEJHaXFIekc5LzJ5ZWxqQldVSzFvcUppMWdXenJK?= =?utf-8?B?MjdLY1VvcmRMT1Y1dk50MGNPNk4wS1lrTmRpWGp1NE9VSS8ydTlFYk9SMmI4?= =?utf-8?B?UVNNNE02d0JvUkt4dUFXWUtNaS9sV05lNnY0TFRQcllOOGdaa2dsN2FhS0dK?= =?utf-8?B?dTlTdE8wb1hiejhVanFLQTRKOFZWZXdGdDhNbldhMDYvVmhMS3J1U0VXOFV0?= =?utf-8?B?eHRjb0FyYWxMeXhsNkszZ01TL1NJVEd4SG9zZEhXY0pjUU1GZWJCZDF6VTRJ?= =?utf-8?B?aTlIYnpIbHVZdytpZzBBOWpzeWUwaHlkUGZoSEVLdDlnT3ZubTJWeldncTB5?= =?utf-8?B?UzZTMDFBcjVWY1drQnVZdGVZVEhicnZ0cUNRQmJ1a0lnczR0YUlucUt0SFZE?= =?utf-8?B?TUdTUTVRYi9zRzhwbnFFRXVRWjBNQ3NBNHpsbUVDZ2FWcCtMeDU0M3VqMitT?= =?utf-8?B?TDBycUNodFVUaE9MVGlkSVdmRnVoNGNKZDN6bTFTa094M2Y0clc2NHhhNkRE?= =?utf-8?B?ZndidC9jZEtkQVlFWEJPSUtGK1d6Qk5jaU5NcitGVmFGc25sTjIvNEtrWHNr?= =?utf-8?B?Y1BUSEgxdys0dmNKNDJYWjhVL3hLOUhzWHpzY3RGSkMxYzRwNWI5eE5GTmpR?= =?utf-8?B?OHdyWFl3VVhIaUVhL0YzZEdvOHlwK1h4Y0hNd2luNTBqOVU3UHpveXNvb3BX?= =?utf-8?B?VjlzKzVIR25yT1hRcEFPVS9KOTY3d2dpSmgrSit1MjFGTWt2dmlZSlBKNHZm?= =?utf-8?B?cWxQTlUvQnJQeDNqY1NETmVYL083QytUWUo0UDhIbDgvaUl0U29lVmpOamR6?= =?utf-8?B?b01kVmxKQXUrTWdId1R5MU41TFhDNzZDQ0o2b1VGM1RPeXozNkdLd0RaYThE?= =?utf-8?B?dzR4S0p4U3FRRWlnSGhCL2kzVkt0alFnbzdtVUZieGM5RVQ1WnBPUWFTT3BH?= =?utf-8?Q?v03GPXW7dn0gSRiGkt6O?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8136c361-5400-4109-3b4e-08db8c94076b X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 22:19:21.2578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0250 Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/avfft: deprecate the API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Lynne: > Subject: [PATCH 2/2] lavc/avfft: deprecate the API > > This deprecates the currently unused API. ^ superseded > --- > doc/APIchanges | 4 ++++ > libavcodec/avfft.h | 25 +++++++++++++++++++++++++ > libavcodec/tests/fft.c | 4 ++++ > libavcodec/version.h | 2 +- > libavcodec/version_major.h | 2 ++ > 5 files changed, 36 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 5afe8bcb75..38fc0b1459 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -2,6 +2,10 @@ The last version increases of all libraries were on 2023-02-09 > > API changes, most recent first: > > +2023-07-xx - xxxxxxxxxx - lavc 60.23.100 - avfft.h > + Deprecate av_dct, av_rdft, av_fft and av_mdct. This should mention that the whole header is deprecated and will be removed. > + Replaced by libavutil/tx.h > + > 2023-07-xx - xxxxxxxxxx - lavc 60 - avcodec.h > Deprecate AV_CODEC_FLAG_DROPCHANGED without replacement. > > diff --git a/libavcodec/avfft.h b/libavcodec/avfft.h > index 0c0f9b8d8d..6401833089 100644 > --- a/libavcodec/avfft.h > +++ b/libavcodec/avfft.h > @@ -19,6 +19,10 @@ > #ifndef AVCODEC_AVFFT_H > #define AVCODEC_AVFFT_H > > +#include "libavutil/attributes.h" > +#include "version_major.h" > +#if FF_API_AVFFT > + > /** > * @file > * @ingroup lavc_fft > @@ -44,26 +48,38 @@ typedef struct FFTContext FFTContext; > * Set up a complex FFT. > * @param nbits log2 of the length of the input array > * @param inverse if 0 perform the forward transform, if 1 perform the inverse > + * @deprecated use AVTXContext from libavutil/tx.h > */ > +attribute_deprecated > FFTContext *av_fft_init(int nbits, int inverse); > > /** > * Do the permutation needed BEFORE calling ff_fft_calc(). > + * @deprecated use AVTXContext from libavutil/tx.h > */ > +attribute_deprecated > void av_fft_permute(FFTContext *s, FFTComplex *z); > > /** > * Do a complex FFT with the parameters defined in av_fft_init(). The > * input data must be permuted before. No 1.0/sqrt(n) normalization is done. > + * @deprecated use AVTXContext from libavutil/tx.h This deprecation warning is supposed to apply to av_fft_calc() and apparently AVTXContext is not a replacement for av_fft_calc(). Probably better to write something like: "Use the AVTX API from libavutil/tx.h." > */ > +attribute_deprecated > void av_fft_calc(FFTContext *s, FFTComplex *z); > > +attribute_deprecated > void av_fft_end(FFTContext *s); > > +attribute_deprecated > FFTContext *av_mdct_init(int nbits, int inverse, double scale); > +attribute_deprecated > void av_imdct_calc(FFTContext *s, FFTSample *output, const FFTSample *input); > +attribute_deprecated > void av_imdct_half(FFTContext *s, FFTSample *output, const FFTSample *input); > +attribute_deprecated > void av_mdct_calc(FFTContext *s, FFTSample *output, const FFTSample *input); > +attribute_deprecated > void av_mdct_end(FFTContext *s); > > /* Real Discrete Fourier Transform */ > @@ -81,9 +97,13 @@ typedef struct RDFTContext RDFTContext; > * Set up a real FFT. > * @param nbits log2 of the length of the input array > * @param trans the type of transform > + * @deprecated use AVTXContext from libavutil/tx.h > */ > +attribute_deprecated > RDFTContext *av_rdft_init(int nbits, enum RDFTransformType trans); > +attribute_deprecated > void av_rdft_calc(RDFTContext *s, FFTSample *data); > +attribute_deprecated > void av_rdft_end(RDFTContext *s); > > /* Discrete Cosine Transform */ > @@ -106,13 +126,18 @@ enum DCTTransformType { > * @param type the type of transform > * > * @note the first element of the input of DST-I is ignored > + * @deprecated use AVTXContext from libavutil/tx.h > */ > +attribute_deprecated > DCTContext *av_dct_init(int nbits, enum DCTTransformType type); > +attribute_deprecated > void av_dct_calc(DCTContext *s, FFTSample *data); > +attribute_deprecated > void av_dct_end (DCTContext *s); > > /** > * @} > */ > > +#endif /* FF_API_AVFFT */ > #endif /* AVCODEC_AVFFT_H */ > diff --git a/libavcodec/tests/fft.c b/libavcodec/tests/fft.c > index 163f3e89c4..a9ea457bc9 100644 > --- a/libavcodec/tests/fft.c > +++ b/libavcodec/tests/fft.c > @@ -18,6 +18,8 @@ > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > */ > > +FF_DISABLE_DEPRECATION_WARNINGS > + > /** > * @file > * FFT and MDCT tests. > @@ -675,3 +677,5 @@ cleanup: > > return !!err; > } > + > +FF_ENABLE_DEPRECATION_WARNINGS > diff --git a/libavcodec/version.h b/libavcodec/version.h > index 9411511e04..728ab8839d 100644 > --- a/libavcodec/version.h > +++ b/libavcodec/version.h > @@ -29,7 +29,7 @@ > > #include "version_major.h" > > -#define LIBAVCODEC_VERSION_MINOR 22 > +#define LIBAVCODEC_VERSION_MINOR 23 > #define LIBAVCODEC_VERSION_MICRO 100 > > #define LIBAVCODEC_VERSION_INT AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \ > diff --git a/libavcodec/version_major.h b/libavcodec/version_major.h > index 95c5aec0c5..cfd0b5023e 100644 > --- a/libavcodec/version_major.h > +++ b/libavcodec/version_major.h > @@ -50,6 +50,8 @@ > #define FF_API_TICKS_PER_FRAME (LIBAVCODEC_VERSION_MAJOR < 61) > #define FF_API_DROPCHANGED (LIBAVCODEC_VERSION_MAJOR < 61) > > +#define FF_API_AVFFT (LIBAVCODEC_VERSION_MAJOR < 62) > + > // reminder to remove CrystalHD decoders on next major bump > #define FF_CODEC_CRYSTAL_HD (LIBAVCODEC_VERSION_MAJOR < 61) > This patch is very much orthogonal to my patch (as expected). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".