Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Andrew Kelley:
> On 4/10/24 07:11, Andreas Rheinhardt wrote:
>> I don't
>> see a simplification of the Makefile.
> 
> Relevant part from the diff:
> 
> --- a/libavcodec/bsf/Makefile
> +++ b/libavcodec/bsf/Makefile
> @@ -45,5 +45,3 @@ OBJS-$(CONFIG_VP9_SUPERFRAME_BSF)         +=
> bsf/vp9_superframe.o
>  OBJS-$(CONFIG_VP9_SUPERFRAME_SPLIT_BSF)   += bsf/vp9_superframe_split.o
>  OBJS-$(CONFIG_VVC_METADATA_BSF)           += bsf/h266_metadata.o
>  OBJS-$(CONFIG_VVC_MP4TOANNEXB_BSF)        += bsf/vvc_mp4toannexb.o
> -
> -libavcodec/bsf/%.o: CPPFLAGS += -I$(SRC_PATH)/libavcodec/
> 

I am very well aware of the diff. I still don't see a simplification of
the Makefile.

>>>
>>> It also reduces ambiguity, since there are many instances of same-named
>>> header files existing in both libavformat/ and libavcodec/
>>> subdirectories.
>>
>> What ambiguity? 
> 
> For example, if a contributor sees #include "vvc.h", they do not know if
> that is libavformat/vvc.h or libavcodec/vvc.h without also being aware
> of other context, such as the above line in the Makefile. The
> explicitness reduces the amount one must know in order to read the code.

To quote myself: "It would be different if we did something nuts like
adding -Ilibavcodec to the compilation of libavformat files".

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".