From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AE3794718C for ; Sun, 10 Sep 2023 11:07:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 88F0968C8D4; Sun, 10 Sep 2023 14:07:52 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2082.outbound.protection.outlook.com [40.92.65.82]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 68E6168C867 for ; Sun, 10 Sep 2023 14:07:45 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RFD85owzfjtC5oDWEz460rOlrlrEzRtZ5IcyXbb9fFPqn7p5JMIQ09lUsOLPzsKHRxsyacDI/+TY2qU1OJrhCoFaJpnPbdd5eJwtz4PgC8D2gWpxxnrSvGHz1YSilRs3UOLH+XIjE7ejgjliioh3NP55cYiAPP9n4o8ZvVdta5Upn//rZewkaNK5GAiHXDvSzqGQsBCPbRH+XZfrF0mAV0pdjLhuMamFCM4gV5Gj3M6JHNJpjiJGfNRc2rztXE+C0yfTBouMK7/Nx2FeihWFqegliOt9LxSZqYgk65KZVZ0MvxKKFF/+oi0nYCZj9/0d5stutcYkzaJhsxNkXlscyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0VgeEcPSdlPZGQSu5L2VxbBjbHsYs3B0pguwEfhYYK0=; b=Cv0WAV/UxRppm21F9c0pHLdk0JlF3f9bRSGHJdM6qeTmqoKkzJIeqZZ83XmPjF8vcx8snw2GK0pcTioSZEGd81X/SY75E1mmh7H/xmyiSQL+t0cYqrGrZt9FksYBcZEGqzsjtYDdmCuu0I8spm7wddYVVJYw46O8zaKG572Pmdmgpa9P9XdSDselda1Dv/LlNJ+9kZC6BN7k9c5bx5QuotuS2BpP7SZoWezOfxMm0O4RCnJLa8tg4Uj5fAkbCFeywjRgUQ0l/wfAcOVnY6yQ3Rq5ts7z9uz99xh6UjLJYLQ96uqhb3H6H8D1kaPDx/Nj0mPAAuq1t+B9c3mENf2CSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0VgeEcPSdlPZGQSu5L2VxbBjbHsYs3B0pguwEfhYYK0=; b=iF5mrAmqRi6R2IKs5RXvA9qMJ8gOgL4yiOuXBQ66GSVZyvLQcUiX1taSs0m5Eq2Pm8USzM2GfBkiDyDKsF0tTCXZdxvKuM2Kiq3rKAJHrEs1YP4ri6InFyjJrXw/bK6FSckhGBLOYDA5DY0LWc27RohJSmeem2aVb103KhbW47zXC1wSkTpqYRaAy4f19zfcD/k2GcoNehW+cHkcE7r/2gJDGBRfQE0BzFBue3Bk8NzTjAkBH7LhCd3tuKpmKJrvNFV9Vcc3EOBBu09mQlGwUiTtG/rclizofRIKqZcQ3biQFXB9AXm41SLMV0cAM9Oj+Hr20MFzuNdHEao59uK5Mg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0151.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:176::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.31; Sun, 10 Sep 2023 11:07:43 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6768.029; Sun, 10 Sep 2023 11:07:43 +0000 Message-ID: Date: Sun, 10 Sep 2023 13:09:02 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [nlHaF+gfSicl4ix/F6Kl8AATnsKPmsWk] X-ClientProxiedBy: FR0P281CA0191.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::14) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0151:EE_ X-MS-Office365-Filtering-Correlation-Id: 263848ae-728c-4716-a5ac-08dbb1ee27e1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xylTAirKr7wDTF2Kj+xjtoc6DbVIWbS7EG+OvAgGp8njIMOoxVCe0DkgLMM6LEjkMxVIJL1gueMb78BhPJVeCRUeeshBI1pg8LNk/FydwtB93oEi7jHJbYWoJvIuqYMErXHpqpgTwqSME+PISxZiae4TA+qiHSMiAF16xpjyrcWHzn0dN/EmsKSNGycF5xpWkohbCIdCB2XWpOrHvcvNMj2wRGieksNN4cPulBYfv6zwAZ883ArDZZ5gEqqgIsc9ZX/tvXFr71r3zNGdbTbOFIe/kRbIW8Xj/u/9kC0hzH2q8h1FPWhPZ3oWF2DlM663GCz4uxyX3WoN92pchYYLD6fszhgDLOzunZRgN3t+062RcbA97vN1oFfvDiK4nG6asIhIzVVHpu4tJ6rdXrqUjk5cSrRScKdyr4Hb/xC1Zge3tWPQw+PBtEVnAaXE3fslvtRGx+aGAenDfQp8kPukg7XtF5PUSS+YuAL79BmJK4ydnxpJDfHg3SeWlCesorhbCKtmvvHn4VdVn0ll5CCp+2c0AoPpF2L5ANP7EHlZ8DsNS6ORkNgORJnJZ9o1Cp8p X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDVkS3QrTlI4N1ZXak5NREtHci8vUTlQak5aOE1IMTJzMUgyYmJzWW9OQTNp?= =?utf-8?B?LzFRbVBJZVQzYjVhTkhQTmFMMHhOdnU5TFJDNTlZVlBzbFhLcExSMEtsZzF6?= =?utf-8?B?bXY0cURBa0M3U0krR3dCRzdpQ05PV2k3YVdnWlI1VU1KQm1mbEJEVGhRWS9m?= =?utf-8?B?azZHU2NrYlB6NytOWFNTWjA0b04wWktBS1NPYXNRdGphb3FEQWhYWG81SmQ5?= =?utf-8?B?NWlNV2RTT0REbHA5SDM4M3FUdk84Z0JxQ1dhdXd2NjRpMWZZTCtrZStZS3ZM?= =?utf-8?B?empXYTBCcGljSUVscWMrM25zRmNWaFdmNXMyRm13a3c1MDYwK0lQYVM3eWxa?= =?utf-8?B?WUZlcmVRL29XRFUwakcwdFFqZnB2MWdPNGVJcndMdEFjQ2MzdDkrS3kyZ2Ft?= =?utf-8?B?WUI4aXkxVHFFbmRJSDEzOG9DYTBVZUI2V3YzTFljNUxRTHZpV2Rtakt6dVNB?= =?utf-8?B?ZTExdU9UWkdiaWFIM1VnSjNqVWdhUkJQVzNYUEI1R2F3dUUrL2hsWWszWStV?= =?utf-8?B?QkhJUEd6WjdDVGZKQVQvTmR5NG1JcTFGVUpyL0liR3N5OWV6L2wyc0ZSYkRL?= =?utf-8?B?aFJGVWFVeFhzeXNOQ0VnY08yd2NManRYV0ZCVjVEanJUc2NRdHd4d0o0TlBp?= =?utf-8?B?WlVQd2kzK0EwODhBK1Q5VnVPYm0weUF3aWFqOVV3Uk1INEZRSlYvM1lTWkJq?= =?utf-8?B?V2krNTVWVS9ZMk13MHpIWnpINlNQcUd2Zk8zU3JJSWFWMm44OXlDb0tIN25R?= =?utf-8?B?KzFYeTBsZVUwdENxbkZSUENLODJDczNjSWNlVU0rZ25QYStyUEo4czk5dXkv?= =?utf-8?B?dXpWcVpZK0pmOVFScjdlc0xNZDk0Zm5WNXZ5d3F6YVBLc09Sc0ZTNTZBOGRM?= =?utf-8?B?anRPamsyYlQwRVJRS213RFgxZXNGTnc5TWZIb1NiT0dBSm83VTM3TDR6SU5X?= =?utf-8?B?eDVVNWZzbDk1QmxodGRaQ1QrMDJ6cGMxcFBjUWk4TUxKRjlHSllFS0FnOG9w?= =?utf-8?B?dXdjWVBpZStWWnhRNkplc1JJbE9qNzdZekFLR1p0Rm5LUDhOZnRXQUdWVEhC?= =?utf-8?B?OGl2NjNLNU56SmpGTTVQY3hOR3lBWFIxV0hzTm1hNmRzUGgxTDVEVHlqMEdP?= =?utf-8?B?M0tIVUFNQkVESC8xZ29TM1B4dnZwdFNVVkFHSHovTmpJZnkvUVBEQmx4YU8y?= =?utf-8?B?U3dXUjZmbHIramxRckNTOFhhWVZIV2pjUzJXTkRXQU5RUmMzWjhCYk1WM29s?= =?utf-8?B?RldBdEhmamFKWWhqNTVnMUZENHZZTkhHdjZnbUdDTmVnNUo1ZW5vZ0t0eVNQ?= =?utf-8?B?WURjQjVPUGMyYXZaWVZnRVFBRjFuVjdlajU5TmJXTkNPdWRUWTU2aDZNNUlQ?= =?utf-8?B?dTdYdTIyUEhhNTlHdW5MakkvMzJ3TmlaVEVDN3NDWUhMd0ZWSUg3VjBWeTdH?= =?utf-8?B?UCtjUzQ0RjFqQ1I1VGhXLzZWL3VlZ1l4WGJtc0EwMWUyczV5azRNNkJpNkhk?= =?utf-8?B?eEd5bTZHQUswQzdtVDRNRGxMcnlmaWc5TkZuZ1hTMk5DVUNobUhXS21rVEs3?= =?utf-8?B?NUxhK294QmxOU1VpVi8xUzNJdkdQVy81SEt4TGtFN2tseEJTTjhqMlNPRG42?= =?utf-8?B?enhkWDM1cHdrRzF3c2ZiR3pQbEc3ZFowaFJucEZYTWk1cWlsdktSK1NwRUtQ?= =?utf-8?Q?7PllW/DY5jxJf3G4Yj1r?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 263848ae-728c-4716-a5ac-08dbb1ee27e1 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2023 11:07:43.5080 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0151 Subject: Re: [FFmpeg-devel] [PATCH v2 16/22] avutil/imgutils: Constify some pointees X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > This is done immediately without waiting for the next major bump > just as in 9546b3a1cbcd94e9107f85c8f1d2175efc6cf083 and > 4eaaa38d3dfb8863a62f3646a62e4098b1c078d5. > > Signed-off-by: Andreas Rheinhardt > --- > doc/APIchanges | 4 ++++ > libavutil/imgutils.c | 14 +++++++------- > libavutil/imgutils.h | 10 +++++----- > 3 files changed, 16 insertions(+), 12 deletions(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 963ad477bf..048232b2eb 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -2,6 +2,10 @@ The last version increases of all libraries were on 2023-02-09 > > API changes, most recent first: > > +2023-09-07 - xxxxxxxxxx - lavu 58.xx.100 - imgutils.h > + Constify some pointees in av_image_copy(), av_image_copy_uc_from() and > + av_image_fill_black(). > + > 2023-09-07 - xxxxxxxxxx - lavf 60.xx.100 - avio.h > Constify the buffer pointees in the write_packet and write_data_type > callbacks of AVIOContext. > diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c > index 9ab5757cf6..da3812698e 100644 > --- a/libavutil/imgutils.c > +++ b/libavutil/imgutils.c > @@ -378,8 +378,8 @@ void av_image_copy_plane(uint8_t *dst, int dst_linesize, > image_copy_plane(dst, dst_linesize, src, src_linesize, bytewidth, height); > } > > -static void image_copy(uint8_t *dst_data[4], const ptrdiff_t dst_linesizes[4], > - const uint8_t *src_data[4], const ptrdiff_t src_linesizes[4], > +static void image_copy(uint8_t *const dst_data[4], const ptrdiff_t dst_linesizes[4], > + const uint8_t *const src_data[4], const ptrdiff_t src_linesizes[4], > enum AVPixelFormat pix_fmt, int width, int height, > void (*copy_plane)(uint8_t *, ptrdiff_t, const uint8_t *, > ptrdiff_t, ptrdiff_t, int)) > @@ -419,8 +419,8 @@ static void image_copy(uint8_t *dst_data[4], const ptrdiff_t dst_linesizes[4], > } > } > > -void av_image_copy(uint8_t *dst_data[4], int dst_linesizes[4], > - const uint8_t *src_data[4], const int src_linesizes[4], > +void av_image_copy(uint8_t *const dst_data[4], const int dst_linesizes[4], > + const uint8_t * const src_data[4], const int src_linesizes[4], > enum AVPixelFormat pix_fmt, int width, int height) > { > ptrdiff_t dst_linesizes1[4], src_linesizes1[4]; > @@ -435,8 +435,8 @@ void av_image_copy(uint8_t *dst_data[4], int dst_linesizes[4], > width, height, image_copy_plane); > } > > -void av_image_copy_uc_from(uint8_t *dst_data[4], const ptrdiff_t dst_linesizes[4], > - const uint8_t *src_data[4], const ptrdiff_t src_linesizes[4], > +void av_image_copy_uc_from(uint8_t * const dst_data[4], const ptrdiff_t dst_linesizes[4], > + const uint8_t * const src_data[4], const ptrdiff_t src_linesizes[4], > enum AVPixelFormat pix_fmt, int width, int height) > { > image_copy(dst_data, dst_linesizes, src_data, src_linesizes, pix_fmt, > @@ -579,7 +579,7 @@ static void memset_bytes(uint8_t *dst, size_t dst_size, uint8_t *clear, > // if it's a subsampled packed format). > #define MAX_BLOCK_SIZE 32 > > -int av_image_fill_black(uint8_t *dst_data[4], const ptrdiff_t dst_linesize[4], > +int av_image_fill_black(uint8_t * const dst_data[4], const ptrdiff_t dst_linesize[4], > enum AVPixelFormat pix_fmt, enum AVColorRange range, > int width, int height) > { > diff --git a/libavutil/imgutils.h b/libavutil/imgutils.h > index e10ac14952..91312a72d3 100644 > --- a/libavutil/imgutils.h > +++ b/libavutil/imgutils.h > @@ -170,8 +170,8 @@ void av_image_copy_plane_uc_from(uint8_t *dst, ptrdiff_t dst_linesize, > * @param width width of the image in pixels > * @param height height of the image in pixels > */ > -void av_image_copy(uint8_t *dst_data[4], int dst_linesizes[4], > - const uint8_t *src_data[4], const int src_linesizes[4], > +void av_image_copy(uint8_t * const dst_data[4], const int dst_linesizes[4], > + const uint8_t * const src_data[4], const int src_linesizes[4], > enum AVPixelFormat pix_fmt, int width, int height); > > /** > @@ -188,8 +188,8 @@ void av_image_copy(uint8_t *dst_data[4], int dst_linesizes[4], > * @note On x86, the linesizes currently need to be aligned to the cacheline > * size (i.e. 64) to get improved performance. > */ > -void av_image_copy_uc_from(uint8_t *dst_data[4], const ptrdiff_t dst_linesizes[4], > - const uint8_t *src_data[4], const ptrdiff_t src_linesizes[4], > +void av_image_copy_uc_from(uint8_t * const dst_data[4], const ptrdiff_t dst_linesizes[4], > + const uint8_t * const src_data[4], const ptrdiff_t src_linesizes[4], > enum AVPixelFormat pix_fmt, int width, int height); > > /** > @@ -319,7 +319,7 @@ int av_image_check_sar(unsigned int w, unsigned int h, AVRational sar); > * @param height the height of the image in pixels > * @return 0 if the image data was cleared, a negative AVERROR code otherwise > */ > -int av_image_fill_black(uint8_t *dst_data[4], const ptrdiff_t dst_linesize[4], > +int av_image_fill_black(uint8_t * const dst_data[4], const ptrdiff_t dst_linesize[4], > enum AVPixelFormat pix_fmt, enum AVColorRange range, > int width, int height); > Will apply this patch and the other constification patches (i.e. patches #16-#19 as well as #21) in two days unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".