From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH 3/3] avformat/aiffenc: Usw avio_wb32() where possible Date: Thu, 14 Mar 2024 01:36:33 +0100 Message-ID: <AS8P250MB0744D305771E72FB885DC0058F292@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw) In-Reply-To: <AS8P250MB0744763936DA411E5A4C088B8F292@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> AIFF is a big-endian format, so this is more natural. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavformat/aiffenc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c index 37aca41847..2cd1119409 100644 --- a/libavformat/aiffenc.c +++ b/libavformat/aiffenc.c @@ -54,7 +54,7 @@ static int put_id3v2_tags(AVFormatContext *s, AIFFOutputContext *aiff) if (!s->metadata && !s->nb_chapters && !list_entry) return 0; - avio_wl32(pb, MKTAG('I', 'D', '3', ' ')); + avio_wb32(pb, MKBETAG('I', 'D', '3', ' ')); avio_wb32(pb, 0); pos = avio_tell(pb); @@ -93,7 +93,7 @@ static void put_meta(AVFormatContext *s, const char *key, uint32_t id) // So simply copy the terminating \0 if the length is odd. size = FFALIGN(size, 2); - avio_wl32(pb, id); + avio_wb32(pb, id); avio_wb32(pb, size); avio_write(pb, tag->value, size); } @@ -153,10 +153,10 @@ static int aiff_write_header(AVFormatContext *s) ff_mov_write_chan(pb, par->ch_layout.u.mask); } - put_meta(s, "title", MKTAG('N', 'A', 'M', 'E')); - put_meta(s, "author", MKTAG('A', 'U', 'T', 'H')); - put_meta(s, "copyright", MKTAG('(', 'c', ')', ' ')); - put_meta(s, "comment", MKTAG('A', 'N', 'N', 'O')); + put_meta(s, "title", MKBETAG('N', 'A', 'M', 'E')); + put_meta(s, "author", MKBETAG('A', 'U', 'T', 'H')); + put_meta(s, "copyright", MKBETAG('(', 'c', ')', ' ')); + put_meta(s, "comment", MKBETAG('A', 'N', 'N', 'O')); /* Common chunk */ ffio_wfourcc(pb, "COMM"); -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-14 0:36 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-14 0:35 [FFmpeg-devel] [PATCH 1/3] fate/lavf-audio: Test writing AIFF-native tags Andreas Rheinhardt 2024-03-14 0:36 ` [FFmpeg-devel] [PATCH 2/3] avformat/aiffenc: Simplify padding tag Andreas Rheinhardt 2024-03-14 0:36 ` Andreas Rheinhardt [this message] 2024-03-14 21:45 ` [FFmpeg-devel] [PATCH 1/3] fate/lavf-audio: Test writing AIFF-native tags Michael Niedermayer 2024-03-14 21:46 ` Andreas Rheinhardt 2024-03-17 14:48 ` Andreas Rheinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AS8P250MB0744D305771E72FB885DC0058F292@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \ --to=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git