From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 65FD74122B for ; Mon, 17 Oct 2022 03:04:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2052D68BC72; Mon, 17 Oct 2022 06:04:30 +0300 (EEST) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2090.outbound.protection.outlook.com [40.92.49.90]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 047F068BB53 for ; Mon, 17 Oct 2022 06:04:22 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BQU4p2XkLJSHamdU0v+HFW2hys6+xMkw2lQ8x/UOhZJ8fdUrg51KqwsKmp6xufFeiq4s7wWnir5zvkZoHBxo+w4xyjq4K2sJw/gauKjOXDO5RZInqOOqY+UMvSKJVWAbG7uRr53CsmR0nRr174nBTbHQWaQ4PSD9XFmGRzs2HyxFx30D2Af6fuGe3iuE2TCAyqor7NQIuvmOGh5Bw3wBEBzqplfB/8/RoB/rrub7NENlNIcau8WIN0jat6OcPRuH5D29Sq4wbAT+cRIXiv0OFHwRbw0uv8AVArrkwqjJq4bQYWdxlsvYugUWehDadYpH62ZnONrhRBO4wIBaaXMeNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HfCvuKovnbyt6qxX1cn4Qp8xEa3p49Kx7QDa1rjfQgM=; b=X5XlLEAIFIkugqgKI6NW/3RbWKZC5j0j0wIUIA3SpKFlyDehnGG0/aAmAMIAdZ2yAytdHFueCDdZ740pCiIemBXrVxaccbnTy4tNNKH6tjwgbtmKyMstrhqqtDGV9MjoUsYpLBQRMBr99ui4LuGbQ1vOjDPuZaEdTeF2SRMIy20/gX4ze7kOfy05k9JjDtgIl3ZWT/o6Bw4NmNK3ZXtXe7dSSy0eGYp8h+lehwxxVxNovOLrLcIxZFS5FY2jZLsfcrvn7/jyw9/KkeqqyrCOTUNGjK6ncg4sm23ezHqF/hVTtbbhi7nYdU4bNu8oE/KPL7FrZDy38eolvNm2Z5mtJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HfCvuKovnbyt6qxX1cn4Qp8xEa3p49Kx7QDa1rjfQgM=; b=h0vFIA8GJVZXWbkfvITgjleacp3sRz5/wCv1ROXi25gbPz2A7ASLNbGcIrpdP/fnnV/l/4tffv3wTrnuUKTx0IArNMwJ/uIVsWjJnmwW0suuilWAtI1hv3iClsC0nqbvoKwFJm9VnMnq5dacODfWqs+BOe4JId916e73z1Te5zaI6hiLUGqFwYWO/fbnWUqedy2WH/ByzeVpQZufsAhLWX0GdZkU4ZumTrPBRmnBMln2rgnR32YVluNLi+scM76TIDOYKP4yYXeSnon8BfssKcFa1NlOyoybOKs69z+ELf30KtjORa72h6mPJDiOzSGH9JSZgADi8hFV9YrfFxiCtg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU0P250MB0435.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:347::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct 2022 03:04:20 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f9d7:680f:70c4:44fe]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f9d7:680f:70c4:44fe%7]) with mapi id 15.20.5709.015; Mon, 17 Oct 2022 03:04:20 +0000 Message-ID: Date: Mon, 17 Oct 2022 05:04:29 +0200 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [1iI4YQ5bHpVNGYQKWATAbRSS8YyU0NKU1/GuySTxiQQ=] X-ClientProxiedBy: AM6PR10CA0106.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::47) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <9fd1c759-0e41-98ef-e7d4-da73228e66e0@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU0P250MB0435:EE_ X-MS-Office365-Filtering-Correlation-Id: c1c79daa-5149-4f47-6d5d-08daafec4944 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oMb3NDl4D99ejmRsh1Vke5GY9pZhFzx4G48vYsxOBO+4XxijOClCX6Ra6ovKt9RcaAh7HZwMU/7LP1N/xFAec8HGp9G+qpZIIqcNgmBYTVEFzHTk11RvJMN/DkAx6r+Q1rX9ErADdzXwdo2rDLuhdUfcwJU0QwPb+SNNtxHpAM34fk4oggdorPkgJZGtpYVwh7RYdyb9L+b8wHCxxXDOO3lrekCv5VGr1aR3jSBlXGIKujL7LAniv9L99JBwCvrT58VSn8R5BcXIDD8Xtp+w94oFAT3MGvYj9trnemwCPsqzoxU0GjoF8mUPUK5flFP/PHlHAXrxV3vRvHEFFq1WB3tweOg/GATH/fWa/EiW4DKZEK2zTJtH8I4bbTWnxULXavMvJgASYPciQaTxKhHQTdUjPnN8zPdhBtkh9RzStvIac+t6HEOXQEKTNCRGRYsTuCZeZjSw8cL6oBLVE4eueDNbgFRWcD3wfFBDO7Q2SkCO6K2V2YPsUUAsssnvDmaoqFPwL2hC2myAU6wX8THxDQJLxL4rnnQS/OyRlJPDeNjI1yRzhVH/iUz+5HDP7fbEUb8KYMUtkUbsH3l2CEMl+wOin4QVET96bA6+CKbTbmlsGDCdO1DyMndjoARpuaJAYmEEhUelH63hlE/TqGiSUuveNCbWqQKpArFlki8+s8HC/VAjFGZlmkZr3DBSsCpl X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDVYQnZzVFRydjFpb2VjSkJvRHBLK2FMcVVkM2pmN0o3c3VZKzdpN3R5NGVK?= =?utf-8?B?Y0ErY0RIN1B5ZjRtZXNrQ0VIdC9mWnFYck5hSTBwbEQrRDRycjArU1c1UWs4?= =?utf-8?B?dC9Xa0oxdVRGaHRDVnpKM25FRnp3OFl2OWNYbE1XVFk2bFIvT3FBd2FaaVpZ?= =?utf-8?B?dzBkVXpFUmRNZXo1alZCd01nOXJqODg0TURsQ1hlM1FmazJSaTIvRmVOb2tK?= =?utf-8?B?SGFGSDYwbVg3WUhBNkhiRTlaeFNVU25wTjVlZllVRkwrNms3VmtCNnBINURF?= =?utf-8?B?c2MxczdGMnM1UGoxOEZRWitRanZrdVRkTmYwYkFlRTIvVnpWWDZaREtEbTBH?= =?utf-8?B?aHVBQTZ6WGNNQzVjT0VsamhkOGJRTHNlMUZSMG11c3plZFBLaFhpejE5YVhC?= =?utf-8?B?Y3JtU0pxUWhva1BrbUl6Y2habG9UQm5xdGlUNHBySU12NDFiVG5jWkhtVms0?= =?utf-8?B?dUZqSHdneXMxdkJ2YlpQYjd4SVRqZERJa2QwMjFuYTI1Y1d0RXJwYUtiVk1y?= =?utf-8?B?bEtFL3pOUEdCbXZjanJHM0ZEU0puSUtlMWpmODBYbHFtdXQ5K1FNcGZPNnhW?= =?utf-8?B?RmQwSGlydU16YWhNV1NhVEdmbHI4ZDhNT0tTSGRxR3cvWlNDaTMzQ0FXeVg2?= =?utf-8?B?eHpHeUtJYVU3S0dIKzkwMGtFcEFFbi95akJEZ0V2V25ZVlNtMjk4cnhVWnF0?= =?utf-8?B?YTBTQlM1dXQyeEJBQ2ZXKzI1UG9NbUF0ZFdZZE1lNlk3MzJYWUg0SWNlT2pQ?= =?utf-8?B?YjZtVTZCRGUxdk1TRGdZYVFqWEtrTjNEYTZpdVo5NWlBdGFZUkZRN24yK1dP?= =?utf-8?B?MWMwNW55NGtyUnNGQzRkTnpJN3BKMmV1RVp0cy8ydlhKR2FrcnR0SzhVMkpS?= =?utf-8?B?NEUvUGhMSVZPOXQxaGtKdlNMVUZkV0RBUVByN2QwY1hXKzFSbXNYQmtscVlz?= =?utf-8?B?YytSNzc5cFNIL3A4ckptMTRVVFVnSnNKdEVGdVhpc05PSEpmZTN6T3hBOWdv?= =?utf-8?B?eXBVdmJYY1JiY3JQMy9GNWlXeU5EYlFNdmJTempjLzZKd0dseW1ZdmRveVBC?= =?utf-8?B?MzV3VGtDbkxZd3MvNUg5U0owWFVzeTN1L25XUnJPNEtFeHRVbExXT1pyU01B?= =?utf-8?B?b2xMY1FHK2Q0QWtZVlV2N05XRnorRy9aQ2FwaDl5Qi9mYmd1TjhlSVBhUVdq?= =?utf-8?B?Lzg5MmtsQmF5OWRHMmo1RDEyYkdqQy9uN2ZvdWtCYWVJS0NZNmxwS1JqbXpr?= =?utf-8?B?UEk4WmlWMjkwVE5EeGhVNHp2ZjZYZm1mSWJ6aDE5MjBHdVp1cXFnRENwck5y?= =?utf-8?B?cFBDaVRNNzVPYVhxbDF4dDlmeHhCQzlhUzRRa0hLRHdZTzFteFhuajdIcEwy?= =?utf-8?B?OUNoMG5UeWl1T3U4OVJpZWtjZThUSTdCMkhKMHdzbHMvQVM1bmcrUU9yNjMy?= =?utf-8?B?WUQ2T3J2MFBPQldJNjBrMjJ4SkJmelR4YlRORW1SS0JZcjR5RXBzdUZETUJU?= =?utf-8?B?elVzbytEbUdFQWFiQ0xKcmRtS2lBUklma0wxSjlWcDJNMGdSTXdtWjFPSVhm?= =?utf-8?B?V3Vndz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1c79daa-5149-4f47-6d5d-08daafec4944 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 03:04:20.5366 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0P250MB0435 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/svq1: fix interframe mean VLC symbols X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Peter Ross: > Fixes ticket #128. > > The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapped > in our SVQ1 implementation, resulting in visible artifacts for some videos. > This patch unswaps the order of these two symbols. > > The most noticable example of the artiacts caused by this error can be observed in > https://trac.ffmpeg.org/attachment/ticket/128/svq1_set.7z '352_288_k_50.mov'. > The artifacts are not observed when using the reference decoder > (QuickTime 7.7.9 x86 binary). > > As a result of this patch, the reference data for the fate-svq1 test > ($SAMPLES/svq1/marymary-shackles.mov) must be modified. For this file, our > decoder output is now bitwise identical to the reference decoder. I have > tested patch with various other samples and they are all now bitwise identical. Seems like this is not the only test whose reference needs to be updated. There are also the fate-vsynth%-svq1 tests. > --- > libavcodec/svq1_vlc.h | 4 ++-- > tests/ref/fate/svq1 | 22 +++++++++++----------- > 2 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/libavcodec/svq1_vlc.h b/libavcodec/svq1_vlc.h > index 06e3509e4d..5c27928c2a 100644 > --- a/libavcodec/svq1_vlc.h > +++ b/libavcodec/svq1_vlc.h > @@ -167,7 +167,7 @@ const uint16_t ff_svq1_inter_mean_vlc[512][2] = { > { 0xA0, 22 }, { 0xA1, 22 }, { 0xA2, 22 }, { 0xA3, 22 }, > { 0xA4, 22 }, { 0xA5, 22 }, { 0xA6, 22 }, { 0xA7, 22 }, > { 0xA8, 22 }, { 0xA9, 22 }, { 0xAA, 22 }, { 0xAB, 22 }, > - { 0x7F, 22 }, { 0x8F, 21 }, { 0xAC, 22 }, { 0xAD, 22 }, > + { 0x8E, 21 }, { 0x8F, 21 }, { 0xAC, 22 }, { 0xAD, 22 }, > { 0xAE, 22 }, { 0xAF, 22 }, { 0xB0, 22 }, { 0xB1, 22 }, > { 0x53, 20 }, { 0x90, 21 }, { 0xB2, 22 }, { 0x91, 21 }, > { 0xB3, 22 }, { 0xB4, 22 }, { 0x54, 20 }, { 0xB5, 22 }, > @@ -231,7 +231,7 @@ const uint16_t ff_svq1_inter_mean_vlc[512][2] = { > { 0x87, 21 }, { 0x4F, 20 }, { 0x35, 19 }, { 0x4E, 20 }, > { 0x33, 19 }, { 0x32, 19 }, { 0x4D, 20 }, { 0x4C, 20 }, > { 0x83, 22 }, { 0x4B, 20 }, { 0x81, 22 }, { 0x80, 22 }, > - { 0x8E, 21 }, { 0x7E, 22 }, { 0x7D, 22 }, { 0x84, 21 }, > + { 0x7F, 22 }, { 0x7E, 22 }, { 0x7D, 22 }, { 0x84, 21 }, > { 0x8D, 21 }, { 0x7A, 22 }, { 0x79, 22 }, { 0x4A, 20 }, > { 0x77, 22 }, { 0x76, 22 }, { 0x89, 21 }, { 0x74, 22 }, > { 0x73, 22 }, { 0x72, 22 }, { 0x49, 20 }, { 0x70, 22 }, > diff --git a/tests/ref/fate/svq1 b/tests/ref/fate/svq1 > index d53e2952e4..0b0948cce6 100644 > --- a/tests/ref/fate/svq1 > +++ b/tests/ref/fate/svq1 > @@ -24,19 +24,19 @@ > 0, 18, 18, 1, 21600, 0x8d5b2ad0 > 0, 19, 19, 1, 21600, 0xe67128e6 > 0, 20, 20, 1, 21600, 0xb7bf613e > -0, 21, 21, 1, 21600, 0xefd0f51b > -0, 22, 22, 1, 21600, 0x31b7da59 > +0, 21, 21, 1, 21600, 0xf697fa3e > +0, 22, 22, 1, 21600, 0x5b6ede88 > 0, 23, 23, 1, 21600, 0x7a84a8f7 > 0, 24, 24, 1, 21600, 0x0351ad27 > -0, 25, 25, 1, 21600, 0xed6f434d > -0, 26, 26, 1, 21600, 0x0e771127 > -0, 27, 27, 1, 21600, 0x37bf0b95 > -0, 28, 28, 1, 21600, 0x30e10a77 > -0, 29, 29, 1, 21600, 0x1a48288a > -0, 30, 30, 1, 21600, 0xf43c6770 > -0, 31, 31, 1, 21600, 0x3c43ae68 > -0, 32, 32, 1, 21600, 0x04dc0949 > -0, 33, 33, 1, 21600, 0x7920758d > +0, 25, 25, 1, 21600, 0x57b547c2 > +0, 26, 26, 1, 21600, 0xbb9e1558 > +0, 27, 27, 1, 21600, 0xcb470f6b > +0, 28, 28, 1, 21600, 0xeb100de0 > +0, 29, 29, 1, 21600, 0x089c2bf0 > +0, 30, 30, 1, 21600, 0xe27b6a42 > +0, 31, 31, 1, 21600, 0xbfe2b11b > +0, 32, 32, 1, 21600, 0xd9ca0bb5 > +0, 33, 33, 1, 21600, 0x12fe783c > 0, 34, 34, 1, 21600, 0x6c12bab5 > 0, 35, 35, 1, 21600, 0x1ac23706 > 0, 36, 36, 1, 21600, 0x7a95cb5f > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".