Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/cbs_h266: Remove double ;
Date: Thu, 29 Jun 2023 20:20:58 +0200
Message-ID: <AS8P250MB0744CEEEB568D0A6F289A2778F25A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <6124dcad-c3eb-1385-2a00-76b059f4bb15@gmail.com>

James Almer:
> On 6/29/2023 3:17 PM, Andreas Rheinhardt wrote:
>> Fixes a warning from GCC when in pedantic mode:
>> "extra semicolon in struct or union specified"
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> ---
>>   libavcodec/cbs_h266.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h
>> index 8548e501c0..03dfd4a954 100644
>> --- a/libavcodec/cbs_h266.h
>> +++ b/libavcodec/cbs_h266.h
>> @@ -80,7 +80,7 @@ typedef struct H266GeneralConstraintsInfo {
>>         /* inter */
>>       uint8_t gci_no_ref_pic_resampling_constraint_flag;
>> -    uint8_t gci_no_res_change_in_clvs_constraint_flag;;
>> +    uint8_t gci_no_res_change_in_clvs_constraint_flag;
>>       uint8_t gci_no_weighted_prediction_constraint_flag;
>>       uint8_t gci_no_ref_wraparound_constraint_flag;
>>       uint8_t gci_no_temporal_mvp_constraint_flag;
>> @@ -211,7 +211,7 @@ typedef struct H266RawVUI {
>>       uint8_t  vui_aspect_ratio_idc;
>>         uint16_t vui_sar_width;
>> -    uint16_t vui_sar_height;;
>> +    uint16_t vui_sar_height;
>>         uint8_t  vui_overscan_info_present_flag;
>>       uint8_t  vui_overscan_appropriate_flag;
> 
> LGTM. This should also fix a compilation failure with msvc, which seems
> to be pretty strict about this.
> http://fate.ffmpeg.org/report.cgi?time=20230629174305&slot=x86_64-msvc17-windows-native

I'll amend the commit message and apply the patchset.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-06-29 18:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 18:17 Andreas Rheinhardt
2023-06-29 18:18 ` James Almer
2023-06-29 18:20   ` Andreas Rheinhardt [this message]
2023-06-29 18:19 ` [FFmpeg-devel] [PATCH 2/4] avcodec/vvc_parser: Constify parser Andreas Rheinhardt
2023-06-29 18:19   ` James Almer
2023-06-29 18:19 ` [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter Andreas Rheinhardt
2023-06-29 18:19   ` James Almer
2023-06-29 19:18   ` Paul B Mahol
2023-06-29 19:36     ` Andreas Rheinhardt
2023-06-29 19:42       ` Paul B Mahol
2023-06-29 19:51         ` James Almer
2023-06-29 19:57         ` Andreas Rheinhardt
2023-07-01 12:01         ` Rémi Denis-Courmont
2023-06-29 18:19 ` [FFmpeg-devel] [PATCH 4/4] avformat/ac4dec: Constify demuxer Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB0744CEEEB568D0A6F289A2778F25A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git