Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: squelch uninitialized variable warnings
Date: Mon, 7 Jul 2025 12:41:34 +0200
Message-ID: <AS8P250MB0744CDB1E3340D69E512B15C8F4FA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <d139703a4be6c6d2779bb84c542b3164b1e23599.1751765517.git.pross@xvid.org>

Peter Ross:
> Fixes CID1655273 and CID1655274.
> ---
>  libavcodec/adpcm.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
> index 92ab248f3d..527384b86d 100644
> --- a/libavcodec/adpcm.c
> +++ b/libavcodec/adpcm.c
> @@ -877,6 +877,9 @@ static int adpcm_sanyo_expand3(ADPCMChannelStatus *c, int bits)
>          add = (11 * c->step) >> 1;
>          c->step = 3 * c->step;
>          break;
> +    default:
> +        av_assert0(0); /* never reach here when bits is 3-bit */
> +        return 0;
>      }
>  
>      if (sign)
> @@ -934,6 +937,9 @@ static int adpcm_sanyo_expand4(ADPCMChannelStatus *c, int bits)
>          add = (25 * c->step) >> 1;
>          c->step = 5 * c->step;
>          break;
> +    default:
> +        av_assert0(0); /* never reach here when bits is 4-bit */
> +        return 0;
>      }
>  
>      if (sign)
> 

Why not av_unreachable()?

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-07-07 10:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-06  1:32 Peter Ross
2025-07-07 10:41 ` Andreas Rheinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB0744CDB1E3340D69E512B15C8F4FA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git