From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2B25049E20 for ; Tue, 12 Mar 2024 10:32:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AA05F68D030; Tue, 12 Mar 2024 12:32:52 +0200 (EET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2096.outbound.protection.outlook.com [40.92.89.96]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2049868D030 for ; Tue, 12 Mar 2024 12:32:46 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3qyK6WlbddME3EmkpEvokU+0pSZihhcVixOMPHsB+8JnpqCzvOk6bmUmWcxRo5YSU1q6tDWX1rjHa2cL4uuzWfqDX4ggfYdCBSF6yZtXk7FKlVbr1ZWRDyn2nxaR3DBD8s+IiUzLgJ1HynKOSlffyL1FJfmZFRNJ4zistPXTZdlaTAOvc4d8AKHaEalnAn3epSOd326mH1SKmnRT9HCegS6fViwbW841zZL4OFQs0hnPbEOOCQwTihZ0aYW7E3j47YjzU4Hbt9WJgPS60D/4eb/rSqnRB0nzjc/l7V9tpNoQVrTaZnf+uEs/YiF6HiiNHEwnNt05wolnqTpqkOYPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CcjZfeGifKPW5UPUe0Y7eBQcmMLTbAnJF5iDVtmHxsI=; b=XaqMyhXebw8hfY653QcBV9UJ/DQh1GsvIDI2ePySlKr05GU7//DvwIhF6wLuRMfLupHMsdMs2ympZjs2NTHK0IAHTaYGOBKegK4oXFRe1gDnC34woErr0FD80qYHwvHXCtGfoi17/HiMbno9sc5dgpDE+XFY7lpqlL9xVF8yLTZ+SIHDYkSq73LQs4MW6y6WETVW6yBghfyrBM26iB0t7FFly5I7UJn9Yj0avfIFCpjcL318Vf2Cn/Eal3wkd9Fy1ex13JAkcUcYcm2iN7ScjfcfL2831zYRYH/OdXagbVJtepGa4dHUxT2ZZ4cSF502C/IxI8vWSfm1ODQNt7k/rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CcjZfeGifKPW5UPUe0Y7eBQcmMLTbAnJF5iDVtmHxsI=; b=hqG+BnrLrcoSQfaaSUoOOFxKycazwtIhxTh9GsFsxN7nQR+k9sachrSO5kVyc1mWHOpsT7GM7lnXE46oOneUC49z1XtqtYOUfxc2A87tbje+/QS83HtV/Bnq4h+Kyy1VuerVRaZdkrDntUzaNVspaLZy/hWXN+M9k84DInUSXBpIt6jN3NL/fuSCETHFQ1rv2RqwGAITLw3L5TfaijaXsFgzmDhciyE4gZw/m8K8ZRzhpTzi9BuwsNNshkb2sI5l8OaYgQfK8UVYMndREvGHJFecSh1Nq3owZr2rzOcdwliz3aJl8uleCaOfu7r0aOj7qNIPAKNlTSpH7mW93secag== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PAXP250MB0598.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:286::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Tue, 12 Mar 2024 10:32:44 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::228d:8c6f:ed10:82eb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::228d:8c6f:ed10:82eb%7]) with mapi id 15.20.7362.035; Tue, 12 Mar 2024 10:32:44 +0000 Message-ID: Date: Tue, 12 Mar 2024 11:32:42 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240312084343.18441-1-anton@khirnov.net> <171023422319.7287.11903630014703761101@lain.khirnov.net> <171023835685.662.14765949974652498933@lain.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <171023835685.662.14765949974652498933@lain.khirnov.net> X-TMN: [cbFs2e4T8q7G53DGYPkRhOIxUI3jJFVmbsT4ESXKdB0=] X-ClientProxiedBy: ZR2P278CA0039.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::16) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PAXP250MB0598:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e9f4f13-a085-414b-c63e-08dc427fc0f7 X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnoAVlBsXi+5fjBAzVXFn6z11adPF0Ms/sdinDH/KNZS1QA/VST/mGdZawF/y3Bf0uomfXAeezuc/TcTQ7yiV6Acp5Gq9zZV3AM3rV+YS057dzXgsknl9f1HS4ouokK7ZjGo4qFSgwFJw24+FkrYp6xp0q6CZv6UDc/N/8JmZ5MC+Fa9rp4pvziA9Pkd5ZZvnTgkMvxotym4m3FZo8zsDhE6ZHtvxqeZntMNhVfGN4sAVg+zZYDi2JjOR7zsWPOtQ6QWDBVdhkMR/Hm7/o6DH3H1245KEcTY72UIZ4DA/ydSp9A3fyDuSdgOSXb5K/gEn4j51HrIeNDr+BSPE/eMqE6iwK8dSQmoPSy0VuqJ4DZaK2PiY5uX+FOo80UMq/XFgKySEHrMkQqtqTK0BEh+CYONSVO5HZQ/D7iuFIFvRVueTKffbGot0LdgHRyEiO7WVid0erKjkT9tkxgR8YqOfjSNZ+yBptRxKeldOiRyKNDcCvqhL5cagNGeRlyfYZOTDYvpQ0KM+VTjBEifaQJaMywH8bGEezwySBEHpaQQezeNJmcyylGP3u6JnvZarB5TLjJBjQdKCj4U/bFn/DzTAk8efoFY9t3nnIwlvpuHaso1zswF5fRg/LwDsA+KpuYJ0dbggKow+qgLBtg/NHwQhAToK11JmGPzaxJe9py1d+1fMqXp4uexP4JPjuNXthxEl2s/yxjcZ8mr/yONqAw78shTCS7KwTXndS0l6a+VEk1SqNCM1mQUithb7zZagdOTWBg= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fx9a7i1NvvmQBhM+/m5M/xsIYZgHWNI/l6zhmK5tMcdmUkspAnx8VOZWJ7a0zuGYgMPLrbwUmR5w18CxOQIZUKnql9xElSqI5mZkpBzd+OdkqBCg5tkBrC8nttMksPRCjEUa+UyiPDE/3Oi9Z+t54izZIy+gjc3/P9AFHQl6N4AQW0b+UlFASgp4lUYGoLWEyCtH83/1C+8WdEboP3GfYIWVcLpPWQvVmSBMu8Hw2eb6BON9FbpKjqzSxwFLYBusZ0tXo8BfE/k0lFYu82F8EeEDrzolhq0vElE83FmuWnh0meFPSI6x82grFJmakQCiaqtr1cwz5LIMLt8+LLSzlgsOVGl2bxzyiqICN76PO+EyQf9P6AYQVN/UlHALy0bv64OJ5MY1wofdCl9mM2GHKsvNPaRJuWPpI1COH3nY+xYArNAHmV/dbZ/zrzfczAJsK7yXcefkwZs/E3QWTqf6kD9eoKP3FRagn1XH+EUViFZl2WTUjQAqMs3DtOsFczaruOX5hUtBxFpBadKr4DrrRoo/goxri3dHHnY+VChDLOp99/hcdTw9TXLN3k7bNViA X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWxtbWg0Sk52VDA3UjJULzRnbW1RZC8rTk9vdi8ybzN5dVBJZC9BZkFPb2Rr?= =?utf-8?B?QjJMSXE0aHozUXRZa1VPdTVDNWRPQWY0WFYzUE1vQTBsMURpQUhzRmFqL1lF?= =?utf-8?B?V3lQYmlRK0FnUmpLRTN2T3NWOEtSd0M0cEFvcUdsUEIrdDF3QzdDRmdubXVo?= =?utf-8?B?eTlRaUJIY2YrdDVBaUpsUHFiVlozK3VOVGEzN21HRUE3K2FWbEt5eUljR0NL?= =?utf-8?B?YWcxaTlxT0hZRWtYYlV3bW94VG8wSDdJeXQ5K1RDYVlTaG04dVJ0YzVSYzZ5?= =?utf-8?B?UUFBUVBiMyt3VkRPQlBraTV0elp1NjVEWHFMczhBVDgyanlzcVZzYk1tclpC?= =?utf-8?B?akgwUlVoaFVJZ1JDUWd3dEIrMVRBcmZLSFNVRFYvWTdVM0dUV0lDSENVM20r?= =?utf-8?B?UzJSdWRjUVNFeEV6WS83ekVZUnczVS96bWFNam05NFd6R0ZENE5idnZMVlkw?= =?utf-8?B?Ymw2WWNvRXVuakJTUnBYTktLVDBjTU0rc29EVGpBNTNDMnJTMDMvbEJHUkJF?= =?utf-8?B?bWMxRHR2OGkxM0d5UDJsMGtaRTNpQUVKbmt1d2VaWm1NbXJ2amlYSHdiYS9G?= =?utf-8?B?QnNGZ3RZenkwVFZYWFZOYS9ORGhraFN4R25aaTk2Qjh3a2F6RGdJalFOQlhm?= =?utf-8?B?aEpPS3AwNlhEa2xtOFZISC9SclAxbk1vSXhGQkEzb0p2anJmdXBSVWxlWlln?= =?utf-8?B?Vkh5aHcxcG5VMk5rVlFDZHRFQkY0bUtVWUQ5SCtseVhnMkd6YllWTy9Qay9w?= =?utf-8?B?TGs4N2FRNmlHOEZXTFJRY0hkMUVpbmxnMVBvWHl0UG9zZ1FZQjl3T2pKUDBn?= =?utf-8?B?U1FENkRJYkhaZ2RTcWdsaExBVmVScS9XeEdvWG90OFFkejFoSmVYQ1ZCTlA3?= =?utf-8?B?SmRaSEJHNWIvNGJYVTBmNi84RmE0OGFzSU8zTjFvUmhxREFuZGpoNDFweXRn?= =?utf-8?B?ek45bkNPdG5vU2tJV0UrNVRYZ1U1Q0ZDd2w4c3l1a2ExUnlFbkFaSjR1TkIw?= =?utf-8?B?WTNxQzJDR0ZOTXFqZ242dXk1am1ZZXJuZHF2VFdHMytuWkcxcHI1QkNzZnAv?= =?utf-8?B?OVVuWWJGTkZZTUhiNnpUNW5XTWk2UVdvZzNQMEZKWjYweEYyN0hKNE01NlV3?= =?utf-8?B?bkJFRHVRZmovcHJ6MCtEYXBzaWN1dGdGYXNFSWRDK2JWV3hXQTJOekgwMTVW?= =?utf-8?B?NDlUYzV6dHcyRXgxeEFVeEs0NGwzbjBtbjlTWnRaUXpKL2FvbFN2RzJYZ0FM?= =?utf-8?B?NFFYYXdrVHZGTm5jV1Vya1FWd3lBSnNwdTJJL2dwL3RIdU5TczVuY2U4RTQ2?= =?utf-8?B?QVYweDdyN2orNHpZSUcyZ2RLRlpXUk9MTzZ4L2VaVFh2RjlmRW1acUk2T2pp?= =?utf-8?B?ZjdpaTVEQjhrZDN3R2Q2NzhkVFRJYU55RnJPS3h0V1lEMC9YUWNoMU1zbGZF?= =?utf-8?B?ODBzbVVndkY2Y0Y3S0xqRE9vVjVsbkJtYmU4NGMxeUVoZXkzeGJDSWtYVUYz?= =?utf-8?B?em45U1lMLzZ4RHNBUTMvdG9tL2xiT3pkeTRxYjhrQ0ZiZmF3b2taRE5UTWho?= =?utf-8?B?UjRKVi96UmsxY3hRaWg3M0FwOUEwenZNUytWYUlVWWpBc3cvZ2pwTzlGSzBo?= =?utf-8?B?ckxnT0lsSDBwMnVSTCtCRW1MQVljS0xybGNqbkJaaDR4eWxNdjV0OGh4Rllw?= =?utf-8?B?bDEySVJHTUJxWmg4YzRXNmtyVnl1MUxlSmE1T25pQWlUaGRreHo3THFBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e9f4f13-a085-414b-c63e-08dc427fc0f7 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 10:32:44.7398 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0598 Subject: Re: [FFmpeg-devel] [PATCH] lavu/attributes: add ff_ prefix to attribute_deprecated X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-12 10:21:52) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2024-03-12 09:56:46) >>>> Anton Khirnov: >>>>> Otherwise it might conflict with caller-defined identifiers. >>>>> >>>>> ff because it is not supposed to be used by external callers. >>>>> --- >>>> >>>> This is public, so it should be av_attribute_deprecated. >>> >>> As the commit message says, this is not supposed to be used by external >>> callers. Or do you see any reason why it should be public? >>> >> >> It is public given that it is declared in a public header. That is what >> matters. > > I agree that it is (implicitly) public now, but the question is whether > it should be. IMO it should not. Do you disagree? > It needs to be available in a public header given that deprecations are supposed to convey information to the public. If you are asking whether we should add a note like the one for the FF_API_ defines: I don't have formed an opinion on that yet. >> Furthermore, we have used the FF_ and AV_ prefixes for public macros and >> the av_ prefix for public symbols, but IIRC we do not use the ff_ prefix >> for public symbols at all, therefore I'd like us not to reserve another >> namespace. > > We do reserve the ff namespace for private identifiers that need to be > exposed, e.g. in public headers or when linking statically. > We reserve the FF_ namespace in public headers, not the ff_ namespace. If I am not mistaken we never use the latter namespace in public for stuff without linkage (i.e. a project could use the ff_ namespace for macros/enums without conflicting with FFmpeg). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".