From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 109C844874 for ; Mon, 26 Sep 2022 12:26:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 372D568BA8D; Mon, 26 Sep 2022 15:25:57 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2010.outbound.protection.outlook.com [40.92.89.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 897F568B6AC for ; Mon, 26 Sep 2022 15:25:51 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mfoMYnM0a5brUMfXqD5yqZihumsgl8SLDXm9M0dcb8QvlR4ayYxyFItNjOPDKprB2Xmbvkx4BD8CAl55l79WWCswCyCi86BGj94IVG3Iw2OB9ym0QjNleQbcLypmkkRNM8egv1N61FBp8dRiG9DONn1zmnsdAnMBKn3ciWl5kS9v2VxTTni7HehgKXpTXd6psQtCgtY75tGh8aBktdZsJJRJyRcSDsGTPW8AJayOwSJssXHPgu2S87k7bImphWb0NJhUxbTiBWa73m7ulOq60Z9KXnKmdP4txNlLYiqiDEfxiB6fLlrrEU2RsNulp18EzxmifYybr9YO3gPTW5PEZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cpH1HXb787dQLnVMDGlRwKsimqyRwkw5VsqbL8wdrk8=; b=b2QZrmroC9Gn5wapG5hED06fXwG1UGCtCe7l8Zs67x8Xbo1pV9jUlIrgFEJPEXvd9kwC4/Gk6Q0n916jq2XP0FR7biHSYYeB3s2PENC2idZQkqqDvEBg+r3wQihWOgJdo+CCf7bRAaCb2pUYnxLisDh0wYW0B6v1pyq6cfUJCCDGizEWtdrn2+76lVBCvGbkBx4dqvxgfykG/oy7nKTHyIH6QwwNuhf23qZ3tDEOOhsCbbjic5p61j/jzPXviyxih8fSCPbtZwdeYY/5vPpnQjPnNE8qtcq0HzL+MoJpyTVjgW6mvv7WfxeBi/lj1Ck0++QZC8Ujh/embWBPHaeS8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cpH1HXb787dQLnVMDGlRwKsimqyRwkw5VsqbL8wdrk8=; b=AXOHr8gKVEYqhp5RCwrrQ7A0P944lau69oiG8+EEbX+L0XFXycOKjiq/LZ9EEFZWoHMCPy3mwO/2gk96E37X+MT42Y3tlw2d3TtdR19amF/dzr6sa65R1ctLc++hOKe6LfGGlYe2bxDscuzmV2Yu7Z5c439uK+8Z9v9X+3RwxmpjCmjBOcvNDoHHRR1+FbmdYZQh23NFws728GwOx0L4Q30boIhnLEAY4Iok4g9uUaEs46DM3+M+gwl222HiAjM5di4SLe8UC0zRNMduC7w8oRBPuPszTrNjQKBU2bJTq9eLHCXbBOtEiN/E0Ry9hef7fIcPbICV7SJCaMg4CxQWkQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0059.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:3da::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:25:49 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::85ac:1b92:90f:dc18]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::85ac:1b92:90f:dc18%4]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 12:25:49 +0000 Message-ID: Date: Mon, 26 Sep 2022 14:25:54 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <165778644704.15564.15015584182496894872@lain.khirnov.net> <165804661780.15564.263905578360823358@lain.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <165804661780.15564.263905578360823358@lain.khirnov.net> X-TMN: [5GTdYmT6v4SDt+514BO6ixkNXhJLxWcscsSwUrrLZXA=] X-ClientProxiedBy: ZR0P278CA0001.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::11) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0059:EE_ X-MS-Office365-Filtering-Correlation-Id: a34c993a-6642-4cdc-7797-08da9fba3ef5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FLojzPb6x+g6xXv4gA0FZREFdcAD7FO21r5/1U4oWlSAfmjL1OS+/7bP866cox/qEqipPTLQJAajg31VOfv+wxd8zcF/GWCRj/c2UCizwkYl7OpyKK5gO7V+isS+qZdxYFB8uSVCe3nU8oNMiE4nzys+ptBOLQJ5Pmh0795lZyGc5nkSsq2A1tbq6tbVA4iZvDA1OYd76tAXwIrmEYQixde3ZNCRNHyQU66JRWSwxSny/ZFxw7/NMmmEIof4mcUFt75xPwq6dPJ1vZ03tDoHC48AHZTcPLbEfdCiFeyYb2MgAcUo2H4PW1fn4ndKfdFmPXIQ+QGJ/zLFKQEY/Jbs1w0DfNOe2KMGxb31bR3ys4Huc7ngcpRMsiUXAuA2LOAydrF3DGJKQ43iZ4L7BNPDHKOWeDTf81szKiwi7DjTiIwmbaDNi3G/dDbNQsppEXhrMPtOndGV7ViI1pYugZ2BzOxQAq/ENhNhko0w32gmWRtLhNYLiJc347y7D3YwudHwEGiry1OCmAqcDec+BjueG8ToBrPOX9L95FiOOv1DKfjoiIHpmdd0lkLLFY485syc9uiSSCViKLKQ3IVEuKt585+KCFdICv5R4a9DB0mUXIRU+MlAo8ke7lQEdwVv1E/BVLBOy1wN3gIXxNdS/8Lx0UBrRi4Rl5dIs2Ca3hrgVsjreppfNuBA4h+u5MqiG8rR X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHNJLzMzL2pZNjY4a2oyUGo4WEVSUyt1Uk5vL2Uxb1hPemJQTldFQXU1bmRV?= =?utf-8?B?TS93YWpjZndiOGY3MkhKc0cyNExhZWtEV1R1cGVqTGI0N3pMTUc1YS9TQ3E3?= =?utf-8?B?VVNLVjBLcHIyLzFZMzNHaE1sRDdvYmhNVmhzNkxaMytpbnR5TklVVVgrWHFn?= =?utf-8?B?U2RNV1QxQ1dGYWNaNSs0cVoyRFBRM3phdVNMRk95RjRadjdxOUljVTYrSDRx?= =?utf-8?B?NU1HR3lES3FnR2c4bVBkamE4KzhWRjJGcTdCZXdNZGNvZG1oaGRJUEh2UDRB?= =?utf-8?B?aXlleklPbzI2WDlzVHdMNkswZ2ZzbFczY01wR0toR09kVEY3Rk44Wk81U3Js?= =?utf-8?B?bVgzdlMyS2hQL0s2alIxRkk2aHYxTisySW9ZZ1VMd2srbHVLRUF3QjB4YVFw?= =?utf-8?B?S2ovb3M3OFB6VFJkeGgySmhLU2VLMzJYbGx5a2tqVWxzcHJrTWx0YWlIQkJO?= =?utf-8?B?bkd0Mkdta043OUlEM0FaakZad2V3eUZpeHhRZGR3TS9venlqUVFRQ3hOY0sv?= =?utf-8?B?b0o2UzREUW13Nk50UXY2cHNGR1RrWVE1VGwrV0JTNEEwdXpsa2tkM2hxeGFq?= =?utf-8?B?ZHJZNUt5ekRvTlhFcVhHK2N3b1FqT2UycHk0WVpqaGh4YjlHWWtqTlFTemxX?= =?utf-8?B?VGlwTG1oSmVrZDRDa1kzanZoMEYvQUdFNVdJbFlZMGhIRmVBMGp3ZmE1eEV0?= =?utf-8?B?WDRTMGgyMHRkRlVMMFhybmMxTkpWMWMrc09zblp1SG92OUR0RXNEc2RFcG0r?= =?utf-8?B?MUNITVkyVUpFQ3hVSG1kVmlVQnRseDU1ZGJjWExWWXhCVEZMMnM1bWMrNFh6?= =?utf-8?B?NE1zVGMyS3I1NnZxV002dk1aRHZHZGZTMHhCOXV6azlSZzRkQWYyMnhqZW02?= =?utf-8?B?VGZpM1hxWlhlV3p0TWUzYlQySngwUi9KcWVlRzRib2MxY1NQWXNGUzFycDFv?= =?utf-8?B?SjVCOU9sOEVpbDBKbHdEbjJXNjVCMUZqVjZDSUs3azhhSTFMczFDMzhsdXVt?= =?utf-8?B?WXRxYjVBTVZsSDdaVnM3cWZWSUh3Z0FuVStuTjBlemFTNDZJbFhkeDdwWGJ1?= =?utf-8?B?M2gvYVpqV1BtRnZTdnZLWUxQaWN3ZU8xZVVma2N2WFRwWGoxbWR1aVkzZkFx?= =?utf-8?B?RGlBdEdXRWtQNDVPQXdhd1FXQ0ltdUhRcHdtRDVjQXRIaDB4UVBLWUkyS1VR?= =?utf-8?B?T3BaZXRKYStYa2VoSlhvNDJINzRQcDM1STEzRnNOTDkrb0tPL2hvUEFLY1hl?= =?utf-8?B?MjJMNk9oR3lTY1NobE1rRGdaQ1ZYSkpxVk9XVVlqWURPYkNEcmdVTFdoL1dP?= =?utf-8?B?eVM0NFl3azdxSjRyMWxRa1FBYmI4aGhhbDc4TlAxKzhES09wV29WbGhXcThR?= =?utf-8?B?ejZIUjhjOU0xTVFJVjdWckduTTNiakJzbjczOElyTVU5RnljWElVOEZCcE1o?= =?utf-8?B?NklJdElGUmxlWHVRM3o0SlpOTThZZGhFRDYwZ0lXaGszUDN2UHQ4SUw5d2g5?= =?utf-8?B?WFBLLytHTmFkMkdLZWxhc2g4SUFJTURST2RVQURpRktDLzhqcDlZdjAyeG1l?= =?utf-8?B?bEk4L3ZzUXBkcVZ6MEZ5YjVKaGZQVHEvaFFHeWo5M3dTbVhQdlNONDRvL2o4?= =?utf-8?B?eHFsT1Z4UlFObVZhNEJ4ZURIRFNHT0NoSlkydjBydWNvcVZ0U0U2Sjk1dDJx?= =?utf-8?B?bC9GRVVIQnBrU2RTY2xadHNvUFpnOFRCVkpLZ3hsdGlWanhOWGdrZkRDK3RV?= =?utf-8?Q?nHnIQAL+WwXsNSyDAiHqsByHEH/N0oPg2H0VpAK?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a34c993a-6642-4cdc-7797-08da9fba3ef5 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 12:25:49.7541 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0059 Subject: Re: [FFmpeg-devel] [PATCH 3/8] avutil/mem: Add av_fast_realloc_array() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2022-07-14 14:51:07) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2022-07-12 16:12:16) >>>> Anton really dislikes the av_fast_* naming and instead wants this to be >>>> called av_realloc_array_reuse(). I don't care either way. Any more >>>> opinions on this (or on the patch itself)? >>> >>> If people dislike _reuse(), I am open to other reasonable suggestions. >>> This 'fast' naming sucks because >>> - it tells you nothing about how this function is "fast" >>> - it is added at the beginning rather than the end, which is >>> against standard namespacing conventions >>> >> >> Isn't reusing the basic modus operandi for a reallocation function? So >> your suggested name doesn't seem to fit either. > > Ordinary realloc just keeps the data, I wouldn't call that "reuse" since > it will often be a copy. This "fast" realloc OTOH reuses the actual > buffer, same as all the other "fast" mem.h functions. > > But feel free to suggest another naming pattern if you can think of one. > I see two differences between this function and ordinary realloc: It never shrinks the buffer and it overallocates. These two properties make it more likely that these functions can avoid copies more often than plain realloc (but in contrast to realloc, we can not grow the buffer in case there is free space after it), but it is nevertheless the same as realloc. But I don't really care that much about the name and will therefore use your name as I can't come up with anything better. (Of course, I am still open to alternative suggestions.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".