Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 1/3] api/api-band-test: Remove write-only variable
Date: Sun,  9 Jun 2024 03:44:33 +0200
Message-ID: <AS8P250MB0744C40BCF65317B6E0D3BC48FC52@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)

Besides being write only it had the wrong type:
An uint8_t is definitely not enough to store the size
of these buffers.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 tests/api/api-band-test.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/api/api-band-test.c b/tests/api/api-band-test.c
index bbaa6edb58..d40e31b850 100644
--- a/tests/api/api-band-test.c
+++ b/tests/api/api-band-test.c
@@ -31,7 +31,6 @@
 #include "libavutil/imgutils.h"
 
 uint8_t *slice_byte_buffer;
-uint8_t slice_byte_buffer_size;
 int draw_horiz_band_called;
 
 static void draw_horiz_band(AVCodecContext *ctx, const AVFrame *fr, int offset[4],
@@ -158,7 +157,6 @@ static int video_decode(const char *input_filename)
         return AVERROR(ENOMEM);
     }
     memset(slice_byte_buffer, 0, byte_buffer_size);
-    slice_byte_buffer_size = byte_buffer_size;
 
     result = 0;
     while (result >= 0) {
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2024-06-09  1:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-09  1:44 Andreas Rheinhardt [this message]
2024-06-09  1:45 ` [FFmpeg-devel] [PATCH 2/3] api/api-band-test: Perform codec admissibility check earlier Andreas Rheinhardt
2024-06-09  1:45 ` [FFmpeg-devel] [PATCH 3/3] api/api-band-test: Query codec capabilities to decide admissibility Andreas Rheinhardt
2024-06-11 10:23 ` [FFmpeg-devel] [PATCH 1/3] api/api-band-test: Remove write-only variable Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB0744C40BCF65317B6E0D3BC48FC52@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git