From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 111FD4900B for ; Wed, 1 May 2024 20:43:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA7E768D735; Wed, 1 May 2024 23:43:51 +0300 (EEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2096.outbound.protection.outlook.com [40.92.59.96]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4035C68D6C0 for ; Wed, 1 May 2024 23:43:45 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oMTkvtvckq8ZxURLYhlNkwwa7eUtJqBim/bI2x/kU3bPXZA71UoH9w4A7JhShJvau9N+fU4s/rpQ20Iuc/JZMenPO897r2CmgV/rhLYlMxERRgaeJgn59Ai1jOQTMrklZ9uGO2CrRjK8+7VP3JKZ95WE1YGALBggg+ewnUiMFu5A72GvOxooFG/PcVTuTA/9TQL4iA9HMNYXq+7ulCjeXmTXucJPpoynWpODddob+Poy3qip5G4xQx6OlLX8U5qj3hihipftbAjvwRlM/j03X2r9SsmasdrR+4z+AGKg7pe6J+5D2gCx1LmkeDJFqIL2k/S6ZjUQvvKl8eITEVmN+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0FUZHdokFSB1pSPSp/okSRVKSQQ2NpWotbApFb/kDwQ=; b=nsanC0i6f9EpfYKmn3WzDmrhnrH+sA8mRi6ETfBu030dttpiLT3X1HZSc09koZb3R4sJxZ/lnCzPc1jWnSR79UjaOe2cU4weOe0Br+3vfxhnMsBEssEyNm8GJZ1qNWSGJ34PWHirrlzBoYHKuYs95+1MG3B3+U8mSLFaMu/JMtsvfP5JEcs5Q/OuEP1E4vyrrshsKgdZTQzQ0v9adUHY/+DZ1Pv7behYJg+kRnhzpo22vxAKMVHhYFGdZjjx5+/5jpg39qBIPIDfQQ/JehoqIHs3NlLoxnOGf2PXamM1J3zZTpd1wtroAnGJ1sUWP22CGfY54o+r1AEqfo1LDX/N3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0FUZHdokFSB1pSPSp/okSRVKSQQ2NpWotbApFb/kDwQ=; b=IYe1SWDLOwHcmsGR0V6ePXm310yDQxWFV41ddx6KCZXnT+wNVYUWy9Zc23qdOFoWIYfCYr9GpFGIJSoiF2Sy1ASszJ90AEmLFnUqTGSWCbjKRN6nHzWuKiZH6eWpN1gkCz52JpZnql8wFl1YSAqhxacUym1xog1Kas5CelQlF+PFIKVtXdR1IK4ChtI/a/3HC2Sl0iGAEZ/ChprzspnceD3QVje/Ft6BDUZeDeAYlUdu9Lg/0aYtONlPx+nV9hVVx7UYbuYnKGXxp7mIYBgHdChc3Lj0h/5x82HHcqYIvajoqx3WA3l8K7nLW2uKAefaMOCLTmFgsK+BePZmUSZiPA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PAXP250MB0448.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:277::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.36; Wed, 1 May 2024 20:43:43 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7519.031; Wed, 1 May 2024 20:43:43 +0000 Message-ID: Date: Wed, 1 May 2024 22:43:41 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240501190156.36095-1-jamrial@gmail.com> <20240501190156.36095-3-jamrial@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240501190156.36095-3-jamrial@gmail.com> X-TMN: [bAjPHRNgxT7HFTFDt5MxB/C9I+lv/hEKKwxruar6mIE=] X-ClientProxiedBy: ZR2P278CA0010.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::14) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PAXP250MB0448:EE_ X-MS-Office365-Filtering-Correlation-Id: f72135c5-f69d-47bb-2438-08dc6a1f641e X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: R6kaPPGiAqUlbAY+w27+LEYuGR3EN0sGpvPvDgAq3t+V0sxga8gAF9aCrc3g4u5aKeBkTSOEwg+E22YwSLgyedksv3s1TxP4nYABC90wrgp8Tbr4pr0ruIQpNeVaiUH6GnrIG5eLSYs20BCbftgmVutc4GuEWFDohw7MC2HWpckNoyNy97VT2EOjl39ZV6go9tWqOdawwrLg1lbt7EGeQZ0V1QoZWJ1UajeQlfezM/14tfipZIBT9Ef6qPkTiUafwSRdZQNT5N8liXPSXhmRjIqeLZnIaDNJ9oZeyoS59+kyvwsReA6bPOPSZ13KRzR7fv6CI9nrlgNJQVVUyLmBXLlkXAM/JLZZRTunUfzLn5/PUGUL8B1pYNTitFaXPPjtIYm8gVmUUqM/wKB6k83CNf/EbW6omZ5vlRx0w6UDgxdVBQT+vhOsqZKUsf9rkYpQu/Ou6KtGRxNuUoEd7YnvPGNQ1pvlbZHeARytOYJ1r55ECa5vzUwXDfkOMltVmkTefOlvIZ8Or0XMLICJ3XR+pjqZ3YTX9uJ9aTOfqG68zL7Cf/SlwyETFqV5sfqHko20 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Skx0cU1yU0VidmJqRGZLdjc3dnZ4ZDRkeGtlOXJ0dFJuNDFKOG9JaWhNV3pn?= =?utf-8?B?M1plRXdZb2ZNVVhwTEthUTdoRjVwL1g0WGtKNzNPUEswOG1GRjF4d29qSFVX?= =?utf-8?B?T05pNDZ3dDdwSDhlaFFqckNiTnM5Vm5nOFI3ZFF4YUhORHVOMGxaNk05VGN0?= =?utf-8?B?OWlEZ1JPQk9wMGN2Q0NrS0c2R2ZBekhpRC9YNEJVdGhmVXhyQk5GTW9pZ0RR?= =?utf-8?B?aHFrdlJrNDVIbnFuMVJtRk9KNGliZ3dSQTdDNHdBcDlQeEUzV05BMnlodnNZ?= =?utf-8?B?d2YwYmpWYlJzdVNGN3B3MDBsb0tJZlJGdjIwVDNEMWVPbWtFSTY4T1Y2UHg2?= =?utf-8?B?dmREemJ5dEJYMlpVdW9VYnI3T0VDYklrNXdoNTROUkJuWEVIY3J0YUNVQ3FB?= =?utf-8?B?SzI3dko3NlppUHRtSEZPdzR0VzU2TVpFVklTY0c5cmpLcmh5YlBPQlk4Umtq?= =?utf-8?B?NzYyYVpOQ2o2K1hUTnpTaUVPdDRuaDJkZ1ZVdGtpbmNnZm1FQms1MnkrT1hn?= =?utf-8?B?WExRSzlWaUFEZ1RuQUhFNmxVWjdFd3hXaHJsWmJIRjZDYy95Sk8vRHVMUWtt?= =?utf-8?B?L05sS2txRFFudDRCY0o5QzlWanpBT21tZlE1eFVvQnAzeDRnSVQyREp2dzZa?= =?utf-8?B?TmtWM2h2UEhqdjlWSDE2cmVOUHpscHczMGNITSs5aVBIQU5YRUI0L0duRzlY?= =?utf-8?B?M1pqT1liUXhENnNLNXg2ejdOb0FhQTc5a1g2TlAvY1lBTmlNSE9XYWhOekZr?= =?utf-8?B?KzIyVmxJdVRsc2lsd3ZFNkUweHdSNWJWUWwyQUdJV2RnS1FSdGJuQ28vL2Nx?= =?utf-8?B?QllUalFuWTBqL1piOGIxMWpxRjlpWXRJYVBoSzMvT29iVDk0a0UrRDkvZXRB?= =?utf-8?B?bnhvMy9GY2RJVTI5c1psMWQ0N0VXQlMraGFlazVCWTJuUUdYb0w0RWdaRWpx?= =?utf-8?B?NkpQZ0lMNXdhcEI3UXB6WDZuRXpoUWo4d0J5eC90MElyZFVOM2wwcFI5UVEx?= =?utf-8?B?Mjhwbzh2a3YzVGZBSXkzOVZNQlkzQ0lEaEpMZkdiSFFqNEJtb2RjaUhaMnB1?= =?utf-8?B?UVdyK3dnbFB4MklpR1dhQ1IzK2lGdzdpUHZOOSt6L1FmcnExR3RMOEtwNStL?= =?utf-8?B?bmU4WCtKcnhRVFZ6UVAvWStheFhhdkJidnpUMXA5c3RBdWtYSXFDWktzTGN0?= =?utf-8?B?d1ZsS3BzTm0yOUtoYWFUWk1iaTFGK20ydTgrbUJITDZNckh1QXFyZlNHZExK?= =?utf-8?B?V2tPbUMyTkJWSTdtWGVDZHdyL1BvWlVpRnFoTnlSQlpsb1NjekNNLzl0RHNx?= =?utf-8?B?WDdLSnZabDB0TlFQQnd3ZmtZc1ZRY1lvVnE1cEY1S1E2WGlhbHprS29JR1hS?= =?utf-8?B?UG5pQzhpUXFPeVdhN0VKZUdmVFpmL3BPMWVVMW1aMFVkV09QaWFrMFlmNFp1?= =?utf-8?B?Y2hnWVNrZ3AvMnFsUlcvMnJRdXo1QVlZY2kyMUNUVkxmS2hvd0xMQjdwMCtY?= =?utf-8?B?Nk4weEZCNUNRUk5LaWR4eExaZldwRWFZaHRjZnNpR3JzSWFNc0dNSFI1cmNP?= =?utf-8?B?TjNISDVodU5XbnVlZ0I2ZHlhMVF2QmpVamxpNittUjNlM3A0MFBDdlExNE9T?= =?utf-8?B?VzJ1bVBDUE1hdXdnamFlVkpZRWpwcFB1YUtRVWlWbUJPNWR6TW1MZVFsd2RF?= =?utf-8?B?TDNGWitkVDVyUDZzU2c3ODVERHV2NDFOeG5sQTBaU01mbm5sVkJQQ1FRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f72135c5-f69d-47bb-2438-08dc6a1f641e X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 20:43:43.7457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0448 Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/avcodec: free decoded_side_data in ff_codec_close() when decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > It's set by the library, so it should be freed when closing the context. > > Signed-off-by: James Almer > --- > libavcodec/avcodec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c > index e560efff6a..189a0a2193 100644 > --- a/libavcodec/avcodec.c > +++ b/libavcodec/avcodec.c > @@ -463,7 +463,9 @@ av_cold void ff_codec_close(AVCodecContext *avctx) > av_freep(&avctx->coded_side_data[i].data); > av_freep(&avctx->coded_side_data); > avctx->nb_coded_side_data = 0; > - } > + } else if (av_codec_is_decoder(avctx->codec)) > + av_frame_side_data_free(&avctx->decoded_side_data, > + &avctx->nb_decoded_side_data); > > av_buffer_unref(&avctx->hw_frames_ctx); > av_buffer_unref(&avctx->hw_device_ctx); The documentation actually states that it is "owned and freed by the encoder" for encoding, so your restriction to decoders is wrong. And without it, the corresponding code in avcodec_free_context() is redundant. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".