From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CE4B146FDD for ; Mon, 24 Jul 2023 23:18:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9231E68C2D1; Tue, 25 Jul 2023 02:18:50 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2049.outbound.protection.outlook.com [40.92.90.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0DCDB68C74C for ; Tue, 25 Jul 2023 02:18:44 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fq3hznLcem1wNybyX438NbXEAUimLQWZ2p3AEbnS8WjlqMZz8P4UEs9W4XmdbIu4CsrGuBh7RU6vhQemLBg3YIx7XLKrCZZWaATUaFyOEvtLg/89IDwGoBJ4zhZKNXWZ06iZ686lzYPOytffeT15AZvNMD2v5OL388h3yqqi2F0fKHrH8eTCuWLyWFiayM57R9FsmZguUHZuBEhWG5nl0tJlsOs9WGGSrdoHWiQT4F/UtDemMKtYJZe1KK03Z2L40LhGF44RWszBOVJecVEG1Mhr4RS7K7XQk4apa+XXV+xK+iEmWkmeCo3YhP3u0SOILU1LWgTorQWK3nLGYpU3jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9xOeDgk3VpdUTxUBf2ViwOrugicP7a3Hx2YTl3XXkK4=; b=e5zjkJbMwNZYzknhKC2kBPQ1gNMRZqSqUXzODQ3s/xvilkcPmA4P35RvkVneuGex47IrTSdSu1bSfM9oiKe145UTVgt0O5/GilB/9rX94yrzoO7khfEaWeJgFnkFo71sUQEBlIShi9T43GxVt+lkMdTPswhNKs2gMsFFUcUU07A8gRE25XA8Miz2KUnismJk/k49/mj7Fl1a9THjryS/TwZ+ZWZW9dQNF27h2Z9DaEXqCeYcZsoILnDnzIC3VDeytADHZ6IA8z8DzEEFKlvbB/2RRtOo9U8vUpftjLbKTAPxt1b63cTlS5FOIKc1W/J9k7Xp+CieaVkfOGutpNvKYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9xOeDgk3VpdUTxUBf2ViwOrugicP7a3Hx2YTl3XXkK4=; b=WydSDRj+TjI0Exw9bRcsbWXqzS8ErQn0eLOjOC8JyATogTN1AkI1q6IVAZVbaYuedQtotUTRCn5wHtvgppse51InurIAE5w/iCs/K5kmt1+nAWkP7jNJeyldtun1wJRCXtIGd6BiolbMKguZ/b/BItC06CP073YtmfRCgVhbMbALr2p/HISA2R4IE370tnJ4zCUN0exsbbFRnngMHjJBoLcIEW8i5wPa3IE/AFCKSBLQrJFBHz+Y/qX8ipqDQjxd88WuShJ49YXjUjUhSkjKBRg4434i0/VPsnoakpT8lSJuGk7tuwR9OA9vEFnHx5vwBMVS1JuvFtPyxuousjT4TQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0173.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:27c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.32; Mon, 24 Jul 2023 23:18:42 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6609.032; Mon, 24 Jul 2023 23:18:42 +0000 Message-ID: Date: Tue, 25 Jul 2023 01:19:52 +0200 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [ZaWpDGutpjaytVjN8zugxhAPMTDacfrV] X-ClientProxiedBy: FR0P281CA0242.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::12) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <80b11fc4-1ad6-a3aa-9dc7-6ccb4d413463@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0173:EE_ X-MS-Office365-Filtering-Correlation-Id: de17c4f4-d1eb-40ef-6b7e-08db8c9c51db X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hanPr8WR7olEKHYZttzKuMNyCmxMoBmfR5lAvwNEWMHbfwRKHv1Ixm+20jEufKJaJF/JGkopuC/V7yCeSgVPLDacDwjPPK+HuYmWm23H7BeKESPdNOtcEIlwrYfTDuRkDB+225EGaPlIo0SQqNE08NDPOqipdCzHDZIeexrq5XUWeZcDyxKtTYOnX8iLZ+1dIC9x52sjcDvECw7+N2QikA73jUx4mpOnRo20NsIvQd5mD3Z05NLS2/UfeBRhHcIMl8vul9DZVA+RmO6tWGd7pfvEKZtum4eSDyjZFAsTJ2PDfpl1FMHPWQhCrONf5X7kV8s57YbaSmg2WgigHOkWaC/OLAr8tt6kbwuDEdFM7Z71kVgNhTNHcXh8YTusAhymE8edYbLM3d+SqamoSN41jGqdUivoXBUvDAxevwvh+TvUOA192M/bySPBrQ45QoRS4Z9Yd5JdPVMcDAst+2iVTcr/PCcTaranUgiUyrsMiz8SHvz6/4Gc5Ad5xnLnFbxxEmuet3oKzn041lUoWdHFBoInlqP//p+mt5ZQmj5H8ezUJ+OENCBY0GnXCOJQzfJB X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnBOSXBjRHhFdTRhdytTNnBLS3lTRzErVnBwOGF2TDBiT0JFbXhjaWZjY0J1?= =?utf-8?B?UDBIenJ0SVl1REVpN0FWeHFhcHhnZ3hxSFFmNWpxQUZTa1kydlZ3UHVNTU9X?= =?utf-8?B?cTdVc2NZdGhJaTJock5NOE8rWnM5Unh6YklKS3JjRExJOExQN1YrY3Qxemt4?= =?utf-8?B?SnhiZ1FzMGZnODdJVWxoT1NMekdDQWp4L3N4RmFYV2J0TzlkRVFFaUo5VVVJ?= =?utf-8?B?b3dYaVphaFlDd0tUNlZYb2RYQVdxOHUxd0RHOWdZSjRFbU1hbG5XdldleDh1?= =?utf-8?B?ZnhaMWt4dFZzRmlqL0dGN0wrTWRuNnZSZFYybXlpR1FFQThSMXlLTTloaC9a?= =?utf-8?B?TGZhZlpkSXBLNUhON0JxUnZWbUM4cUgvRGIxZDVLejRXSW5lUDFqWlJQd21X?= =?utf-8?B?QkMvdCtpemMwOEc2WC9KeUJDRi9wNzlMVERaV2VzNDNQYUZxTXlMQVMyOEJY?= =?utf-8?B?Y1QxVGxYNjZYUGpybHVyTzBKOGxBSFJYN0dSZmhQTmNMTCtUeFYvS2QrWkhE?= =?utf-8?B?MUNwVzkvUVFpaW9adTVHZWlVemV1SGVkalBPRHorbXpRWlpIbnNNTFhacjEw?= =?utf-8?B?aktWd1VsdTVJcFRuUW1MNXo0WXJpdkczektEcW04ZWw5WEFIajhMUzhWNDRD?= =?utf-8?B?ZTh2eTZJOVpZOTdRejdlVS9NT003bjRWR2haYmhsMUpnTVJnSE5lSmo0dWhS?= =?utf-8?B?OUV0Szc0akVldk5wQTJOLzBQc1lKWHhLRDhQc2cxK0o5SjBXUXErSXBHdFZD?= =?utf-8?B?V2dZOFA1MmVEa2xLd3R5ZVhSdmhFYm01MHZGYjFpMVkwekllanl5dTdwbzJr?= =?utf-8?B?NSttbTI5UmtIdjJkWnFiZCt5VkFJb2JJWm9kVWVxV3hzQ1dTM1hJYW5SdlhP?= =?utf-8?B?MDhIMjhYUUVzMzhWaU9reU5WaEpBM1FJa3lHSkhpc2d3WDJHblpqU1lTdVhJ?= =?utf-8?B?UkFLOGZmZ3dXcDZ2cXZ6Q09kM3ZhblNuYVgvQy9Yd0lrSEZPaDRFTFl0eWJy?= =?utf-8?B?R1hDQmxqMi9MMXNDSmg0QWFxWW05THpPVVFOcmgxV3lLeG8xbXlPTUJtc0RP?= =?utf-8?B?d0xiZTNaT2RrYVBQVHFZSC93YjI5d3hqVWdKaEx2UVVWK3RXQlBhT0pyQVF6?= =?utf-8?B?Tk5DWVYvcEZ6U3djNlF0LzNvNnB2Z0ZKd0dkdHlpSWNqVnI0amlockVjelkx?= =?utf-8?B?UDN6VzFUWC9xMGoybW1SSzZJSEJiZXlFdFNxMDVJeGN5MjFmL1R4Z0p4bEZl?= =?utf-8?B?YjNJaXVheFBzUVJyeVBYSEVEUFdJbWVQSnFSaks2L1dXL2w2eUR1NGFSc1JN?= =?utf-8?B?Z01EcXNoKzZhWDNsbTlIQm01VXlzSUJFK2ZQZ1ZDTWViK3RCeWppZksxNG40?= =?utf-8?B?TVBIa2s2STRSNld1WDN3L0Q3anBTWlZub3IyeURLTzBCbGljTG9DcDE2ZnF4?= =?utf-8?B?a0RESEdYZngyTkJ0djJ0Q1pOS0VtUlRLRzhnSjZndUFTZzJueXJjbFBNYXJz?= =?utf-8?B?R204SXFKZk9DZVdFUTM3cFFUVk9KU1V6Ukh6c3VEdkFjVjhLNUZSOEtwcVY0?= =?utf-8?B?ZUFSL25KR21CWmpTSkNMSTZqMTZxUDFnQmsrZW5vTU1EdC9Bb2p1cWx4SG52?= =?utf-8?B?VzFSaGQ1cnYvQzhZREM0VXQ5amlrWENOYnEvTDBScUVBeHVzUGRybzZ3WHND?= =?utf-8?Q?jrgluETtXd6KH22UDh0p?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de17c4f4-d1eb-40ef-6b7e-08db8c9c51db X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 23:18:42.1134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0173 Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/avfft: deprecate the API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Lynne: > Jul 25, 2023, 00:19 by andreas.rheinhardt@outlook.com: > >> Lynne: >> >>> Subject: [PATCH 2/2] lavc/avfft: deprecate the API >>> >>> This deprecates the currently unused API. >>> >> ^ >> superseded >> >>> --- >>> doc/APIchanges | 4 ++++ >>> libavcodec/avfft.h | 25 +++++++++++++++++++++++++ >>> libavcodec/tests/fft.c | 4 ++++ >>> libavcodec/version.h | 2 +- >>> libavcodec/version_major.h | 2 ++ >>> 5 files changed, 36 insertions(+), 1 deletion(-) >>> >>> diff --git a/doc/APIchanges b/doc/APIchanges >>> index 5afe8bcb75..38fc0b1459 100644 >>> --- a/doc/APIchanges >>> +++ b/doc/APIchanges >>> @@ -2,6 +2,10 @@ The last version increases of all libraries were on 2023-02-09 >>> >>> API changes, most recent first: >>> >>> +2023-07-xx - xxxxxxxxxx - lavc 60.23.100 - avfft.h >>> + Deprecate av_dct, av_rdft, av_fft and av_mdct. >>> >> >> This should mention that the whole header is deprecated and will be removed. >> >>> + Replaced by libavutil/tx.h >>> + >>> 2023-07-xx - xxxxxxxxxx - lavc 60 - avcodec.h >>> Deprecate AV_CODEC_FLAG_DROPCHANGED without replacement. >>> >>> diff --git a/libavcodec/avfft.h b/libavcodec/avfft.h >>> index 0c0f9b8d8d..6401833089 100644 >>> --- a/libavcodec/avfft.h >>> +++ b/libavcodec/avfft.h >>> @@ -19,6 +19,10 @@ >>> #ifndef AVCODEC_AVFFT_H >>> #define AVCODEC_AVFFT_H >>> >>> +#include "libavutil/attributes.h" >>> +#include "version_major.h" >>> +#if FF_API_AVFFT >>> + >>> /** >>> * @file >>> * @ingroup lavc_fft >>> @@ -44,26 +48,38 @@ typedef struct FFTContext FFTContext; >>> * Set up a complex FFT. >>> * @param nbits log2 of the length of the input array >>> * @param inverse if 0 perform the forward transform, if 1 perform the inverse >>> + * @deprecated use AVTXContext from libavutil/tx.h >>> */ >>> +attribute_deprecated >>> FFTContext *av_fft_init(int nbits, int inverse); >>> >>> /** >>> * Do the permutation needed BEFORE calling ff_fft_calc(). >>> + * @deprecated use AVTXContext from libavutil/tx.h >>> */ >>> +attribute_deprecated >>> void av_fft_permute(FFTContext *s, FFTComplex *z); >>> >>> /** >>> * Do a complex FFT with the parameters defined in av_fft_init(). The >>> * input data must be permuted before. No 1.0/sqrt(n) normalization is done. >>> + * @deprecated use AVTXContext from libavutil/tx.h >>> >> >> This deprecation warning is supposed to apply to av_fft_calc() and >> apparently AVTXContext is not a replacement for av_fft_calc(). Probably >> better to write something like: "Use the AVTX API from libavutil/tx.h." >> > > v2 attached. Added a comment to both APIchanges > on a replacement, and added comments to this file to > indicate how to replace each functionality. > Looks good to me. But wait a day so that others (Anton?) can take a look at it, too. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".