From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 06CA849C01 for ; Sat, 4 May 2024 09:50:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 48E5668D6C0; Sat, 4 May 2024 12:50:20 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2045.outbound.protection.outlook.com [40.92.73.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2F5F468D6A4 for ; Sat, 4 May 2024 12:50:13 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bFZuBxnqja3gl1pUzXIZlHzZvHy33r5uRRtod8WO1e0I4pLyzU/mXBwGqjSBV1/wkrEYrvZa6Lzv2xKOVvOEvU5ioLgqZ1Urv4AwUUMWSETW7hjEXW8VN+s9mRTGtFCRfGiuhr2mrN2OVm119kSKpTlA3zKPFvvdY1vjKoFHEiKufkdBJtxQS/oGdEYgmyLNsSegdJdCoh+1pxlOinpmIF5ShavUpVFG+xr57vVFqXH43at+Fmeeq3KvTllCK8flbNmaJ2AljHKx1HpFSBf7URr0+J+56x2WV5fGkRjQjoDQNRL9JE652Es4z4xXsmNzQOmzYd13+XF5rWYVgiATNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kv91Lx/aUpOzI+Tre2pWiI0JbgZegsD33miZ7hxcGcg=; b=Ao+okh0uWnNP8UNXszhKcbLGmFkWinIZxdyo/eF7cfyDq4fYeaiUZOZEE3SiAYuA53ooARHkb+gSK0LCNaHgSUzXlB85EQUkdt8cuqxHfo4r3UEucLpYyypITRq7N+VAvUYE37r6skMwsqhi3BsxSYtVicaBHyHQ0oKGn3MtkySAXzUNXIAGCyimIeJfrUoBruB7aOEu1BrGgduQgZsfoqZuocerSoecsCaVRtMet51wYMFRLZGCwE3msQnmPFg/LCEMBaXqJBlT9f/MQnHmtJLbvPuvBvOBkgxTQz60n+sKKZDtsCrsdjV8Qtmx/GltpAffgRjl4ap5viAdQ6fgeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kv91Lx/aUpOzI+Tre2pWiI0JbgZegsD33miZ7hxcGcg=; b=mEdaLtH+WSV2W8AWkBUv6VWMkFEEez2LdHqkmtlTeDWYdPTAtkvVN+d40dNoQbbSinjymytGTsPSjf6oIZEk7MC+V7yH7fkvJvnpSwS9nhm1UwEpErQD76FLHACWk1VxWCLDHj+oiNiJfLgQk9YjqDmv1ETBDu1YUCVBdDaMxoMyI1oUck5aM5NFZlGVyhsFzGTSJDog9dXRHt8Uw37fqz44zF27Gd730InNOigLeGNkkk+Mc6xjrm4kReyPMdKvbzWSUkp+v/8L195Qqwcl90VY9lPPlPihTA9tibnIET/jmfVOTr/rMBHk3Cpwfdt44uif/IeAiGm3TqiGE/e/4w== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0237.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:276::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.31; Sat, 4 May 2024 09:50:10 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7544.029; Sat, 4 May 2024 09:50:10 +0000 Message-ID: Date: Sat, 4 May 2024 11:50:07 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240503215502.1509887-1-michael@niedermayer.cc> <20240503215502.1509887-4-michael@niedermayer.cc> <20240503233801.GO6420@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240503233801.GO6420@pb2> X-TMN: [CR77EBcPlGy32Dx4vQJhlRLCpOTpZ/mdg3wWk9TYIEQ=] X-ClientProxiedBy: ZR2P278CA0004.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::8) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <861ec816-16ea-42a4-b671-1b9f4d5013ab@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0237:EE_ X-MS-Office365-Filtering-Correlation-Id: 66d9f407-1a63-449d-865f-08dc6c1f9621 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: tKXO6oOKf53upHsnx8McHZ55S3VNXbzV6cRqcGJog+xa3AZo4qyHGQrVzybPEwoEBXDSrwV9eT3DAugH4sPU9PC5P5tO7CAi9DQe2KiBcl+Ke5nGowGIDr6UjxTd55TtRivgOytT2HrCPUT9XQJWFpowQ8GZbD0S2fz+ueJcBOaCfN2IzmXIOnQhI91fRHrUi+nRmufKmCtIu/14iEVJhLanYIKxz8zTO6hwEdyqaHIXes00yQYw7+0cA3a7QQ8N/DA8o/crzaMNjTvZLkzmq0wLSkOSspapUJ4kvn2epd2HLHTup4UYltzgQJEyq/Qb8eRAx3RnKRKULkNXKkNaqMPOmeXmut6JJ7NQ0jqxZCw3yadPGx64h7pE3GAH6GTc9eXdAsXdL0QWms1DlqW37/T6/kQKFN41WEJskq66bOvDXgUvbnupmjihwmHCeEajHdnD3bh4eeg20A6NLnJJxm0Y52fsTxyGnrO3lKk2njvPV5yJ4TaIUT5Qc5qhaa3VfrzU7ey1mfR7c8RM7R6AG23xtrgIL9eolDX2eb6j7ueziPx8Dm8Twqs9GWFn3xcD X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHBaRGRFQjEvbklpRE5welFDcFlNUWhLbUVLemd1dWdhMm1BOHNkNGRKUmJ3?= =?utf-8?B?RnpJc0dsSzdTUHZjR3Zsa1lNOHZhRFZTY2o3dXBsSXJ2cWhyNXA3VFRyaFlC?= =?utf-8?B?ZCtaV0J2V1FhcmZSTU4wT2FNTElLc0k5bjBybytPSWpOb2Q1TWFvbFhyTWFI?= =?utf-8?B?Y3RqcmdrTUlVV3daN01HeGQ3Q0FGSVhCZEtsbVNISCsrWFVCU0pnTHVLRWFv?= =?utf-8?B?QWJuRXdmVTFNMHZpL3VCVmNCL0ZmTHdaNVp3N21BZ3duNTNhUDJhODZnNncw?= =?utf-8?B?dlVQRkhqZ0tYb0g0Wlo2YjJvbHliejlxcC9NWEJTY0ZoK0pJY1YyaDhWVkYr?= =?utf-8?B?NENMWTAwVkRKNktwN1NkZFRpMkxsMmk0ZlVQNnZydTNKY3FrWlZ3T0FKeFFt?= =?utf-8?B?alYyT3N6L1NtMnozcW8wUHA2bWMvQ0I1RnNIT3ZyUnJPcmtHSmpRNUtiQ0sy?= =?utf-8?B?aDhhZktSSHBPSnFoMURIVnhKc3RUSkpPOGpYd0Ezc3JXbGFkaldGbUtENnU4?= =?utf-8?B?R20wMXp2emRlLzBGeS9TckJIY0hIckJQOHpRQW1ZWlBvVkVLa1B3Nmdiamgz?= =?utf-8?B?b2pEbU5jKzVXNGM5VHpQM3BzNjB6Q0l3NGtwTEpJNitSOWxPL2IvSklwNEFh?= =?utf-8?B?bTFIRTBLaTVTR3ZIUWh5UU9XZnBhMlNHYmhCNWdiWTlvdGFXUkoyK2p5ZUpF?= =?utf-8?B?endzQWZ3UU1BVG9RKzFsRXpnZGxNK09SMjl5elRheUdSR1ZaTmJtRjBHeXR4?= =?utf-8?B?WnlXcURsR0xLdzlmM1Z5bXhkNzdNQ0o1aEMvTEMvYnFEUjBsVHBFc0t0a3hu?= =?utf-8?B?NXl0VnRkNzN6eXRUYXFLd1pjSjBZV2dpS0syYjZGZjY1blh4TWVhR2NHVkR2?= =?utf-8?B?UU1hc1FMbjJaT3dJZmhVZzZMbm1aQS9qckk4ZTZHMVN3S2RvMnE0QjIzRkk5?= =?utf-8?B?ZGpHUGF4cVR5SWJ1amluWWZnalluSzc0OHpjajk1aGhBaFBjcERTOEg1bUVw?= =?utf-8?B?L2hJL2IwUUU3TDFhamVHbHBPaURKWUpNZHZ0MS9NQkFoZnZ4NFBmbm5HTVVu?= =?utf-8?B?dzhjODhhN2Y3M0E2a3FQS3NYR0FqSHBHeFJNTEFIVjdERGVKTlhoeWNBTTdF?= =?utf-8?B?NTRJTWIxQndKU1h0Mlp6S3FQM0E4UXlGY25BOE9QbEtVZTBnbFFqRS84WXRh?= =?utf-8?B?UDZwQmZ3dUVZOGU2QlhIMndMdWsvUVVxdU1aYUF1WHVkVm9TUjZxY0Z1dTVR?= =?utf-8?B?MGUxaCtCNzFmaHpNZGZJZjMzajA5R0tySFN3N1hhVnNlRHV1MmpkanYzai81?= =?utf-8?B?QjFkTzY4UXpXNHZoUXBObUZqY1VWZlpNK0t1WkJHeHVOcjIzcFFmU1REelFH?= =?utf-8?B?cjR4dFJodnRqQ2VFQnFPVDY3M3dOMHJtTUlpaHpmam5rYWdyeXliQnNNVmkz?= =?utf-8?B?YVB5NUVDUUVGTXJPVFRSK1VDTkZtUzZEcnZhUlQ0MmlHck0ra0dKUXgvenpY?= =?utf-8?B?RHB0TXVFMU1FdGJuMStIM1FMSkFRb2NaTXUwZjVYVG4wUlRmZmNmQmZhZlNm?= =?utf-8?B?ZTdTOHg5OHdhelhsckF0T0F4TkwyY3hmeWhKQjJqVDJDdzVLWUMrd2k2R2g0?= =?utf-8?B?eVozV1VxazFTaFkwWi9NSEJXVGVlUk9UQlA0WXEzWnE1L1psR3ZqRitMZXRR?= =?utf-8?B?QURmVUpIYmJPRGRpcHFPVVZNY21ncnc3U3FSMzdjaXR0NVZoM2JrbHNnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66d9f407-1a63-449d-865f-08dc6c1f9621 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 09:50:10.1112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0237 Subject: Re: [FFmpeg-devel] [PATCH 4/5] avcodec/dovi_rpuenc: Initialize bl_compat_id X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Sat, May 04, 2024 at 12:21:03AM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> Fixes: CID1596607 Uninitialized scalar variable >>> >>> Sponsored-by: Sovereign Tech Fund >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/dovi_rpuenc.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c >>> index 7e0292533bd..c5e452957b5 100644 >>> --- a/libavcodec/dovi_rpuenc.c >>> +++ b/libavcodec/dovi_rpuenc.c >>> @@ -57,7 +57,7 @@ int ff_dovi_configure(DOVIContext *s, AVCodecContext *avctx) >>> AVDOVIDecoderConfigurationRecord *cfg; >>> const AVDOVIRpuDataHeader *hdr = NULL; >>> const AVFrameSideData *sd; >>> - int dv_profile, dv_level, bl_compat_id; >>> + int dv_profile, dv_level, bl_compat_id = -1; >>> size_t cfg_size; >>> uint64_t pps; >>> >> >> This is unnecessary, as the dv_profile switch is exhaustive (i.e. the >> default case is never taken); but if you do this, then you can also >> remove the other "bl_compat_id = -1" assignments (which conveys that >> everything is treated as invalid unless we found it to have a valid >> compatibility id). > > i see > case AV_CODEC_ID_H264: dv_profile = 9; break; > > the dv_profile switch only contains 0 4 7 5 10 8 no 9 > > what am i missing ? > Ok, I was wrong. (Well, I could counter that ff_dovi_configure() is currently not called for H.264 at all, but it would be a waste of time.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".