From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 024A449A28 for ; Mon, 27 May 2024 13:10:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C22FA68D42E; Mon, 27 May 2024 16:10:13 +0300 (EEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04olkn2068.outbound.protection.outlook.com [40.92.74.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 545F268D2C1 for ; Mon, 27 May 2024 16:10:06 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QU1cp1Rja1+yYrXVKb71i2keEKWbcCMvgnI6eEe5jwL51ilUHE0k7WhzA8uqlAPaR/uNqFnTSbnEbhRIhfYcjaSIwr1qHMULkYch7igBx/LYTqBVze4fKlZvRzmzer+Vrte7YUS60/p1q+aJ5cX/t2xreBMTnrBCvEjfQdMoKUn4yjndH8TgxqvXupuQ55V3dV1Bk8YquIB9Kj8HEIF+hJTz0cXliGZkYlFbUmMEvJMC5XtdB2+Z4erKhxb7o5dLG5gK2XTvPTeI/v+Kh7onEoq6d6fLvw/Ok7Wq4uisOhaYudKUEKgbYj4mL81i70aLgOH+1IGt233FzEhuTja6Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Nxjcdytj7JvsHd98QXp+Lz096Gn8V5HX0RS1ayymcM=; b=NG5zagigvz11KYlZUUkvnWR5i0+WdYZ6STcf/27cQGXe9eVYRQeTJCn8UNM6baHw173Fh91rghi98IqyGhUJqx+vQYzmWavgvDHw0rgnktl6iqwRyK4Mv35zazDOniTQ62mLtwt+WjBLUVrwsughy5FfUkkhbRD2Piymsf9LZq/w2eQFLw5iZ6daraszQqs0KOJrNuSlbt97KWSYWmciPz5OuVFvI+OUuHfPp+BXWAD5eIGkJYClZrVZtHullUYDV7YYT6sck8i3KAnM0VhufSyuneVx9MC/09ZI/FUb35+J3lPFwZ69N9WLI9Bqt6zSP0BsDi++eHYfaY8hXzWBDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Nxjcdytj7JvsHd98QXp+Lz096Gn8V5HX0RS1ayymcM=; b=XvL9nwccEp771IJPd30Z8nJNifm90ORRPu9Zooxzdfv6fH1nONMQJ70cjRLiRXtx2N9PW9lsToJKGHQZxCoh65i6fS++Zi5Y7vVT10RhD3F9oJ56NTXPjlSudxiEosvezxw+YDZi6luWHRoP0pDuL0MaMupJDW/vC/Hpw4T+iLMhLii77SZanIfuK6Brh3JQAuPG5ocovMgfSRKrBNBWUh/r3lNSW9EMdFGqGeEUJgnOduKl0jEIWlDIdqpc6nJ2kN3hXSXOmNlV2oPa8p/tJUzGSujke55LXpuuP7+ADTqGiHbTVzbjwYbc9zi3esl+Ck3aylhPkPoTPvOP37kSEA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PAXP250MB0573.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:28b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Mon, 27 May 2024 13:10:04 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7611.025; Mon, 27 May 2024 13:10:04 +0000 Message-ID: Date: Mon, 27 May 2024 15:10:02 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240410133118.28144-1-anton@khirnov.net> <20240410133118.28144-3-anton@khirnov.net> <171654143551.28895.3093393442533883603@lain.khirnov.net> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <171654143551.28895.3093393442533883603@lain.khirnov.net> X-TMN: [9Ah7zLahRHLeFexTryWvmo9bY3QIbmvjqhVv2yUpnPU=] X-ClientProxiedBy: FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::19) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <1329bcd1-d61b-4181-9aad-231a852f0f0c@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PAXP250MB0573:EE_ X-MS-Office365-Filtering-Correlation-Id: c4b29db1-51c5-4fa0-cacd-08dc7e4e52c1 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|1602099003|440099019|3412199016; X-Microsoft-Antispam-Message-Info: NuQ6W2+z+g2d9UoTST2xRSqk4cWlpBK6amYW0UnEuRLyQS7+jybmH4jNKvXVqgIkFct/d1udwi2p1GfCVW0tCBukeeHxE2M5XbQFfQoJyUPOXGydHkTdoGxc0pGBQGpvjg80NrLXX1uJVMcv/lgSqPSi7eXz5LwDUgc0Vd7du+aQdLpwAqChs6BYm2BcMHh+auNGKFcQ9aIFutzDcR/kbAXbQWh0OOibUYqxA2yKsV/UavB+gSN56c34gaDp5uazNM6cNCxqJxrrJ7ZP5kdm+GS31DzXnFrzQ6C10403WXUQ2j2DAnAwZRwe/XhQUnN6GoEP++r7CKKoWsj23jtPd+IIbKmzdynlJMdkbycCkoA14oT8KwARedpeRgFnCZAZhQb0IOD7M5TO/3BvIEbFVYduP8DXrrzmFABo0tNbRB5uNv2CJM8jJPMiG8rzLEiJyGelEzRfC1fTcd8U1Ne4Wu3mdjmao9g052A/472hvbgZsPULb0XMHsFEW7KJivocoRfveUg4MewOP09BCG4e2cO/l9fK0yJQYsiXGuMFmNCvpO2xuqomf37Mf32v1p5ivXjxXRhyMNV54YY/hqBLffpoeb5C4BhkIDcvPKLQW7P7Tse9ESV2RHHy5wF2tzAMDtkdcsiOkvaPGbZ2yt0K/741sqL5SQ6mmxvlsu2DLg8= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXdEMDBDSlhmaUNOQkFaV0Nvc3FrTkx2Tm1wdnhOTUk3emZBUDJsUjlyZGxk?= =?utf-8?B?NStxR0ZNSTZ1OFdac0l3UHZSSXk2V0NFWkRBNnNyOEtqSXNtOE9qQmNPOWZq?= =?utf-8?B?eWZyUGlld3I1VXJBNm1oZWtYQnNGa1d5Mm43UkswVDZRUGxJb3M2RWxWN3li?= =?utf-8?B?aGM5c3BvZXhORXA0VjFSR3Q3bFBZWFJkandxS2Z3ckZHOXpaTGNEdTZWR05k?= =?utf-8?B?M3B5VDdxTmVCN2RBTm1DaTZkeVFTTlVIazAxaTlxUUdtRDBXdHR2TE81QnRr?= =?utf-8?B?S1p0cndYUWliQ0FFSWJlbEhlMjQ0cVlNclRPQ0tYNTNxQVp6cWVudkE5cWU0?= =?utf-8?B?V2prN2ozc3BUK1IwclVaRDV2MnJnNXVSZlRnWFA0ck5UQklSV1l1WVNQN0d5?= =?utf-8?B?TVVlVUpJYk1RWTJ0RTMyMk0vTVJFaDFTZVVFUUpOdzREanp4dFVKbC9hb21l?= =?utf-8?B?YWhWNUo1a29hMGVRd3ZDUStxOTFwVXdrT214QU5rSlh0NDJtMlVzM251V0Nm?= =?utf-8?B?ZXd3ZXFuODhsOUdWQlJkVzgwTW91ZmRCc29BeDh5cEtld3dNQXhjMHA0aEhS?= =?utf-8?B?K1dwRXdxUlZBVE1jcXZpWTBrLzFjK2RXNjRPdjRBMVB0RVNETDdmaGtsQk84?= =?utf-8?B?MTlSMjVrd2ZMcHZPcjVJWnVGYmpVaVg4Ty9xbG1MZTRDYzZ1KzZSSkQvME5M?= =?utf-8?B?azJnSkx5YXlnTHdQOUlDL2thSFUxdzlUb1FLMzY0bDJDR2hhb1ZnUFFsNDFm?= =?utf-8?B?cU5BanNpQVoxTllRMkZxTXozVlg3ZDJQdEJhYnVQNXpZMFN5dktsNFJKZ3ZL?= =?utf-8?B?TlFxYThVM1dOblZxNlhBV2IvNHhURk9iYUozM3QzYUlVa3BRRGhSMkZRcWMz?= =?utf-8?B?cTRMaWI0RXUwd29LSXJ5b3FKOTUrc2EwM2hzaW5acm9aaWo5dGJnUkFsK1dF?= =?utf-8?B?QWl1d1liSERUaHZyak1oeklYeUV6dFhwemkyNzNsZFJNeUcyaTBVQXJVQUd1?= =?utf-8?B?eDRrQlhIZmMvTjlRQzExVHRxTFMzeWlJV01BYTI2TXpmK1pobGlFNm5oV2RY?= =?utf-8?B?NWMzTzhZVlBZNkpQVU1uM2VXQXIrN1RMRGFrSVl4VTE5cUd6d0dZOGpGajMx?= =?utf-8?B?WGQ2YThHM0NsYUR3SUpFR2Z6S0RpQmxBMlVnUS9BUmNFVEI4QlhOY2V4NlRp?= =?utf-8?B?SlVWclRtU2VyUHB2VGRPNktOZWZnazdnSE9VVGpCUXRPMEFJY0V2Z1BzTWxE?= =?utf-8?B?Wi9KS2ZMdzdrWTBzcmM3UnRFWk5GU1o2elIxRWt5VlhmS0M4c0FtSUhLcmxa?= =?utf-8?B?NGRJMmxURW5vK3UwV3h0V0xBR0RRakJzQzJaSjRMay9RSXNGOTdFZ2hqRGpR?= =?utf-8?B?T29QMDRTcGhvaWtmKzdsKzFRRUd6R1BJSWkzOGxFdXpaR3JJYkxieHhzSml5?= =?utf-8?B?cHJaazdXMWRPY3Q5UU53UDdOYjF1SE56V0JGNnlzeUN2VW5HeVFUMTdXbVcz?= =?utf-8?B?bGZxdk9Ja0xOQlFTMENsK2JHd2JJUmhtWmNWWmFBVFZ4K2tLQjZCckplRjBQ?= =?utf-8?B?OTdzZXpPa1FEL3NHejJDYUliTXI1UkMvcTd5b1pXTG0wTFl5Y1hLY0FLd0hB?= =?utf-8?B?ZndBRGRTM2J1b2tPb3VTZWRtL1lDbXd4QTRPaGZZTDRId3VZY2lIdXhrcWFo?= =?utf-8?B?ZmNSaVFSSlozV1V4c2ZtRkVKWmFCSWk0eko4T0xEOVVWTEszM0RaUXZRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4b29db1-51c5-4fa0-cacd-08dc7e4e52c1 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 13:10:04.2849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0573 Subject: Re: [FFmpeg-devel] [PATCH 03/10] lavc/hevcdec: allocate local_ctx as array of structs rather than pointers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2024-04-17 11:29:18) >> Anton Khirnov: >>> It is more efficient and easier to manage. >>> --- >> >> Allocating structures used by slice contexts jointly has the potential >> downside of false sharing if the structures are not sufficiently >> aligned/padded. > > What do you suggest? Align first member to cacheline size? > This is problematic, because av_malloc is not necessarily aligned to the chacheline size; for the same reason it is not possible to simply DECLARE_ALIGNED_64 for it (see e.g. 7945d30e91b96d2f4f5b612048169087d214d41e). Given that the structure we are talking about is already pretty big, the easiest way is to add explicit padding at the end. Use __GCC_DESTRUCTIVE_SIZE if that is defined or 64 if not (or maybe always use 128B? https://stackoverflow.com/questions/72126606/should-the-cache-padding-size-of-x86-64-be-128-bytes). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".