From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8B63D4A358 for ; Mon, 29 Apr 2024 21:14:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D48D468D518; Tue, 30 Apr 2024 00:14:55 +0300 (EEST) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02olkn2056.outbound.protection.outlook.com [40.92.50.56]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C1BAF68D422 for ; Tue, 30 Apr 2024 00:14:48 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UTTtcCsIaN4oJmxv2Y915xksm1GdHEd7by7hxsNz9bi4bUv0snhsKB+iUNzCYxl4jwYndS7oXac0RlsyehxdQFvDn37gjozAGYomjN7bulZ0cuiQ0/8Kir36tHlBSqaS7cCL8Xb+2Kn0wWf+Xfv1bgEgbPq0FQ0JITeuIq29KNv6G/IHM7pGU4FEAt0TPmaTJKP77fzckA465Qjjf+ct6mKwNTpicyFWS4TqWetEuG1NZN3wGfhIzDuCBpSsYUxtZhNru8Htnm5mVXcEtXrKqPuQbSxCSHNb6ExHE4ut1ztJHh8K9f29kQeSwjX75c6oiKB6Px5+gPmNOUkOULNkHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D+UIDoJ9BvO2/c+o4pge01AbzxMKD78JlYu61qLtFKk=; b=AeY34x7fNc3SEoZ13ysNf4/mymO5Q5WzN8yNLXbNxpWCj6qUzGG1WYcnO7C0I5oVk5YDmLY6UduGl/ScFu/KAtXx/PcbJt1CjKFYnSETYLh94Cf5SB4nigVkzkQyrBUeJm4OuL/k1iFD9OXctzIfjAYpA7/SFOWd/79ZHuQjFIuY3h6Z/umt8BBmKQoFyT7RBZFKDHrx5DU6HL4gfa0p81UtIREqhs/ZyduSlh4mIv/HtnrJBreJFkMee3/O5EH+5IV88Yvu6Tj2m/Z23KFpASvYvCkBWQb1aAEp3E2ShlKPRv3L/jheeELEGj4TYwrH97Dr18vqU6CyelsEojOEjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D+UIDoJ9BvO2/c+o4pge01AbzxMKD78JlYu61qLtFKk=; b=S+fGJwiZUTIDS9UwSq5SEXakm1H7smHBw4/G6nGyuQXiVUtiC/cDq5qGRF606FxI9vgI8zodaA53y4V0bjpQnYAmK4S8vDKrTPCtIITdzNge697Q6p8dYBJPXuHl0/uYrIqxhkt0P3BfCJl6azYG6/ocdyEwZR329aZhf3ZYSTGJCIl5lqV8b0HwWxblOycTKNXJqalXmbzhE6gtoj9TTxSjHVvCmEB2B2Kr0rihVremd8iZpNaOB4WRU1cynsMoumuj2ltxCamC1rKpPz9zzUsCrsTCBZfLqx4J8xPe2g+vDT1DzZo3qSizRyHEugWgEXkQlNElF+ZLfgDjRJu+uQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0372.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Mon, 29 Apr 2024 21:14:46 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7519.031; Mon, 29 Apr 2024 21:14:46 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 29 Apr 2024 23:13:56 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [dTqSnHD+882DujZ3JmpaitjHsQVq3DelbQuM9ai0qvI=] X-ClientProxiedBy: ZR0P278CA0199.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:6a::21) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240429211438.3274834-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0372:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e2be62c-995d-4c11-624b-08dc6891651f X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|440099019|3412199016|1710799017; X-Microsoft-Antispam-Message-Info: FZqKHegpKJJ/LPXX0fwo9vzQDzMjEJZnAlVRjgqsk+jn/T/ISzAsQoxO9lUdECPRf/HftkWCz6EwVEsQhw0R5zEL/5kBG+ivJrpd+bA5jEKk9vF2fP9RbJKNVx6ocNnBURMEbVbHkqxE0Cg1EoawIzdBMAcnsDjLZSY6JJwsszMxiy4kjMwyYyaDtrVSvv2P8H0GOgSaD24k9ju6v1KeziGqESeOULfYVuAqPV8JWgDItlteGcAaa6DD6/QJTLZuuiAgWp/XHIvEd/0nb46ciL4r7KOk2C9Svu2KEDu2dDT6EovLStUA98l03SbR/HP3sDEqYo9H0eyKFXrT8qrq0bCM7I5PnoPhkn1WmbtXIxRYZ5Jea6Po3tFP4ezk740axi59R8ZP/TZFGd0jyqtE/iKsXyAQQ28TWOuYupTVLM4i2QDB3chYphw8TPmbcFqOk0mTmFFEeu+JZJDkEjhLBMI3DFq0DVlQZqLZO3BqbkFW7dhCIGvxblnHHXZkSmMpXLXOO2HbRnXSzHewObCUAMROT5NFu+JCIKjpKhq3JZn/EMRnuuzMiZY0GoCjkGqDGLSFa7t6pvvc9SuA/CXlhyPyHgK7ZN5B9MG0pt5zTVL7tSn/s6iPaRO5xcyXiYtJ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rBu3EavRX86MTI1tOBZyvnuIy7Al3OwnNvyUali0EvBHMo8JrheBnIiYXYKQ?= =?us-ascii?Q?R3ZU2CBKU4lV6vUqywhsnUABiVLyTtCeot/1V1TDN7/j4ai9ivcG19LZoCu6?= =?us-ascii?Q?O5ZwbDMkDXZLB+3wNtu4/gBVN/SKPJ7ytkNlwwkMQ7jZzPuNfZ1WKKaCatSj?= =?us-ascii?Q?LfjiMtJDBQ2uX4ttJPEGtYJkxH7klVRU+lUYmVSsWac8W+UdQcwILJDJS0gs?= =?us-ascii?Q?f4DajM0z5YrChAD4qhWMwUBe3Dk8ONL2rdtgPvoRfgr6eZX26bJo96a8BPkL?= =?us-ascii?Q?Lxz3cfYz2SYXreXMB17ayMslZ9Fz/xARue2OKpMI60r/I3BVgkDRrhe+Roml?= =?us-ascii?Q?6jddoM/8XjOjVLktMfmwTV/OuLKVzrvNBfrX+z+JuC4QCc2lGES0L4kuBLNp?= =?us-ascii?Q?OkC2VGWx4tOjq/a16WThjwxwc96IzhDkwcW6Lsbf8gRZ4UkCD3snD/wtGobi?= =?us-ascii?Q?QHeo2EMzSzPmvxeM2ekXpNQz0TmYaZpzjLCx73PriVNOfqtdl3Aj2eC/2MCF?= =?us-ascii?Q?kXCFzbIi2vRnC/lgcPVa7ovsFNTtDKzdAy54Ptr/rsdEA83S3ctIZc+zXvOZ?= =?us-ascii?Q?SC/NoIU4Gc658dAS5veOwCTIqGmNwp2B++FzoJl7oTLQIPX4R5kPDqUunRwu?= =?us-ascii?Q?PUQUfkOM1A7BOgJRLwhHCHAgC9OG4xlVNt5fdz3HQWa0FG6ahKb14Dkp6Zn7?= =?us-ascii?Q?QYgXcMopicET8AjAEMluRpmF7u36Zc4VHOXtbiZuhp0EcKaoA6TI69GktFQa?= =?us-ascii?Q?VCGb58L6tiy1S+PkrYJTe+4tZTh80Lgk4ffo6BkscFs8/h2i1w3/i6QDwbmV?= =?us-ascii?Q?gYoCA7KgbCRyDZFYuWA5k46eNUb5+bhUArVa9Whzblic7fRa0VIQ3VJX1sIm?= =?us-ascii?Q?PuO5nAZ8a8cBkkOcA+kTOfgisU6ivYtKLOQiAOezNU1CHiGJAcV4/T6U7ZZN?= =?us-ascii?Q?v6JkkEJvtpB3deBibuTqdxnQ94Rth+Zq2J0BQCsi91G1IAq0tlYWeVgk0p2c?= =?us-ascii?Q?rreHDIyFhnmeJ3K3zypIydvoIhaxTbU6/YsHxr2Qa6Vq0s4acZFzz2zaMMqI?= =?us-ascii?Q?elssYhdL31KddoP0J8TcfHdyfwZ2JXkkRCPgLPDIi5LSw8TXIucEHHiDjkxF?= =?us-ascii?Q?/KbBrxSOY4r7dsQDnWWN03+rChrYZVDUMLTC8lnAXfaGPm6yq61NNvPl8ZLy?= =?us-ascii?Q?k0ZTr7t6S2Md3p0u+yHJSdv+bAxRojXYbmof33BpRQ1xBEqy7g2ADPnBWoCg?= =?us-ascii?Q?/Rw3sXfCiFCP3CWIJrhen/yrH9CFZVzjXbxz2cBgPQ=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e2be62c-995d-4c11-624b-08dc6891651f X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 21:14:46.0614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0372 Subject: [FFmpeg-devel] [PATCH 15/57] avcodec/mpegpicture: Always reset motion val buffer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Codecs call ff_find_unused_picture() to get the index of an unused picture; said picture may have buffers left from using it previously (these buffers are intentionally not unreferenced so that it might be possible to reuse them; this is mpegvideo's version of a bufferpool). They should not make any assumptions about which picture they get. Yet somehow this is not true when decoding OBMC: Returning random empty pictures (instead of the first one) leads to nondeterministic results; similarly, explicitly rezeroing the buffer before handing it over to the codec changes the outcome of the h263-obmc tests, but it makes it independent of the returned pictures. Therefore this commit does so. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c index 88b4d5dec1..06c82880a8 100644 --- a/libavcodec/mpegpicture.c +++ b/libavcodec/mpegpicture.c @@ -245,6 +245,10 @@ int ff_alloc_picture(AVCodecContext *avctx, Picture *pic, MotionEstContext *me, for (i = 0; i < 2; i++) { pic->motion_val[i] = (int16_t (*)[2])pic->motion_val_buf[i]->data + 4; pic->ref_index[i] = pic->ref_index_buf[i]->data; + /* FIXME: The output of H.263 with OBMC depends upon + * the earlier content of the buffer; therefore we + * reset it here. */ + memset(pic->motion_val_buf[i]->data, 0, pic->motion_val_buf[i]->size); } } -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".