From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4105B49C67 for ; Tue, 5 Mar 2024 17:58:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 19ECA68D027; Tue, 5 Mar 2024 19:58:35 +0200 (EET) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2010.outbound.protection.outlook.com [40.92.58.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6B4CF68C22A for ; Tue, 5 Mar 2024 19:58:28 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PnwFC5rSbGE1MCkyjZbOphfbq4dVlRCxZZQdMVaiwzF88sgHoZcTPT7vT6Pvb8er2u6DyhnQO70jWFU6ul279OZIHj/IOErTiueYxJyASZsu+TQLrvVuaiyBMng1wIumXQuesd5r4HlSE+TKviSJjqccWNQdiOkk1fy5Kbn8EGOFEmN5Fv3v4GnAR41NCtAy446VNFHMUj/+4hibul7LtRFGS3Ys0kRw/tcURlKt8ja0l6k5Rzd5SbJ4EpOroyl2TQq+9vHiiplGxiS28YIV1ar+iX4YZM7wYQgUPhAVzaEIL0JgCfYqJDgHw0HcYnG8xpAB9PF25DPegVzDunEzzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3UQWr0IvrJOioZYtsxsdwprUVahfsdDEj4GgzTzGrQI=; b=e4NspicjhUONSvyEj8YJizeXmEQmyC1qbXgDMtBgYovE1iYKTyP1aWVk2eMh1mtz+gsFVvpLFXshZgWr76Ru6FCPb4UPcjy2n7H+iUqmp/HS3ATax6jBS8Ai7szDP3yIz8/5M8ssuxyWGudUbydPoUxq9bvrQKmbYttF4xQPdYopTMKBYk51AMZvJKMkowqT5emZ7gJFqp+XVMC+qZyYi67hzIIXqGCvJX+dM7JkkMP0G4+3YI0/yDGu3iMRGntKC33RZqANol6FR09IdZh6L6EAbXX6XZasZkCfdofRekcSnvO9JrlKWq6tvh2MglYzayfR+Klm/zCcKFhwmw8MwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3UQWr0IvrJOioZYtsxsdwprUVahfsdDEj4GgzTzGrQI=; b=DkUBnBhxlvOa7elkEJdqSQITSPxNcfNoWVwqIN7AK6xXOeFTuy8x3hb2megKu17g0RX9DNCQlkxdNYGA4xywkwuz8an3q5K/HcTEgEbOZQqoyVIO7hR/WaEzyQhEpUiRXkw8HrBFXLpYMHtQ4LoJoc5udXFpQ1117osgUZxwAZbS9qm8TrlLod6KS30t+2GTr/O8e7eLjdSran5+uL5IG8sr6g6QmhvhQ2CDoNbR6g8jv9dv59j56N7CiY5dqGVGutsbvvhQOOy8MFMK6WQT0syK4xOsUmzjrlTpV+PFAU0vUmTnbb8FiqqU2uH/kzJ2HM8iibVx8vzbNcuCYZfJOw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0279.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:32a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Tue, 5 Mar 2024 17:58:26 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7316.023; Tue, 5 Mar 2024 17:58:26 +0000 Message-ID: Date: Tue, 5 Mar 2024 18:58:24 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [nEJdnpKTK/kS4SqpP+KiQrVfmA7XD1wFC2sdz9W7HjI=] X-ClientProxiedBy: ZR0P278CA0128.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::7) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <9697b56e-3528-4f87-ac77-63affbaf291a@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0279:EE_ X-MS-Office365-Filtering-Correlation-Id: 60269f3e-9cd8-43e6-4c80-08dc3d3ddb76 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +bH0H1IfzBsxMk3legX89mZn0fH+w/UbX6iJMSvjbt+njqhtvt0qkudSBjro62uPUKHTgGFhcymSCixu9eB7nrj86oTt1zc6UjKwRGUO87yB5/2VCWsXDdjyvaAwReDayuGYFOW3S42kkylWWZhqFgMsmqGNH5JlFG7qBeGEQZ3TZmQadL7E8/0WSQZbOiTw8h5L+tmjdpg2jUOcjstV/KBTtACqLZ4IlvyKU0LwCHu9HsLwjCiku50TJye6YWZ+bXiNop3HLAkUF8u67ZxcRbj6JgVJ31y7VK3rgYoBbQ2ld85wfKuZNhtftBzrj6pYAmqA6s1CflhoaKy7jQ8prLJfQJ5pe8yVgS6tT0zgLjsOF602Uxiy9N8y9rE5pfqDgphdpKjVwta8HaxE4UKpvDgpct+uDLh5+mevt6zCdtgYxOlmZO3JErnWLHoIMkyVtDHsiXWblLb5i5BHZNCJ11CcpnlMuMjlhKfNNwP3lmHO+gZX0WI8cbXk5CRFzPZwE0qcSuchqlExxGbnb9n7End1qIKitZ4KbnShIid60S3BazxVhsH4960Tv45DF5L4 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1I3TGJXNWY1WE5NazZRdVRSQzNPSGgvcHZJcGJUQkFpQXFhMFh2QUlMdUZw?= =?utf-8?B?RTRHSFRzTmNJc2J3WmZzZndZWnNlTlNxalZWQ1Q3S0N3ZGVZMjJ0RXFJYnBC?= =?utf-8?B?RjhGSWNhR3NjZXdpRmQ4Tk1tdWVPUDl0WDA5YXdDZWs5ei93Q2d0TjlFSFVR?= =?utf-8?B?Wm5jbzJCdU9kU2dpdDhkOStVTGlPa1EvSiswNGF2MlRaM3ozNzVLNHFDQ1Rv?= =?utf-8?B?eGtpRFFLL3hEaE5BYWhja2dPWFk1OUNidzRmUFdRWE9pRWgwWSsyYlBVb1ps?= =?utf-8?B?c01xRWJRVUtMQmV5WE15VmMxQ0x2Zk9rUkM3a2tnMThWRHhpbWxHKzdqS1Jm?= =?utf-8?B?WHZ1anVJVVdjVW5WMHZSRU1GaGpWMzdEWmRrVWhHMndzcEtLeEwvbHY2QWox?= =?utf-8?B?a0t2UmI4TU1JdXUrZjJJQ01yMzRGc2VqcmFqbGdLelU0M2VnaUZnN1JVYXE2?= =?utf-8?B?MjZQVkgrQ2JIOGppbmJvMlYrTmRCRk9PUTd2MTg1bjVvRWcxK2FVZEhSVjBz?= =?utf-8?B?NkdIMnBYeVJFbnA3cXc2WUplU3d6NmJHYzlZUGVvR3VrQWt3Y3czUFpiRUtu?= =?utf-8?B?eVVhYjBvZmRMV2pJc2tCQlNBRTVVK0p1WXhNRE1WaWRiTzlwclNtcTZpSDFs?= =?utf-8?B?UUptWkhXakRKbjFKcEVjMjVUWjM3UnYzV1BTSGJpTWMzdUE5Mmx5MWt4M0Zj?= =?utf-8?B?TUtaMTdyNk4yZkNqYXBwQ3dRZnhTRklkWStyMzd2MmlKTjZxWTNEdXg3R0c4?= =?utf-8?B?dzZkMmlYSGZDUWMxWXpVZHVGZXk4WFhabUtKSXBPYURpYzJtVVlwVDRQUTJu?= =?utf-8?B?MHhPQjFFaGlscmVtSmFUcU1RaHplTHJaS0treWVTd29TcDlhQXBkY05YanR1?= =?utf-8?B?U0hsV28vblhQT0hCT01kcll0Nko5V1VQa1BqblFaVUMxYjg5NHlpQnNCWnUx?= =?utf-8?B?NnU1b3ZjSmQydUJJdkV5K0RKTzZFamhzaysxL2ZPVnRUSDFyZ25VWm55UTNS?= =?utf-8?B?Qklxc01OaVppWDdZR2pOakNtYk4wTlBvbm1RZUdFRWxad2xEOVVseHJISXFT?= =?utf-8?B?bTRub3pGS3lycStBdVlGcm1NdmdPbmVTRGhWaVBkRHNDaFdNSE0vOVoza29U?= =?utf-8?B?THg1aUpoWmROcDNVMDk4Y3lEOUZabWZYRUk5Zjg2YVVzajdyMzkwRTJGcUpK?= =?utf-8?B?QzY3dldEeW91NlhsZnB6MWJrZ2xGTXM0Ukk3MHYvNmJsYnBYUTZqbmg0eE4w?= =?utf-8?B?ZUxKdHVoYVhtN3hQczNZTHp4YmtmazIxZjIyc2JKWVpHclZGSGNBdDUzR1Vp?= =?utf-8?B?OWJ0dEdwYjhOTHM0SGlXZjByd2NiR2p6OHA1ZEdWUjVXRFh3bVJqcEFsQ01Z?= =?utf-8?B?YU1wRGJFbHFOekNEZEZZTS9WTWFRdWQ0NUsvYWFERHJJVjFWY1pLK0h4alQy?= =?utf-8?B?MTk0UkUvbzJ4NlNPRVZISlBvVE9wQVM5K1hiNGhBQzMrdXVjNEJPWXRySHds?= =?utf-8?B?dXNiaDFRQzlkSndBeVpRakFuNXF1Si9SK21tdjBXLzVGOTd2SktWbmQwZ01C?= =?utf-8?B?VXRyeUJ2aFlNMGlnVnNNVDQrbThlZ0hYZENnRWNkaXMwZ1BzWFZOaVlZNWdy?= =?utf-8?B?blVMRlFqN3JHanlKVWYwalBiYkdZVFhMWE15Z1FLdVZnSU1FSXN6L3l5STkz?= =?utf-8?B?b2FpSTB4U2R4dW5YZXlRZU53SExwaGhrWjNMeUJRYVBJL2JHY3JXdjR3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60269f3e-9cd8-43e6-4c80-08dc3d3ddb76 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 17:58:26.5475 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0279 Subject: Re: [FFmpeg-devel] [RFC]x264 avcc and related issue X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Zhao Zhili: > There are multiple encoders which can output bitstream in avcc/hvcc format, > e.g, x264, x265 and videotoolbox. This can improve performance depends on > container format (no more ff_avc_parse_nal_units_buf). > > The problem is these encoders output parameter sets directly, not contained > in a complete AVC/HEVC configuration box. But muxers only expect > extradata in > annexb format, or a complete AVC/HEVC configuration box, not support such > length+sps+length+pps format. The following command will output a broken > file: > > ./ffmpeg -i input.mp4 -an -c:v libx264 -x264-params annexb=0 broken.mp4 > > I want to fix this issue and improve the performance at the same time. > > There are multiple options that I don't know how to make a choice. > > 1. At the muxer level? It's easy and ugly. And there are corner case > like 00 00 01 xx can be start code of annexb and size of avcc at the > same time. > > 2. A new bsf? It looks less useful outside of libavcodec. And encoder > can't enable a bsf automatically. > > 3. A specific helper like h26x_vcc.h? Can it be more general? > > Any more suggestions? > If we support a new packetization (even if it only affects extradata), we would need to support it everywhere -- decoders and muxers, too. I don't see an advantage or a need for a new packetization, as AFAIK all containers with ISOBMFF packetization also use the ISOMBFF configuration box. So I am against 1. and 2. Implementing this inside lavc seems like the best approach; I don't know whether a common helper for this will be useful: While these lists certainly have a common pattern, there are subtle changes between them which will probably make a common helper unsuitable. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".