From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9B46D44167 for ; Mon, 29 Aug 2022 15:29:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BEBF568BADB; Mon, 29 Aug 2022 18:29:12 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2030.outbound.protection.outlook.com [40.92.91.30]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 98D2668B898 for ; Mon, 29 Aug 2022 18:29:06 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c1q9+q7JS1zZ5C36vQqHRdwvL7FjifHPDqR/xbhl+TXFZfIrwwSgN/fsjwe6h/Vg2LVH10osGaj3g5c+U6wsBGCawOHvAoTWZ/5YI9+W9njkB3XdlIOmrfZIvzfJWHLNWKjo3VdOkr8MBePs1RPzl3DkmppefAvTUCz2wrd1zF03r3HiaAcw4M+WHIwZeufFtyiPyjvNUYhK5p+0ysL1wEpe5INHgfqYSJ/an8h0an2SzOX2h6IU9cyKtYw+whe1olVbIxU3+aNcJF6glQmeJUye5KK0c8IG2RIwZXjPRUhbNHvt62hAs+xK0xtYHaCLnqnEK3q5g7dJMSG3+fYEDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPRmN0ZCxDyhQhRJMV8sqixDFnmedHJoqwrNgqJ5JBw=; b=cGnaGh6z7iyMkx/Gkz9yDe4EoAmnA2OaJYC+n9pwEw/qYltc0+O2bhEX7VU1k/yYztZujfMaZQzzIJR90pD5xum6o/cIck79C4fKKAIlvBMVrAXGyFx9A+gZpR6lcO5T+/JHzUWUUIFjo6VpoGTqWOlVrTuQszfPX+yUyNJK7PHy/C3LNlAp4GQDHsox1XkP6vIyl+a/3at0ZHoCYakG/OK0tDopJSmOpSLuPhqhFANSr4tdqTNhOgok6ihsBnnmZKh7Z3rr06hjneCPvRg9DmIpUUo5QPFrONsFkC/v0la/mkSm6babIJ5KbMz1dHoP5O7nNWPcIDwWFkuQooWNlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tPRmN0ZCxDyhQhRJMV8sqixDFnmedHJoqwrNgqJ5JBw=; b=q82FWQFoOWbQoEYzfbdz81w5vygCo/9LIxqTgdxty71A7XVE2+o37Vj3WUCij3DugGXxXGArqctmdRhPPEXKpVWtHbebFKDHu/1GcQm/fJHY3ezv1IqIs07FTGknhAcg/TGce2DZhZvxylomGH4YJFdP2zYlu2y7AMCbBHs163/ntpr7LO7jskoNnFR81C8i+ytS5UptDAwEhoPQ0f+Y0oLiY1R7zA1oymh9VCw2wvd6cGruUcHMfE0qfPruoVAClGrMzJruB6cPq9SwCLc+Zkk0kW77lSrd7aUYgy+tXp4Lx+cfVKjAJ2dSR0Q/+9HyRRu0LsALep642qyVm2yDSw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0089.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:36c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16; Mon, 29 Aug 2022 15:29:05 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::7d2a:d9d8:f384:4cee]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::7d2a:d9d8:f384:4cee%9]) with mapi id 15.20.5566.021; Mon, 29 Aug 2022 15:29:04 +0000 Message-ID: Date: Mon, 29 Aug 2022 17:29:03 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220828172545.8185-1-michael@niedermayer.cc> From: Andreas Rheinhardt In-Reply-To: <20220828172545.8185-1-michael@niedermayer.cc> X-TMN: [uLZYjouConaI2i3XlL4onDSzQNbQ1ioN] X-ClientProxiedBy: ZR0P278CA0058.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::9) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <1a0351d7-ddfd-3b90-835e-1a5e521665ce@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 638fe4ba-e3cb-4cc0-5eec-08da89d33509 X-MS-TrafficTypeDiagnostic: AM8P250MB0089:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QVrS/oOvSGrSr6/eM0PJUwnOKvhJxtXc/NAQBKBkVB2k8CO/zF5i/9dT1KROzLHRxooCHwzNFIN6uNH+0vUynbjHIwFQwHq+wReTw16Vf7vipj0Yv4LsEYHg2Z9d1qF3C8GXsJ2AbmOm+brLLlRguKFKfP/Dev991/PFlsBZkxp7gfhT+wEZ6/PnGjHkpZgYVPS3jviwfQOuEr9Mz2BJj5NM2wThASMSBQhrGb3K4Tz7DN8YaUu/SjO5Guhy/KLdLBGRRvEgWifCOFRjuM+JdrQiqkXpNZz3SHb77n52fyWfTtlwGzDJb/xSQFWUI+TDQGsjv1jrY6rNWZOxud9eKnfv33bmADQK+pogs+qkDKyHTR0WuqgdVFl9xpK1EfhZichoZZL24SP+0LcnkGSxv23z+2IDaKr7cbh5cEcl8i+jIBFKtwGESe4eIg2vjqMt3BPqcOUu7OdcpgIpThDUczZFXz/kXH8wb9rXx7hzh6qbS98YyPa0PLzofN5BxXr4OOYie8QUyJeyr+mCVd+0e/Y9tpg6KYh78gWm7j426928kEVcjVWLsMsOfydpaSGU7q6GzOj3s4QchG+slYBa59QSdgujGvo7M5IrGD5AvhbwgvHOCs+zXkrxH0QwLj0h+BA3QXcwP6BQXankT1wEUCz0MhSrRyOIRcwn2mW+mkWXdzxt8TcqOiwwji//bIQO X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXJFcnJ2VXlRNmNKY1hvbGxrbGsrK0syMForcGoyZ0Vld3lvREZveFIwL2Za?= =?utf-8?B?bHo3TEl2VE9rSnVvSW1PWEhPNGNsTHoyVWpwNWp6V0lFVXU3azNMZm1MQXZz?= =?utf-8?B?VXUrMXI4c0NGSk5hSWh2cXdzeFl4YXN5TVhNNEJmVFFoSHFDeDZSdVQ5WDNp?= =?utf-8?B?U1VqS0V2QnExVVErWkd2MWdtRlhsZE5BdmxvZDI1aHF2aS9INkxQbnk1b2tt?= =?utf-8?B?VlVtWUZvRUpwcE9tRnRxMTRRNkdUN3g5eDdCSkhEb016dVl3dGtFR0lSdC9y?= =?utf-8?B?OTFUWXlRVlI3RkNrZnlUUXNIanZxODhpeHcwa3JWOVlvZkhmc1VPYzQyckUz?= =?utf-8?B?WERxUGluY01DSVJNbDFFVmhJdkFxaG9VRmgwcDE2YjdtQVc0OUYvQXB5QkNG?= =?utf-8?B?alY5RXR3QWhkYnVxc1dtZDRnN0RPeU44TWQzcFRoRmtJVHlvN1RwQm5PRUFm?= =?utf-8?B?czZJZVVBS3B3YSsrZ3c3M2tsTE9yVXpKUjQ1eVFiQzRZRGVGWUFsM2VJZmxw?= =?utf-8?B?MnRQT0pYRHY3d2hwN1RtN1dDNWJMVGVVdFlQWEsxK24xK0NNSjVlVVE2bC9q?= =?utf-8?B?UmNhWkRVTnRraE42N21MamlNVlpkVGQrQmV4emxaUVRHeHgrWm9hQUViSjRs?= =?utf-8?B?eFhkTnJRMXc5dWVaNHZQMlBJN2wwK3Q2eHBOVFN0NFIvc0pPZFY0VnhpalQ4?= =?utf-8?B?SVkwQy95R1lJTlpuZUJuV2dNV3c3UWdiREJlaGR6RkpQaU84cVBsejZVVG8r?= =?utf-8?B?T3ZUZVI0ZVh5U3k1aDBHeG1DdjdhVUtpdEF0ZnNrTkpvZFhZZzAvVG9Vb0Q3?= =?utf-8?B?L3lub2hXY0M3NzRUU3lnTTVFZmU3ZmJOWEdNNzQ0cUhRa25VOW5UM094MWVS?= =?utf-8?B?U2F5Sk5aUnVaNkV1TkVTc0dJTmF0T3hRbWxoNDZJSjZsNUpJbkErY0ZNZWUx?= =?utf-8?B?S2xuQWlYYzJJOWhkSUsvbWVBNUpIRFdHbjNienk4YkxuNlJ6eFVRRnhoOWNo?= =?utf-8?B?MUdhNk5mUklLMXVkcnJrZTZKNDJIcUhreVFhWEVCOEtVWnBlZW1JMXBXSEJt?= =?utf-8?B?aGpFZEtWTE1nR01NM3R0T3h6UzE4ejVJVCs3WnBLcFc2bTZxZktDN09tamF3?= =?utf-8?B?dHFNNHdwNUlMYlZvVXVvbjR2U1BGSmhqRStyUG1Pdm9QMWpiNkdielRhc2NM?= =?utf-8?B?ZWhDdXFvTVJueFdyRjJsVlJDaDJRcEUxc2orYmxRUmJKQ0ZKSzdpWGlFOHBK?= =?utf-8?B?dURIQk5mZ2xnak5FNGFVVmpRS3JWWTFiUTJ1NTUrd0RvRkthZFhtdERZbHBa?= =?utf-8?B?cE1KbjIrSHZONXRVeU14bHZ5SlFVdUxRNHhpZVB5dFJ5NU9zVENYQ1NLUEY5?= =?utf-8?B?UURIWStTQ3oybGtnYUNUeTY1ZXFQdUJ0MUdyWHdwdDZXV3htUUFHN1FZTnBU?= =?utf-8?B?UUJvcFVNbGlWeGh1M3dGMS9EbitZSGN6M1hSSEVNSW9qeUFBT2FpbGRXSXZz?= =?utf-8?B?NkJreC8yQWlWWmZ3aTNSaS9KNWdmVCsxTWI1cUl5TzF0ZDg1UDFWd1l0N1d4?= =?utf-8?B?WDV0M3o2L1NpejU3UC9vbzJwMFdTMkVaUGhSa2hpakJTRy9SUEVqWVMzZW1p?= =?utf-8?B?eDhYZmFwTnN3N2diMk4xNk5ReEdWY0VzTi9PNzJFOE5rRHdMWFdlOWROTVZa?= =?utf-8?B?VkEwMEZPdW91QTFpR1ROaEFGRFk5UGJEM1dKQ3JwaSt5S3NlWHdvbEJMb29Y?= =?utf-8?Q?i8Y9HwlPrPeZNnMMM8=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 638fe4ba-e3cb-4cc0-5eec-08da89d33509 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 15:29:04.9132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0089 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vpx_rac: Adjust vpx_rac_is_end) threshold X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > A threshold of 180 is needed and sufficient for the sample, twice this is used to > cover potentially worse samples > > fate/vp5 changes as the sample file is truncated and the damaged part is handled > differently > > Fixes: ticket #9754 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/vpx_rac.h | 2 +- > tests/ref/fate/vp5 | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vpx_rac.h b/libavcodec/vpx_rac.h > index b158cc0754..2f5486f501 100644 > --- a/libavcodec/vpx_rac.h > +++ b/libavcodec/vpx_rac.h > @@ -52,7 +52,7 @@ static av_always_inline int vpx_rac_is_end(VPXRangeCoder *c) > { > if (c->end <= c->buffer && c->bits >= 0) > c->end_reached ++; > - return c->end_reached > 10; > + return c->end_reached > 360; Is the file from #9754 defective? Or is it our decoder that is overcautious? Your commit message sounds as if it were the latter. Is it guaranteed that is now enough for all spec-compliant samples? Does the answer depend upon the codec? (vpx_rac_is_end() is shared between several VPx codecs.); I presume you can't give any guarantees. > } > > static av_always_inline unsigned int vpx_rac_renorm(VPXRangeCoder *c) > diff --git a/tests/ref/fate/vp5 b/tests/ref/fate/vp5 > index 09ebe62b25..2116fb9b81 100644 > --- a/tests/ref/fate/vp5 > +++ b/tests/ref/fate/vp5 > @@ -249,4 +249,4 @@ > 0, 243, 243, 1, 233472, 0x6f530ac6 > 0, 244, 244, 1, 233472, 0x94f7466c > 0, 245, 245, 1, 233472, 0xa8c1d365 > -0, 246, 246, 1, 233472, 0x4f3ef38c > +0, 246, 246, 1, 233472, 0xedcff050 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".