From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D5D1748D1C for ; Mon, 19 May 2025 16:46:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 070F568D825; Mon, 19 May 2025 19:46:17 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2040.outbound.protection.outlook.com [40.92.91.40]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 776C068D321 for ; Mon, 19 May 2025 19:46:10 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c5xNjX/Ifa6u7h2ZT2jBCJWaVPHg/ZMRGeIxtPebt7+i4t4deNs/Riad5rFmwYBatzDY8u8d1aY7StZ+QyQY63RRzovAXEsDB0Cge5Oob80bta2R73rZOvZT3fOmANGd9et2oa/ZXXan561uG+q52iT8sfqyYREcc56evDcJRtotuxcvi033oHwzJcqbPFTnzINeSr3QSq5f3FEoc9b4vFsQXwn2pOAD5fyWYjisz/Zm30/ndQr1siz828lZdnhT46rfirSVjsAjZx9kQDdos40eApdH1krefEed0fAsW8rW7txXkiJK96TP/c/ihMvoQdruDp5pvoIG+YgIgZQxow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TVj1rNeOiRQh3d9FIG8SalQFrd5YiUh4hI3jDtt2Fak=; b=GoXGStZ2dj7MW0Qz1VSILsknulHWblOk+rYkVRi8Tyr/noc7WKN2NBtCIy1Jlx5bxBKJTn61Z09zM7qx5YrGlEBi0akqQqqgz+PF3kCa8owJqbv71Q92SqxS2RtTQp2+vLxZJLQ0O2/JFvVVBXs86EP39+fF62byRRwYwtOxCJGo0+oEYR28z+WK0MjrADSojyyNHUZZYqXt3kIYMBbZvhFX9S05I6FkQj2NDIyTRd/+k000rz77J8fcPyPR44Jkzc9d63HjI/sU1VaD5uYfoZnK7wZyrQZV+OF2ObzOBeTdNkL27EeHxshaQHml7e38VFOFNyTu+BLTPLeb6BmVEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TVj1rNeOiRQh3d9FIG8SalQFrd5YiUh4hI3jDtt2Fak=; b=Y+fP3M4WJcaQyCgglfKWUK3nSUrPYlmm08bF3ONPP6zeL4I+re8J+XBxwr2jyLF1vDFLKRBFbhImiYwSJ5YDgXD/NAiHpCJGZ4YSMDnfrNtOZkMX9S6gP2fY7m6ay06h9Dgl8GFJYJq/63nXKM5yeB7x6eKXb8FdvS84UnScuSHa/ekJaBSQDqEPQYqotHclqFFIT+L2xg2+1loRL5Iwx4f1+/0tDSCrrllYdSII5Lnn/5duXL7ovJbDJuala4q0lBa/I3ydGvDSDKK5WIw45xnlnVQgwXoAuXh/A2Gm+bzJPt6fo8VuUprtFmGwqtIYST7FV+mpjLgRdF5io2zYVw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0029.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:358::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.32; Mon, 19 May 2025 16:46:08 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.8722.027; Mon, 19 May 2025 16:46:08 +0000 Message-ID: Date: Mon, 19 May 2025 18:46:07 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250517204907.482987-1-47210458+raphaelthegreat@users.noreply.github.com> <20250517204907.482987-3-47210458+raphaelthegreat@users.noreply.github.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250517204907.482987-3-47210458+raphaelthegreat@users.noreply.github.com> X-ClientProxiedBy: FR4P281CA0357.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f4::18) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0029:EE_ X-MS-Office365-Filtering-Correlation-Id: 62c04b6c-3eca-43a0-3e9f-08dd96f4a76a X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmoaApi1aWVt9ILKZbGoHsd63OHC5D+/grCeR19u1smAkd8ec/2sNzoWHSP27zCE6eaY/bAzIZWgjf7TcrP1xS7bMXl5EkOCiZ8jIcBcgteV2fqAUo8w4PPv2iuI0uCNrviNTxB7W6gcC9kFy/lLynZdK5FQU4AXLSavIk339w3dTXKbn9Pm5kQ/LwrmImp7m3MsiALCVM8vqAQTTpKUr4SIFhGfRSZp9CcuQHjeE3C+O5d9PjHEv6P/gfJsSJMTQT2uaLoMuIEDdBOQNmaRgp3EhqepTCLpoGLwJgGV7EdVmFkjZ52/gzOUZv3by/V92nHzG/2qy/xGubTOUZMenJaao8Xi688Xvej4ECqgMOHLO9JGUq7pNKS6sLwIpgpvCLASNcqW8YK+n0TLtwz5SAon8sGfI+/mxCljJgw+4E1/oXqhT+nxaJG42tVi31HRAMe8RInQCjLE4BCnnrGD5YFphBDBqaSgJ+NJlkdggof080KAolM29YSgKN/if0mhteXr6rV0M2Oogxo3hU3u4EaiVNDgpNe80xk/+kcTRBInQV/PFdKMvxuqTGtHIhWoZ506CCQ9itcRa/4dg7PhYWaoEuApj1jXFXRsyFextnxDnuYYTJa8LdUnm/sGIuAv3wUC/FET0YKUtyM9vdvXCCQiDC3yVQzmXt7AOtAOaf9mMCs/dayyC+eVOx8sVRYmzb0iXm51ciGVlDjGyCb1r/ll+sXBeKIg2/+5NpoN2ErsfuatY7RgDn+7S9I9MGW3x+g= X-Microsoft-Antispam: BCL:0; ARA:14566002|6090799003|8060799009|5072599009|15080799009|461199028|41001999006|7092599006|19110799006|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YmNIZTY2dFZpV3dBbDJsVC9yWGtyTXpPYXhaNEQrRGtGekUyRWNjNHdTUzAx?= =?utf-8?B?NTdHWm8wMVV4M1VvT0xpY2oxbTE3T0tEY2ZpaVpMZ25WUzRRWlhxRDVPV1U4?= =?utf-8?B?M1g5UnAvYWQrbmhwbWJBMDQxRWxmMHg2VnFiZEtEM1I3RlFuY28xVTRGS290?= =?utf-8?B?QTMvcis1M0NjUUJzSlpXT1o2QnhpWHJSN0MwOU5wWExyVzR0eDVDODI4cWZv?= =?utf-8?B?eW92aDRnU0N0L1c5aUh3c29xNFBJZFdNQis4K0FoUGFFZnhuaVVHU1dmZlFu?= =?utf-8?B?K3ZNZ3JrOWNGWVZpV0ZhSVltbGZNSUZyVkJOSU5tMHpmR25ZWFJFUEd3SWdq?= =?utf-8?B?d0VuaS9tQmt0UzBvVm96ZzNQWk9GRkd0RDA5WWNNenRpQUV6MG9sTTN6RVFr?= =?utf-8?B?dzRsVzFBaURIcG11L3VUS1ZSeUU2VjdxalNENWVPUXNqRGk0Rkc0eTl5RFBj?= =?utf-8?B?ZU0rU1dDQXJwZUVDU1hPTWVoc2swTG8vSmNTM3E0dmd4Qk5Wd2lhU0lJUGRD?= =?utf-8?B?cXl6U1hZaVBDT2tjZGw2NVJrUkcwMWx1d0QxZytnR010TFQzS21mbnk1ZG5q?= =?utf-8?B?VHI3OUNJMkhKVkNnTUkyZS9XbmRla0tOV1N6a3BNMjNaMHp3UE55dzRDUzB4?= =?utf-8?B?dFdPVmFmMlVWcVQwVDdNODJ4OGorUGNtZG9aZkhMY205RVp0Lytlc3R3Q2hp?= =?utf-8?B?YXhhSytHTDd2MHo4di9sL1NhTllRUWNnWkROSk55RWtma1RQMEFLeCtRRzlk?= =?utf-8?B?YWVwdXFqanJ3bkxpV1l4VXR4NmtOZEQ0NWw2clJIeXJSWS9Qb3N4eGljYmUv?= =?utf-8?B?bG9UYmJDZ2dIcW5jWHAvTTlQRXFJVnlpeEEzRy9VVnF1TENuUmV5UVQ1alVs?= =?utf-8?B?NHRYbU5YWkZhN3NERVlDVXREU2Y1TDI5bjlSdW9KeWw4U21PM1UrQ3Zibjhs?= =?utf-8?B?NVhZWlYvcGdkZk1IMlVMcmRHVUJ2d0pYUS9ubEQzRmlkc3ZRVmZXNUE4YWVY?= =?utf-8?B?TXpVcTVvWHEvR3JIMEVxbWw4bWV0TjRTcFFIaFJWYmYxV29XTnIwUXMwN2tw?= =?utf-8?B?TXYzU245UGNMQThJVXF1dWt1TFlJbmRkUSt1YWo3ZEtSUjcwcHE2NFdJMU84?= =?utf-8?B?b3QrdC83bUFQY3FzQzVUeHM3S3NTc3FZeGxVSkF3bEdMQThJZS80NFgzVGx3?= =?utf-8?B?OHRTajRmcHRTYjdDZmljY3ByUzFWUFFpNGo0SS92emg3US9SR1p4emcvUzA0?= =?utf-8?B?VlY4WXMxS0t6Yk9uaXg1N2lLcVpVN1FSY2VJSHB0V0h1bC90WkQrV3ErVnFj?= =?utf-8?B?Z2QwY0diYmI0b2t4WDVzQVdJRGdrMUdLa1dLUUZnZFVab2FMNXBZRVh3amls?= =?utf-8?B?Qmtxd2owNG1zcE0wa1VYUVFyVUdBQnRyd2d1TTUyRlc2ZldRQm1WTUhnOWsx?= =?utf-8?B?RXZ6bGhJMktVaFQrSGlxNEVrck42QTJNUWhkOUFSZnZMakJ1K0FCMUtSMDF1?= =?utf-8?B?OW5DL1ZZcGgzbGlydkRtc20ydFl0OXRWa05YWTRJNDJuTUdUTGZVYkNLa0lI?= =?utf-8?Q?K7yjyOjCho4m2uV5a/G4l7gsg=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWhLbVdSTHNiVmFiTlFBZ0VxU1k4SjVYc2w2ajVNOFNJM3FTY01ubHBSZUpw?= =?utf-8?B?WExNWER2QUlHdXJPZlRQdGtCa01UYklXUm1lRHA5WGt4R2xBTWFUWTNYUGJO?= =?utf-8?B?aHdRcHFBd0piOFYzRWI3N0FBWGRFYjd1MGIvSUV6SkgycURLaVJKeVplSmF0?= =?utf-8?B?QytzeVJObDBFSlpMVk1XMS9HajY0SmRpMjI0b3RhSExDS2dsZTBrSVN6aFJi?= =?utf-8?B?b3JmVzBvZGtLV05PRjRUdHpZK0UvWWFXSjhSd2xHTWNzZ2FQdlBHYTVBak80?= =?utf-8?B?bHdLSWo3bEp6S3VWSG83SXRoWWdPaWQ0YnFqa3VoTW40TE9iUUlFelp6Lzhi?= =?utf-8?B?NldyZHlETGpFZU96K3dzMTZGalpYaGwyUlIzNFJ4SzIreUoxeUNBYmUwZDJB?= =?utf-8?B?TSsvbmdGdWN1dXltaWIraGFUdTFISjhERjFaSWZXRmFQRlZBbEVpeU1tb0pR?= =?utf-8?B?RlVrNXM5TmFtKzdPWktmM1hWb3BhT2ROVTJKSHRBUTZ6MHl4Z2wyemJLRFZw?= =?utf-8?B?MEFUNUZ1K0hVNjdTdkIyZ1BUQ000WjdUbDBYOVhEUmdKTE8wWnhYUXNQN2k5?= =?utf-8?B?UjFFdzI5d1FwTVp3LzAwZk85U1ZqTUppbmFBOFE5dm1VZXZnNm85RVRoZ1hp?= =?utf-8?B?VUdQUUpxMFNlN2NYWGtSWEloMWJObnhJSEtMeW0vV2REZGh4U0p0TlVzY1Ju?= =?utf-8?B?SzZ3eVdpbXY4WkZYei8vZmovOHluejZLdnhURU9xRkJ5TmtqNU85Znk2WkRD?= =?utf-8?B?Vkh1QUNFT1JGYzQrT3hRWFJSRWhaeVMxOWhsUWh4K2FDUSs1RUtxUWp5ZXpV?= =?utf-8?B?QzJKeEtsM1BUTTdPTlkzYXNEWUM1aDZQS0oyQzJlU2k0SVRJZ3JVazlKNFhu?= =?utf-8?B?L2llRUYrRFhhSjhJQ1hqSklFRm53WnM3VlM1ckhuUlZLeHlKUTIxcjUvdmJR?= =?utf-8?B?eXlHRFl1ZHpFNEhwc0FuTmJHUit1emxsYlhNNkJVaGVoMTh6TzBKV3FlOHc3?= =?utf-8?B?dHAvaXREWCtsNjVMKzFtclVoaHYvL1NFbGZFdzd5RlNGNms2MEZ4UFY4c0hr?= =?utf-8?B?OTR0MHVQVVBZSTU5WVBrMk9HVmJmSW52Mjh3OE9malZaMHdUc0JycENlZ3Jy?= =?utf-8?B?K3NSd2hMcmRzL1ZSSzNVdTNGZmYrV0QzaHhkSkdhNStpME9kS2VsQ1NLNi9H?= =?utf-8?B?am0yYjJLbmgrd3ppcWs2QXZzbkVSNjR5OGppMFpQZjcxTXhscHp1WXIvODdr?= =?utf-8?B?MER4c29HVkpCdEVZVDN3QzVRUjRZK2FIUFg3a0dXcndRVE92Sk02ZG9xQUhm?= =?utf-8?B?ZHpsc25PQjBaK2tTVUtzNllLSm5lS2txSzVrU2xqUGJablYxMWV6Q3ByZlgx?= =?utf-8?B?T0NBY0tRVjNmSk9pbytvN2YwenZuWG5vRllKN2xQM0h4NHJxeElGOTRaUjhv?= =?utf-8?B?dktLUjY0ZnJ1SWxGTk1nZHl0Z0pvV0NjdVpycC8xenFLMkpMWHlzUTNRK1Mv?= =?utf-8?B?UUtPNmdoQjRFRmhZcGRnWmJSVmNlMi9sVTVLUmx1K21GWCtqbzdsbXFKV0Vy?= =?utf-8?B?Zzdua1FJbkROTlU5WGpTamxpQlJzdlB1ajRSR3J5ZmEzbFY0Uzd3eXcrZzhw?= =?utf-8?B?OFZOa3JURkEwVjVBS2hORzF0RHFMRG1RbFZkZGZPYjljUHRWTzI4b0hybmpi?= =?utf-8?B?SDFwOHhKWlVpM3dYNy9jQ281aGdBeXdZTHVzanpYK2JHU2RwQ0t5QWpXYmx6?= =?utf-8?B?emYrc0tvTkV2MUlVRi9sRENRT2M4V29YYkFkVDd5QmlnTXlPMnlLMTQ1bXpq?= =?utf-8?B?dzVtQ2hyQS9MWjRtVkxpdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62c04b6c-3eca-43a0-3e9f-08dd96f4a76a X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2025 16:46:08.6024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0029 Subject: Re: [FFmpeg-devel] [PATCH v4 3/4] libavcodec/vulkan: Add modifications to common shader for VC2 vulkan encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: IndecisiveTurtle: > From: IndecisiveTurtle > > --- > libavcodec/vulkan/common.comp | 54 ++++++++++++++++++++++++++++------- > 1 file changed, 44 insertions(+), 10 deletions(-) > > diff --git a/libavcodec/vulkan/common.comp b/libavcodec/vulkan/common.comp > index 10af9c0623..db216a2ac6 100644 > --- a/libavcodec/vulkan/common.comp > +++ b/libavcodec/vulkan/common.comp > @@ -18,6 +18,9 @@ > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > */ > > +#extension GL_EXT_buffer_reference : require > +#extension GL_EXT_buffer_reference2 : require > + > layout(buffer_reference, buffer_reference_align = 1) buffer u8buf { > uint8_t v; > }; > @@ -61,22 +64,20 @@ layout(buffer_reference, buffer_reference_align = 8) buffer u64buf { > #define mid_pred(a, b, c) \ > max(min((a), (b)), min(max((a), (b)), (c))) > > -/* TODO: optimize */ > + > uint align(uint src, uint a) > { > - uint res = src % a; > - if (res == 0) > - return src; > - return src + a - res; > + return (src + a - 1) & ~(a - 1); > +} > + > +int align(int src, int a) > +{ > + return (src + a - 1) & ~(a - 1); > } > > -/* TODO: optimize */ > uint64_t align64(uint64_t src, uint64_t a) > { > - uint64_t res = src % a; > - if (res == 0) > - return src; > - return src + a - res; > + return (src + a - 1) & ~(a - 1); > } > > #define reverse4(src) \ > @@ -167,6 +168,39 @@ uint32_t flush_put_bits(inout PutBitContext pb) > return uint32_t(pb.buf - pb.buf_start); > } > > +void skip_put_bytes(inout PutBitContext pb, int n) > +{ > + int bytes_left = pb.bit_left >> 3; > + if (n < bytes_left) > + { > + int n_bits = n << 3; > + int mask = (1 << n_bits) - 1; > + pb.bit_buf <<= n_bits; > + pb.bit_buf |= mask; > + pb.bit_left -= uint8_t(n_bits); > + return; > + } > + if (pb.bit_left < BUF_BITS) > + { > + int mask = (1 << pb.bit_left) - 1; > + pb.bit_buf <<= pb.bit_left; > + pb.bit_buf |= mask; > + u32vec2buf(pb.buf).v = BUF_REVERSE(pb.bit_buf); > + pb.buf += BUF_BYTES; > + n -= pb.bit_left >> 3; > + } > + int skip_dwords = n >> 2; > + while (skip_dwords > 0) > + { > + u8vec4buf(pb.buf).v = u8vec4(0xFF); > + pb.buf += 4; > + skip_dwords--; > + } > + int skip_bits = (n & 3) << 3; > + pb.bit_buf = (1 << skip_bits) - 1; > + pb.bit_left = uint8_t(BUF_BITS - skip_bits); > +} This differs quite a lot from the software implementation: It does not presume that the PutBitContext is flushed and instead of simply skipping over the buffer it actually fills the buffer with n 0xFF bytes, effectively adding the memset used in the VC2 slice writing code to skip_put_bytes(). But this file is (if I am not mistaken) supposed to be generic, not vc2 specific, so this feels very wrong. > + > void init_put_bits(out PutBitContext pb, u8buf data, uint64_t len) > { > pb.buf_start = uint64_t(data); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".