From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 46D2F47A8F for ; Mon, 30 Oct 2023 00:22:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EFA6768CD02; Mon, 30 Oct 2023 02:21:56 +0200 (EET) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (unknown [40.92.58.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D987C68CA0A for ; Mon, 30 Oct 2023 02:21:50 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zn9KCuZ7+gM2JDkkOHsCvozXqPvPa5qA288a4XHr5iwSQxac2ZN07rkT7+80Qlp918gA1ZNU7My/PV8ZNiYT0LtpTpOVnDSPZZ8nMLgChkBm0K+pw/ZOC0cNTxuRgV50+xFiDpnFy+7QrjSLZFn3NX6K6ny1r1ayj2vpYStuH1BzTIFzw/K+7hAzes+DJw5V9M8dojhoCZskGvI8BvYOEtigzLE15sTrltACZLDvnra4K0+J4D0UXVhKZz0WOCyQx1YmRZck9qc36yq17fa5qY9+ySAAgbpuGPtIxD48j98+GLeth7FP2S0VFJrIFti3Hep++iDq3yf7wvcjDakHSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sd6PJ/VFX5Zx1Fak/7ckEmO17wwRyysJuB+KdJP9vrs=; b=RhmoJWIFVSnKy7KgrID19OlfQ9vLROyLpN9iBmDQJLmEWHXR1QZtqSvk3bNyeuABTtNPYpv1WyH0v9cJ2AF/RP+E9SdOxKaj8aQbFieSk00WEsNrXonyynOz4Eq5nt7Daot2sTeV3LeOzIErWlbIMh/+qnEdJm18V7eNlSezGxqWzak5qUM5P9BhBB+Fl1PAb53akrhLCf6GjCAY2A6iVt5546LTmjImSWUz7AQ2cujnSYSfBEkEw/VJ4fKN+31H3JX5jrfGN0buE5rhX4DcdkfI5fjxtngyzF+JqJbzpKXDUC4pgxlTiqhJ0omryqb0Lit226UvYnaZdXmRmPMS5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sd6PJ/VFX5Zx1Fak/7ckEmO17wwRyysJuB+KdJP9vrs=; b=LmbJ7UL2PvhwsR5ipJmgT7+SwThASr/rUKr1xwn3+d1rkXBZZj1/XHAsGk7u5Io44CgWo81ovlJP4W3cUig91IHpyhniPVTmiSBqrEx/r4febiB5c8tcA83z/CfAQcgfo3rqUL6fUzsCC3Qhebr8MnzoKAMhGv15Vr4PwD9j4gLo4vBCquMSrNBDIytP14he77ubMDvtYw0AsCRR4c+AB5TYtuRhsc4fkdJmSVn7KsXYsj833clIhkALypPYVey/bQu5JwvS/20uDNNy3x2tVTGtN9PUn5bwsuohYFLnlX+AiIuW9/PLJclZfviUDlgGWfrpwIHnw8XVRZ+Ken7q/A== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PRAP250MB0417.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:29d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.26; Mon, 30 Oct 2023 00:21:49 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde%3]) with mapi id 15.20.6907.030; Mon, 30 Oct 2023 00:21:49 +0000 Message-ID: Date: Mon, 30 Oct 2023 01:23:07 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231029124723.398581-1-leo.izen@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20231029124723.398581-1-leo.izen@gmail.com> X-TMN: [/hewVMMcyShB3hkam3WnkCvu5BQ8RjpW1HgGdGl56qE=] X-ClientProxiedBy: FR4P281CA0428.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d1::11) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PRAP250MB0417:EE_ X-MS-Office365-Filtering-Correlation-Id: c6e6d5e4-2b66-4d2d-4d4e-08dbd8de3529 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PVS9JzpKZw7FRPR2L67Dzpd+c37+Cn/LeoMHjOzuNKx3jQ5TodgeImAJJJHVRtZhkp3HjmdsNSHy47CL8RrBgop+2eyFVLgtf83jVMRI6w7Hz+ecHrkm3TeSblKPmDsTzJkYFLH+r/3eNRblcuQVc8POYQd7AcPEMsddbZkF1NvQIi48KpfgYq8EDsye9uZaATcrXLXIVMvfGKG2L11uRNvxVxpoaAUeY/V5YaczVUW5iLrpRmjo1yk8l8pLBYkicrGatl4zriORCuG4Vq87s+sn0zRQG0WwNMLwQ96z0cZS3h5EZwU4h5CTdFMaUwSntIRFRYzlIBBcRVfsrU/WYEh1fv20RLM0hHeucovKlOcHFia1QBQqcspCMUmrigt/QiYq2hDAPLsrFXqdw1lJmdum3VZ1DntQPOxwh9Sd1gZHq8agZAcJbK70cTyjfNXgiuRGMSrDjLxq2MItbYDNnku+0QF+kZD6LeEEKNaxzr3EFzGruc//offB85pH3rrqRJ3LyfpJHvlCiPra3XTrDp8jm5+0jCMDEP7wGJLuj0ed2BhTxw2bNYZFYg/GMDPL X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnJiVWtwUFB4cjhkY1B5ZXVmWDBhYTJzL3BYeGVMRk1vQjhKNzA5T3hJUExV?= =?utf-8?B?REpleWhMQzlXK25ROXFJNGFPNmdndEJMWjJXaHNuV1J2am1vWkNOMTl2RXZu?= =?utf-8?B?YVNabUMxSVFCaXZXbVVMRldHSkRUSzBaVldOUWlsK2FwZ2RSMTV6WVdkWmFN?= =?utf-8?B?MmN0QmVreHFyMm93bkpJaU9oWXdGUENXeWduQzdvd0ZKRG9EbW1VdFB1Vjcz?= =?utf-8?B?NnduU2s3T3pZcThvU3pLNXd2dUdDd2tmdEdJYUY3Q2Z5U0F5OW00Sks0U1Jn?= =?utf-8?B?elFHeXFsMlQ4N3lCOXBXeXNuZEhOV09nV2ZIK2dEMUllYVZEWnhhQVZadzFP?= =?utf-8?B?THczQXQvQUZJNldDZVBoZzFISE1vdWJNQ08rUkJMd0dxOThvTFZSYlIrK1NW?= =?utf-8?B?YkFDRnRhM04rREJ1UUhBcTBCRlFtdUMzVmg5Tnd1N0dVM1ZMNDBKVGlLMG1k?= =?utf-8?B?RW5SeFFjQkoyZTVSRFYzZ1daQ0NPendJaG5zUGkvQU5vL3Uxd2U4WEd3UkJ0?= =?utf-8?B?M2svQkowSEJSVzlrLzY1V1FjYUpRaVg2c080cmZEeTUrM2oyR3ZmdmxXdzQw?= =?utf-8?B?MmJWRlhRU09pbDNqcTdZVkc2enVoVXZXQXBpaVNVak5HUFN4TnJ6bGJFMFpx?= =?utf-8?B?R09BTlU3cUNLSFIyNnVKN0N4dG1LZUc3WWVzZ2tSZTBXaGZNSTVYWGczRXAv?= =?utf-8?B?TFpRa056RHpyYTMvUHpwaDQ5S3dyVzU1Q1hIbEMzRjFhd1FTTHBZOFM3dFA1?= =?utf-8?B?bnFibkhtS01sWGdUL3hSSklraFBnT2d3TkNwQXI0QlpyMEN1Y0FmNGUxVlht?= =?utf-8?B?N1FGN01wN014V3V1M3QxSXB0WDlSYnZMV1VPNlcwNHRRcUU1U2V2Q0t6ZWl4?= =?utf-8?B?ejM4QXhsS1RTQ3NUeXJYVytJc0graG95NHFUeEdMMDlBRWUzNE1IOFdsc1Ew?= =?utf-8?B?NUhlRVJPTXRPNVk3NWxRTXlCZ3RpNGFrVG5YaHhQVlNjV0VBNmJla2xZVzJE?= =?utf-8?B?Y1Z3cGszN3dRMFRtbkhuYlJKdUxQdDFQd2NhcUJsNW1wYXZUM3VLZXZQVGFx?= =?utf-8?B?N2lhczEwUHJBMkJsNENoWGRkMTBubUZmRWZYb1l4R3AvNEVESDIrL3cyR3B3?= =?utf-8?B?UDBMVi93NlJ6OSt0Rmw3cTZmRlBtQ0xGcXdPN0tkanFrTHh0TWMvSWFPNkZu?= =?utf-8?B?bmtiOXpKUUV4bGl3MnhVWlZQTmNZRkNxKzhVa1lEbXdDbWxaSVlHR2RTdkgy?= =?utf-8?B?TUFOMDlGandVU0VYSU84TCsyOG5iZnJjSWRnZFhUaEEwVE9QWUFqUFRDWFFt?= =?utf-8?B?a2RsdkRMWUdSYU1TQm5KYUtVQkszUmhtSHg0UzE2cVViVDlhMnFCR3VJSElH?= =?utf-8?B?RXgzK2Qxa2xqUDNiZEhVcnk1eEN5QURYekErTmtkSjBMbDBHVGxvWHNvemYx?= =?utf-8?B?OWI3TFVzdktNRjMyOW14UFdrSnhkVHVhcWpLT2lTYXN5WlJmb29Sdk8wY21j?= =?utf-8?B?VS9EVmhPc201WVVZZjdpQzRCSTNyc1d5R29qVkhESDk4WG83ZlZETnplTlNh?= =?utf-8?B?ZHpIUlN3SEJHaHBoMG9QcHNYYTVRaDV5TmN0ME1jVTJGeWhyTXYvY2FRdHdP?= =?utf-8?B?RzFsVFpFeFhzam1vMmgya0d2TFVSbk5sdGRoWHcveG5JZjVxN2V1Y0xhaXQ3?= =?utf-8?Q?SwtHJCIRNvCWljfWpjKD?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6e6d5e4-2b66-4d2d-4d4e-08dbd8de3529 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 00:21:49.1936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0417 Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Leo Izen: > Avoids a -Wstringop-truncation warning by using av_strlcopy instead of > strncpy. > > Signed-off-by: Leo Izen > --- > libavformat/hls.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index f5f549b24d..39440176c9 100644 > --- a/libavformat/hls.c > +++ b/libavformat/hls.c > @@ -543,8 +543,8 @@ static struct rendition *new_rendition(HLSContext *c, struct rendition_info *inf > int langlen = strlen(rend->language); > if (langlen < sizeof(rend->language) - 3) { > rend->language[langlen] = ','; > - strncpy(rend->language + langlen + 1, info->assoc_language, > - sizeof(rend->language) - langlen - 2); > + av_strlcpy(rend->language + langlen + 1, info->assoc_language, > + sizeof(rend->language) - langlen - 1); > } > } > As I said before: You are merely hiding the truncation issue instead of fixing it. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".