From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C7F5D482E8 for ; Mon, 22 Apr 2024 16:48:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9B53568D307; Mon, 22 Apr 2024 19:48:29 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2076.outbound.protection.outlook.com [40.92.73.76]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7BF8668CF59 for ; Mon, 22 Apr 2024 19:48:23 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C0otYNaJrNnYDld0f5A70/DolHRIMHL754LJcnzO1VnbCK8dhJb7BnWICvuyhQqcZbhupIuQl/ugLF68mu1ZNc3qW1jYNb/z4/3U15uXORYkhahgMwCPjObmj4eKacqwEZaCSq2nuSC8qxT6RArPY5mgPEyikpFJuW6ZEQCbW1LEeLangV6qaPtXkqbRU7aInXHZTlk/P7rr0OwdRSkKhsXWOrHYF556EvggW6sUPr2JExbLjk/qamMyT2jeXN3I2NGPPfD7dae5nHhf8eP3hZ4VxXESbcTnKpL6ATXdXDugPdI3A3Yrfx9/e8Y7yEvankKYAfJU3ZZ0zgq1i9F7ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XFFYrUBKf0IZyoXumZBgkv2hnjv1K1tMw+8Oq6glK0E=; b=EjoKtxPp6gciRH32BbGQZK/kNbowdAEsUQnyD/ykaHCk5vn2qnapSf8rWcohugdDqjRsNoATymG4YA0iUhp1EugdVfZwk2yZDtKt1JYYpY+nzPI9K+kdHoSleVqTDYiBbF8EPwyx3USIs3kSmiLYyasSoBtRwASu6cFRuvFpVzSOfsTtYjz7UkOtdQrTN4gRUC/fWWg/y6VnqtgBq/JtFTFz4NeTqov+KlbjsUEoMiHInuhWhFwWEVuUImyZ4JNLawAOR0TmAesiMF1nWba81RrbGVwr5gKrfSy+Oqgc4Xr14GQZTrIYnYZQRuaJHYN3DOwzkoVm2myoqVW5/U6BIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XFFYrUBKf0IZyoXumZBgkv2hnjv1K1tMw+8Oq6glK0E=; b=KhrYTqi0Mo6MbhISLTVs1K3z132LHW23k/QwbTydAervhtuICI3jCzVHGNsoLgPo0ZB4fdV+fbV/WmgjokoqUcza471SoPYb1YS/LGSuYvYYQBFaYLFDbAuMiWZlOQt5P00kMfU/36P9bN94H6rRRGzgSClJLm/DDLuuxobdHrQFm8nM/lwAkEhQUsw1LExki8cHUAtpnVa/0i9u7v0HzMTnx92TMT61iRze1Qy7cPpuMoCxEmqnrkYkB5rkKlku1y2Hdx8LmtXhosEnqBzVNsBGRenzbjsgxQP2ApJHZJl8doc5J8QDnUfNFum/qTjs9wm5pw8b8GzVoTF6PzmE7Q== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by VI2P250MB1056.EURP250.PROD.OUTLOOK.COM (2603:10a6:800:22d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Mon, 22 Apr 2024 16:48:21 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7409.042; Mon, 22 Apr 2024 16:48:21 +0000 Message-ID: Date: Mon, 22 Apr 2024 18:48:18 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240420114835.35645-1-stefasab@gmail.com> <20240420114835.35645-3-stefasab@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [xsiW/KROoitnDQw8AA/DNp9nUZ5GglJl] X-ClientProxiedBy: ZR0P278CA0101.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::16) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <276f6b99-b4cb-4978-b8b8-e3837fc0bfc0@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|VI2P250MB1056:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cd202e3-d9c3-40e4-d4ba-08dc62ec047e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GoLl3nYnLAKkXPiNnTyGMgyTBN5Nr6lBHQlcKCYIu92o1yiyrz1/buMMOoki+L3ckAoAntTLJz8NtqiA1/QksdkpQE1tI9/OV9WbwacP6q++wP4bKtQDMltVbcD5Tm1Ge+eDAhM7p7HMB+hNv3fuzBQNf4VsCaZD3aXOIjAydMwx1QOgvptBML/4z/v2yb2phXCV6orIfxSOjBMFaOJwzfSzKB9JZvaHlgYhWU0aVE9oWlF1I/+KiPoY4+F4Oukyxaf5+meJRWdqBQD6WXsHR1dbkA11bzc4/ynRTzkn0JrCIqqiIgRvBkCI2sQXGLU8O6k0mkjWVPD44eYwOJIhzwBjaBAfdSKZTif+9fGqfcqApl93vQebWiP6+UULSG4GHWF4AluU+uBwXEzyozltAEIpvK3SDZRFVq3rTd+m2OcFcD1y1dNjXEtf2Q+358SI/edl4UMUHPOiPWPwyuYNbn16iCGUhw942t3yGQnFm8bqsFF2EO0+Lvnfq3BRpenRmWRbrnDEX5h76MYm9RzEYlZZr/oT17SpnmXHtOe8ruG+hm879ZhPny9klMsl03mm X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXB1cVA2ZzNrVk1mZU5MeTZyVlNqa1paK3VXMmtxS0RITjlVZHc0eDUyZ2FQ?= =?utf-8?B?VVQ0dDBRbTBEblFXcjBMNEtXV1FPdG1zTHk0KzNCUk9aWllOcG9OV0Q1d3F5?= =?utf-8?B?VFNWSnVTbG9PcWNnMW5rR1lpcHMybEFNeHNnb2xzbm82YXczSXh4akZYRDR3?= =?utf-8?B?OUlQMGM1UEZRMEtsNjJXRStwRTRZOUJJb0N3TFBlRmRreFR3SHc4SzBRbUxZ?= =?utf-8?B?MGxXZlZjNzJJYXVId1BkclRGQ0hmVlFJT1RYMC94Vk5NNlVWdGFFNlJrNkN6?= =?utf-8?B?aHZpeUYrc2hZZC9MdzljMFVpWUZZL0lZeVVGWXkyK2lmOFVacGs1MTlRajRy?= =?utf-8?B?VEtLekRIdGlsTUJUU2dBaTZPSnB1eVJrTHpvbE5vczdwWkpyYkRCUEVOMWpx?= =?utf-8?B?QTVEbTBWZy9qbzhXVFJObUhiOC9BY1h6TEZ3V3NIWFR5RUVKcytLYlZkTG05?= =?utf-8?B?bkVQTTh3SVhPUDhpVTRmZVFaUHQxQUtvNUZTZmNaZWpzYTN0d21Mb0o4SDVM?= =?utf-8?B?VlNiVHRkZUpEZlliSlRmb0E0TTlseDhQRTZTOHZFWFpaT1N1cVl1NDRZVjVO?= =?utf-8?B?eHluU0RzUFlscG9jaXFPeUtsTDdoYXhDZ2lPTEE2OVN4QUdUdlN2N0pUd3BT?= =?utf-8?B?SzJKVjdTd3FmdmQvTERTQkpQTGprNW5lZXE0cHVQNm5YckxsK2lTR2Nwd3Y3?= =?utf-8?B?U3lnVDRMUTkwb1UxM0tXWkVkZUxIRGJzR3poc0lpZmdzZFVVdXlsQmFBTHM1?= =?utf-8?B?ZHgxQ2dqbHZ6NzFuQit4ZUFaa25uOHdvbjUyNWc2TjVSa3JtK2lVcUlRMmNq?= =?utf-8?B?OWhSWFBHVFFGa2ppazhrMXVQd09Ud282TU1CUm5LMlNDRTVLZ3YzSnpObFU3?= =?utf-8?B?WFVjelBvSTczdTdwOVg3am81RjV5Q0dpaWFMQlpKUmN2bFRrWnZTakJFbEVI?= =?utf-8?B?d3BvUkNUYnhEdzViL1JXQzR4dDByd2ZSaWV5d09YK2FSMndValRyNzVCN0pz?= =?utf-8?B?dHJkR0dISlFKMGcvdWN4UE9yK3EwakdGOU5xWUNOQ3ZPWXAzZnVFOHR4Zm16?= =?utf-8?B?VE1oeUtNM1R0NjZHRHVPbkNnQS9JTVgwWlVKSG5NdFBtcm1BNStxaEJaeHJN?= =?utf-8?B?MlhmYWNSaEE1dzdUSmZUYmJWdllnU0dWUmxhTUltck4wS2xtOUkvSjBXRkJR?= =?utf-8?B?UHBYWEhjb3k1WXpiMEtCWWRQL3lORzZhekRuWnhLL1BjTXRpemI0TFg1aWV3?= =?utf-8?B?SU0xNXU3aDNMTXVtUFdXVXJicW9JZHpPSkxzWWhRenlSWjNRbjVNRmhSNzF6?= =?utf-8?B?UWE5QVlvK2Z3VmxxT3hUUzhyTCtJbDRCeHMyR29saXVOSlFtSC94V3ZIQWRh?= =?utf-8?B?c0l2UXMwdEluM0I2Qkd4c3RTa3pXTmc3aEs1b3VrY0tBa3FwYXc4ZU9wdWtY?= =?utf-8?B?NURqaTh5TzhmckxiZUR6bGMwUVdKaDRxUzBJT3FmclI4RFl6Q3F2T1N0dnFJ?= =?utf-8?B?ZWkyV2NJSzhVM2d3MFB0aEpEdjFaSDVsVGtQZHdsTml4M2NMSnJoMDdqYTdo?= =?utf-8?B?V3F2NnZmOTFqaUlnbTBqUEo5a1IzL1h0MVRhTXBmUDkxRHFNZk1PRzl6ZE1y?= =?utf-8?B?SlFnbDUrNllzMlZ5TkdoeTFyZDArSGNhRklIcEhkRTlKYTNDY1BQd0J4MU9E?= =?utf-8?B?UE05RDZwMXRrSXl0QTl4VU9iOHNBeGQzMFNCNGZ0Yk1JNjh5OFFLUGNnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cd202e3-d9c3-40e4-d4ba-08dc62ec047e X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 16:48:20.9533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2P250MB1056 Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavf/mkvtimestamp_v2: review implementation to match mkvextract behavior X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Stefano Sabatini: > On date Saturday 2024-04-20 18:47:58 +0200, Andreas Rheinhardt wrote: >> Stefano Sabatini: > [...] >>>> 1. This does not match mkvextract behaviour. mkvextract does not force a >>>> 1ms timebase. >>> >>> From your past comment: >>>> The accuracy of the timestamps output by mkvextract is determined by the >>>> TimestampScale of the file in question; it is most often 1ms when the >>>> file has video. >>> >> >> "most often" != "force" > [...] > >> (I am not certain wrt MKVToolNix handling of fractional millisecond; old >> versions of mkvextract may really have simply rounded/truncated to >> milliseconds.) > > It doesn't, at least with version: > $ mkvextract --version > mkvextract v65.0.0 ('Too Much') 64-bit > With old I actually meant really old. As old as this muxer. > So far, mkvextract seems to output DTSs as in the original > implementation - therefore no need to change implementation, but for > the "timecode" => "timestamp" issue. > What is the TimestampScale of said file? Given that we are dealing with a video stream it is highly likely to be 1ms, so that there will be no difference. The following is from a 44100Hz with 4608 samples per packet and a TimestampScale of 22674 (equivalent to a timebase of 22674/1000000000 s). $ mkvextract fl.mka timestamps_v2 0:fl.txt Progress: 100% $ head -n 7 fl.txt # timestamp format v2 0 104.489795 208.97959 313.469385 417.95918 522.448975 (The following is with the current implementation, but your suggested patch won't change anything for it.) $ ./ffmpeg -i fl.mka -map 0:a -c copy -f mkvtimestamp_v2 - 2>/dev/null | head -7 # timecode format v2 0 104 209 313 418 522 $ ./ffprobe -hide_banner fl.mka -of csv=nk=1:p=0 -select_streams a:0 -show_entries packet=pts 2>/dev/null | head -n 6 0 4608 9216 13824 18433 23041 $ ./ffprobe -hide_banner fl.mka -of csv=nk=1:p=0 -select_streams a:0 -show_entries packet=pts_time 2>/dev/null | head -n 6 0.000000 0.104482 0.208964 0.313445 0.417950 0.522432 (The slight differences here with mkvextract is due to lacing: mkvextract calculates the timestamps of the non-leading packets in a lace with the default duration and uses nanosecond precision for this.) > $ ./ffprobe -hide_banner slow.mkv -of csv=nk=1:p=0 -select_streams v:0 -show_entries packet=pts | head -n 20 > [...] > 0 > 1201 > 1235 > 1268 > 1368 > 1301 > 1335 > 1401 > 1435 > 1535 > 1468 > 1502 > 1602 > 1568 > 1735 > 1668 > 1635 > 1702 > 1768 > 1869 > > $ ./ffprobe -hide_banner slow.mkv -of csv=nk=1:p=0 -select_streams v:0 -show_entries packet=dts | head -n 20 > N/A > N/A > 0 > 1201 > 1235 > 1268 > 1301 > 1335 > 1368 > 1401 > 1435 > 1468 > 1502 > 1535 > 1568 > 1602 > 1635 > 1668 > 1702 > 1735 > > $ mkvextract slow.mkv timestamps_v2 0:slow.mkv.out > Progress: 100% > $ head -n 21 slow.mkv.out > # timestamp format v2 > 0 > 1201 > 1235 > 1268 > 1301 > 1335 > 1368 > 1401 > 1435 > 1468 > 1502 > 1535 > 1568 > 1602 > 1635 > 1668 > 1702 > 1735 > 1768 > 1802 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".