From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BF0CA44F66 for ; Thu, 12 Jan 2023 00:02:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9C5F968BCFC; Thu, 12 Jan 2023 02:02:36 +0200 (EET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2012.outbound.protection.outlook.com [40.92.65.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 747E168B080 for ; Thu, 12 Jan 2023 02:02:30 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZZko/Q4i22sYPFOkyUpO4hbOPcVQEbH756fik6V3gUNxLfCIPFpBNhtNkcHG90GG0Ds22C3sUXc8U4whQ22YMogyxOMYJFFYJoNq/0LbvxAPscl9Ko99ildIM0aBp40enpRVh6kqKXSDCZTGK5IE0g+pT3aVFhzDMB5hom0gu6q5oGtQY/9cD5L0wptOU+7FgYep3rn9MBWTPRHm5+pX3zIQUzOOptriir07uHQt2KHbbwWPlxQKGO9RkDiYtE9W6r3hCVZeGAX5w7BiApnu0el6tffsi1IhdS+cY5naQSBDZwrdDh3LCN+K4AWu4yNvXkF7DkEgU6P6RMB56QGpHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Iu8YbEsLJJ4o2HKWp1DfrAbcBCxU6kEjx8Zt65DcCk=; b=RkG6RT3h9+Cb3gaoybma65KuVmuMQ8Uz71VUldSIdNhstm+cQOzi0tW3ag3h2O8yyu6hXqsdFsOO5F0UR+q0ziU34zG/04jiyCcjC1MIwZKBiFGzLlFuhp8HGq45VsH+scgfeZTSuI5ngJ5BtFdMCva2E4RpmWY3sDRTa/Fk1iGqI1Al71mCZPF2atcF2bUEzt+0HVl3Qg/80scNDiywlavOC0o4HzdSxNCCEf/b88bA38kXCbPCIH9u3xfUC2gImO2LT1SuLn8HJF3dJhZRyxgRg8ANjSWBB++64V9tXJVJWdYsLwxTYq5jOfxLJn3iJyFmUGUD2n+Qqxo+OMqL4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Iu8YbEsLJJ4o2HKWp1DfrAbcBCxU6kEjx8Zt65DcCk=; b=LvnnAJJdA+9qaqUQ2lJnECEe3SBzuoMz4hHM56Mygn0uQOyqTkhY/C45w+gu+eh7bscYvnIYrF5nHLH9YH+riYQ1SALkAhc5eoS0YzY/62fYsvfUQcnBgrW6uW+roaFWsEk0iBp14Mlhobesd3nl4LrQp9bkgaAsJKbq6qZ+TsdxPRGIeyTWXWyyM5bv726qiVHkpAYp480Ps/+9kFoPmVIRwl86vZ1hdzQnztR+J6ORMAJbSFacpUdK3CX21qQEIz5Kp8Bvhn0qu7dkacNf0NJNpNff3T0yq0PW8mWDepS11R0PqHl9lm9mRgk+EBzhwo9Mx8Voss89HOhLrkx16Q== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by GV1P250MB0836.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:98::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Thu, 12 Jan 2023 00:02:28 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::c37:cabe:316a:60b2]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::c37:cabe:316a:60b2%4]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 00:02:28 +0000 Message-ID: Date: Thu, 12 Jan 2023 01:02:57 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230111235432.2135-1-michael@niedermayer.cc> <20230111235432.2135-4-michael@niedermayer.cc> From: Andreas Rheinhardt In-Reply-To: <20230111235432.2135-4-michael@niedermayer.cc> X-TMN: [CxaAgnwe/KUlWMkGUch6e/JWRQz6JmRq] X-ClientProxiedBy: FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::19) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <93e8ceb9-2d26-0d8b-1bdc-726d8b872459@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|GV1P250MB0836:EE_ X-MS-Office365-Filtering-Correlation-Id: ed824b72-bdec-4a7c-4f52-08daf4304b1a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BgZP416fPrPNytehbEVU5qrOARKzAlUlkvLnXS4t/E3Jxo8b6gIIh/T7toqnzpwAaFB/tWAwp0KiljewsV5wu5rCMWltvXfkqOg7AOFxiEz/dLo/9rgWaXHeyxRbbqbq8j5x/k28B5E4d2KN+rqzBIYBwlxgLdhv6qQbQRGqlMln/ztnre2bEpBqZk7VGY8BsYivfBcz6jnS3yNx8EqJPB59APRokeNhSiPYl59zb43xY4n996fDsq7ID7BI772DgkkFuCmgOxGodyAM/UoKpDhJSZ44vpkmdqHnGKEgb5eHhjE+L7ic6or4Ol74aMRJhGoPptBr5Vuy0MAh7VGsUGuGd9NHv2eVBIfONtEEQujgrrSmbQMoe5lnFD6t5Tot3uK4MY9/g83Ec2D2WDlHQKeta1EufESiNbgVT1hiPFsxdvf+q7HQpyckgPTF6YlAPqByS0qW2PMz+Q5hxjWqDKkDhYYVDJnzbggB9wICNH0JU9AcxyA6zQcYNZXdoOqVV+2jeK8cWkjDkyCv12wQV6PzkSfx6XsYNM8xIYxF2afFFSIa4IMJclbyS/uv0MjzIjB7MDWEfYaZ6jDl0OS8tXNAnQEb2Sw2/MRrbFGdGj7mjj1t/ppd18z6OLJdjiakIsI/PeyV5uSoO2aPSmI6HQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHEwTFBIc2EvOU03QVNPb3pJM2I0TmlkVUdOTTFXRUhBTXFZU0tqUTg0Sk5q?= =?utf-8?B?RTNMaWdLdHY5VDRaMTFWUHNXRnFMYXdPaSsydlZIQ1VVTVVUOW81VWRXY01x?= =?utf-8?B?ejFHOGR4alJkZVVqdldqd0J3Unk0OHJtWWdRUW51WjJ3aGN4UUdKdFF0WnQr?= =?utf-8?B?YkFKamNNam02L1EvRGdaUnhsOVpUelYwcmw1SklIK1YydER2QTZPTmtERlZa?= =?utf-8?B?RHo1elFTcnFSbUllWEk4WUZBdFlPYzRFNWplcGVsc2xCSUcrWEw2bU84RmNs?= =?utf-8?B?cTNxK1A5aTMxQ1c2amFNWlpaWUVOeTlydnk4QlpZVFdaOFdoajF2Z1JXWkZF?= =?utf-8?B?bldNdmVwWFFiMGlYUzZrMDJ4dldQZGprUjhLY2VUZU9nNzFBTjJ3MVhZZHE1?= =?utf-8?B?ekd0RnFGLzJuditVNVVxYnFPeFZzVlBUVGN1MUF1SWw3MWVBUVAyekNIVHdP?= =?utf-8?B?K1kxeFNKY2ZBNmRIWjRVSUc2ak9WSHpNN1k5Ykl2N01tQkgwRklnaXFuQ1U2?= =?utf-8?B?RmZ3cldqdnBPckp5RU54ZTYxYVlhc2V6NkRCZDZpd3BXcGYwNWtWd3ZVMEFu?= =?utf-8?B?MzFha1FFRkhyZ3dWN3VFTm5KWURqQTVXV1k5Njgxb1RLOUljUWRrY2xmL05N?= =?utf-8?B?N283OFhRMUFFYlBHMDNXcVBuR2xycitKTS9vdmxMNkVmeHR2K29BVHVGdFdP?= =?utf-8?B?RnBWdzF2Uno2dGMvV1pOdnJGOXl1TTdFR056dy9SY00rRmxmYlZRUVBHZjFy?= =?utf-8?B?RjIrbXhtSHRkY2I4S3RwSjlzRFRva2ErblN6NXNjWHRjOC9oSHI3OXpiSkF2?= =?utf-8?B?bmpVcGRZQ3k4V3JBc1F1amJBT0IxdSs3eXRaM1NaZzJYaW1heEdyaGUrNlp5?= =?utf-8?B?bmI2QXpuVS9ScnRlTjJFL053ZW10WmthaVl6MG4vaXpJcjR5UlQ4NmRmN2Ni?= =?utf-8?B?cTd5MEdkcXNUcU82KzBYaXdIQzhKUWkvVGtnbjBJZ01GeTRXenpyVFlhSHQz?= =?utf-8?B?M3k0YjY0MjhJVWVIUjQwUVNFTFB1S0JNWU4yeXdZM2V0aFFaL1BXWC9rQmNL?= =?utf-8?B?OWtuQ1RtUmFKNUJzSWpSbHpiU1E2Q3UrcmFvS0Q3S3BLaFE2YmZJYnRXY0dM?= =?utf-8?B?S2Qxd08vYy91RjZiVU8zYjNCM2lQRW55MW51dEpnSkFEWTdBOWpOdzMrakxV?= =?utf-8?B?ZDlSKzdSa09lWnNHb3RWbFhudGJqRTlkTmlMTUEwbFdHR2o2YmFGTmgwUndP?= =?utf-8?B?cUdicU1hVTA5cTk5Rk9ZVHB0aEllZm5LUkZIdDVyMVYyY0lINnNlL0hvOERY?= =?utf-8?B?TERHSmdmQ0tCY3BOemhVeWlSR1FXUG1jbUk4YjNIYisrUW1rVjVoZXpTTWJn?= =?utf-8?B?bENQVUw4c0RKUTNKeWVCUFVTMERGRlc1dUwyNzFGOFlnT051ZkkvOEEvTG5B?= =?utf-8?B?V24yeEtDZDk0TjJyQTd6MitLb2JWTER1bTRSODE4TmZoWUhTOXcxVGlKTDJE?= =?utf-8?B?em8xcW1KbWF5VkhBN2lWWXp4eW9QLytiTWRZQ2FUMFJnTklQUjF4Qldvdzh2?= =?utf-8?B?QkNORmtFL1dNVXNvaXVkd3VlejBzbmlQTGdRV3RwcVlNbFpzVU01T09TOEdp?= =?utf-8?B?aFkrNU5Ja2xXNW5LK1h1WlB5cGJxT2pUN1FsRytXa1U0Z0k0QytMajU3YTIw?= =?utf-8?B?YWRRZTMzcDRnZVZqdkRHYlA5RHdwT3B4cVJ6STBYcU1ZUC9kSjRMY0RmZyt1?= =?utf-8?Q?mutMuLJ4Emt0aIr12M=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed824b72-bdec-4a7c-4f52-08daf4304b1a X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 00:02:28.4324 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1P250MB0836 Subject: Re: [FFmpeg-devel] [PATCH 4/6] avcodec/sgidec: do not forget the number of components in read_uncompressed_sgi() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: out of array access > Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SGI_fuzzer-6704753329700864 > Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SGI_fuzzer-6683986844057600 > Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SGI_fuzzer-6697387691474944 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/sgidec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/sgidec.c b/libavcodec/sgidec.c > index 6ff2ee97f6..92083f23de 100644 > --- a/libavcodec/sgidec.c > +++ b/libavcodec/sgidec.c > @@ -159,7 +159,7 @@ static int read_uncompressed_sgi(uint8_t *const out[4], const ptrdiff_t stride[4 > unsigned rowsize = width * bytes_per_channel; > > /* Test buffer size. */ > - if (rowsize * (int64_t)height > bytestream2_get_bytes_left(g)) > + if (rowsize * (int64_t)height * nb_components > bytestream2_get_bytes_left(g)) > return AVERROR_INVALIDDATA; > > for (unsigned z = 0; z < nb_components; z++) { LGTM. (Sorry for having forgotten this in ce4713ea731b9deb0440abe8d8a2a41d2957efc5.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".