From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 13BB54406A for ; Sat, 24 Sep 2022 14:12:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D1FE668B8FF; Sat, 24 Sep 2022 17:11:58 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2024.outbound.protection.outlook.com [40.92.89.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E6E3368B7D1 for ; Sat, 24 Sep 2022 17:11:52 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bp9+MUa82G6m2TaPMARhLAGXQyRXdbgz27kkTz6X4SOTb7mWnMO8YnLpeAOug1CiLIl/mprpYhdaE1X0v2KDuMyPYGYJ9BLnSbwufPwTNR1i0flqaemclIjA5K2olLxwQ75qbv4ibt4n9CpS8u0yL9j6abbkaVBrA1uf74KM7eo8DMAcFDQV7LX+T/UmzTiC5xf1Y3Xhb/RvBC9O1FBxj3zApkR8d3t+8/XXRNt3fp5WSbNGFUHLC+umLdz+mYIruDRTEuI7a5mCgBBJfmekbKdYpMFkbj5OGfdhVBsUJrTPTdmf9lxJ3wZhJnpi8nXbch+t34hhSmcAb2Nt68sVmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NxcqjxqhuSHbGFyma3+fx1o4wnw2z7bLn1N77z2vlco=; b=LV1nRBW2p/4SpX0xWH8/gcsLHjerbTpELGRrGShWd4Lx6vgAVxg8jthPQA87vogA4lNsevou6JY7TNWyCun54kFip0yp6d80G07Hh6oZ4qtBd/isuYHTaRmKSUkBGj2/Zia7HPzFvRKElDnNKdzU+9Qf3Mz5FCGagEKMKK2SkDUMAI6oVsIUSHP5D9gdoV4DjDG6Gz/tVc4e8l8qvin8Hk4TCncRMXQV9M/JJOu366oiLK9q+yWoMyxgU8jHIUDnQAeVYEsJI2FRATXaJeO5a3u8vftwZdpjkjhRcXV88LKsQUVml+BK4rxZO4TIJKmGfmxmKBRaCoD9qsy2Wn3m5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NxcqjxqhuSHbGFyma3+fx1o4wnw2z7bLn1N77z2vlco=; b=JrjeSigHYHaupOimrJfn94Be4Kyp08ZcG/jtG0SmIwa+MSxZ0c2sbL8wZF/x4u7wCCv6NO65/w058DayFaSaOGKlKYfOHdj1/dKgu+M4jsEtedIKKpLDm5X+UvDRRyjgtxg+v6ThmUfnqszZoJW3aEzdWzGcg8VVCKS1mkd0oPtGC35C08f1crXaimVlMQP7DjTmZfXmdowl/S7TRBjp+A4GrciED0ab+T0+eURftP8+xarbi9cxaM05ZYSUOmcZ8R1hbtIOF03kH403cKfEaEhF4C8LywBCm2YmNWrhmw9tjKp+YtRhxAO9S+XYwjaXz59usruO6jE1qbP/W2fGXw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0392.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:32b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.23; Sat, 24 Sep 2022 14:11:51 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::85ac:1b92:90f:dc18]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::85ac:1b92:90f:dc18%4]) with mapi id 15.20.5654.016; Sat, 24 Sep 2022 14:11:51 +0000 Message-ID: Date: Sat, 24 Sep 2022 16:11:56 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [KXDr/pT9ROytUDFczG752FMOpBco7UCxJFKzGeHSdAQ=] X-ClientProxiedBy: ZR0P278CA0118.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::15) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0392:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a57c699-6bec-4a9f-5442-08da9e36b9de X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XZQGGpfYnqfzhEOw7is180GRGZiTFIr1bE4YyuN87ZwOwM28x4Mugyd365/eCLexoA3HgHuSKJ5uHJ6zoVpCJceS2q2AHP1sucrB77jYB818lySd7no94awA4CollJf6qEVgPSwI2g/hXAX2wJqSHyNMLrq6uykme+Bte/3ep0HuH3+MgEpoPvWHSlg+GWodqPoavMCg7L02wIbv+jQsDH+Uw26i1EcLrL3L7xW2Ybbo4i3i1ikbNz/yz1slwofmfKkxkY2zkApw1PQx8jqB+ROc5TX6sVHHagUuv5Kuda6bZ9V/7V7z1qbmOcESeM4hHp2v5FXnMjt0R46SVg6xmgg8DUZnmW01l+jAcOgiSLNT5aFWNi1fAt/9Amk5+Du8R0Qolw2HM8tIpTtFUHQqk3aLR0tar85nIRFss3U8ZX3z2fHiIMn81iDcdLj94bfdgQGBKz+vzdKgoLOkDyRYDnQ7z3lvWJwXpvdV2NjDLQUAqI5Dhe2JXbMjV6BX5AT1ysvOS51r63wTIUqihiJAydk35nvXeun4XX0ik8Ey4ytQ6MXiChJ7fb0JK3jVDSNpqfc3E9JNPqasXSiPPeWqGIFqESTjpMPsA1TopC7CXZDjDx4XVf4HCDx4/bVNB73SwjpNA47v3op9HhuflLdajG2AfBOgzlxzwv1r52xEO5f/ISDQIcJmxK+xnbEywG9e X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDVxVHdkNkl0ODlCUVM5QzlzVHp1ckNsVmJrYWF0OFF0N0tOY3EwRi9HOWw1?= =?utf-8?B?RnJabFVFNXFtWjN4OTkrWkFvakJYaEZIQXRPb2JjT3lJNjNzUWlMKzdIc3lp?= =?utf-8?B?QUpMdmtnSnVGWFVMOUwyZUdXbkV5QWZnRldzb0NwY0FPeVZ4L3doYmJBYnU2?= =?utf-8?B?OE1tNzYyWFhKVmFMSFU2MmVsZ08wdkcvR0hjckhWckhKWW85VVkvUCt1cCt4?= =?utf-8?B?TlExazhNQVVuV1YvZGlkRDJTeVJLWHJ1ZWNUbmEyR3dlcnU2cXJ4MkdmSVlP?= =?utf-8?B?VXZLcGZBY0NxOThXSzcvYlZ3Mnd5SG94NEdyU1VnMVBWWTlYRGsvWCtXZXl5?= =?utf-8?B?R2RSVXpra3JsNTNoUGxmWTZET2E1RnRCUnhDTEh0b1JwRWYyM3BkbXAzV0Nx?= =?utf-8?B?SFh2UUxmN2k5WGtnSmRtVUZpa2lZaXpaZzRHS2k2dlEzZTdqSkRrc0tmeld6?= =?utf-8?B?dHFUM0cvNW5KVHo4SmJkWXpYeUZHQ1BBQzI0OHhiRmdCUnBEekFqaWdmVEZK?= =?utf-8?B?T1hrQ2tBTHcxWTJ0dlMzam9GNm44Kyt0MkFHbEgydERCc3pLL21jVjlLaXkr?= =?utf-8?B?R0VlZmtsZTVEYzBsdHlzMHVuYU9oZ2hublNxd3pOVnQwSzdkb09zT21QbCtK?= =?utf-8?B?dFZ2OXg4c1ljQy9HUHdmVVRzaDhUam1FSjZacS9mbFZJOFZIYlVEWStpemNW?= =?utf-8?B?SmFXN2Z6eTVVWDRYVUYzYStFRHlBMk94N1ZLUEU1YmpGVmFNNzg5MXYxRUth?= =?utf-8?B?b3JTM3BJV2lRMm5LbHgwa2d0TlZlbkdNd2hkVE1hR2tsdEtnbjMyamRmZG4x?= =?utf-8?B?ZnlpSGRqNXJ6QisranBnN0k5TnJ2eXZ6SkVyRzVaNDgyQlRiNlhQYkxpTi9i?= =?utf-8?B?VzVXR1F4d2QzTFUyOW1YMkpzZHlscGNiQ0U3YUlkWDcxRHBYViszbUxjSVJZ?= =?utf-8?B?elV4ZGk5U2psVjRZdmpqUnNucVhnR2tZa0hnVzhBcG16Rm91Y3V3VVRGbVZ0?= =?utf-8?B?YnRDZ1VaZklKa21TbTJQL0V0dHdCSFhqVC9hejMwM1llNW1TYjQwQ0dvakk3?= =?utf-8?B?blZwOUVhd3ltYm5SOWNNTENJWnYrVVEvQkRUMkJaU2NqZVMvRGovNmFXUXgr?= =?utf-8?B?QW5NRDdKc2N5WmswSmNEQkJzTEdBU3YzeFhLM2t0dFU4NzhFRWdWMlYyS2pD?= =?utf-8?B?bm4rWCtOd2RlYVlpVG9zNEZIZ24xNG0xekZsZjN0SzZWQU80UU1TUmdYYmZI?= =?utf-8?B?eklod21mR3dZWEtocG9TbXlrcXhrWFlQYjdSa0lnSG8xUys2c3RzaGpqNUM5?= =?utf-8?B?RGpGNXRKU3lzdmp1SDFwOHZ2dk5CeEZuTFRsQlBsU1Z2VVJyYkJnUWV6b1hm?= =?utf-8?B?Sm9GU1JxSlNXOGt1bEhIWVNKQ2s2UkNMWnRmR3ZsTlI1eWRJV3I2OGF0a2Jq?= =?utf-8?B?RE9hT1JhOHExTVZDc1F2bVZIUThxUTYxZSt5amNJMTRJbEMzZGZjYU1vMEtk?= =?utf-8?B?V1BWT1dyUmVLanpUN0JPWm9mY0txc3VYY1gvSXgyZWEzVno2Tis5VXdTWGZX?= =?utf-8?B?d2I2S1lqSGNxcTZpeHJlcTlscWZ1SVhraUdqdDlmK0JwK0JMZ3k0MlJsMUhQ?= =?utf-8?B?U2ZUV2d1TS9MYjBNckVuZnZ0cGxmVnVIZzhua2k2a0xCSXNWWHNQR3czVVZR?= =?utf-8?B?UW1DZzJCbzAvdmdGd2N2d2I1QlRFYld1Qm5KZXlMK0Fsbmt0aVIwK2w5ZCta?= =?utf-8?Q?Y/GeQuRwRE1Wkvp2yXk57E0+16jMzX9lbliOxTY?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a57c699-6bec-4a9f-5442-08da9e36b9de X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2022 14:11:51.2311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0392 Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/h264_redundant_pps_bsf: Don't remove PPS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Andreas Rheinhardt: >> There is no check for whether these supposedly redundant PPS >> are actually redundant. One could check via memcmp which would >> work in practice* (because all content buffers are initially >> zero-allocated), but this is not portable as compilers may >> trash padding inside structures as they wish. >> >> In case the PPS is not really redundant the output is garbage. >> This happens with several files from the FATE-suite. E.g. >> h264-conformance/CVCANLMA2_Sony_C.jsv doesn't decode correctly >> any more, whereas h264-conformance/CABA3_TOSHIBA_E.264 even >> fails in ff_cbs_write_packet(), because the inferred value >> of num_ref_idx_l0_active_minus1 mismatches with the value set >> in the slice (this happens when num_ref_idx_l0_default_active_minus1 >> changes in the PPS; the value in the slice header is inferred from >> the original PPS's num_ref_idx_l0_default_active_minus1). >> >> *: Unless slice_group_id is used, i.e. unless slice_group_map_type >> is six. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/h264_redundant_pps_bsf.c | 11 ----------- >> 1 file changed, 11 deletions(-) >> >> diff --git a/libavcodec/h264_redundant_pps_bsf.c b/libavcodec/h264_redundant_pps_bsf.c >> index f8bab1f109..df9a88a705 100644 >> --- a/libavcodec/h264_redundant_pps_bsf.c >> +++ b/libavcodec/h264_redundant_pps_bsf.c >> @@ -80,26 +80,15 @@ static int h264_redundant_pps_update_fragment(AVBSFContext *bsf, >> CodedBitstreamFragment *au) >> { >> H264RedundantPPSContext *ctx = bsf->priv_data; >> - int au_has_sps; >> int err, i; >> >> - au_has_sps = 0; >> for (i = 0; i < au->nb_units; i++) { >> CodedBitstreamUnit *nal = &au->units[i]; >> >> - if (nal->type == H264_NAL_SPS) >> - au_has_sps = 1; >> if (nal->type == H264_NAL_PPS) { >> err = h264_redundant_pps_fixup_pps(ctx, nal); >> if (err < 0) >> return err; >> - if (!au_has_sps) { >> - av_log(bsf, AV_LOG_VERBOSE, "Deleting redundant PPS " >> - "at %"PRId64".\n", pkt->pts); >> - ff_cbs_delete_unit(au, i); >> - i--; >> - continue; >> - } >> } >> if (nal->type == H264_NAL_SLICE || >> nal->type == H264_NAL_IDR_SLICE) { > > I just noticed that the documentation contains the sentence "A new > single global PPS is created, and all of the redundant PPSs within the > stream are removed". As the observations in the commit message show, > this is just not true because every PPS in an access unit without SPS is > considered redundant, making this filter dangerous. So I would simply > delete this sentence from the documentation. Is everyone ok with this? > Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".