From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AF5564421B for ; Fri, 2 Sep 2022 09:27:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0E11168B9F3; Fri, 2 Sep 2022 12:27:13 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2015.outbound.protection.outlook.com [40.92.91.15]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DD42068B411 for ; Fri, 2 Sep 2022 12:27:06 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZsZOTo2E4NpFySPg4FoljX4AhjI0GgClJBCq7dFBr0AKxh6VikPCD+g8Zutii36F+X9o5jim2MopNyEb/W00KIuuOGTED36u2vUtxJJlnGrrQAliH/596Iap8bqHJQ3Sj9P+4Gmnbdi5rXQYxMCKEIpyYA54Q7MAyB6JdcBZgSDjJTZ7bm8MJrNd0WbH5uj/ZdThOM3nSiTgwmkrT/LkgUUx4fA1O6FIIcA7/smGVg+EymskiHkdusE1nbaJixLrbbKuKhJHstiFKva9FIF69JsOfTmJ66NfEtAf5U1PI2+pn8nRSyPodZuSC9eCJpuVsP3mGLh9CSexWbwNHqWQwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V5OWDEmv2Qs2lI0p/0B6MesAaVLk4II850vnA/Uip1A=; b=CBwfzt2mYIfwPwGIDhNeAwUokDsrCik3ToQzoBq0dXUa9g92e3WomcKNsIGYpSfin2qBJjSKAMRN2nLW4O3x5UBrVYp7/gV/DzwprD7EF78dzfYA/UuRi+EBMltGVL3KFcXmorvr8WGyTOwVhxzgxD81GoS6DaAob2p7qqYKC7VolOIyxpr81AmfdWmyz+rFcKMW1R2M7zD1Xl7oUfIkqslxN8rLmRLXX3IOt1pusieVC3q2wMnbramJQjBgGwOjnIHJ6WCfSlxA/3J2ZCIKL0xCCya6T2jJbEix5vUcqfOPLyBZsjqAqt7pI2kiF5PFDFdM//w7cXPwfj38RVf1Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V5OWDEmv2Qs2lI0p/0B6MesAaVLk4II850vnA/Uip1A=; b=tGrcefGPCVIijttu1VYSEx15UdMq2WLsVaaYlPnjIb8yA6X0ZAnBSJyTaKrat6WVpVfLzgcZO8lZpHYHxsck+iPUm61GuhttvP5uS9c+Ddxccrv4OIEJhJ2L7V267LM1PEC9ZL8HhvM9iMxKIRqZv9NRaWCuYCnoC7zQSH9eNbi4DVYXRLmSJScrdMKEymwduuC94e/4pKU7Y+nWLSU+kjeUaToyjGPPxZESRVHQR82Lt/xYB08G7UOsoSS4LzdPRXmFoISJtw9JT8EmJzeerYoe0DpxnbD+UUcL9QIMFHYPdrRNPMld1KZxKL6RYH4QEanWuZoXUCKi8k2fzftbrA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0862.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:54b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Fri, 2 Sep 2022 09:27:04 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f85a:9a02:f8be:7c47]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f85a:9a02:f8be:7c47%2]) with mapi id 15.20.5588.010; Fri, 2 Sep 2022 09:27:04 +0000 Message-ID: Date: Fri, 2 Sep 2022 11:27:05 +0200 Content-Language: en-US To: Paul B Mahol , FFmpeg development discussions and patches References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [7JXydtRhlLSD5UDIzVz6RGM4w/nGZHJv] X-ClientProxiedBy: ZR0P278CA0063.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::14) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <4918dbb9-4790-75f7-1c93-e27ca4865cc3@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3bbd70fc-9c30-4838-9c6a-08da8cc54c67 X-MS-TrafficTypeDiagnostic: AS8P250MB0862:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +AzWjPk0OImKb9q8Jq3DidA7PKuehycmIg6QqdJ4eirmx7DFrYgTS9N0Ul0GYLTnDZRHUBnfp/eWrMTg3JLoeH+yGnK/edGTxpSHjlaxq0djNzaUxc0xT3OepVAPFR4yaDd9/1SICjrr+UkwN9qhp8qNF45m+PqMHejqc17mmd5tw+sk3+v1vV+HB0/KfsB0QzPC65DIgRpawjVtDF6tfibnPsBCMtuJE0HMGhusFp8d16wB3p9RJyQ7qd5mn/KdXNwO2D9q2YIWy5WtZfTy2nn54zgL3RjP1sYRCO5PWP9+SjOCxsicbA+sWKKn4Ynima9SpIVEFHmFu7ivy6gbjTbnSIjxsICXe4McyeW2AyLOxVt2z67DXyZMEBT0jjvnVL6D6hqUp9pSSzspcZAcvWaomdoFQLeJW6+xUQTDRcabIpc+86/opwNGNG+Bv1ns4rZLiod3RMwM9Xp0a5qF1v2Yfdt9xoWa9Y0yxiEfL2Xi4wQfmtHzs/lDB5DJhmWt9OFsY/K73+qEYVr71XhuJiQhkmvdODXEfJbKS+DEDR86rR5z6rakwpyi+kKj3rF/N/XfLi6XZhSe7pAJmZDrMEB81Dy6aAUk7B8pXQ2xXf0t10QG4TFusaM5iJQz1Dmn5N07THUo+68RuiGUdSVo/7dTY19PoiSI2iUHRv4c/BmYQOpGXJ69FZsUGGIiGs4l X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STB4andLOWFKR01TdGZqa3dvQXk0ZDh6RlRibEcwR3lSTTkreEoxS2p6cENO?= =?utf-8?B?ZTQ2YmtZWDl0NnlZSXVUNktTeG1kc1llZktsd21tVTZMM293Uk9mZXYzaG9h?= =?utf-8?B?ekp0cG4vQ2lIZU9SazVCVi9ZWDJicENoMG5qUUlZMitncnRmTGpCQ1ZxQjhP?= =?utf-8?B?alpITTNLakZIVkdMcTlIZ1JPNWxtNnVPUXJrWi9NOTg0VENKZW1Pb0JhU0hF?= =?utf-8?B?WW4xWVhOdGJlSGR5ams4emdWemdzYlRudDZZaTcvMzltK0hBSVRjNzl2R3F2?= =?utf-8?B?ekkybkdWaUZxMW9XSFdpVC9zWHZlb2FnWkYzTkV4TG0wYWJlSUdKUnVyOWt5?= =?utf-8?B?a1JBODk5SmlSeTlsUU1xYXQwY2lSUG1ieWJYR2E4dzFPV3Y3ak54MmxweEly?= =?utf-8?B?c3ZsVE52RW1KK1FxdW03dHowM2JKbzlXdzZYdHJlQXhwL3hteDdJYkpyakRK?= =?utf-8?B?dk9YeC9hZ2s2MGVzdmJFb29LT0QwaEtPZnVTd3lPZWs5VUkvVjQ5TEpKcmRG?= =?utf-8?B?RHpabXBNT1JwNXltMjRlVVhZTlJVMCs1LzBBOWZKWk9zUmVVak8yMkN2eVI1?= =?utf-8?B?cDErSkdDQmlUU1hSY3RpSDNOQ0NXL2Q0dW9LQ3dudTh1bW5kbTU0NnM4UzdY?= =?utf-8?B?em52K3c4SDZOUkpRUHJzekd5aW9lcnd1YXRBRFFBckxWdFpqdXp0U0hhdDN3?= =?utf-8?B?NFVyVXZLNVI3dnVFS0Qxb0lKR3AxY3BoT3ZBWFZxL3pGTFAwdHBNSTU3YVJ1?= =?utf-8?B?OUc4ZnNESFR5TTBrZHRkMXlnekxSRkZaSHlEVmZ2SWEzeEhlTysyZHFYNzlX?= =?utf-8?B?bERFeTc5dEYxNzVkcXM3cFoyNnoybTExWU14SWM3M2VOUmpXSExObjRQM2V0?= =?utf-8?B?dTFBWGEvcGFwZVEzMnREMWdZbEI0Y29sQ3N1YnJrL0NKNlhkWGJuWXVxd3Zs?= =?utf-8?B?b1VXQmNjdnBwNlZvRE9WSysycnFrbFREU3hUMWhlLzZrVzFsVkV2Y2VPK2V4?= =?utf-8?B?L2o4SXF1cUgyR3dYTHowMHA3UEZCWm5KWUVhSVhJa0laVDhpeC9NUzMzZjQz?= =?utf-8?B?OXhTU2h4QzZBNjBXZEIvSXVGa0tPV0V6bmFhN202dzlQenByNnN2ZTAxNGFS?= =?utf-8?B?a1lHdEtyMUFMQ255TEs1d1pTTUdXN3Qyck1hSitSWUNzSENxSEhmT0FiNmox?= =?utf-8?B?cFlTZnl5M0JDcWh4enNHeFQ5STRub1NqVE9sTXlDaHR6TnVnbDlLRzV0SlJR?= =?utf-8?B?MlFoenlOcy9qY2NvNGhyM2dwRDVWTXVManJ6NHdpRlNQMG9JK0lDNlV2NUFS?= =?utf-8?B?U2NOcDlocXIxcnU2Ni9IMkFhOXlsWmhkZDlqOHluT2xWUVFrYkFzd2FEOFNQ?= =?utf-8?B?V29PekpGam1HMFY1OW9oaVR3ZDhubVk1ejN3TWllQmxXRzhtN2F5OTErSWNq?= =?utf-8?B?cENiMUU3Y0xpKytmZ1BxZzI5REhLclZyWHpSOG51a29jUTM4aFdiZUpqdzIr?= =?utf-8?B?N0o2WXhBNTh0Y090SjdRVGNyQUlabDFmbnhCRHhzQ2ZqMkM0cFYvSnlQOHNh?= =?utf-8?B?SklRQU5MQmRuMEVRUnk4d2RiQkxEZ0FqVU5PdTNxWkR1ZlRPSEVHOVUxWlFH?= =?utf-8?B?a2R3YzY2VWthVS9NbVQydTJxRGU0aW9vOFFnWEJJZHRtS3JsaDlXMXFTRlJv?= =?utf-8?B?emZtaVBSRjA3cnlrRTlzRjlzS3U3MFpzUWdMdHUvS3FUYlVKM1QrOExIanlF?= =?utf-8?Q?1FVOwadSVb0+dVdPkM=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bbd70fc-9c30-4838-9c6a-08da8cc54c67 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 09:27:04.7619 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0862 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libtheoraenc: Do not use invalid error code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Paul B Mahol: > On Thu, Sep 1, 2022 at 11:50 PM Andreas Rheinhardt < > andreas.rheinhardt@outlook.com> wrote: > >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/libtheoraenc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> So it currently does not compile or? > This is in an #else that has apparently never been tested. 800841fd0c6c686c62bdd482e46b6c61b72fa531 (November 2009) added the #ifdefery for compatibility with libtheora 1.0 and 8cb76ef275f7e4be049ac7d6dbfc23186ec73631 (Nov 2012) improved the returned error codes and added the mistake. We could also drop support for libtheora 1.0. > > >> diff --git a/libavcodec/libtheoraenc.c b/libavcodec/libtheoraenc.c >> index 22835553d6..92bf3a133c 100644 >> --- a/libavcodec/libtheoraenc.c >> +++ b/libavcodec/libtheoraenc.c >> @@ -119,7 +119,7 @@ static int get_stats(AVCodecContext *avctx, int eos) >> return 0; >> #else >> av_log(avctx, AV_LOG_ERROR, "libtheora too old to support 2pass\n"); >> - return AVERROR(ENOSUP); >> + return AVERROR(ENOTSUP); >> #endif >> } >> >> @@ -158,7 +158,7 @@ static int submit_stats(AVCodecContext *avctx) >> return 0; >> #else >> av_log(avctx, AV_LOG_ERROR, "libtheora too old to support 2pass\n"); >> - return AVERROR(ENOSUP); >> + return AVERROR(ENOTSUP); >> #endif >> } >> >> -- >> 2.34.1 >> _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".