[FFmpeg-devel] [PATCH] tests/checkasm/videodsp: Don't use declare_func_emms

* [FFmpeg-devel] [PATCH] tests/checkasm/videodsp: Don't use declare_func_emms
@ 2025-03-19 10:48 Andreas Rheinhardt
  2025-03-21  3:28 ` Andreas Rheinhardt
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Rheinhardt @ 2025-03-19 10:48 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

[-- Attachment #1: Type: text/plain, Size: 27 bytes --]

Patch attached.

- Andreas

[-- Attachment #2: 0001-tests-checkasm-videodsp-Don-t-use-declare_func_emms.patch --]
[-- Type: text/x-patch, Size: 2042 bytes --]

From 69cc1770876b15331a448138f77866990ad4b0d0 Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Date: Wed, 19 Mar 2025 11:42:10 +0100
Subject: [PATCH] tests/checkasm/videodsp: Don't use declare_func_emms

It allows the callee to clobber the MMX state,
yet since 1e3dc705dfb9546f0f7ff4479d20baeb4bdb6187 this is no longer
done. So use the stricter declare_func instead.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 tests/checkasm/videodsp.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/tests/checkasm/videodsp.c b/tests/checkasm/videodsp.c
index eb2845a7d9..9751ec8658 100644
--- a/tests/checkasm/videodsp.c
+++ b/tests/checkasm/videodsp.c
@@ -66,13 +66,12 @@
     do {                                                        \
         LOCAL_ALIGNED_16(type, dst0, [64 * 64]);                \
         LOCAL_ALIGNED_16(type, dst1, [64 * 64]);                \
-        declare_func_emms(AV_CPU_FLAG_MMX | AV_CPU_FLAG_MMXEXT, \
-                          void, type *dst, const type *src,     \
-                          ptrdiff_t dst_linesize,               \
-                          ptrdiff_t src_linesize,               \
-                          int block_w, int block_h,             \
-                          int src_x, int src_y,                 \
-                          int src_w, int src_h);                \
+        declare_func(void, type *dst, const type *src,          \
+                     ptrdiff_t dst_linesize,                    \
+                     ptrdiff_t src_linesize,                    \
+                     int block_w, int block_h,                  \
+                     int src_x, int src_y,                      \
+                     int src_w, int src_h);                     \
         check_emu_edge_size(type, 16,  1, 64, 64);              \
         check_emu_edge_size(type, 16, 16, 64, 64);              \
         check_emu_edge_size(type, 64, 64, 64, 64);              \
-- 
2.45.2


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread