From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 686584A8BB for ; Sat, 18 May 2024 16:59:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF79668CE03; Sat, 18 May 2024 19:59:12 +0300 (EEST) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2028.outbound.protection.outlook.com [40.92.49.28]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E05C268C0F1 for ; Sat, 18 May 2024 19:59:06 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g2KBDW8lshFqI63qu6fROP39Xeuoz8jPDXh/r6Z9RtSs7jKAY0DemL895VUkUJBi8Hf3Mp5Ory7Jv7YmUeQZqA5JdGR+eKl+EeUhGaJjYcf/MLkNVyoVP3xSqFsCopF9FBaT0gFZ9wjgkMdjzKpFhITgsMMMt0OxwwaaqNHmi2ZMF+TvuayjmPL+c4U/EbWgzsoeuncbjIjLNwwBX+SNbaaPGO+QHL0vqbH79xg1Xjj998k/fV2CZyXgb9DkO/WAmzemQY1H4KX2OHNXYHcM8pXixvAM9kafGFBGZym3igEKJrlA+576CJ5jGvuyH5IldAxScjH17ZyHipBn2sPUfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yzat462vUbhZvFsiFlzgRPNJlw50dt9FrO2NMBwbEGM=; b=erjHq+7KvMk50dYe4T0WxDe74UvmZawbAaGhN3mPCW9I1CeDHswuG9FYlegwMW6oWXbKtkPk1K1zeSkevG3YhGZtRQtCLm5mpkbKa/hyM4+/+h+eDE20XCZtHTEVVveJTIGZ5D2mXShgJOxtLmsTIKFmEfejUqnro+soFAOLScmlJf2M89KtkyTLkYEdQI6iaTZRRjFJbU7E5MmmigsIDK8iDIvjeqQ3+UeBkNrPm/jAwy0+71xQpi5+okJ67BuhtWkFQDFan6WgIxohZUK4k9XStPZ52YJ7Tl79soswN/T1q/K48he4TXTNqmA0CtO/2AI+YJXNY9L0CIvc490lWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yzat462vUbhZvFsiFlzgRPNJlw50dt9FrO2NMBwbEGM=; b=GqRifL4PHnZcyu/cIkIEqWHFGXVCrzNxSbs4OxsOgWJJSM6Ho2oc/vwR72uHZV1uxMPr517WVua9hGzenfB502p/YCR1eTY4yI7DXWtax+he5++vmRsoQWTQR4enaxfOtLrCYgXEa/vEpKWBDOEurCp1jg0JockVRyqLFx1D26RT+4mtnAdy5zhSyR8ptOL5vjy9Qs4rI7vtdFEuPBNCT4+IR3q0Iak7og6mnt9rZVE+jKDfHarShDrNAScvPD3xS/AkNMTzxwS5nUoTWwHhC7CQQNH1iobPQFCVYw9sKLzSZS+LhOaN8SznsTPRLR6e7jjzuh0/s98O7LY4OjQa4A== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PRAP250MB0490.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:290::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Sat, 18 May 2024 16:59:05 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7544.052; Sat, 18 May 2024 16:59:04 +0000 Message-ID: Date: Sat, 18 May 2024 18:59:00 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [dnOqMnAgujeL8IrTJ0X6qcaQ7W7wkqrCSg/8dALC9AU=] X-ClientProxiedBy: ZR0P278CA0173.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::8) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <0605a509-f1ee-42fc-8684-7999a87fe3f0@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PRAP250MB0490:EE_ X-MS-Office365-Filtering-Correlation-Id: 17cd4608-fdd2-480e-e8fe-08dc775bd317 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: AedylBdz2yC8cqQL5rX3XyFN89+mjo5S3YKaY4xFhtrqDF3UTB/s2n+V/gX1tXVYjnblcm1Ww7zXboAzs0LNAFZiglnv+0WzcSpsRdiEpcMKuUwk7UDX4gGOtV+DguEqoh1rwB8jex689b7/+M3bID269MWqriLCENPSZjOHXzXDbqjvabLovHtzg8s4swAE2Wcreae6jPxZ8DfxEnw4fPfQKwZx8mnWp/O5u9Hij5AXNJHu6ZZMKQCSNmMIGNylWW/YJw7UiedoDIwlxnVvhjU+WXNp55Hg+sbHa62WugQjbxODFoLu5yCkiz5fxTvKAHTA8ErKpFNYClCGLklbvKy5cFdHpWFnjm2gkKeaWvtY2xyRZh3Zi0KxYJmb4inrC9sGNWsTcZm31KLd1j3+1WldcESIMQfbEurEqT3tenROru6I4joqtP04dqI/HKEHjs2lVnqH/hYbPqoCPreivSEekWSGCptQHzGjzf/LD2oIi2bjBZl4Vox560h4rwY1nT7wRvrao2VFw3VZq8ennnm15CVvekHeplYYQ2rifM0Fv5t+tcnFk4g1IvVYxtMp X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDQ4dnNXRTRmQWFiODVxWDJFM25XcmdGVTduRE5wM0N2b1kxcTRrZWZ0bWg1?= =?utf-8?B?bFE0RENtdndsbDhrYTRWaGJCVk5HbGlzb1RSRHNoaWRTM2ZHYURmaVBpZXdF?= =?utf-8?B?dWF0dkxhRG01MGxiM0EyRUVEZ0tOd1RadURObHR1dTI1UTJvOE5GWENJeFMz?= =?utf-8?B?bDNTQ0FSbTJOUzdpM1NkSnF6Y2lWOW5Dc25oYXo4MlBwK1JrazFyaFJocHZM?= =?utf-8?B?RTJ3K1FEajgyakIzenZDcWpBanZYRjBFMGhad09ZYzB1bVYyRHVsclNQcDE4?= =?utf-8?B?TlRhaWlYWG9YMjJXUElQa3VkeHBrQjlFT1VZY0ZmcS9sSW1EM1JqRHZ2QUZK?= =?utf-8?B?TGEvekJmWTdTblQrR2M4enNmN05QQ3NuWlNZRERFd0FybDdKMkxiSitZMU1y?= =?utf-8?B?NkVHT3ZWMzVnWjdnNUNWWGZXd0hvdnJJMTJYa1RPUDkvYmh0dmQ5dk50ZThG?= =?utf-8?B?ajRsMTRjWXhuNTk3cDBqcWV1VXFIZTJqM3YxY1dFRVg4VEhKTCtWVmFRRE0w?= =?utf-8?B?aTlyTXVMNHNYRkRzL3pWYnZLcml5Uy9maXBBcXY3SHZ2QmZRMlNXVE1NcjEz?= =?utf-8?B?VjJhL3UwMUkwdG9XWHhRbUNMSUhsWllTR0tDK1JRb2cyaVhGSkdzU3lUbUwv?= =?utf-8?B?cnNGUncydURUOHFMUWFzME9mcENPUUtZc1dpa2tHQjJBSDRhaXVLZlhnMlp5?= =?utf-8?B?ZlRxSklGdEo0VjVwM09mMUlEK1pLbHNHL2JsN1A2Q2U4UytBb3ZkN3UvYW9w?= =?utf-8?B?NmV4SkVESDZwSXlwS3JyYndweFRWVVRDaWQ4NzlQRFJ1eXduSW1hT3NYcXhH?= =?utf-8?B?blFhUGt0bTVXZU4vQm85MklGK1NEczhMbWQ1S015d2h1cmN4ZW9jV2doUk9L?= =?utf-8?B?M0d0cHN5V0swSjZ2MkRrZVhxWklGWldMMHVEM1NmaWNSa0ljeE1pcU5MNzJB?= =?utf-8?B?ZmxmdDNsM3JOajhUMzZzNE1GSmc4Z2Y2NmtjZTRVbHgzUUhuNzgxZGQ3blhZ?= =?utf-8?B?L01RRFdOdHF3aUNSeXY1NGtWY3ZrdlRKMXF5ODMvR1hjOExJYW1CTHBpaTF5?= =?utf-8?B?UzFqWnFpZjcwOE9wcGhtSVNreFBGUmFWVFhQODh2M3VDVlZpbWN2anRWUE9o?= =?utf-8?B?eXE4Tld2bmRodnYvNW9zRW5pR1VyaVJyU05FVS9xL0h3UlFrUFJTemxvS3NQ?= =?utf-8?B?dEl6YXhuVEV5NkVIdmlLcHZEL3ZrSlJad3JoQzAzWGx2SkY0bC9rZ3l5cmdD?= =?utf-8?B?dEJGQ3A3TDVaTDNGK1o4MFRQVWtkczRnS2VKbXBkVWpFbVRpZ1c5NEJFWnpx?= =?utf-8?B?TDcxSGJzOTUwdCsyMmJYRUJUbmo3UXUvMmg2UW1mZkVuTVpVVnZHWHpCVzdj?= =?utf-8?B?UjZ0dGhqVzQyaFAvem1zTDZzT2hhYUk2OXhTNjZmVHdsbHBseFN4dWEwYm1F?= =?utf-8?B?bW1kRW1TZFdIU3pRTEdYa3ZXQ2tNeGRzd2JlVUw2OTQvcnN5NExXZGMwdHpZ?= =?utf-8?B?TU45cTA3ZC91ZG8wa01qMUFRaGxyM0RCQnY5R1czRWpvei9EcnVKNS9NdjQz?= =?utf-8?B?dGZFelVBZjRLdHdWeUF2TVpsaEp6QXRFOTd2ZDV4K2NWdmFPTW5iaS9RaWt0?= =?utf-8?B?NHlNUmgvNUJzUGhteHcyZFRNVFFza0JZT0ZZR00xbUxWQy9JOWgwanlzNkhY?= =?utf-8?B?QUVtLzE3ZnNGbFB0SVBIMjk0RC9KdVFJUm1acFZGLyt4bDlQN0I0MCt3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17cd4608-fdd2-480e-e8fe-08dc775bd317 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2024 16:59:04.9044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0490 Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/adts_parser: Don't presume buffer to be padded X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > The documentation of av_adts_header_parse() does not require > the buffer to be padded at all. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/adts_parser.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/adts_parser.c b/libavcodec/adts_parser.c > index 6c22c86ef2..81e2669149 100644 > --- a/libavcodec/adts_parser.c > +++ b/libavcodec/adts_parser.c > @@ -28,9 +28,14 @@ > int av_adts_header_parse(const uint8_t *buf, uint32_t *samples, uint8_t *frames) > { > #if CONFIG_ADTS_HEADER > + uint8_t tmpbuf[AV_AAC_ADTS_HEADER_SIZE + AV_INPUT_BUFFER_PADDING_SIZE]; > GetBitContext gb; > AACADTSHeaderInfo hdr; > - int err = init_get_bits8(&gb, buf, AV_AAC_ADTS_HEADER_SIZE); > + int err; > + if (!buf) > + return AVERROR(EINVAL); > + memcpy(tmpbuf, buf, AV_AAC_ADTS_HEADER_SIZE); > + err = init_get_bits8(&gb, tmpbuf, AV_AAC_ADTS_HEADER_SIZE); > if (err < 0) > return err; > err = ff_adts_header_parse(&gb, &hdr); Will apply this patchset with the remarks by Andrew and James addressed tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".