* [FFmpeg-devel] [PATCH] avcodec/libtheoraenc: Do not use invalid error code
@ 2022-09-01 21:50 Andreas Rheinhardt
2022-09-02 8:28 ` Paul B Mahol
2022-09-04 22:52 ` Andreas Rheinhardt
0 siblings, 2 replies; 4+ messages in thread
From: Andreas Rheinhardt @ 2022-09-01 21:50 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavcodec/libtheoraenc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/libtheoraenc.c b/libavcodec/libtheoraenc.c
index 22835553d6..92bf3a133c 100644
--- a/libavcodec/libtheoraenc.c
+++ b/libavcodec/libtheoraenc.c
@@ -119,7 +119,7 @@ static int get_stats(AVCodecContext *avctx, int eos)
return 0;
#else
av_log(avctx, AV_LOG_ERROR, "libtheora too old to support 2pass\n");
- return AVERROR(ENOSUP);
+ return AVERROR(ENOTSUP);
#endif
}
@@ -158,7 +158,7 @@ static int submit_stats(AVCodecContext *avctx)
return 0;
#else
av_log(avctx, AV_LOG_ERROR, "libtheora too old to support 2pass\n");
- return AVERROR(ENOSUP);
+ return AVERROR(ENOTSUP);
#endif
}
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] avcodec/libtheoraenc: Do not use invalid error code
2022-09-01 21:50 [FFmpeg-devel] [PATCH] avcodec/libtheoraenc: Do not use invalid error code Andreas Rheinhardt
@ 2022-09-02 8:28 ` Paul B Mahol
2022-09-02 9:27 ` Andreas Rheinhardt
2022-09-04 22:52 ` Andreas Rheinhardt
1 sibling, 1 reply; 4+ messages in thread
From: Paul B Mahol @ 2022-09-02 8:28 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Andreas Rheinhardt
On Thu, Sep 1, 2022 at 11:50 PM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/libtheoraenc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> So it currently does not compile or?
> diff --git a/libavcodec/libtheoraenc.c b/libavcodec/libtheoraenc.c
> index 22835553d6..92bf3a133c 100644
> --- a/libavcodec/libtheoraenc.c
> +++ b/libavcodec/libtheoraenc.c
> @@ -119,7 +119,7 @@ static int get_stats(AVCodecContext *avctx, int eos)
> return 0;
> #else
> av_log(avctx, AV_LOG_ERROR, "libtheora too old to support 2pass\n");
> - return AVERROR(ENOSUP);
> + return AVERROR(ENOTSUP);
> #endif
> }
>
> @@ -158,7 +158,7 @@ static int submit_stats(AVCodecContext *avctx)
> return 0;
> #else
> av_log(avctx, AV_LOG_ERROR, "libtheora too old to support 2pass\n");
> - return AVERROR(ENOSUP);
> + return AVERROR(ENOTSUP);
> #endif
> }
>
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/libtheoraenc: Do not use invalid error code
2022-09-02 8:28 ` Paul B Mahol
@ 2022-09-02 9:27 ` Andreas Rheinhardt
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Rheinhardt @ 2022-09-02 9:27 UTC (permalink / raw)
To: Paul B Mahol, FFmpeg development discussions and patches
Paul B Mahol:
> On Thu, Sep 1, 2022 at 11:50 PM Andreas Rheinhardt <
> andreas.rheinhardt@outlook.com> wrote:
>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> ---
>> libavcodec/libtheoraenc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> So it currently does not compile or?
>
This is in an #else that has apparently never been tested.
800841fd0c6c686c62bdd482e46b6c61b72fa531 (November 2009) added the
#ifdefery for compatibility with libtheora 1.0 and
8cb76ef275f7e4be049ac7d6dbfc23186ec73631 (Nov 2012) improved the
returned error codes and added the mistake. We could also drop support
for libtheora 1.0.
>
>
>> diff --git a/libavcodec/libtheoraenc.c b/libavcodec/libtheoraenc.c
>> index 22835553d6..92bf3a133c 100644
>> --- a/libavcodec/libtheoraenc.c
>> +++ b/libavcodec/libtheoraenc.c
>> @@ -119,7 +119,7 @@ static int get_stats(AVCodecContext *avctx, int eos)
>> return 0;
>> #else
>> av_log(avctx, AV_LOG_ERROR, "libtheora too old to support 2pass\n");
>> - return AVERROR(ENOSUP);
>> + return AVERROR(ENOTSUP);
>> #endif
>> }
>>
>> @@ -158,7 +158,7 @@ static int submit_stats(AVCodecContext *avctx)
>> return 0;
>> #else
>> av_log(avctx, AV_LOG_ERROR, "libtheora too old to support 2pass\n");
>> - return AVERROR(ENOSUP);
>> + return AVERROR(ENOTSUP);
>> #endif
>> }
>>
>> --
>> 2.34.1
>>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/libtheoraenc: Do not use invalid error code
2022-09-01 21:50 [FFmpeg-devel] [PATCH] avcodec/libtheoraenc: Do not use invalid error code Andreas Rheinhardt
2022-09-02 8:28 ` Paul B Mahol
@ 2022-09-04 22:52 ` Andreas Rheinhardt
1 sibling, 0 replies; 4+ messages in thread
From: Andreas Rheinhardt @ 2022-09-04 22:52 UTC (permalink / raw)
To: ffmpeg-devel
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/libtheoraenc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/libtheoraenc.c b/libavcodec/libtheoraenc.c
> index 22835553d6..92bf3a133c 100644
> --- a/libavcodec/libtheoraenc.c
> +++ b/libavcodec/libtheoraenc.c
> @@ -119,7 +119,7 @@ static int get_stats(AVCodecContext *avctx, int eos)
> return 0;
> #else
> av_log(avctx, AV_LOG_ERROR, "libtheora too old to support 2pass\n");
> - return AVERROR(ENOSUP);
> + return AVERROR(ENOTSUP);
> #endif
> }
>
> @@ -158,7 +158,7 @@ static int submit_stats(AVCodecContext *avctx)
> return 0;
> #else
> av_log(avctx, AV_LOG_ERROR, "libtheora too old to support 2pass\n");
> - return AVERROR(ENOSUP);
> + return AVERROR(ENOTSUP);
> #endif
> }
>
Will apply this patch tomorrow unless there are objections.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-04 22:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 21:50 [FFmpeg-devel] [PATCH] avcodec/libtheoraenc: Do not use invalid error code Andreas Rheinhardt
2022-09-02 8:28 ` Paul B Mahol
2022-09-02 9:27 ` Andreas Rheinhardt
2022-09-04 22:52 ` Andreas Rheinhardt
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git