Re: [FFmpeg-devel] [PATCH] lavc/vp9: Fix regression introduced in 0ba05857

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavc/vp9: Fix regression introduced in 0ba05857
Date: Tue, 23 Apr 2024 14:14:02 +0200
Message-ID: <AS8P250MB0744AE9096D518DE8D2CDFA08F112@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240423043258.30883-1-haihao.xiang@intel.com>

Xiang, Haihao:
> From: Haihao Xiang <haihao.xiang@intel.com>
> 
> It is possible that ff_progress_frame_await() is called but
> ff_progress_frame_report() isn't called when a hardware acceleration
> method is used, so a thread for vp9 decoding might get stuck.
> 
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---
>  libavcodec/vp9.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c
> index 3adfb98f2d..6e2d18bf95 100644
> --- a/libavcodec/vp9.c
> +++ b/libavcodec/vp9.c
> @@ -1735,9 +1735,9 @@ static int vp9_decode_frame(AVCodecContext *avctx, AVFrame *frame,
>          if (ret < 0)
>              goto fail;
>      }
> -    ff_progress_frame_report(&s->s.frames[CUR_FRAME].tf, INT_MAX);
>  
>  finish:
> +    ff_progress_frame_report(&s->s.frames[CUR_FRAME].tf, INT_MAX);
>      // ref frame setup
>      for (int i = 0; i < 8; i++)
>          ff_progress_frame_replace(&s->s.refs[i], &s->next_refs[i]);

LGTM. Sorry for the breakage.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".