From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH 2/4] avformat/dvdvideodec: Don't store AVInputFormat* Date: Sat, 2 Mar 2024 16:43:25 +0100 Message-ID: <AS8P250MB0744ADFC92FC0051E49017D88F5D2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw) In-Reply-To: <AS8P250MB074422FE8D5933916C3A0C358F5D2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> The inner AVInputFormat* of the inner mpegps-demuxer is only used once (in avformat_open_input()), so don't even store it. In fact, just use ff_mpegps_demuxer directly, as this demuxer has a configure dependency on it. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavformat/dvdvideodec.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index fd1f640560..ef2d4e6df4 100644 --- a/libavformat/dvdvideodec.c +++ b/libavformat/dvdvideodec.c @@ -136,7 +136,6 @@ typedef struct DVDVideoDemuxContext { int opt_trim; /* trim padding cells at beginning */ /* subdemux */ - const AVInputFormat *mpeg_fmt; /* inner MPEG-PS (VOB) demuxer */ AVFormatContext *mpeg_ctx; /* context for inner demuxer */ uint8_t *mpeg_buf; /* buffer for inner demuxer */ FFIOContext mpeg_pb; /* buffer context for inner demuxer */ @@ -1210,12 +1209,9 @@ static void dvdvideo_subdemux_close(AVFormatContext *s) static int dvdvideo_subdemux_open(AVFormatContext *s) { DVDVideoDemuxContext *c = s->priv_data; - + extern const AVInputFormat ff_mpegps_demuxer; int ret = 0; - if (!(c->mpeg_fmt = av_find_input_format("mpeg"))) - return AVERROR_DEMUXER_NOT_FOUND; - if (!(c->mpeg_ctx = avformat_alloc_context())) return AVERROR(ENOMEM); @@ -1246,7 +1242,7 @@ static int dvdvideo_subdemux_open(AVFormatContext *s) c->mpeg_ctx->correct_ts_overflow = 0; c->mpeg_ctx->io_open = NULL; - return avformat_open_input(&c->mpeg_ctx, "", c->mpeg_fmt, NULL); + return avformat_open_input(&c->mpeg_ctx, "", &ff_mpegps_demuxer, NULL); } static int dvdvideo_read_header(AVFormatContext *s) -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-02 15:41 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-02 15:42 [FFmpeg-devel] [PATCH 1/4] avformat/dvdvideodec: Explicitly return 0 on success Andreas Rheinhardt 2024-03-02 15:43 ` Andreas Rheinhardt [this message] 2024-03-02 15:43 ` [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers Andreas Rheinhardt 2024-03-02 15:47 ` Andreas Rheinhardt 2024-03-02 15:51 ` James Almer 2024-03-02 16:19 ` Andreas Rheinhardt 2024-03-03 2:31 ` Marth64 2024-03-03 2:32 ` Marth64 2024-03-02 15:43 ` [FFmpeg-devel] [PATCH 4/4] avformat/dvdvideodec: Reorder allocations to simplify freeing Andreas Rheinhardt 2024-03-03 2:34 ` Marth64
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AS8P250MB0744ADFC92FC0051E49017D88F5D2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \ --to=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git