From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C423B451ED for ; Thu, 12 Jan 2023 04:31:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CFC5D68BAA6; Thu, 12 Jan 2023 06:31:34 +0200 (EET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2041.outbound.protection.outlook.com [40.92.75.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 75FE468BBE9 for ; Thu, 12 Jan 2023 06:31:28 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jBWS0oKCAenwFMIHeu2CZEFLW8Z6jR0xw99Lvbl7IgwYvMH1YjGw7aEB1odp/O7JEZDiBdSlOqMybO0myiqy2VfsaSXU8C2fN7h7ur/qKbzkB7oRVxqPD1qPSa7HtLb8zRJ78ctsjRjCGDf6dmg/ZZ9Beab8TMnCFzDDL2TXyNd4ukghU1U4VpTxB9dy+XBxpTn1Lw8HunKq7FcBvWRqOV8MzeNwuYYOUuXqbqI4bYBOpq5vzr6yNAj+iwUHtov/9k3I8fZo0url/uZ6SZAxXwgxf5t1n22Av7pGkNmXc5McKQgO4eVMoLuvV7V/liF8ScJskV0zv07MtJ+G9G5mAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ra7Hn0Q9HK7u5PE7TTLSHFZCI0RtE/sP42whobnWb1U=; b=eziGXwD5t0aofiahweBcSykXKfaiAaOMBLfENUZeVnW4IIfZJAuAfMGKL3/uhYMdjBweZZbK0XqfvQbkqccrMSlnYuviMlnF3L6CI8m+1nrP1p4o2AfFlQ4+ELRMQzHdnQ8Anbkcb221BV5EsPdjZ1FssSo7TN35ZEnXNDARM6ayn3bzSmILnaUUNTI23HBy0zggIIXOthtvQGE1La6tBgxFcjcT6FY8wTRVgPvj4FZ1EEpk8JMX2GoKXxFoiIgy4TIEEKGtRSiEjocngpEQq+wptm3lonJsIxKJnzmtoNMzU91R/3TfF1aOmfEsu+vIwGQLRhUYGxICeMKGydAGaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ra7Hn0Q9HK7u5PE7TTLSHFZCI0RtE/sP42whobnWb1U=; b=nxV8oPdinjQv+ERSkEZZ9H2VPHSNwfifaTiwMliF5stxsAnr7Nn+L6MHoeOy9uknvR9LomLiu+v0RGWP8uV1ITf+BYFF8ADZb/NXRL08hxlsWsHJ5Fk0nEkXum+24dttFz0LnHX55yX8aGH/hd1gJAlvTbkjUGdnERSdA0RUDlvY1w/Vnrn6y96jUAV2M54lzX5pbi8YW2OxsA1rs+DpsnXlYSaN3ADWlC/OYKeCZ1oW9TysZFxF9Q28a0EPib2wDXXXjk5ohSW4MsFXAS5AvfNyXKSONHxq19918imOLkSaRbkhFfwb5WgMnaS9inhVoFp/fArqrJB0KAF27iN1Og== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS4P250MB0896.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:58b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 04:31:26 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::c37:cabe:316a:60b2]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::c37:cabe:316a:60b2%4]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 04:31:26 +0000 Message-ID: Date: Thu, 12 Jan 2023 05:31:55 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230109071210.1829699-1-haihao.xiang@intel.com> <20230109071210.1829699-5-haihao.xiang@intel.com> From: Andreas Rheinhardt In-Reply-To: <20230109071210.1829699-5-haihao.xiang@intel.com> X-TMN: [S1Vueas53uUibQI8Ik1jhPfpo0ymq9mJ] X-ClientProxiedBy: FR3P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::14) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS4P250MB0896:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c8fe3c1-d1a2-4d6e-ef4d-08daf455de2f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: POuvbNQLKAQ/7drXc3bcuTG+k+iRx8A55r/Vtyxw5kykrK086qAXsfG84RvxLjAoZbQQzFmLhv0VGXJ1xsFxyDwhR+eS8fqc3hQZ+TyVKI10uMqMn86kDCudcNgMPQL1rzjEPFuz2Y+3RxohJyd+k+vxZN7iZ0T3g7OjrbL7ljVgp9opXp6FOiyR3cobxlJ9qGGui7rUTA0XJlrQNdWdHKIxG67puo5jrmfxYT2UCTDSOjGNTQAyVhm+jUpfnHcFxuTReQ/CmvIB8u2k9TZSZo/KYLNa5WmqQd9W3CVx3UnnBvOy53bhX7eHNSvaT9y3HCvrjIsVAa4tKVsDrRkrVdb+rubp87HHUXHpQSq4TSdUR+d1HUJDtahBKIa7BeRa2IUTrid0SujxZVxBTfOcXBKz0YR9pIrHIYfHv0GCUYJ7OHgMcaEH/U5ML1KglSALJnvqvq9g+zpG7roVrD9BSWF5bOywlY4dc+Fjb8JXIguLW32K5e8knOhoPrekwmpJxCdTSZT08BVu+vf770LZtaT025unm4wrJ853WKNao/fOOvRQFXey0S4IonV6pf+tzxTaR2Kv8KfoMG50XMRO8L/mmP6Fm98AI/7MceDpGLfwNHb/3j6UBHIoJb1SOeksemMKvk0eWgCAIdtkCibu4OEtXvIIICIxaPq1GbQxE0E= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmdzNEdOK0VNbUdJbXZtSHI0V29RZmRCRnhGMmoxT3lOUkNqLzNhN21SaXhw?= =?utf-8?B?SERveEZpc01TL0lvU3pwVGhPVzR6U3h2ODBQL281S0pHS0RmWEZhT2I5QTJN?= =?utf-8?B?MGJDU3RGVWRvb0VUcTJXUHE3UlhTazlTSTNkWVpUUWM1a2wxSjNySGNPb2o3?= =?utf-8?B?RC95TkJTTFl6TTRJdSs0N2hDbE5PM1FVbHk0bysraG13UUNsdGtlWXdzTkRp?= =?utf-8?B?NitSL0RxOFpZSkVpa3gxdWhGZDIwSTkrbE14MXBZNVNVVDhnZWZIaEdxanAv?= =?utf-8?B?eXd0Yk5vemNVaG9FeEZaeXRyWGExc0JqYXVEejc4MTBYL2tVU25zOGF6dTNS?= =?utf-8?B?ZS9GUXVKczc4Z1B4YzN3czM1dnEwcVdpQXBJY1N6WlVPZkxLM3dwOUNlTEpC?= =?utf-8?B?dEJFczNucWxOcVMwMjBZZTRrQlZ4ekRVTHJnbHlXL1ExOFJ1a1BVLzlhR0tL?= =?utf-8?B?K2xBOTJUWGFaVjg0Q01QZTA4OE00S2JlcVM3SlRmSFFvemlrd1lsQmR1bmdh?= =?utf-8?B?U1lWcVJHVVZZWWcycUhUWldudUxpZDRLMERFQm9nQTZlM2xFTmhVV3lGZUdQ?= =?utf-8?B?QU81bXdvTVNqaVBwV3pBTUtTcXpQYnF2cGxKem93K3lXOHpsUE9Kb0I5REN2?= =?utf-8?B?aEsyV2g1RFBTQk56RUFJYzE3dFZCbHNHdGxxczdZemc3UVZhWThYYkhZSncy?= =?utf-8?B?NFZHYUN3MW4vU1cwcWdGdWkwRCt3L0FGTkZRTDRxWVZUM3hPckY1OVh6M0oy?= =?utf-8?B?eGJYTENwYTZleUpQOG9uV3hTMVIyejI2VzBUdFdZbnk5ZGlkQXdFc1orNjZ5?= =?utf-8?B?dXBHcnc1QzRScm5ud0hJREhkTHJJbWo2ZEd4TlNlNlZWWVlnZmhyZ0ZWMEFx?= =?utf-8?B?Skllc1EwYkZ6emRtaThzKzBtcjVVYlZFTDMvSXJPb1RNeGkwUURsa0ErL0pv?= =?utf-8?B?dFl0UE1MYUpRSkVqKytKdjMwZ3VVZ3BtM3NwazBsWUdoZUdVRTlaUmRrSGxh?= =?utf-8?B?TnJwWHE3N2pJNUZtbENtaXNlcTBRMmlwY0c1VDR2bUdzZ1I0NUszcUpUMWQ1?= =?utf-8?B?QVdiWmw4S29JM3FLVWdJTDI1STdTcUVMT3RWcUQ4NWUrR09lYkdabG91blN6?= =?utf-8?B?MzM5SWdSWUEwdnkrMmVZWXJlamh6R2gyVTFVVmc3MGdYZ09DNmYreExGaERW?= =?utf-8?B?NFVndzdYbllxTytyT3hVOHFSR1JXM0pOcmsvd2dQaUpYdXpMQU9nVVlYQWNN?= =?utf-8?B?VlV5VHRia2FZTzVJbDk2ZitCa2g0cjJTOGtjd1lXYnk4SXdsUSsrazBtUGta?= =?utf-8?B?Z04wdEI1NVRBQnVibkN3MTVOZ254OVpjZVplZGczN0JHN0ViNEJSOUNTYm5z?= =?utf-8?B?ditsTXJaL0U4QU51eThCT3RnbE5nK0lwWTFGYkpHZndpUGJtY2kzVjV1Q0ZS?= =?utf-8?B?L3FzYytCc3dBbjJtNDZ0MW1UbUNRSjVsbDI0cVh1YkQrNHY2MHY3ZmpFTjNo?= =?utf-8?B?Z0Ztcmd5RWNwaGE1a3ZGTEEvaVh0bnhBY1lDTEE1OExNQ2RJdnlNeEpwTmxQ?= =?utf-8?B?bnhaYUJhcFh2Y1p0MHBmNzdLNENPbUJvYkRUQm01c1ZhakJwcFZrSXJtS2ZK?= =?utf-8?B?amtwZExRSGpFdUQrbGd3bVN0SFEvbFlLN0Y0aE1KY0tvcllobTRna0JPd3BL?= =?utf-8?B?dStVN3hnb292L2thLytuWHlKaksvRHhUTVk2aVlTQlBTSVFFMmg3TmxmcXQr?= =?utf-8?Q?7O2gOKQxp1zjU5cQoM=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c8fe3c1-d1a2-4d6e-ef4d-08daf455de2f X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 04:31:26.6708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P250MB0896 Subject: Re: [FFmpeg-devel] [PATCH 5/8] lavfi/vf_vpp_qsv: add has_passthrough flag in VPPContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Xiang, Haihao: > From: Haihao Xiang > > QSV filters may set this flag in preinit callback to turn on / off pass > through mode > > This is in preparation for reusing the code for other QSV filters. E.g. > scale_qsv filter doesn't support pass through mode. > > Signed-off-by: Haihao Xiang > --- > libavfilter/vf_vpp_qsv.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c > index 2a7b06fa33..b04307b644 100644 > --- a/libavfilter/vf_vpp_qsv.c > +++ b/libavfilter/vf_vpp_qsv.c > @@ -102,6 +102,7 @@ typedef struct VPPContext{ > > int async_depth; > int eof; > + int has_passthrough; /* apply pass through mode if possible */ > } VPPContext; > > static const AVOption options[] = { > @@ -269,6 +270,8 @@ static av_cold int vpp_preinit(AVFilterContext *ctx) > vpp->contrast = 1.0; > vpp->transpose = -1; > > + vpp->has_passthrough = 1; > + > return 0; > } > > @@ -552,7 +555,8 @@ static int config_output(AVFilterLink *outlink) > > if (vpp->use_frc || vpp->use_crop || vpp->deinterlace || vpp->denoise || > vpp->detail || vpp->procamp || vpp->rotate || vpp->hflip || > - inlink->w != outlink->w || inlink->h != outlink->h || in_format != vpp->out_format) > + inlink->w != outlink->w || inlink->h != outlink->h || in_format != vpp->out_format || > + !vpp->has_passthrough) > return ff_qsvvpp_create(ctx, &vpp->qsv, ¶m); > else { > av_log(ctx, AV_LOG_VERBOSE, "qsv vpp pass through mode.\n"); I don't get how this patch either. In the current patchset, has_passthrough is always 1 (after the preinit callback) for the vpp_qsv filter. The code here is only used by said filter and no other filter at all, so has_passthrough is always 1 in config_output(), i.e. this whole change is pointless. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".