From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8C9A548EBF for ; Thu, 29 Feb 2024 11:51:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF69268CD95; Thu, 29 Feb 2024 13:51:07 +0200 (EET) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2057.outbound.protection.outlook.com [40.92.49.57]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1F00368C830 for ; Thu, 29 Feb 2024 13:51:01 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EhWCfesigObTAFL6CyLFm1LTEENvAJcV+vlwTPRkrhmOj3hLbsCmqwrApWhdl5Be/FKMxdtgqqSYdfah7nTK6HeH/u8ynPvsaXTUAR+ukYZkerJTbezKc58Z1lzP+xYXIprNp3/fC+RV54xlant9x4QZKzNN1Va2QIB9Efctcm5xNPPPkTN+0R7Lpii7oUtCWiuJgyYeqzb/stcP8iyhzCduu01NC4yZoPHSgxH0hsSLoAcCHE2KwfqkXNsfJ8Elc8dI9RN+qeOR0f8ltMv7w4MuvSvmEArzFUCOZkeTppeuVhs1fErOGExiivBp5rBayvqjOveFwzv2jcndkDhptQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WHoASWL7vIfoMOL8e2f2dNFDvNmSisjXwoOY+g9NAp0=; b=c2RgfMe/WUvfFx2jY6T4MqUMB4Cx8/44zlDIrXKEHok0z99FCYfg2DcBcLhIDzx0d6tkombwbSUloQdJGdLXTF8X2HUEN7neVfC/+/511FByDqX8fl+aiSZDaZ3IkULUmFaEcsB9XFnl0vK1ma4oaVdvN8miKvLy3TviwXtBwJ6cC0PCp1rfjh9biKDiyqVdOVx9t2LMYYYRKL/29g549Q7rAKgr68/lyydhu6LKzlA5bandhmjqgEPk1fw8V8DQ/MAGmQP6PBn5I2ihR5hHAoJz6+wR/R5oGk2BPFOSK4CuCXVETrMc7ghHeOBiRWh2v+dnBr5l2hz7vBwxn+SuBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WHoASWL7vIfoMOL8e2f2dNFDvNmSisjXwoOY+g9NAp0=; b=sy0G39szYDABaLNzFDYqzbEPHHO2FnrHW07cevp+VY8nykJbhvZ4Kzbot68GzjdwDqw+Bp+LvIioaJ0jvHrYNu/5BWld0kFGj5yBBxqmA9NUifc7tCYzz9ejB2As7oGt3c18XJrcMc1yQk+eODTf4Bk/PgQojNUSQhxQfdx8BgYoLm49JKqf0psHxRxBCpTs1lagT9dygPfA2ewab535hhDTvDUyhnDYjs+OEuygLL21yi/sXjZR1j0Ro5cMXbnxPVN5Gsr+8Irvr7MmzwSbiPW2XIXOoNKg7jjTvdtMV5S20rkoY5T/0tT+tT7Wt6OwnuK5YPIhAyiN6qZXZ+zrlg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0939.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5a2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.41; Thu, 29 Feb 2024 11:50:59 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7316.023; Thu, 29 Feb 2024 11:50:59 +0000 Message-ID: Date: Thu, 29 Feb 2024 12:52:58 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240226143521.57913-1-ffmpeg@haasn.xyz> <20240228165605.GB85477@haasn.xyz> <20240229120301.GB20801@haasn.xyz> From: Andreas Rheinhardt In-Reply-To: <20240229120301.GB20801@haasn.xyz> X-TMN: [lLM2GMqJjPU1RynD5ywBCqSafyJGhHiPuaAoc/jF5fc=] X-ClientProxiedBy: FR0P281CA0154.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::11) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0939:EE_ X-MS-Office365-Filtering-Correlation-Id: d5c954f9-771a-4460-23fb-08dc391cb23a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Usc25o4Tn2u2qawWFlTwZHf20hXEtSD4W723Kq6H4vLGo3VXFu6uyfh4/KhuIXeKvl0NPdAosIXwLzWzQ3oTaDwBI6ONwkFU1QIm5i/ZHkHjRH5p570n3ay9NJdwm3SVG8wFcO+/BCgU0L3VZnIyR3Fx8RUIsVerb5lA0eFQ0XiNDU69u/LzLnTcEwgDiWpdqUSUNrrMXCqqqv2yN6HMeZ0BUpw5bbprHOiJdAykiH0J3niXQ9BCsKnrcOsoUdpXRRKwEPQ8r56sItrkHOwjnjWoHgRv9NAJ4YD8UrFGZSW69ZwEkNTcRGj9tMLbLDhGrr5NE+pKIbcSyHvKOePQYPu4+JIgEclNa7yT7pWAVq3zSMXHfb4+IOFO0UVRoj2JwQfShbhM65AbzpZUW+LoXJ+TXZYRamdjKiQaDHabno/9ioqIAJLMHoQJV5xKb3Yaoo4bh4KAYpoVc9h13TeIZYTgmN/SeIOQVe0+SgcUlxxwVtY01JckIj1xGGbXPbZkHoSFmNq1C1kCBxGITbyYvufH91SMXeMdoZfvUut0PXtU6GcDnyzYiJCvY4fwQyIF X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1Y4cWpnVktOVzdrWU96UkJTRGE0aDRMODRWUzRlcVhDZ3p5eGVQeDdETW5K?= =?utf-8?B?STZ3akV2dVptWlc2RTFBbjVRWWVvUzV3SUtoNjRwU2Vla29qdUsyK1VCV3cw?= =?utf-8?B?QU1ZbFpWdVozVmtMSzIvdE9SV0tIOGxPdHN1MWxYR3FVRHZzbVQ2dUhpOHgx?= =?utf-8?B?NEV5ZzQ5S09Ddi83eE1acytuNzZqL2lJOUpIckh0WnZMY0tUYW9DNHRnZkho?= =?utf-8?B?Ri9IaDU1S1NmZE96bnZkMzJVNFBmUVNOM0N4K0V1NERIOWZveFlyTmVpK2dO?= =?utf-8?B?b0pHTDMySVJxWWp6blpDOUZuZjVIR3pXTy9jdHp5cGN0TTJGcG5lalB1QVBF?= =?utf-8?B?T3czQWUwQ0QvdWJuQWtxQTFBUXl6QXlHOUxRZWNwTWlBR2Zmd0VJWXBkVXVY?= =?utf-8?B?WndMYkRoRUkwQ2hzbmZwOGJtL2dmR0VudnF2dXFMWVUvL0Q3WFo1ZFVXMzVM?= =?utf-8?B?UE42dFYzemRqMS9FWFEvVGtQMjIyRzFLVEkydFZZNXhKNnRTTWthT0FEVHNL?= =?utf-8?B?VTJsODd3a3hGVzNYbXRVNDF4VXdvWGgwbkpNUnRQM0J0MjUvZUxSbWNEMnFP?= =?utf-8?B?cUFWd1RDc2NFNk10QXVDWXpHOFRab3NudDJRcHhkUytMMVl1VDRRVE93dXIy?= =?utf-8?B?QnZnUGlWMFRKbkJHZGVlNkpDMzNKZUJUdTBaQndIdnRhR0RuUEhXWHBuRnIx?= =?utf-8?B?NHpIbTZwRGV0SEJtYklEdW5CeGJPQzZROU1MWmJ5ZitOMmsreG5LV2ZxcTVk?= =?utf-8?B?TXp6N3FqUHdVNGpVd2JoTzVVQnJhTmZrNEgzZ3BlckRpUHJMR3ExL0g5dHpr?= =?utf-8?B?QUhNalZCdC8wc254dnF3c2hpanNUeU15ZlBUVzY1REJ5dzdOSFpHUlFCM1JR?= =?utf-8?B?RlA5Y2ZOMzY4OHNxMmlrdnQ1dWJjZEdmTWdzbEFOVUJCMGQrWVNQK2dNeDZm?= =?utf-8?B?b3R1RWVHR01JUzF1Y1NWc0RwR29JR2I2UFdNczNrWjY4VHd6cjV3b3dNNnda?= =?utf-8?B?bjVuakZhNElNbWdjRGFDcTQ1MU9WYmM0OVBHOEU2M3lWM1liZksvQUNQdVky?= =?utf-8?B?Y0VJS3JNMTZZRHRKaUZVdHA2SldoWi8rR0ltTFU0WlZyYzRNcHFiU3ZFdk1l?= =?utf-8?B?OWQyQTcyRmNHSUk4ZkYzY3R4YmpVa2lYNjV6TGVuanhhQmllOVJ3b05BWHZD?= =?utf-8?B?SHVTV2JvamFYYnNzeWZUaU1WbkxGZG5vdHZGTkpmd3BTdkZaUUpNWmUzR1RT?= =?utf-8?B?Qks0di9PSUdqRVluZmdIelVlT2FER1lyY05KSlRTbEI5WWZDV05HSDYxNjI0?= =?utf-8?B?M0lMUFNuMUJXWThaS2xtQzFLVDBadGQ3ZFVXT25kMFU2NTY1ZVkreVpNY204?= =?utf-8?B?R2NjdkxZN2JkVCs1REFzYm80VGRhUngwZGpsVFRiRFZDRG5WSHdhVkpxM3NS?= =?utf-8?B?bk5SdGRnYUpxT3hQYWhtR3hsZXRDS2U5blhDWHJiYkhhTGN5cWxXYWxKRFlZ?= =?utf-8?B?anNIZ0FydFJkd1duaDZDdHdPUDZhYjJYYk95Q2hlTmg1Y3p3aVh0TWNzeEh2?= =?utf-8?B?bmNQbmFZRXduZFl4YXpKRDJ3YTI4SjBFcHBRRmY2WVBhZFBKMmRlZlNsMGZH?= =?utf-8?B?K1FYWjNsUGZMTUJYOTFGdGtYK0czRmVWcG1DbEs2YndId0hsSVhjcERaN0dO?= =?utf-8?B?RzNaODk1bDhFTFZjY0NlTnFSN0QweXlEKzhLWmVXa1RXWWJJNEVBN1dBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5c954f9-771a-4460-23fb-08dc391cb23a X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 11:50:59.3653 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0939 Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film grain synthesis X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Niklas Haas: > + av_assert0(out_frame->format == in_frame->format); You already asserted that generically at the start of ff_aom_apply_film_grain(). > + if (in_frame->format != AV_PIX_FMT_YUV420P10LE) > + return AVERROR_PATCHWELCOME; wtf! This makes the whole code pointless on BE and makes the 8 bit version pointless, too. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".