From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AFF6F48999 for ; Fri, 22 Dec 2023 07:40:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 64CC168D22C; Fri, 22 Dec 2023 09:40:24 +0200 (EET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04olkn2103.outbound.protection.outlook.com [40.92.74.103]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C40FE68CF2C for ; Fri, 22 Dec 2023 09:40:16 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JwGcEu5NFxo2JF6lB/I4NsgFAUdEiLpQKpZjLgD1XX6lpRMzbfBX5jS07AFCU+3JX5OSyUZkstgGQFhbmZIFtCMB8lhyeTn7L+c6q9DDYW0i/lUUu2MHMnJE7XUokOwMjfZ/fwWxFj05zFP+nLuJ8RWPWAxjMw2KsOYpQgrgh+tKyy62lS38ODzNONKJfK1m+M6PnAimsXk9yFYfKsNu/FC82RVzhMjmgANix06P9xhUlab5L4SUglv1c9uF+7Wzb9XxQ0boMFDaktKXYe4RLyTLJOblnk9/b16Xsn3mr7PIYsS4rrkA+Ryj0mwl0jVEXFFMlniOFHiP2JH9JaqpUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7vV/Pc16RFbbwHl7JfBHhNQsWi0wMSjVAEThpwBXVnA=; b=oJhpQwz7Njy91R3NlduMiKfvJwPo1LA7qOhNJXH82yfjbjZuqYp/4X3f5v17jNNiRTUqmWU0Lh/IM7NGUBwHca0XF5Dt7crLF01lVEb6/XtusT8AwuCJO9RVW64FnDSniye/O9cS7jN5bUm7XUSIAGi6SxClVgQKKxjcxtL9hSm9kjgssMwybqNuzqdRNHy/2KEu1RM4wnFm2ai2ZvVjrKIiuHdQVAJLyPHN+kIOONg0ksPbW4SbxY7kbToYi0GLxEuhEhENzjR9YuDAq9zF9SfbWXybLSh5PYBEHg1Kad3V+xzEtI1UHBi4xEZ+WuoW954DmruHNX9dekB1FEZRHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7vV/Pc16RFbbwHl7JfBHhNQsWi0wMSjVAEThpwBXVnA=; b=IdMsvC6kYce+8Xcp1MMPnKjNB7Ooa5iMVCG8a/PqDnOb1hGnUrjwS3NJWwvEhXs35v8RBrG9ZSEFqQnxvRRR3ywWP0RUSvqBJnhBYE+dY+Bn+pxUIVfzW2ZAsLFdj3T3NBbT2L9wpmCEyOqLOEfgUBEv077V1J99KBcxxF8GP8mRszvq8vRz/5gDfD/4zfyfpGEqe4wvWWPHi2D/unUlVKvwRpoXzcaQs7cVoEgugrQr6F1IvKSMsbaTx3vAcapxHbFdh33JILX/3GnsAZUvRGe4qo6d+vkOTTF9ysMXQVjESfK4GaSevAd07wj9qbwyjVzzgc3iT1ZvYCz1xGWBiA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0387.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Fri, 22 Dec 2023 07:40:13 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde%3]) with mapi id 15.20.7113.016; Fri, 22 Dec 2023 07:40:13 +0000 Message-ID: Date: Fri, 22 Dec 2023 08:41:44 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20231220084356.796186-1-fei.w.wang@intel.com> <0ec4a5a324fcb829eea33916dfc4b44e7a91b79b.camel@intel.com> <51d4f55fcabe1704f17ac4154b3d108fec4dbacc.camel@intel.com> From: Andreas Rheinhardt In-Reply-To: <51d4f55fcabe1704f17ac4154b3d108fec4dbacc.camel@intel.com> X-TMN: [Y5x50sxkewC6/F71agTq+3aQD2FZYXI67Si7LK1D/Jo=] X-ClientProxiedBy: FR0P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::21) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <3e044128-3487-4dc5-b19b-13aa5ad856d0@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0387:EE_ X-MS-Office365-Filtering-Correlation-Id: ec8d386d-be25-48eb-2b66-08dc02c13b6f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QjbUlNjmFj8HerZFGL3FRWBN7oQ/rjfeF4E5aoXCBDeZAIzU4nuu3+IDZy9SDInakW2K2+lPJHB5Ev8xsj0zYJBncGhHP4jKTvIkfWTEMTqufp5lsIMAqvghRv8id2lxGl+Ut3zJuk+2/ohP/8wGkHYMdxdGCerxDxRl/QrlLH3tCnApFXX2ynVQWDED8AB0chQZ4YYF1FXMHO0ik0bVHZMPcFyfGMrum+/I3sCvQ+16s8/T7mjN+H/IyRcLYMe3WAjmMg1pFHgGw/yby+KgJhoGYg2/aenXlZU+LnEie7POlXEK370mx1qHSKvQWf4FJeGwUuFRu7EwXxtuRaQhgdGNA5B3J9VCGxPY33vZSzesqqQddxnOFhO0EQDMyNlJ2GF66CoZFhmRcxAgP1jfbkcOdcF/TuB9LS4LOYuYAT3e9kQOjvKk+C28GHPuiw+eeAHHAxgGtE86T1EZftVmeuMLJl/Ktxj/BarzcsCsoXR55PoYmkDBgT5ANW5UQW5uXfe5EPs2EMHAL/4Mxz27D8SDUkmYfOQ0WDM1EhgO7ZlJJS/FkiUs3LFJNWcGgT9D X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YStyakhqam1lNUEyODZXdWNPazM0NTVZbkMyRTZjZEpVM1hWNWZwTytrZGpM?= =?utf-8?B?STB6bFNHS2Z3TmFocXpoSnY0elYybWtLamNoN2hBK1hPb1dWOWJqY3lOc2RK?= =?utf-8?B?LzRIZEhPdWVzdk5qTXB0NSs5Q0t0a2Q2WFhZMlNXZHMyUkpJSWU3TFlxbVh2?= =?utf-8?B?NHJMTFA0eittNVJYYzR5OVJOOHNLeVlkV08vVDNNcThIY2ZhSUkxOHo1YktN?= =?utf-8?B?cUFIVjdhenBBOW1lV2lkNC9GbmVUUlk3WDNpN3pEdHo1eW45Sm42S0ZFRzZP?= =?utf-8?B?dTJsU1BlSk9vMmtPdEM4dHduR05KWmRUVERjcm5LMDdsZE0yYWlWVjN6ajZB?= =?utf-8?B?alNseDFGMU91SWhYTVZzTmN6bE5ld0FVUmpzS1VpMUpnRFNqWUVIY0pYUktN?= =?utf-8?B?a04xWnI5K1dtVDlKaU9YQmsybExnMjZFZjhteHdGd05TS011ZzdsMGV3UnhN?= =?utf-8?B?M25DWENmdk1Kd0RJbU9JR0ljTkt4Q1dFOCtaV0wrRzFRVG9zV2pYcTdoOFZx?= =?utf-8?B?WDJUZXlMaVpWQ1BRZ2pQM2NZc3Y1dkZOdmRiUDZZeHhjQUp1MTJjejdoa2h4?= =?utf-8?B?RUtkMmdIR2NOSnJwRmxjYTRtelJQNjVNNGFyZldCbEpYa3hVeTJSR2FXdzND?= =?utf-8?B?QjNSdFBIMGZmdlg0dG5nMzN0aHZCUE4zZDZHYk9Ub1RYMkRaL2pkM1VYNTVl?= =?utf-8?B?MHFZZDNCeUhHMkh3Um0vR21tNUVxaUg1dVhhSjRsbjhrTnNiMlJUdk5LNUt6?= =?utf-8?B?TTExWDJtNHVDVFhaQU1jUXBIWVFJVnVRYmZBZzU1amVOckZNZnhOc2RjKzNF?= =?utf-8?B?S24wVDAwRUEyUDNCeXU5WDVVQ1ZsSHBWR2pVSVFVSDM1ZXdlajlVM294OW9l?= =?utf-8?B?d0k5cGQvVkVSTHFjbm52STBlalZ2M2dJTWZoZjRWUXVWTlNISUJnWGlXT3Yv?= =?utf-8?B?djVCQUloRCt1OGtBNGQzalBTRmMyM1AvOWdnV3pHRkNlSEZtL01YTllrNEt5?= =?utf-8?B?akNONFI4dVlNbkZQTnE4YzhzUXMrOTVHVnZjM2l1NmZkNVdhd1llQTRIWHhI?= =?utf-8?B?czhmRG00Ymh4aUFYZG5rZlBuZVpnajFYQkZWM3Jza2xCS0VSRVlKT3NheXg0?= =?utf-8?B?RGhLNzVnQVg2YyszWG5YamlIeFBYalRzTmlNdlZycHhkcEtxam1Qd3BKeFJH?= =?utf-8?B?MUJPeXB1MmVPSEw1K2FUblpwTi9YcVpsdldaUi9BbzhoNUpYZEplM1VZQ2Ra?= =?utf-8?B?R1luVnF5eVpIR0dTSXZBRHA2enRHZGc4Z2E2QVBLdzNpVExwOUcxZk1JdEtF?= =?utf-8?B?VG9ES1hvQm4yaExHVzV3M21rV01uditHS0kwd2R0dkRPRk5vNXdFU1JIME01?= =?utf-8?B?SGFPZm01U2hMbGdDN0JLaUJmVWFNSm1zOEVHVGlkL1VGdllvMUE2UlU5N00r?= =?utf-8?B?b2FpRG83RS9qTlJZVldjdUZvbEw0T3dHUkcvRTZ4dmNYanZrUlZTOFlFamFZ?= =?utf-8?B?Mnk0cHZFOEVKeHJjc3hleTZzRG9PLy9jUFl3czlxVGtac3FScXNXL2hqUVJl?= =?utf-8?B?UGNmdWRZWDh0aVFtZkFXQUV3aTNtUmUzMnhxSXNBb21QNlcrUXV4VG1UV3Nw?= =?utf-8?B?b0VXM0VCaVRIL0dRYXI1N3h3dy8rWkZ3UUFFVmkvdk03YVJzK01TSnJFOUgw?= =?utf-8?Q?ZdjPPZF/PwvjrZtOO4bQ?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec8d386d-be25-48eb-2b66-08dc02c13b6f X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2023 07:40:13.1845 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0387 Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/av1dec: Add tile list OBU to decompose list X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Wang, Fei W: > On Thu, 2023-12-21 at 20:14 +0100, Andreas Rheinhardt wrote: >> Wang, Fei W: >>> On Wed, 2023-12-20 at 17:11 +0100, Andreas Rheinhardt wrote: >>>> fei.w.wang-at-intel.com@ffmpeg.org: >>>>> From: Fei Wang >>>>> >>>>> Show the unsupported message and return unsupported for clips >>>>> contain >>>>> tile list OBU since it hasn't been implemented. Otherwise, >>>>> decoding >>>>> maybe successful but result is incorrect. >>>>> >>>>> Signed-off-by: Fei Wang >>>>> --- >>>>> libavcodec/av1dec.c | 5 +++++ >>>>> 1 file changed, 5 insertions(+) >>>>> >>>>> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c >>>>> index 4dcde234c6..629e37c3f8 100644 >>>>> --- a/libavcodec/av1dec.c >>>>> +++ b/libavcodec/av1dec.c >>>>> @@ -805,6 +805,7 @@ static const CodedBitstreamUnitType >>>>> decompose_unit_types[] = { >>>>> AV1_OBU_SEQUENCE_HEADER, >>>>> AV1_OBU_TEMPORAL_DELIMITER, >>>>> AV1_OBU_TILE_GROUP, >>>>> + AV1_OBU_TILE_LIST, >>>> >>>> What do you need this for? Decomposing it would only change >>>> whether >>>> CodedBitstreamUnit.content is available, but you are only reading >>>> CodedBitstreamUnit.type. >>> >>> To show the unsupported error and let user know that there are tile >>> list OBUs in bitstream that decoder can't handle them. Otherwise, >>> like >>> my commit mentioned, tile list obu bitsteam may be decoded >>> 'successful' >>> according to log. >>> >> >> As I said: You do not need CodedBitstreamUnit.content for the error >> message. > > No, obu will be filtered if it is not listed in decompose, decoder > can't receive its type neither. > Did you test this? If so, this would be a violation of the documentation of decompose_unit_types: "Types not in this list will be available in bitstream form only." My reading of the code of cbs_read_fragment_content() in cbs.c is that it does what it is supposed to do. If you were right, it would also mean that the current case for AV1_OBU_TILE_LIST and AV1_OBU_PADDING is redundant (and that the default case will be used instead). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".