From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0F0C4497F2 for ; Mon, 19 Feb 2024 21:51:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B615868D40D; Mon, 19 Feb 2024 23:51:10 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2076.outbound.protection.outlook.com [40.92.91.76]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1045A68D400 for ; Mon, 19 Feb 2024 23:51:04 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e7kM8iirSORKU9ghatgK5LA8AdF8zsQYU3MpsRLys2zK9zq6jlB77xQbxR5CeZSi5e+NxxQSkZ8dBn2FLA8uz3YiZpC5UxAjZ1oE4Mttkq+kA1mSNiG6vHJDtecs6IF2Kz6SvSO4C3yiYJ14lZqNzTvwSZMRlJP4Z0lGAzsyHhGfos+5l4mM2MpIy+QBCdyr0AY+nr5XlQh4KKXHQH2c+oh9pbyXwvwECEWRydISP0CggHu+eXV+gx1qRTf351c7PPzR9cYkb4xesgUA+TWAZanQ50SW4qDnhs8CPiTqLNkEz9TTexmZkA8t+HZH1R70VqEJSnxknnTAPYku18LAFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1g4F6CeiyvB57piHPn0C75VO4i6YT0F6yBYdx7YG40g=; b=GVSR5Jp4XHXPVN3asyjs9BzWfTkDGOadyyc3h0XTb5LV/4ZlLuZihRfpwdA+upo6fclE1dPmWbH5JVD5KHxNjAKbm6/B4TkyelLnPm14jxMmiUty6/MmJm2CRoFjAjTXHCObdl1ekk8VTCYVHgTsSZPDc9D2xqltF0+O0wzSXBsq49FK5CadjHnZbfWMfnccv+Y1mnW/spKkGE+4PdLIBHBARwFZ/7/EoKIV9Vii87iHMMCzZv3Lgw66068VUuGBcL5Xa9M7LgOLdEeh45TN+NfBqQk20LC4msh0jOcBMOHTea59Bt4qVjiWgSkEAfkTtXPBE3K8WR4FMuBePqMzgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1g4F6CeiyvB57piHPn0C75VO4i6YT0F6yBYdx7YG40g=; b=m43tvwi4AW+AaS9opgyjnGyW4R4QAULJCZxmwYC4X3JezYs6dASqNFm5KIeezjoj8r8EM8MxuE/ZXgyWTw/HyACd8WikDlF/3GVcJexySpkB9UMnpTH3Dwgl+zDGEsP8r+GczRBMW/NTm/vUZqbhHilAXhqEw/WTT71ucvSDWh+Y09umnM3W+P/Uzz8t7ysvezoAfzchNgZUbH4e0Kh2Dxym2SBGXLk4qmvdqXducAT1D/fGn0XWl1RQoE2e0b50bDTGrDRjIqUY0U9A9ME4FZxpd/mKAq+6tXqqtOGx219jeMjgiFUHtxY9pLcCc4L2Fm9lcl40foFgLAFSUwX/IQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0161.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:174::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.39; Mon, 19 Feb 2024 21:51:02 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7292.033; Mon, 19 Feb 2024 21:50:57 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 19 Feb 2024 22:52:43 +0100 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-TMN: [x9IATuj9zPkLQdFn8J4BSjQLpBvRep3Bkbl4rqGpxus=] X-ClientProxiedBy: FR3P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::6) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240219215246.743238-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0161:EE_ X-MS-Office365-Filtering-Correlation-Id: 68cad602-7636-40a8-e7f1-08dc3194da5e X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnomf9zhpdf2mR/+OogaImHYUJ+962m0XE6fVT7GBfuY+VPrRySaikYIkSAbh4sVTn78bNiNEZIsBa19iBZe99nqY5gvYWEV0pYF5ZPvbDYAmAvCOVECxkkowbN9ZROsJOGXim77eQJYJkHpFCe+o7zwOGXk1zu288e2zxIWQOrYwmoFvlFAQlbCxt/9DqE4X23sjJlxtAt6+nI6O8w8miIiKOrDXCbK4KJl4s2u5xNB5IKuBD4knUohqgIxSIA5kKOEhAyrQrXkLZD9WYxsiSTGkf/asHyeRQ/G7LaCHl9zQXPIVXkHzEEBir4VULrHlCMeCYmbpeI0lP/BMw22C9GmNcV9f4XAn0NzNvAGpRggGvtdm9KY+aKOSQE6YZNrJiEF9AGlH5vtDmrNOgWiToQJmm6XACi9olLrS68jAgjGdvQhVdJdY7VbSGpOr2pqpwKeJppeKw0mVVk2vCz3R2eTtxuGCRaHLRMDUm4Beg9DDUYtgEQVndwfdMVaELciepHogUtw7N1aTQC5LZfYV3n8yaH0Tsn5khlCpENYrS1BzZ3oxNudXSpm6771tZ/b6iw8ARdJRWZUTkFcd9dNj1QgFpmiZMnit7imUEp4eesyDKZm5yVf6egHpZBLfyclsPE9StHFfqpHIcitztMXP8pQJgKFCmbHCZwzcLpaNpRGj7UHwALFm7nFy3LcnCZhXJvn7Tg/F6IzCninKdRaNYogal27fmGedsHiBdv+plqYKpwlt3lLm/W5fYhsd+Ce5t8= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4mPL3SbAHV6gKaO1lRutQ7nGKY0MySeWYyE8P4WVmRsa1iJUt8EkOB6WX0jULTWdxnE1YBgE4LWHryMDp6YHQLeG0OJOPHXGmG7F/p7cBNXPju0ysPzmjQz+sCqWNRknw1uITX9dCB0l447OnTzrqKMmDLREklnPb4aXFPiwIiDoCbIDyQFg4GLISvSEle68q+pi51wrKcMwCfSwXBA4ct1VLAr4B94J9w6B38quZesuTePmyZHW6FuPPTTP+XuFMI0RJv6sQEwd2F2y8equdnW/2aSzpbKCnsG0iEOcAxbv9qdgYjTtHDgKUjNg/BUITdrNsCIbcLtybSG4Sjm5HlmiBKwVS1v3GU43IfbdmpkcCE1OfV6pYfrTmQt2ywHtSjdE2dOCBxYGVM8CeL9aoOzDXJyrxvPXy+OxWc5YIx3K/SJquNvdwfB7xnC+GH7gXVO40kZ7J/PR+HngW60PXlIBu9sjtTb0u/hj66HtWnpT2N85MLe3KDdClmluomPKyFjjIZIxBPvfOR7xI1zc8s4tvlNSWWPXnlVf1o7FGcEJxrcMMVhxKbx08U6qktM/Seml5mFN4RCNN2cyEL/2mrIHj1HpzneVyb/dxm2hoxHxwSCB+byQG96WdCS6pS95 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ID5PQXjd4ZZsRf7iOISUnTQNaP5kYlCyX6egBf5GzNfK2b3IGP136enbbfwY?= =?us-ascii?Q?+vgJTUFOYTPUYXAq8y9D+YY7AQ/ySA76B3OqW0xhg0ohC+F7BfzHsWKyyzJW?= =?us-ascii?Q?5xoFeJ+31Wh2qdNj9jUIQgLB3JlOq4txmwPcH+PMXUlTDoC5k3mSEL4log6L?= =?us-ascii?Q?Pf8H65UKyGtC09QI3LX5s29tHEftYFtGAuUF+3DvU1XTh23rNOMy5buvFlkS?= =?us-ascii?Q?OxmzVSCQSowDza+B4Mdj+/zpKu28u+W3nqmfbStLC3hJblJZRVFhU1eo84NO?= =?us-ascii?Q?S6zuEtNxfvJfock8LIToKpY0WzKGGwiY7rCIcSEJZy/3KPFO6k5tSgpNEffA?= =?us-ascii?Q?2P82XbLowmsyw2WCq8d6CUuqLPQ1KGFjkxqjdz9oHTbMx7JbnWUxLBn1Hds6?= =?us-ascii?Q?zSQjgUbRW02gY17wiZsK5QoXWrZZKj9sJ8nNyxzV76rMg9CoghDwKc+qq/Xv?= =?us-ascii?Q?WoYFsDtZdxTBF6fIWTR+xCh2DdBvO9nDBF+zOl+Xd/Kx7b7fRLQYH3fI+N3Z?= =?us-ascii?Q?xPiJwAq8s7OnucxiISeu5C3y5Y58I6K8i0bczblpOOgcBcTMB4QozzewqXUx?= =?us-ascii?Q?FwCmmw1Bd7XWOmh0w0be1kyw5Pl0qmq/u3YfdqQUahdq4i7vumsKsXQM9WvR?= =?us-ascii?Q?UxqCh46qveh6PK+X1K4S38RePlJI0wUbnOB59UC8qcRlX2PYMPrhBnsOaOmI?= =?us-ascii?Q?Hlpd38cDc62cT+KWu/NsAKiQNBAtr0Q9Zx9J7gyXCPlYgNUCVenfx3olzxxA?= =?us-ascii?Q?u1/YvAqNnUk5XtxBtAQCeSFuWwkPsw+z4IzlI6piDrRtfaSQ5jG/JeiB9CDD?= =?us-ascii?Q?WCvrEHXPg7czk1ix57V42CS5iBCOq9apBPEneIkIqQOSidBe2xNMS26GLwEC?= =?us-ascii?Q?UEficbLGdlEywyVcW30AI581cJw/2uOwglEw5QZg7bACAxJKRofcdstXt3pO?= =?us-ascii?Q?Ar0F6AS5Ma/WuD+6FNo41/efa7SV4v9EkskVgMdfHyG07CkSn89r7XfIhz2x?= =?us-ascii?Q?1GpfUiOFQhypW5CT/SSwBfNRpvFG4sP4sQwwqTi1S52kvGfDioVgu+EP8hEF?= =?us-ascii?Q?nG/4OvYNq5X+kaWt71HuKrJM7wv37YE0vZv+uhGp/lUNbStp/6jHLwO402kd?= =?us-ascii?Q?qgcOdIpjwtE9ET0iAsZMYzZ57RHkTRz3tg+o+kktlTt+7+7jobcmCcxb30JC?= =?us-ascii?Q?0K9kJwkopfK0zXCdkeUXPZvayXM+ylK95Ao9FgOvY3DZFfmSlU+YXJnPt1wm?= =?us-ascii?Q?ZCSdzrnRxIBUoxmfJRk7neg8d+NB/SLH/aRrS2KGhg=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68cad602-7636-40a8-e7f1-08dc3194da5e X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 21:50:56.9853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0161 Subject: [FFmpeg-devel] [PATCH 2/5] avformat/iamf_writer: Remove nonsense check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Checking whether a pointer to an element of an array is NULL makes no sense, as the pointer addition involved in getting the address would be undefined behaviour already if the array were NULL. In this case the array allocation has already been checked a few lines before. Fixes Coverity issue #1559548. Signed-off-by: Andreas Rheinhardt --- libavformat/iamf_writer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 897b06310f..e0c47b5e9d 100644 --- a/libavformat/iamf_writer.c +++ b/libavformat/iamf_writer.c @@ -251,8 +251,6 @@ int ff_iamf_add_audio_element(IAMFContext *iamf, const AVStreamGroup *stg, void int nb_channels = iamf_audio_element->layers[i]->ch_layout.nb_channels; IAMFLayer *layer = &audio_element->layers[i]; - if (!layer) - return AVERROR(ENOMEM); memset(layer, 0, sizeof(*layer)); if (i) -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".