From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6805E470FD for ; Thu, 26 Oct 2023 10:53:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1107168CA67; Thu, 26 Oct 2023 13:53:18 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2097.outbound.protection.outlook.com [40.92.90.97]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E248268C8E7 for ; Thu, 26 Oct 2023 13:53:11 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oXvVymyfiSdS9SyRNV4RUVfwPQWjblXEq6vgWv5U5HfPSyZwXHBLYkpQQW6eAWe5PTZa2VSFdB4FVK2IRNPDRjHKZErifIcZsU+pCM0rPc7KDrx2BouY+FwXbM+7Us90Wpdrzro7HUg7/GtNsCmYnRSfxl3OY8+35SxXH1vZ8BiaSklpHm4WeV4oQ7k1VPY7FUJJ0D6CV14b61AvbJIkaW5IbCs11x3gmpEMd6M+IWCaCVe4MpH5S/F9ZAwDMHWOf/4DoqASObyXsVJ/EYNMu+rZlEQrzqDq7E6OzMQq267JY8oJBoiMmB24ioGRGuV15Vw16kmH7cb7OVssu9d2Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eFCORL+11VG6ErjPZGQT+i5vG+HYHeb0HK2QTXfqMdI=; b=BaACTqduT9hRqOkbsBV4wS2k1wOQNwxA5VqNGY8JWo105QJN3oThg9FImmT5/fLN/f01nKgnLrtbZGxjmEEqDCWSdl4MuvjcSZKeMXsdEd+gg3XpZV9pqUOLGHEm44yjafw5cgjxsHbBT7VgqHlFI/OCMwc0jyyVxLo/o1V9s8wrFT5FhZk8DdohpABsxhqe2Od2T35YfFaXXJfwAP1YGRv6jrOAXFgy8sB1Hr7FFMefUv+BmepkhFBHbxqbcNpJHFbO+3NEsfK/w1IkxMYppmkmbuyDXAsd0SpHCdRnnNfg337ot+Qs1iXLDTZ0hsgaS3ScCcUJofJP8NzzRW1Jcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eFCORL+11VG6ErjPZGQT+i5vG+HYHeb0HK2QTXfqMdI=; b=RWq4EbIVd2Kuw1WPAgKSnVLyrp5APQPXFKQ9OUKGNRYX2ftibtaYob2YHtGnM9LfXuwKJcCacBa5Qat/HzzQF8CVTt2wHq0SKeoNivh3UQ5mb9qR4VPUqUp4RyYl4SUCopS6709VS5XegsrrZCJs+OaOYnLspls5rqUaYfQwhZKeLXx0Gnh9an3TbfT9N7chl91aHGqBQgW1q6c0/8uJDue3cEaOtGP5JzkyvXiMmWX49K1lLJiPOvue9IdJL1DxSTTjiEp4k7Gotn4IUfNg7VMXjhRF+ds30ZohRP4VPyUuKidMka3WbTCqGmBbKxj8SXTsqV8qeVlobp9M/xDTDA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0324.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Thu, 26 Oct 2023 10:53:09 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde%3]) with mapi id 15.20.6907.030; Thu, 26 Oct 2023 10:53:09 +0000 Message-ID: Date: Thu, 26 Oct 2023 12:54:22 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231026031427.150182-1-leo.izen@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20231026031427.150182-1-leo.izen@gmail.com> X-TMN: [MirVrs1xWjnqOna78twxWcudA8N9KMjIafVJ5QxyNjI=] X-ClientProxiedBy: ZR0P278CA0177.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::11) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0324:EE_ X-MS-Office365-Filtering-Correlation-Id: 3be5ee22-a726-419b-1f75-08dbd611be1b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bKRGDaxq0FDmZVYwK57irRfqaK5VbqMkT0Qkx2X/ZPX0iy6h0T2EpEryEw/O3Cv+gYgO600blXIDp0GNHE2W6HjM5JxHnvgNs9+JMZpgMmPMBwQ5PFl+wGbTL50/YWNPtardm5o/tOOjftgAbwXuOivTBlRy0CP2m0xBaqIK1+YYeExbw2gHiq7oP9LoNk97wPBEeMMt9iBfXbDbldwoos1DG07G1MgPXPieeX+bM0Ld4qjMQUXPgmMFfUeq6Wd5U5dqSXrdUfVgAnpiH6vkdIvXZ9bh2i2dIS5XgLMSWQlpNBH+BqhyMRJ/p0+plB2sMy8TP/QuaiG7d72kBPRBe4W2WFkwcJ8A/X2FBooBfCmLA0kg+TPwbBiy5XWL6SejtGFlSwWPbjdQ8SXw5bcEY7ZPmiDWAAVyxJivdnUjyGb0nLpXWIvBPHags7xOAkvaIIqPjkQklWmh9JoY40oRSBsOl5QN1ckgCbKygtPnvzvz1jIPYoggsrfSfghQpMk5bPCk0GNxEbWACPa3OY/PragQhCAEMc48/+N2IL94Rkv1neYyYnCuCZPe2A8Xsb/o X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnNRYmE0dXN0SkxUYXNRNmFHMlZKRlNEaUJrelI2Skc2Wk5xQWpaemZLODk5?= =?utf-8?B?dHU2Ym1Obmh6aU15REV0d1k2NytVRE0xbWcrdzNYK2UyYnJCNG4yS1FlZ29P?= =?utf-8?B?cXJNbmdYVk5UbGxnN3loTHB4aHNUWmlYV2hIUnp1c0JpQzJDWitNSmVxN1kv?= =?utf-8?B?WU9iVkVSOFFSNnVHU3JqZ3NOUVVYMjdJTzhVMmdDUjYxa0pwQmRlL0lzdGVU?= =?utf-8?B?b0tLaTFia2Z5Q1Bia3Vya09uem9FMlhoZmhQbVZOWll2ZjFDbWQwb0FzSjlB?= =?utf-8?B?S29nOEMyb1NFTVcrT0tnNUh3VWd5NkFUSFJyTllWcTZsTjI4SFViT3h1RGZZ?= =?utf-8?B?eWNkOWpEOHM2ZUUvamswMVJYMUVxUWVrUnFSL1k0MXlNbDUxUFpOYkNVc1hN?= =?utf-8?B?cmtQeFI4bVBTbHlxUSszL0R0WWtnbTh5VW5jSzJtV0lrbC8yaE12Zkp3dXpI?= =?utf-8?B?Ymd1TCtLOU9zTzdORjhyR0NaWXpsUThNN2MrMldHZlNpblFlWjAwbHNQOU9N?= =?utf-8?B?ekhYcWJCSTBLMHdzbGNndS9VeldaeFNNVHhwUUFSKzdPenNGRjdFNlBXaHBL?= =?utf-8?B?S0xiNGVFdTR1YVU2L2xhVmhjYXF4VGw4Ryt6ZXlIQm1mV21XcWVoV0lWR21z?= =?utf-8?B?dmo2WVdLbVVMSVhSU1VEc28vaGljeEQvdDczZFljL1Zyc1VLMVhTZ3Y4S05n?= =?utf-8?B?bk9yTXlaV0RtTFU3ZStGbXFuZENwdmVqcWdJck9JUDlUY3VJSXE5aDZNbExP?= =?utf-8?B?VVpPajNMdGpGQnhBcElvN041S1RjRWtjTlg1dnBEc2tUcjh3d3l1WnA5ZWdH?= =?utf-8?B?bFcvVXVTMlNrdmlXWUl6MjlOeDF1M3dlU1Q2cGh6TS9yZlRNZUJ5aEt4RUJP?= =?utf-8?B?NUFuNnJTM3psYXIzTitrelo2M0pDcFQrbGNxZS9SaGpxWjIyY2hCbUZRQ3FK?= =?utf-8?B?b0k0OFNoSGRXeTY3dWxGYldCK3NuSnRuWFRDdTIrT3NSQ2NLTERVY2lWSGZ6?= =?utf-8?B?Y2ZjQW9nU0xTYXhMcG1nZ3hFTHdOcXZpRmx1TTRXN1UrSVczc3pJWWxNWTFz?= =?utf-8?B?cm9WZzNvOWpjREJZZFZnSWZxM3IvMWlXVkJKMTVMVTdUMEJDdHJZQWg0RmdB?= =?utf-8?B?T0xTc2RBemJ0QnJvWExrMzlvcUdoY0huTGc2WGZMQm5zeklyMUFqYkdQQis3?= =?utf-8?B?S3Y5Sk5GK3JMckxicHFKcGtOYnZ6OU93cXJJUW1oTnkwOU5rVHRyT2QrcVI1?= =?utf-8?B?TWttamtaYWg2aFl6Unc5TFJxZHFmZ1V5VXJnYjdhQ3JCMXN2V2JVVHdSZmhr?= =?utf-8?B?TmVQWUQrMys0Q241OXdiWHNnQ2k3Y3dqczJFRmJndGVUU0Ztejhyc0N3dzFj?= =?utf-8?B?VDQweWRwVVYzWmllandzalZsU3YwR1c1K1lvcDBoNUI3ZjZZTUh2dnNFdmQ2?= =?utf-8?B?L0ovQVJoYmYyY2YvSVJCWUhqaTBCQm5CVEYrOHdyRnhoRE1tTXRGT1V6UDVa?= =?utf-8?B?R3JFTWh5Q0xvRlhqYlVybG5yaWZmRVV5dzZ6NXFHdWx2cDcyVkc5aFlSbmI5?= =?utf-8?B?d04vQU4wSjVmVVBWZ0lLZ0ZyOVA5MFhnQ211VFFMbDVrWnhMNmM2WjZGY0k4?= =?utf-8?B?UWlROFk5NkpJN0EyVFA2empKMFlrYnpSenVvMUU5alJCWTdKYU1ycHlzQUth?= =?utf-8?Q?ifdsjOB3/lVKnhZhivGq?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3be5ee22-a726-419b-1f75-08dbd611be1b X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 10:53:09.8349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0324 Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: use av_strlcopy instead of strncpy X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Leo Izen: > Avoids a -Wstringop-truncation warning by using av_strlcopy instead of > strncpy. > > Signed-off-by: Leo Izen > --- > libavformat/hls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index f5f549b24d..076f92ecfb 100644 > --- a/libavformat/hls.c > +++ b/libavformat/hls.c > @@ -543,7 +543,7 @@ static struct rendition *new_rendition(HLSContext *c, struct rendition_info *inf > int langlen = strlen(rend->language); > if (langlen < sizeof(rend->language) - 3) { > rend->language[langlen] = ','; > - strncpy(rend->language + langlen + 1, info->assoc_language, > + av_strlcpy(rend->language + langlen + 1, info->assoc_language, > sizeof(rend->language) - langlen - 2); > } > } Doesn't this just silence the warning instead of fixing the potential truncation? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".