From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C8515449DF for ; Wed, 28 Sep 2022 19:44:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D0A1A68BC16; Wed, 28 Sep 2022 22:44:00 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2064.outbound.protection.outlook.com [40.92.89.64]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CD46668BC10 for ; Wed, 28 Sep 2022 22:43:53 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kfGw47e5nGasTjmq5q5JyhivgU3s74esrBf4fwCllMJolC/cOu/fj1b0t9qoa4rEYm48C+lwlLsnB8fHONTTKX/HtEeQixts7oaHSPSCDVmQkjkx1YQw8M61202fjrq21wWr6VeAOXt6N+UaOxAJJfWfIzN3tJI0lW7JIbBsvymaPCo3oI6sSrv0HliaT1ieL+WECrqd1Z4Km6WrFvT0RPVj4O6yUWZSYXveGN2gxm19YosT1M+cD7HjQ54Bj9l0/ugJkBuiaf6NSiybRLF8LHPYaQpHmLvhqlFe66qFGLFAmhmc5jaHiKgywEWiL4YCu7caLn0R75o+pQ3aK0V/xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kTIXs+xyZ7GQMwJvHCRcU4gs90P6mxQaVyECatzMlXo=; b=H5q70533OXrZKp09VF/WRxLPDD5jwNhMhrgFLczBBg5wf+yCAVRAQIRQ+K8y3xO2sBVnmE6j9LA54IIYisXNf53J/okrpzTwpvDgqbgUtUPf9T5r5+k0RrTeSgIBIREEFCyvmVJ0KyqLmIIIGhfGa4X4or65CiyLM9gNIdkW1utPI/bHAM21kwBAo1UaporHvTTKtDqabGcvMEIB70ZAXH1lISolXfkhDxDWC4nSrNrrTMR8QoH/GLOcgJThlq9KonhWf3mMhnWSf4amLkJX/7Q86Gj5/N/rHYwofhoW0ekcvuKjqq4W+Wj3qEsOxZ3t4hQ0/Be959aLiXft6fpDYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kTIXs+xyZ7GQMwJvHCRcU4gs90P6mxQaVyECatzMlXo=; b=gq0QiAJS7uCE2fKqycoz5Cz1EYnqM5r0IzVTvdfb6ZlVdFEh7KPWpiaAFTL1ieuLvWQURvNC0GZfDDr+AiT2+jlr2Z+FsxkdWF5bZpkjkoRMEWTM8YJIKEe9Pea7239CStIeGaYLuTx0RLw9/5dIyaY76t8KierZr3TaHpN2suTFGo3tv8wb7rbiE1yUAI/I+uphgzAzGaJ9haO+4poHwSoLdMZvGmGNJRdBtPiyXFGZBSzNgTwNQCAIQk4tDgu3e0lhb9Xhzt4CV8TccleEU2BVxUfIglNFlQFSRDNPK2MYKiM6acBbldF3S7kh5dTgHgMmpRNp9H0s3c6BezHlag== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0125.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:238::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 19:43:51 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::85ac:1b92:90f:dc18]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::85ac:1b92:90f:dc18%4]) with mapi id 15.20.5654.026; Wed, 28 Sep 2022 19:43:51 +0000 Message-ID: Date: Wed, 28 Sep 2022 21:43:56 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220928193925.GZ6583@pb2> From: Andreas Rheinhardt In-Reply-To: <20220928193925.GZ6583@pb2> X-TMN: [ucZkuEnzw4yUQPoJCSW9uBHPtvKrPdt/WRzzDQPhp2E=] X-ClientProxiedBy: ZR0P278CA0150.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::14) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <0747ecca-fece-ff3c-0e83-95cd33413658@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0125:EE_ X-MS-Office365-Filtering-Correlation-Id: bfb3eeed-988d-48de-a55f-08daa189c4e9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZZEA4/x132sn9cP/x6zsWynBsSgXJ2ltdONo5X8U7pVRbFDK+P+3kGpEJfmOHALNuLf6gpZq4eAk23wcZGq707Mh+ASOHsMexJpPqkSyWydIAiqESrJaCZQ2aRS2XR26wxGZWc/Bi4U3vg88KGnayxmd01//9fTuCsJxfWTsVAku7lwT10nMgHuQOIohKJA7oJ41HuKqmPYla1UnRn7HIivhbzxbPohmTqlscAbvre47CMeCtEZqKqqSP+kesK3WOQPafdVZIdFd5wGW6x3F4s09NlPszH9fTm+UFu9q0EliC5wscj2xQvhnpnD/b3ac3RZN/0YYK7htI36SRtqTwiF0DKFs/Xlv6VLj4XDVfAm9JE5s3zFih44FuX3WAzc/hGvAVqTRANyKnBChBnNi3S/eke39J0ni1F2gRqlU3iNbWmlQPqucG3CkoOl7UTYAPDu2ykd/2pKV+iL4Uq3gSFpu8O84NOy60+HIq+BeRn0Zn/mpZUWifZ2naaMR1XN4LLZSnq2k14cS5ANtnzT38PvQumSduXBcTTLReKS4awpHdyeYtM2fCv+nDhmcy2y7uyJcPhphFBn5rsIfVOU7jCZu8yfJCZfpEmQYnMvk3i4VcvJjhXKZpkvyBe1WfG+jPEQL8kE+10L5KJxY17/MdobXbRPZ2QjflZsjgDnv7DQfbRX5ryky6ZHewm7IvBz6 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVpKSlBNRmNMMllaTG1NWHN5cEY0alBiS3dFVWdRcVpuZzN3Yk5Ta09nZkQr?= =?utf-8?B?UnN5My8rSmhwTldXVG5oSlpLakJxNlhmMWJTblBrV3pKQ05lbVRnYzFvN2ly?= =?utf-8?B?M0hEWUlncFdPeVNZU2czS0pJSXNQTTNNOFg1YnBLY01mSWQzV083WFEva1Q1?= =?utf-8?B?M2lRUTZhUXllS3F3M2NObFFRRVRWU25UeHpjYzQ5YzV4MWZ3a1A4Nno0ZHdq?= =?utf-8?B?YnVkdkRMbmVCdUdPQ3JxL2VNVW9TUWpFK0ZNamY4MDdxRXhmQUpPdm1aa3V3?= =?utf-8?B?VzVCNEVGNytVM3hmY1VpOUFxWS9lbEEvSEc4ODB4QTJhbTArdmFOMWs0NnM1?= =?utf-8?B?aTBuUGRXd0loMDg4YkNYRlRjUzdLNWRPb25Td1ZFWW9EL1ExdUc0RlR0Qkl6?= =?utf-8?B?TW9vNG5xTlA5YXo1UzJOMnlvN2N0OCtzOXkwU1pCTWdHZW5vOENqMzhHaDlR?= =?utf-8?B?U3BZdDQ1UUVmTmFLYjdqNzNmQkFNWis1aWNoQVNEYkhiZktRSlR5UlhqbW9j?= =?utf-8?B?S3hUZHJNNjNGWE1nNzZkQ3pFNWtzaTFMcnJqZGJ6VGpaZUFSZGdibjcvTVlJ?= =?utf-8?B?YjIyYnQyNzhMb3ZBMnFHdEJuS0IrOHcxTkRzLyt2dGZzUDdKYlpnemVQdXRD?= =?utf-8?B?VFI4RVFmV3J4RjZQMm5FdEdBVmhKRXNRY21ObW5rSGYwMTJFQnhHQ2p5Y1JN?= =?utf-8?B?Z3lxQ1E5SlZOeEwzUkUyY0w3Z2ZDM3NlQ0xFelBxRElpdzB5aFl1Kzd1c2Q0?= =?utf-8?B?NzVVa01BYi9RRE90c1BYNGhDc3MwODRuVjM2YXdDYVZ6U01pdlJqclZEQUUv?= =?utf-8?B?Vk95T2NjeGdNeWFrZTJMUi9lUHNUeUh1eEp1SkdFb284NVBySXpkUFY3R1Y1?= =?utf-8?B?bk1CU0V6MzBtYWppTVdBd3p0WW80NmNLTEpkQlQ2TENPOFVCK0ZQcTBVVXM3?= =?utf-8?B?N09yOXc1amdudjZHTlRLY3VTR3BncXRXNVA2Q2tCQS9IenEyZW1WZHhMRWg4?= =?utf-8?B?ZjhyaEFGOXNJTGR2TkErYzdpQWRGK3A5WCtuYVlBZXpaVEE1STJiNEt1Ylhu?= =?utf-8?B?elVhUlRtbkxPVUVKWVdtb0tPUmw1NW5qQWFLSG9FbElxVlpPcDBEcFA2VXFE?= =?utf-8?B?Z3BVbjV6WGlpc2VhT1ZvYm5NT0phTHljdE45dlBEa1VOVHlISyt2N2FzOGo3?= =?utf-8?B?dm1YT0FBd3FqY29kUmh6SWhMQ0JpQ2hEdlNZbTdXT0F3ZFpjTm8wYkRLYkhP?= =?utf-8?B?bmJCTFZnNVZuSUNCZ2dYWUREZG1zSllTeFV1NkZ3VGEwdVArQm81V0hBQm9q?= =?utf-8?B?RnJFNjFsNG0vaHdVNnUzVHNQWUNFRWl1bitBbVR3UVJFakdOVFBoek1BVTkz?= =?utf-8?B?Rit1MFVXbXgrWGZVaXBlZU1lZ1JuWjZFNjEzUmEyM2FLdXlySVQ0blBMNzhN?= =?utf-8?B?NFdQdU95dUd4YVRZQWNqd0R5OWRmc2M5dFM0eUNXNGc1Nk1UVFhWME1Ca2ZS?= =?utf-8?B?alJ4ZFRFTE5MZkNDK3UyZmRZanpwNmxrYVc0cU5FN2Z3dnVpNTdsdEEvZlI2?= =?utf-8?B?d0xXY1IrZE5vMjc4RitNYTc4WHVna2ZLTFZNWUYzYjcwOHlYc1o3R3JycDBD?= =?utf-8?B?aVNEaGgxRHRlZmZDeFdaL3RFdjlVaTk0ZEJrNnVtU2ZuazZENUYrUlRHaXk4?= =?utf-8?B?Rm9OU2ViSUMwaGRVRWRJejRtdWthbkdaamdhU3poMWxvTk0xTkhvb2s4dnJl?= =?utf-8?Q?Rghhm5MLifBMqgNHxk=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfb3eeed-988d-48de-a55f-08daa189c4e9 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 19:43:51.4615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0125 Subject: Re: [FFmpeg-devel] [PATCH] swscale/swscale_unscaled: Fix undefined NULL + 0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Wed, Sep 28, 2022 at 08:39:09PM +0200, Andreas Rheinhardt wrote: >> Affected the fitsdec-gbrp16 FATE-test. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libswscale/swscale_unscaled.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscaled.c >> index 8838cc8b53..0b97377934 100644 >> --- a/libswscale/swscale_unscaled.c >> +++ b/libswscale/swscale_unscaled.c >> @@ -695,7 +695,7 @@ static void packed16togbra16(const uint8_t *src, int srcStride, >> } >> } >> for (i = 0; i < 4; i++) >> - dst[i] += dstStride[i] >> 1; >> + dst[i] = FF_PTR_ADD(dst[i], dstStride[i] >> 1); >> } >> } >> >> @@ -729,8 +729,8 @@ static int Rgb16ToPlanarRgb16Wrapper(SwsContext *c, const uint8_t *src[], >> } >> >> for(i=0; i<4; i++) { >> - dst2013[i] += stride2013[i] * srcSliceY / 2; >> - dst1023[i] += stride1023[i] * srcSliceY / 2; >> + dst2013[i] = FF_PTR_ADD(dst2013[i], stride2013[i] * srcSliceY / 2); >> + dst1023[i] = FF_PTR_ADD(dst1023[i], stride1023[i] * srcSliceY / 2); >> } > > is there a reason not to check the pointer in the loop ? > as in > for (i = 0; i < 4 && dst[i]; i++) > I consider NULL + 0 to be sane and would be happy to see it being defined in a future version of the spec. So I don't like adding checks to workaround the insanities of the spec. Notice that FF_PTR_ADD() is designed to allow the compiler to optimize the check away. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".