From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 195B9490CB for ; Fri, 2 Feb 2024 11:28:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E737268D081; Fri, 2 Feb 2024 13:28:45 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2032.outbound.protection.outlook.com [40.92.91.32]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6604068CE11 for ; Fri, 2 Feb 2024 13:28:39 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O6rHOP0mqW0h4oXELLCWMBhTHRkbtqBqs3VdzjwUjXdCaWQN4/aouxM3YNsaqeGMnvdXnhVNB/c605/dBa9eVrsDTxfdWO/WU+Hp0mhjhvcd2YnqhvXbsjSKqIuZu5HHdH/JE5tp2FZR56+I9Ilxvyw7yYQbq6LKe/6iclhRdzPJ50r3tg7am2gAiBABrf0UUi3mlladpjzTKtfJ0sduU4RSeXHLjaL89sun2S68leSJAoUNhgg7z9XFRzzwevUhmDPAqTtJHQXuGsEEgEEiLVbDjqhBVtkUCmmcDlmaJ+pkahcZKl8VAqbcCRqi8F+u1UmFzGgk5f1vPHuySdlwSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I83LaCkpIO0FQ25iodYbjrlWJWbWoqYYUrGUz3RJCBM=; b=iSo3N3ocfNaBSSEZkOKqifMc7Hcu0gaQpy4R8vww1AT8qaWmx22qtqn1yk4SOzfEMx+5/+F1ZXSEgoDaKv0kMLS9Qj2AFh3GOhGlPN+zVBx+j+ommEtlBnFM1wtmUHLSl9Ybo7MSqIfBzWpA64N8Rm16JzNoqOkrv5jtT75cgP2cu+PIEz+jvd71ou0TsXDtWAN8l6kERY5p9Is4lgfbVM3ns3VTshnusHTfBmqSb/EAvku0NsWXE+5zJg3JQUV5ukR9bQSyTz+z9gIp9F2J64NtTTZLNNitR6Y9aOMwvj85GCdwuKc4ml5IlvW/ixqKZLKDJxasY9xDwjaUu/I1Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I83LaCkpIO0FQ25iodYbjrlWJWbWoqYYUrGUz3RJCBM=; b=NNIT6PrE5f1mj06J0hbfClhyKTOlDNec3vF0sSty/W0xjcrYdHFDG2bYrIgBfyf6c7kV9J57rQmjVByP258eoDNNjfpvCGcd3wdzHlwgAPy44Sd3l3GgoDTifuDKsciHv+FjNeO3W453yVa5ySrxImFloQsWA6B/hxGri23HTfp11XkrivItoCKngMGg/Qn0QacJnhJvvc91sUaJ6X8Ld0AmVniqFitKgWH2H1rImjbsmcPwJhO5YzsY4nDdohGrKH5h6A6YuAY40O+0Er58MfjArvFdOEF9ZT3vP8SQjBIBc+D1I9dwqKngWN7ROWEaiCsP5r5enFzx3seYIvzHrA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0240.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:279::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.26; Fri, 2 Feb 2024 11:28:38 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7202.031; Fri, 2 Feb 2024 11:28:37 +0000 Message-ID: Date: Fri, 2 Feb 2024 12:30:32 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [H1IeKoxeLiYkAEQZ9B/pPEnmjQ3EBbsCNA0Xqx2Bdis=] X-ClientProxiedBy: FR3P281CA0209.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::8) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <0fd8af7a-4c28-41b1-b589-7f19a8e6fc6a@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0240:EE_ X-MS-Office365-Filtering-Correlation-Id: f675e277-ac10-4eb7-22c1-08dc23e21986 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l11OThVAzel34LtOI24EioL8k1POcPnGvP20RZA9PpHWdWMUAkLFk+dCh4K/yh5Shb3W3BZZkHVGUGfEAIiftmlctAqfy90Mfzj4tEPEu5mE34YOoRjt8lJJuF9F+R3Di8KVmmb0czbi+FgwD9eoNMkqOvvrVJeOnnpYaJKoNmwFEL6LXlm6MmyW9dWelV5xr/6veGQJTrNv0jB4WFIMuwb6kcTk4mxHkIoMLbjqYfUFptl/xDcUZrAt2qwYg21k27Vmq8SPlUVdkkPvrWYAsY2hyakFEwVx3aR+nn6g3XyDR0NAQXx3Lelo/Ue8CNryofFFEkCAyzrWNJezMAuHCreLiyx1fkE5Qlnf8RAAtUCZ6JXt9aXirm4VyFiiBPol8GUdsQkAd9hQi6F83kAKdYKhzLWjA0ZSDj8Yrv5u5FklhbuUGT0OWlAlEQyun9zKhZhP9jqWHs4PdJzJOvHdyKPrR08M9yhXqFGp3JJ7lFDUIsae9uuwkev8bSR0DsJYXM/cP9j2Dl5sGaBLSkOcrRhabEeuVpK3GeGjFCNkUEITT/dV7zDOnbS6BW1ue930 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enI0NU5vQjFjMUZTTi9KaVJVaHdTOEVvSlNVeFpEQWd5dEo1akZPTWZLempj?= =?utf-8?B?dy85MUN3dVNlMlpUUlZPblpRanhOckNaeU1sRXJBaHFRdkppM2RRVVpkWG10?= =?utf-8?B?WkVPME1nRDVmY3ptclpZcVJ0QTA1ak1hR1ZXb1NUaEdyWFdoa2w5STZ5TDdG?= =?utf-8?B?UEtvNVQwenduWlRlaDNvRDhTWmhsYVRHakt3WllRc1ZiQzl6bGdRRlgxQmNw?= =?utf-8?B?bGgxODhRYS9NYlc1bUsvQ2lFdHB0ZU4zdVV5NmQrMG1ZcExkc3Y0WU8xNDRW?= =?utf-8?B?QlZRZGY0cXpnL3dCZ0J1ZGpyQkZQTkVQNEx6VklVdmdiVCtGWDVNUjFlV2tV?= =?utf-8?B?L0tzN3FkSjBsSVJXQjc3SytITUdYQ0hBMEtDU0NRTU9CTzhLVi9iZG5aVUow?= =?utf-8?B?czE1eVQyQ3I2TzJwRUhidDlUQ3NKWnZrUTNiL2VMVmgrbStmZEQ0QUVhbVE0?= =?utf-8?B?TVFVcmFBcy9aTWJicG5TaVhtQ1NNMEFWcUN3aGV3aFV6UkJNZ1ZmVjdkTFZW?= =?utf-8?B?djRYTzhkVUgrL2VLa3ROek9VcGdmTlhWdE0yVWR2VVlnWURZNkhWVFY5YnFv?= =?utf-8?B?SENjbVhjYVdLenQrRWU2Ym9JZXYvOUtEUTQxTXcrMlk3S21vWUF5ekxVWHRw?= =?utf-8?B?SU01YXRNVWtIcHVPTUF1QVpIUUswM3daUm5QRVlXV1MwNmEzVy91N0IxK0tw?= =?utf-8?B?RDlJWnNjdUhmWXBMQnZYaGNMWDZPSkxZWmlkZ1FMQXRTTnhMYWFSY1F0b3dh?= =?utf-8?B?b0ZLSVRDU0JFclhQTy9jcDFEUHUyKytBc2g1TUgrdGEwME9LMjZUNFVrclJv?= =?utf-8?B?K29IMDlkVkwvMU00ZG8yU29mcDRSY2FFbW1HRktmeGZlQzF1L0ZtYW1NQTVF?= =?utf-8?B?c3VKb3F1TkZEMi9RczdvVVBzQlZMb092dUx4WWUxbHFXbUlGYnpVQUhNeTNT?= =?utf-8?B?Y2dybmJlaUIraXZUMGozeFpGNW9hekhaUWNjWEQvTklySW9NUzdMMWF2ck5H?= =?utf-8?B?QkhEM1YyYmhITWdOM05VSm5HWWdPV2FmUGNPSFl5eEF6MUtMRWZWcEwzbHI5?= =?utf-8?B?c094V3cvdVZVQmp4QmNRdkxTdHVXaXpZdW40T0lidkVsaEYwVko2VFBkNkxC?= =?utf-8?B?OTJjN3FLbnQrVVZUbzdYbU1jbEpISnF0dEJvc1UxT0EwMTdOWThCamR1Mlph?= =?utf-8?B?WTJod2ZwNkhqQTcyRXFwL1poME1ZYzBKa1paWE42T1JuNlFKam53Mzh5OUZW?= =?utf-8?B?VW9GYVoxZzJOOVJBSjJGZVRxVS9YcEhOTmtyM0pIc0ZEOCtsSlV6c2ZJb2Fm?= =?utf-8?B?UXJmTGpuV3pLM2FpVHF0Z1pIMnVlMXdycFJsMHBxZ091a2lDU0xNSC81clFy?= =?utf-8?B?MFFYZnRrUWNIZFFDR2NsU1EvUHZSSDRRYUhmUHdTRmJrMmhzRjlOZmVRcnd1?= =?utf-8?B?dGFEUHBidXFlUVJyeXNCT0NCSDdZSWwxTnkyODFiS0FOcGZWWnFFVFFqSkJ4?= =?utf-8?B?VGVZajFBaVZBb0p2WVpra1VYSVF4bVFKRTNLcHo4elpXVTFBQmpuSEVldjEw?= =?utf-8?B?N3lIMFNrcmtBRHNhU3dwdTI5Q3FKbzdjY2cxUkYvN25HL082RktxbUQ2ZEFD?= =?utf-8?B?T082MEVkU0pBa2x4UFM2Q0NIbENERGl3Q09FYXM3T2p1OTc3SUFkWnI0VDJl?= =?utf-8?Q?fnrLvhAhFgUaYxtSvHBZ?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f675e277-ac10-4eb7-22c1-08dc23e21986 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 11:28:37.9166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0240 Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/iamf_writer: Avoid using dynamic buffer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/iamf_writer.c | 28 ++++++---------------------- > 1 file changed, 6 insertions(+), 22 deletions(-) > > diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c > index 99602ae204..f665f45b7a 100644 > --- a/libavformat/iamf_writer.c > +++ b/libavformat/iamf_writer.c > @@ -807,31 +807,15 @@ static int iamf_write_mixing_presentation(const IAMFContext *iamf, > > int ff_iamf_write_descriptors(const IAMFContext *iamf, AVIOContext *pb, void *log_ctx) > { > - uint8_t header[MAX_IAMF_OBU_HEADER_SIZE]; > - PutBitContext pbc; > - AVIOContext *dyn_bc; > - uint8_t *dyn_buf = NULL; > - int dyn_size; > - > - int ret = avio_open_dyn_buf(&dyn_bc); > - if (ret < 0) > - return ret; > + int ret; > > // Sequence Header > - init_put_bits(&pbc, header, sizeof(header)); > - put_bits(&pbc, 5, IAMF_OBU_IA_SEQUENCE_HEADER); > - put_bits(&pbc, 3, 0); > - flush_put_bits(&pbc); > + avio_w8(pb, IAMF_OBU_IA_SEQUENCE_HEADER << 3); > > - avio_write(dyn_bc, header, put_bytes_count(&pbc, 1)); > - ffio_write_leb(dyn_bc, 6); > - avio_wb32(dyn_bc, MKBETAG('i','a','m','f')); > - avio_w8(dyn_bc, iamf->nb_audio_elements > 1); // primary_profile > - avio_w8(dyn_bc, iamf->nb_audio_elements > 1); // additional_profile > - > - dyn_size = avio_close_dyn_buf(dyn_bc, &dyn_buf); > - avio_write(pb, dyn_buf, dyn_size); > - av_free(dyn_buf); > + ffio_write_leb(pb, 6); > + avio_wb32(pb, MKBETAG('i','a','m','f')); > + avio_w8(pb, iamf->nb_audio_elements > 1); // primary_profile > + avio_w8(pb, iamf->nb_audio_elements > 1); // additional_profile > > for (int i = 0; i < iamf->nb_codec_configs; i++) { > ret = iamf_write_codec_config(iamf, iamf->codec_configs[i], pb); Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".