From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5A8F847A43 for ; Fri, 29 Sep 2023 16:46:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 465DF68CC74; Fri, 29 Sep 2023 19:46:33 +0300 (EEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2023.outbound.protection.outlook.com [40.92.59.23]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D252268CC72 for ; Fri, 29 Sep 2023 19:46:26 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=frzKlok6kTZKvMu6kFG4eQqv3D3M6Rs52ApLaiy1mvLtRe7T6BVOWeX8Gx4JkDlanZevRw23yTgdxJsyDFspnDfKyTmDRHb/poMMN1iIvwcNWLIr2OTYMukSet+A1XGKlRY28HBN7wSXLOMmok1Cf99YVyCkXoUDOD01vXELPdEGiIsisvtyjHCgcKPppc0RBdnjhzTneY1pcoP/gXSaya1YESTM9ZwEqJbSAElxv7ZJlf0QTuK5gCbqxTuO+FVXaJpJtgX09xKyDHXc0NC1GOE/FxRbK9tnozPs/BvB2Zosx5xtMenXh+qGaPheCxQw+rWoUjzU+ON1oYq+4XhZBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U6LvRrDFfFfa+C/wxY4A4PB2PhQzIuKFFMRD1cEHZ/w=; b=jeY2artgKBnF4LeYqcCc9GSQ74Ib5zQ7S/aofN2EOjoNLcPjV/oII79Y12cOzTsdPdehyLKYlvNMnQieGwPbm8cku6nRGdpiI/+pRKpxyCWNeBLYjy2NDdcPTXsQ5dkj9UiCZRxgvvIqtVtCcI8rc4N9WKlLH+aAlCnDNv8zmqTv8/cAy25GMPpMPKcUghOFriVOr/0JpADX2/6t8YtskWUE5WH459NwhTnr5LH6g51NKkmFSwxba0/k4AHc/K52FAGTNVZOl/1YiYOjdToAS/ieC2risoA6GMQgAXspzgX20d2so4MDWVaXWX2C+7yfDEwmA707JGflVmRJa7Zkdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U6LvRrDFfFfa+C/wxY4A4PB2PhQzIuKFFMRD1cEHZ/w=; b=uuu2sLMcwr1+E9enXukug9pGizhdiUsS2+vhRXM+5J8gfLQT+YGTQTByqR3XEdIC3ITm/SFmeMIbRS6Xb6zpbCj96AbO/ThKk1koHx7QzDpQjHRxR0otcmzkW1gVMLgLuqlE2v9sIB8De4Dr4CP/c7CRmYVI9JljFjAbLj13g8vNzkX66mGEK8oTMdkmRyCU74hFxG9l/x6loKKDnP/yFBNzS0GH7FVANFic+6AHbysCzhYUCXTQaSZoiwVHfBqD0QadRLqRoidOa32jKduSHoVPDp6PcYhW/zhDGutTZHWkNT+jylPLzje6QMxFMyS3jQyYX1IAqTqvz66THQnIAA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS1P250MB0405.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4ad::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.26; Fri, 29 Sep 2023 16:46:25 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6792.026; Fri, 29 Sep 2023 16:46:25 +0000 Message-ID: Date: Fri, 29 Sep 2023 18:47:39 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <181aecfd-986e-4976-bfdb-ef29e3bd1e4e@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <181aecfd-986e-4976-bfdb-ef29e3bd1e4e@gmail.com> X-TMN: [Hr3vGvVsEf3fJ4/PJizUoyYNJMFtAnpy] X-ClientProxiedBy: ZR0P278CA0105.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::20) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <3713ce80-f4d0-4194-94ac-c5619a9751f4@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS1P250MB0405:EE_ X-MS-Office365-Filtering-Correlation-Id: 7dbb7b2c-c1fc-411b-4770-08dbc10b9e75 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c7ydp/BYtXLGkGOL6dOMvt6rZB2PwqngF1unwuLNu3lIavOm9lZAd0ooYGmR4b4R+uyPghHLyq61GvpuNRWYqvHkmDMwDaJTlpNmQWwlPE55mUiFqtrMdj092Nsf7POSryaoHtxllwqEH27XOo8evkpY72pYvDTMtEKXrTUgxC4A8lveRIkJBG0k1aic5Zt6y6dmgMrYhKrBbfW+1Zt7MtqWMuMfECXMI6vzOa8AGCSEHB+rctnrxm5yOs7JNTroWJNPzGmBjhNuPTci1z3G9PoDN0KDl5vdLlumRge7kXWFXfc3Vj7gCTwTs8AubaVS2DCvL83Ndy+4lUqMCsWJ5PWSfwugC2J1ZNUd/zHZGwE2vMu7NKGXEAG6gfFw2TN3WIqLR1X6DNpqSGXy1aZ4rpxTFlNWgofgYwvnD0G8EkpQN3jyphFU9JdvVJbnsd5CNo+a6T1IrrMHjGPDedn6v61Tus76u5YzmFMzUeuupO7GMEWKZEVB5C29Q57aFtEpat6a+n+HYL4KCnfN1uEpYAX6CLJ8jwm3a0Gdiq+n+wOYC+DKw7IKa34VtHwtjQx7 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THAxYmYwb1VyQmkzOU5FZVl1N1R4dnBKQk9YQS9FKzZ5UjNnTWM3SUcySm5l?= =?utf-8?B?b3ZPSjhpYUE2eThCM21aNlppUHF4eWZrWTRXMjh0b0tLeUZ0a3d3REZyL1B4?= =?utf-8?B?TStwU29iVzdCUlE1aDdRd0lCTVRsUk5kVnlzZWFSQjRvTW0vWldQa0Fac1BO?= =?utf-8?B?R2NlcEhWRVdHb1lpdUFhUzd6Q1dFUGR4aGQ0dVRUbHVtYW9XS3ZzTWhPenhz?= =?utf-8?B?bkJIMjBiOGFtVzdDSU1JZE9GVXVCeitYalB2Z2JZQ0FybGRWejFtN3JtMGJY?= =?utf-8?B?aUhSMjJBalpwMXVGa3B2a1BQaXFmaXRpOHJpQWJNMEtKYnUvRHVnWkpDRWZE?= =?utf-8?B?bGdqZ2pWbTg3NDJ5RFFRM1VSSGxuR3hka3NaeEI0TEhIODBZMWNYQTdnaytN?= =?utf-8?B?SHBsRUlMNGw3a0kxUUFmWUpFVEtWMHNvZzN4WUlpTHUwNDI4K0JhSm9ZRFN6?= =?utf-8?B?Z05VWFhyV1haSThKT0U5SmRZMmJYSjQzYmNuYW9NZCtqdUt2RDYrVjZhYzli?= =?utf-8?B?RVYxT3ZWMEtndnJpRlI4WWIrR3JId1lZY3dIZE9Ib3RiZzN6REtxTlFmb2px?= =?utf-8?B?RGZ0V1VnQ2tFOTZ2RERVejI0R1JyWWtFQVAxRFVQVW5HOWFjcXJUaEltOENX?= =?utf-8?B?NkVZUlVjdStmbkgzUHhBWXh1bnozb082UUpodWhuRXNIa0FyeHZDVXJVSzFK?= =?utf-8?B?TGpRajVSaTNMaDB5YkpJL01jdFdvMFcyUCtsbGFiclRkRWwwRG9mNE1KZzVW?= =?utf-8?B?cFZqMUZQVjFhcS9SUzNmMlpPY2M5ekp2alM4R3FKcGRyeW1ua3dVOGpwMDdv?= =?utf-8?B?enhUZ0ZGeVRHaS9peSt6b2dNdXhiYUhBWGcrM2RSOFhKcy8rTm1oU0lMeCta?= =?utf-8?B?RjFhYWd5ZjNLNGZGcXVmcytFRzdqbUc5aVNWNy94ayt2T2JBSDRHRFpHNFNF?= =?utf-8?B?QmM2eWtFS1ZPeGpOaEdRM2xKRmM2NlZqMnI1MzRaRGJHemdzWjducVlIUUJK?= =?utf-8?B?VlRXWk0xYmMvVHpMSkwzL1BxZzA4TWVFRmFlZkpIejJBTTlpSmtHN05yUldV?= =?utf-8?B?LzJQdjJ5dUhRWDlObGhCcWZBTjd5WkJxSkw3Wm5Kdm5rR0tuVmNscUR4Wmgr?= =?utf-8?B?UmpxNTBpMUlWbFpTSmJNL1h0c1J6Qmx6T2pCRWR5a3A2WXZZWm5nOVZySjF4?= =?utf-8?B?d2pCYS9mcEVidjZEZFNUczVkeXgxOHE1VFFRRmdmaGNUaUdKY1FpYUZ3R3VW?= =?utf-8?B?cTNUT1lhN3lHN2NMbzdZdkRibUpKdkxtUHNadFhlbU1Kck1mRGRiZ2JidjM4?= =?utf-8?B?b1dRZmIrQ0p1TFlCS2NndlMyYXNsV3g3VitWVEVkejYrNkR3K04xa0ZvTVNP?= =?utf-8?B?K3pDMGx1SndJQTM3a0FPem1ZakJsdjN2bXdmOUxOZHlmS0x3WHltb1oyS0hH?= =?utf-8?B?Uk9DUHd3Z2dPZy8zcXlicUhIT0ppS3owSnRzTjBUR2ZwMmhpcG96NDZabmZl?= =?utf-8?B?MmFBVW1ZUEdSZHJ6UFBvQmJ1ZHp5TzRBUkpaYVprT2tVTDdCWXQ4NGx4RFBH?= =?utf-8?B?S3RWRVczZzkzcmNBQkVIQXlRMFBYMHQ1bGMwWUhSV2lERzBUdmJmcm9HWGFp?= =?utf-8?B?S3JWbXkyY05ROUp6QTZVd3dmMFpWNmNxcG1HNHdOK0NTcGVOVy9Jdm13RDdm?= =?utf-8?Q?mcc1LZd+cUPD3Epvk1Z1?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7dbb7b2c-c1fc-411b-4770-08dbc10b9e75 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 16:46:25.3137 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P250MB0405 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskaenc: Don't create wrong packet durations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > On 9/29/2023 1:01 PM, Andreas Rheinhardt wrote: >> We have to write an explicit BlockDuration element (and use >> a BlockGroup instead of a SimpleBlock) in case the Track >> has a DefaultDuration that is inconsistent with the duration >> of the packet. >> >> The matroska-h264-remux test uses a file with coded fields >> where the duration of a Block is the duration of a field, >> not of a frame, therefore this patch writes said BlockDuration >> elements. >> >> (When using a BlockGroup, one has to add ReferenceBlock elements >> to distinguish keyframes from non-keyframes. Unfortunately, >> the AV1 codec mapping [1] requires us to reference all references >> and to really use the real references, which requires a lot of >> effort for basically no gain. When BlockGroups are used with AV1, >> the created files are most likely invalid, both before and after >> this patch, but this patch makes this more likely to happen.) > > AV1 has no fields, and the vast majority of samples will also have fixed > frame duration across the entire coded stream, so i doubt this will make > a difference. > > There's also the fact it's unlikely parsers will care about > ReferenceBlock elements at all to begin with, and instead just have the > decoder handle things relying on the bitstream level information. > That's why I consider this requirement to be nonsense. In fact, I would only require one thing from the ReferenceBlock elements: If one recursively goes back the ReferenceBlock elements until one has reached a keyframe, then decoding these blocks is sufficient to be able to decode the actually desired block. That way a simple muxer like ours could always reference the preceding block (in case the current packet is not a keyframe) and create a valid stream. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".